Re: [HACKERS] Extra check in 9.0 exclusion constraint unintended consequences

2011-07-09 Thread Alvaro Herrera
Excerpts from Jeff Davis's message of vie jul 08 00:58:20 -0400 2011: > On Thu, 2011-07-07 at 12:36 -0400, Robert Haas wrote: > > I think it's probably too late to go fiddling with the behavior of 9.0 > > at this point. If we change the text of error messages, there is a > > chance that it might b

[HACKERS] Need help understanding pg_locks

2011-07-09 Thread Bruce Momjian
Can someone help me understand pg_locks? There are three fields related to virtual and real xids: virtualtransaction | text | transactionid | xid | virtualxid | text | Our docs say 'virtualtransaction' is: Virtual ID of the transaction that is holding or awa

Re: [HACKERS] per-column generic option

2011-07-09 Thread Alvaro Herrera
Shigeru Hanada escribió: > (2011/06/26 18:34), Kohei KaiGai wrote: > > I checked your patch. > > Thanks for the review! Please find attached a revised patch. Err, \dec seems to have a line in describe.h but nowhere else; are you going to introduce that command? The new ALTER TABLE grammar seems

Re: [HACKERS] cataloguing NOT NULL constraints

2011-07-09 Thread Alvaro Herrera
Excerpts from Robert Haas's message of vie jul 08 23:30:10 -0400 2011: > On Thu, Jul 7, 2011 at 5:34 PM, Alvaro Herrera > wrote: > > The attached patch introduces pg_constraint rows for NOT NULL > > column constraints. > > > > This patch is a heavily reworked version of Bernd Helmle's patch here:

Re: [HACKERS] Enhanced psql in core?

2011-07-09 Thread Abel Abraham Camarillo Ojeda
On Sat, Jul 9, 2011 at 8:14 PM, Jaime Casanova wrote: > On Sat, Jul 9, 2011 at 5:29 AM, hubert depesz lubaczewski > wrote: >> hi, >> would it be possible to incorporate >> http://www.postgres.cz/index.php/Enhanced-psql in core PostgreSQL/psql? >> >> This patch adds lots of nice functionalities, w

Re: [HACKERS] Enhanced psql in core?

2011-07-09 Thread Jaime Casanova
On Sat, Jul 9, 2011 at 5:29 AM, hubert depesz lubaczewski wrote: > hi, > would it be possible to incorporate > http://www.postgres.cz/index.php/Enhanced-psql in core PostgreSQL/psql? > > This patch adds lots of nice functionalities, which we could definitely > use. > big part of this seems to be

Re: [HACKERS] Enhanced psql in core?

2011-07-09 Thread Cédric Villemain
2011/7/9 hubert depesz lubaczewski : > hi, > would it be possible to incorporate > http://www.postgres.cz/index.php/Enhanced-psql in core PostgreSQL/psql? > > This patch adds lots of nice functionalities, which we could definitely > use. Some features are very interesting but I I would suggest to

[HACKERS] csvlog_fields review

2011-07-09 Thread Alex Hunsaker
It bit rotted a bit find a new version attached that includes the following fixes: - show_session_authorization() no longer exists, instead access the session_authorization_guc directly (like we do for show_role in commands/variable.c). I find it quite ugly tho... - it changed %u to %U and %U to b

Re: [HACKERS] [GENERAL] Creating temp tables inside read only transactions

2011-07-09 Thread Darren Duncan
Jeff Davis wrote: On Fri, 2011-07-08 at 23:39 -0700, Darren Duncan wrote: What if you used the context of the calling code and resolve in favor of whatever match is closest to it? The problem is related to general-purpose programming languages. Basically start looking in the lexical context

Re: [HACKERS] cataloguing NOT NULL constraints

2011-07-09 Thread Peter Eisentraut
On tor, 2011-07-07 at 17:34 -0400, Alvaro Herrera wrote: > The attached patch introduces pg_constraint rows for NOT NULL > column constraints. The information schema views check_constraints and table_constraints currently make up some artificial constraint names for not-null constraints. I suppos

Re: [HACKERS] Parameterized aggregate subquery (was: Pull up aggregate subquery)

2011-07-09 Thread Yeb Havinga
On 2011-07-09 16:23, Hitoshi Harada wrote: 2011/7/5 Hitoshi Harada: 2011/7/5 Yeb Havinga: Hello Hitosh, list, Attached is revised version. I failed to attached the patch. I'm trying again. I'm currently unable to test, since on holiday. I'm happy to continue testing once returned but it ma

Re: [HACKERS] Extra check in 9.0 exclusion constraint unintended consequences

2011-07-09 Thread Jeff Davis
On Fri, 2011-07-08 at 22:51 -0400, Robert Haas wrote: > I'm wondering if we might want to call this out with a or > similar... especially if we're only going to put it into the 9.0 > docs. Sure, sounds good. Regards, Jeff Davis -- Sent via pgsql-hackers mailing list (pgsql-hackers@p

Re: [HACKERS] [GENERAL] Creating temp tables inside read only transactions

2011-07-09 Thread Jeff Davis
On Fri, 2011-07-08 at 23:39 -0700, Darren Duncan wrote: > What if you used the context of the calling code and resolve in favor of > whatever match is closest to it? The problem is related to general-purpose > programming languages. > > Basically start looking in the lexical context for an "x"

Re: [HACKERS] Patch: add GiST support for BOX @> POINT queries

2011-07-09 Thread Hitoshi Harada
2011/6/19 Hitoshi Harada : > 2011/6/17 Andrew Tipton : >> >> At this point I'm a bit lost -- while pg_amop.h has plenty of examples >> of crosstype comparison operators for btree index methods, there are >> none for GiST.  Is GiST somehow a special case in this regard? > > It was I that was lost. A

Re: [HACKERS] Parameterized aggregate subquery (was: Pull up aggregate subquery)

2011-07-09 Thread Hitoshi Harada
2011/7/5 Hitoshi Harada : > 2011/7/5 Yeb Havinga : >> Hello Hitosh, list, >> >>> > >>> > Attached is revised version. >>> >>> I failed to attached the patch. I'm trying again. >>> >> I'm currently unable to test, since on holiday. I'm happy to continue >> testing once returned but it may not be wit

[HACKERS] Enhanced psql in core?

2011-07-09 Thread hubert depesz lubaczewski
hi, would it be possible to incorporate http://www.postgres.cz/index.php/Enhanced-psql in core PostgreSQL/psql? This patch adds lots of nice functionalities, which we could definitely use. Best regards, depesz -- The best thing about modern society is how easy it is to avoid contact with it.

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 1

2011-07-09 Thread Noah Misch
On Sat, Jul 09, 2011 at 10:52:33AM +0200, Kohei KaiGai wrote: > 2011/7/9 Noah Misch : > > On Sat, Jul 09, 2011 at 09:00:30AM +0200, Kohei KaiGai wrote: > >> The attached patch is a revised version according to the approach that > >> updates > >> pg_class system catalog before AlterTableInternal().

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 1

2011-07-09 Thread Kohei KaiGai
2011/7/9 Noah Misch : > On Sat, Jul 09, 2011 at 09:00:30AM +0200, Kohei KaiGai wrote: >> The attached patch is a revised version according to the approach that >> updates >> pg_class system catalog before AlterTableInternal(). >> It invokes the new ResetViewOptions when rel->rd_options is not null

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 1

2011-07-09 Thread Noah Misch
On Sat, Jul 09, 2011 at 09:00:30AM +0200, Kohei KaiGai wrote: > The attached patch is a revised version according to the approach that updates > pg_class system catalog before AlterTableInternal(). > It invokes the new ResetViewOptions when rel->rd_options is not null, and it > set > null on the p

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 2

2011-07-09 Thread Kohei KaiGai
2011/7/9 Robert Haas : > On Fri, Jul 8, 2011 at 4:57 PM, Noah Misch wrote: >> Note that it does not matter whether we're actually doing an index scan -- a >> seq >> scan with a filter using only leakproof operators is equally acceptable.   >> What I >> had in mind was to enumerate all operators i

Re: [HACKERS] [GENERAL] Creating temp tables inside read only transactions

2011-07-09 Thread Jeff Davis
On Fri, 2011-07-08 at 21:04 -0700, Darren Duncan wrote: > > I think you should make more of an effort to understand how the system > > works now, and why, before proposing radical redesigns. > > Well yes, of course. But that will take time and I think I already > understand > enough about it to

Re: [HACKERS] [v9.2] DROP Reworks Part.1 - Consolidate routines to handle DropStmt

2011-07-09 Thread Kohei KaiGai
2011/7/9 Robert Haas : > On Fri, Jul 8, 2011 at 9:06 AM, Kohei KaiGai wrote: >> I definitely agree with this idea. It will enables to eliminate ugly switch >> statements for error-messaging reasons. > > All right, so please submit a patch that introduces that concept > first, and then resubmit thi

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 1

2011-07-09 Thread Kohei KaiGai
2011/7/8 Noah Misch : > On Fri, Jul 08, 2011 at 09:20:46AM +0100, Kohei KaiGai wrote: >> 2011/7/7 Noah Misch : >> > On Thu, Jul 07, 2011 at 03:56:26PM +0100, Kohei KaiGai wrote: >> >> 2011/7/7 Noah Misch : >> >> > On Wed, Jul 06, 2011 at 10:25:12PM +0200, Kohei KaiGai wrote: > >> >> > That gets the