Re: [HACKERS] Proposal - Support for National Characters functionality

2013-07-05 Thread Arulappan, Arul Shaji
Ishii san, Thank you for your positive and early response. -Original Message- From: Tatsuo Ishii [mailto:is...@postgresql.org] Sent: Friday, 5 July 2013 3:02 PM To: Arulappan, Arul Shaji Cc: pgsql-hackers@postgresql.org Subject: Re: [HACKERS] Proposal - Support for National

Re: [HACKERS] Proposal - Support for National Characters functionality

2013-07-05 Thread Arulappan, Arul Shaji
-Original Message- From: Claudio Freire [mailto:klaussfre...@gmail.com] Sent: Friday, 5 July 2013 3:41 PM To: Tatsuo Ishii Cc: Arulappan, Arul Shaji; PostgreSQL-Dev Subject: Re: [HACKERS] Proposal - Support for National Characters functionality On Fri, Jul 5, 2013 at 2:02 AM,

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

2013-07-05 Thread Jeff Davis
On Mon, 2013-07-01 at 00:52 -0400, Greg Smith wrote: On 6/30/13 9:28 PM, Jon Nelson wrote: The performance of the latter (new) test sometimes seems to perform worse and sometimes seems to perform better (usually worse) than either of the other two. In all cases, posix_fallocate performs

Re: [HACKERS] WITH CHECK OPTION for auto-updatable views

2013-07-05 Thread Pavel Stehule
Hello just some notes: * autocomplete for INSERT, UPDATE, DELETE should to show updatable views too * can you explain better in doc differences between WITH CASCADED or WITH LOCAL OPTION - assign some simple example to doc, please * is possible to better identify (describe) failed

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

2013-07-05 Thread Greg Smith
On 7/5/13 2:50 AM, Jeff Davis wrote: So, my simple conclusion is that glibc emulation should be about the same as what we're doing now, so there's no reason to avoid it. That means, if posix_fallocate() is present, we should use it, because it's either the same (if emulated in glibc) or

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

2013-07-05 Thread KONDO Mitsumasa
(2013/07/05 0:35), Joshua D. Drake wrote: On 07/04/2013 06:05 AM, Andres Freund wrote: Presumably the smaller segsize is better because we don't completely stall the system by submitting up to 1GB of io at once. So, if we were to do it in 32MB chunks and then do a final fsync() afterwards we

Re: [HACKERS] Block write statistics WIP

2013-07-05 Thread Greg Smith
On 7/1/13 3:10 AM, Satoshi Nagayasu wrote: Or should we add some pointer, which is accociated with the Relation, into BufferDesc? Maybe OID? That is the other option here, I looked at it but didn't like it. The problem is that at the point when a new page is created, it's not always clear

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-05 Thread Michael Meskes
On Wed, Jul 03, 2013 at 07:22:48PM +0900, MauMau wrote: not specific to 9.3. Could you commit and backport this? Committed to 8.4, 9.0, 9.1, 9.2 and HEAD. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at

Re: [HACKERS] WITH CHECK OPTION for auto-updatable views

2013-07-05 Thread Dean Rasheed
On 5 July 2013 07:02, Pavel Stehule pavel.steh...@gmail.com wrote: Hello I try to check this patch I have a problem with initdb after patching error initializing dependencies ... ok creating system views ... FATAL: WITH CHECK OPTION is supported only on auto-updatable views STATEMENT:

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-05 Thread MauMau
From: Michael Meskes mes...@postgresql.org So that means MauMau was right and backslashes have to be escaped in filenames in #line directives, right? Apparently my examples were badly chosen as I didn't see an error no matter how many backslashes I had. Yes, the below examples shows the case:

Re: [HACKERS] changeset generation v5-01 - Patches git tree

2013-07-05 Thread Andres Freund
On 2013-06-27 21:52:03 -0700, Kevin Grittner wrote: Andres Freund and...@2ndquadrant.com wrote: Hm. There were some issues with the test_logical_decoding Makefile not cleaning up the regression installation properly. Which might have caused the issue. Could you try after applying the

Re: [HACKERS] Proposal - Support for National Characters functionality

2013-07-05 Thread Andrew Dunstan
On 07/05/2013 02:12 AM, Arulappan, Arul Shaji wrote: - Support for UTF16 column encoding and representing NCHAR and NVARCHAR columns in UTF16 encoding in all databases. Why do yo need UTF-16 as the database encoding? UTF-8 is already supported, and any UTF-16 character can be represented in

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-05 Thread Andrew Dunstan
On 07/05/2013 05:16 AM, Michael Meskes wrote: On Wed, Jul 03, 2013 at 07:22:48PM +0900, MauMau wrote: not specific to 9.3. Could you commit and backport this? Committed to 8.4, 9.0, 9.1, 9.2 and HEAD. This looks incomplete. Surely just escaping backslashes alone is not enough. I suspect

Re: [HACKERS] LDAP: bugfix and deprecated OpenLDAP API

2013-07-05 Thread Magnus Hagander
On Mon, Jul 1, 2013 at 4:18 PM, Albe Laurenz laurenz.a...@wien.gv.at wrote: Peter Eisentraut wrote: Btw., I just checked the source code of Apache, PHP, and PAM, and they are all unconditionally building with LDAP_DEPRECATED. So maybe there is no hurry about this. I don't think that the old

Re: [HACKERS] LDAP: bugfix and deprecated OpenLDAP API

2013-07-05 Thread Magnus Hagander
On Mon, Jul 1, 2013 at 4:16 PM, Albe Laurenz laurenz.a...@wien.gv.at wrote: Magnus Hagander wrote: On Tue, Feb 5, 2013 at 10:39 AM, Albe Laurenz laurenz.a...@wien.gv.at wrote: I found a small bug in the implementation of LDAP connection parameter lookup. [...] As coded now, the timeout

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-05 Thread Michael Meskes
On Fri, Jul 05, 2013 at 08:08:06AM -0400, Andrew Dunstan wrote: This looks incomplete. Surely just escaping backslashes alone is not enough. I suspect at least the char and any chars below 0x20 should be quoted also. Right, this didn't even occur to me, but there are surely more characters

Re: [HACKERS] [GENERAL] autoanalyze criteria

2013-07-05 Thread Magnus Hagander
On Wed, May 15, 2013 at 2:33 AM, Mark Kirkwood mark.kirkw...@catalyst.net.nz wrote: On 24/02/13 10:51, Mark Kirkwood wrote: On 24/02/13 10:12, Stefan Andreatta wrote: On 02/23/2013 09:30 PM, Jeff Janes wrote: Moved discussion from General To Hackers. On Sat, Feb 23, 2013 at 10:41 AM,

Re: [HACKERS] Review: Display number of changed rows since last analyze

2013-07-05 Thread Magnus Hagander
On Mon, Jul 1, 2013 at 3:15 PM, Albe Laurenz laurenz.a...@wien.gv.at wrote: Magnus Hagander wrote: On Mon, Jun 17, 2013 at 1:49 PM, Albe Laurenz laurenz.a...@wien.gv.at wrote: I think that the column name is ok as it is, even if it is a bit long - I cannot come up with a more succinct idea.

Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2013-07-05 Thread Hari Babu
On Thursday, July 04, 2013 11:19 PM Robert Haas wrote: + fprintf(stderr, _(%s: .. file \%s\ for seeking: %s\n), + progname, filename, strerror(errno)); Weird error message style - what's with the ..? + fprintf(stderr, _(%s: .. file \%s\

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

2013-07-05 Thread Jon Nelson
On Fri, Jul 5, 2013 at 2:23 AM, Greg Smith g...@2ndquadrant.com wrote: On 7/5/13 2:50 AM, Jeff Davis wrote: So, my simple conclusion is that glibc emulation should be about the same as what we're doing now, so there's no reason to avoid it. That means, if posix_fallocate() is present, we

Re: [HACKERS] changeset generation v5-01 - Patches git tree

2013-07-05 Thread Andres Freund
On 2013-07-05 14:03:56 +0200, Andres Freund wrote: On 2013-06-27 21:52:03 -0700, Kevin Grittner wrote: Andres Freund and...@2ndquadrant.com wrote: Hm. There were some issues with the test_logical_decoding Makefile not cleaning up the regression installation properly. Which might

Re: [HACKERS] changeset generation v5-01 - Patches git tree

2013-07-05 Thread Steve Singer
On 07/05/2013 08:03 AM, Andres Freund wrote: On 2013-06-27 21:52:03 -0700, Kevin Grittner wrote: Tried that, too, and problem persists. The log shows the last commit on your branch as 022c2da1873de2fbc93ae524819932719ca41bdb. Ok. I think I have a slight idea what's going on. Could you check

Re: [HACKERS] changeset generation v5-01 - Patches git tree

2013-07-05 Thread Andres Freund
On 2013-07-05 09:28:45 -0400, Steve Singer wrote: On 07/05/2013 08:03 AM, Andres Freund wrote: On 2013-06-27 21:52:03 -0700, Kevin Grittner wrote: Tried that, too, and problem persists. The log shows the last commit on your branch as 022c2da1873de2fbc93ae524819932719ca41bdb. Ok. I think I

Re: [HACKERS] changeset generation v5-01 - Patches git tree

2013-07-05 Thread Steve Singer
On 07/05/2013 09:34 AM, Andres Freund wrote: On 2013-07-05 09:28:45 -0400, Steve Singer wrote: On 07/05/2013 08:03 AM, Andres Freund wrote: On 2013-06-27 21:52:03 -0700, Kevin Grittner wrote: Tried that, too, and problem persists. The log shows the last commit on your branch as

Re: [HACKERS] strange IS NULL behaviour

2013-07-05 Thread Peter Eisentraut
On 7/4/13 5:06 PM, Alvaro Herrera wrote: FWIW if changing the behavior of NOT NULL constraints is desired, I still have the patch to catalogue them around, if anyone wants to play around. I haven't gotten around to finishing it up, yet :-( If your latest patch isn't publicly available, I'd

Re: [HACKERS] [9.3 bug fix] ECPG does not escape backslashes

2013-07-05 Thread Tom Lane
Michael Meskes mes...@postgresql.org writes: On Wed, Jul 03, 2013 at 07:22:48PM +0900, MauMau wrote: not specific to 9.3. Could you commit and backport this? Committed to 8.4, 9.0, 9.1, 9.2 and HEAD. Um ... 9.3 is a separate branch now, please fix it there also.

Re: [HACKERS] [COMMITTERS] pgsql: Add new GUC, max_worker_processes, limiting number of bgworkers.

2013-07-05 Thread Magnus Hagander
On Fri, Jul 5, 2013 at 6:28 AM, Kevin Hale Boyes kcbo...@gmail.com wrote: The change to config.sgml contains a small typo with the double r in the xreflabel. + varlistentry id=guc-max-worker-processes xreflabel=max_worrker_processes Fixed, thanks. -- Magnus Hagander Me:

Re: [HACKERS] strange IS NULL behaviour

2013-07-05 Thread Bruce Momjian
On Thu, Jul 4, 2013 at 04:29:20PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: I developed the attached patch which properly recurses into ROW() records checking for NULLs; you can see it returns the right answer in all cases (and constant folds too): My recollection

Re: [HACKERS] Review: UNNEST (and other functions) WITH ORDINALITY

2013-07-05 Thread Vik Fearing
On 07/04/2013 10:15 AM, Dean Rasheed wrote: On 4 July 2013 00:08, David Fetter da...@fetter.org wrote: Patch re-jiggered for recent changes to master. I re-validated this, and it all still looks good, so still ready for committer IMO. I tried to check this out, too and make check fails with

Re: [HACKERS] strange IS NULL behaviour

2013-07-05 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Thu, Jul 4, 2013 at 04:29:20PM -0400, Tom Lane wrote: No, it isn't, or at least it's far from the only place. If we're going to change this, we would also want to change the behavior of tests on RECORD values, which is something that would have to

Re: [HACKERS] Review: UNNEST (and other functions) WITH ORDINALITY

2013-07-05 Thread David Fetter
On Fri, Jul 05, 2013 at 04:58:30PM +0200, Vik Fearing wrote: On 07/05/2013 04:51 PM, Vik Fearing wrote: I tried to check this out, too and make check fails with the following. I have not looked into the cause. Running ./configure again fixed it. Sorry for the noise. If I had a nickel

Re: [HACKERS] Review: UNNEST (and other functions) WITH ORDINALITY

2013-07-05 Thread Vik Fearing
On 07/05/2013 04:51 PM, Vik Fearing wrote: I tried to check this out, too and make check fails with the following. I have not looked into the cause. Running ./configure again fixed it. Sorry for the noise. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] changeset generation v5-01 - Patches git tree

2013-07-05 Thread Steve Singer
On 06/14/2013 06:51 PM, Andres Freund wrote: The git tree is at: git://git.postgresql.org/git/users/andresfreund/postgres.git branch xlog-decoding-rebasing-cf4 http://git.postgresql.org/gitweb/?p=users/andresfreund/postgres.git;a=shortlog;h=refs/heads/xlog-decoding-rebasing-cf4 We discussed

Re: [HACKERS] strange IS NULL behaviour

2013-07-05 Thread Bruce Momjian
On Fri, Jul 5, 2013 at 11:03:56AM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On Thu, Jul 4, 2013 at 04:29:20PM -0400, Tom Lane wrote: No, it isn't, or at least it's far from the only place. If we're going to change this, we would also want to change the behavior of

Re: [HACKERS] changeset generation v5-01 - Patches git tree

2013-07-05 Thread Andres Freund
On 2013-07-05 11:33:20 -0400, Steve Singer wrote: On 06/14/2013 06:51 PM, Andres Freund wrote: The git tree is at: git://git.postgresql.org/git/users/andresfreund/postgres.git branch xlog-decoding-rebasing-cf4

Re: [HACKERS] [PATCH] Add transforms feature

2013-07-05 Thread Peter Eisentraut
On 7/3/13 7:15 PM, Josh Berkus wrote: I'm not comfortable with having all of the transform mappings in the main contrib/ directory though. Can we add a subdirectory called transforms containing all of these? I don't see any value in that. The data types they apply to are in contrib after

[HACKERS] Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-07-05 Thread Pavel Stehule
Hello I am sending a patch that removes strict requirements for DROP IF EXISTS statements. This behave is similar to our ALTER IF EXISTS behave now. postgres=# DROP CAST IF EXISTS (sss AS public.casttesttype); NOTICE: types sss and public.casttesttype does not exist, skipping DROP CAST

Re: [HACKERS] [PATCH] Add transforms feature

2013-07-05 Thread Hitoshi Harada
On Friday, July 5, 2013, Peter Eisentraut wrote: On 7/3/13 7:15 PM, Josh Berkus wrote: I'm not comfortable with having all of the transform mappings in the main contrib/ directory though. Can we add a subdirectory called transforms containing all of these? I don't see any value in that.

Re: [HACKERS] MVCC catalog access

2013-07-05 Thread Andres Freund
Hi Robert, On 2013-07-02 09:31:23 -0400, Robert Haas wrote: I have a few ideas for getting rid of the remaining uses of SnapshotNow that I'd like to throw out there: Is your current plan to get rid of SnapshotNow entirely? I am wonder because the changeset extraction needs to care and how the

Re: [HACKERS] strange IS NULL behaviour

2013-07-05 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Should I just mark this as a TODO? I thought it was on the list already. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

[HACKERS] Have REFRESH MATERIALIZED VIEW run as the MV owner

2013-07-05 Thread Noah Misch
REFRESH MATERIALIZED VIEW should temporarily switch the current user ID to the MV owner. REINDEX and VACUUM do so to let privileged users safely maintain objects owned by others, and REFRESH MATERIALIZED VIEW belongs in that class of commands. The MV query then runs as a security-restricted

Re: [HACKERS] strange IS NULL behaviour

2013-07-05 Thread Bruce Momjian
On Fri, Jul 5, 2013 at 12:43:57PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Should I just mark this as a TODO? I thought it was on the list already. We only have: Improve handling of NULLs in arrays and some pl/pgsql items regarding nulls. -- Bruce

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-07-05 Thread David Fetter
On Mon, Jul 01, 2013 at 05:30:38PM +0100, Dean Rasheed wrote: On 1 July 2013 01:44, David Fetter da...@fetter.org wrote: On Fri, Jun 28, 2013 at 09:22:52PM +0100, Dean Rasheed wrote: On 21 June 2013 06:16, David Fetter da...@fetter.org wrote: Please find attached a patch which allows

[HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-05 Thread ivan babrou
Hi, guys! I made a quick patch to support floating number in connect_timeout param for libpq. This will treat floating number as seconds so this is backwards-compatible. I don't usually write in C, so there may be mistakes. Could you review it and give me some feedback? -- Regards, Ian Babrou

Re: [HACKERS] GSOC13 proposal - extend RETURNING syntax

2013-07-05 Thread David Fetter
On Fri, Jul 05, 2013 at 03:22:33AM +0200, Karol Trzcionka wrote: Hello, according to my mentor's suggestion, I send first PoC patch of RETURNING AFTER/BEFORE statement. Some info: - it is early version - more hack PoC than RC patch - AFTER in this version works as decribed before but it

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-05 Thread Tom Lane
ivan babrou ibob...@gmail.com writes: Hi, guys! I made a quick patch to support floating number in connect_timeout param for libpq. What exactly is the use case for that? It seems like extra complication for something with little if any real-world usefulness. regards,

Re: [HACKERS] fallocate / posix_fallocate for new WAL file creation (etc...)

2013-07-05 Thread Jeff Davis
On Fri, 2013-07-05 at 08:21 -0500, Jon Nelson wrote: Wonderful. Is removing the GUC something that I should do or should that be done by somebody that knows more about what they are doing? (I am happy to give it a go!) I'll take care of that. Should the small test program that I made also be

Re: [HACKERS] Proposal - Support for National Characters functionality

2013-07-05 Thread Peter Eisentraut
On 7/4/13 10:11 PM, Arulappan, Arul Shaji wrote: The main aim at the moment is to get some feedback on the above to know if this feature is something that would benefit PostgreSQL in general, and if users maintaining DBs in non-English speaking regions will find this beneficial. For European

Re: [HACKERS] Proposal - Support for National Characters functionality

2013-07-05 Thread Pavel Stehule
Yes, what I know almost all use utf8 without problems. Long time I didn't see any request for multi encoding support. Dne 5.7.2013 20:28 Peter Eisentraut pete...@gmx.net napsal(a): On 7/4/13 10:11 PM, Arulappan, Arul Shaji wrote: The main aim at the moment is to get some feedback on the above

[HACKERS] Preventing tuple-table leakage in plpgsql

2013-07-05 Thread Tom Lane
Bug #8279 exhibits an intra-transaction memory leak in a plpgsql function that repeatedly traps an error. The cause of the leak is that the SPITupleTable created during exec_stmt_execsql is never cleaned up. (It will get cleaned up at function exit, but that's not soon enough in this usage.) The

Re: [HACKERS] Changing recovery.conf parameters into GUCs

2013-07-05 Thread Josh Berkus
Robert, Simon, All, On 04/01/2013 04:51 AM, Robert Haas wrote: On Thu, Mar 28, 2013 at 11:48 AM, Simon Riggs si...@2ndquadrant.com wrote: a) recovery parameters are made into GUCs (for which we have a patch from Fujii) b) all processes automatically read recovery.conf as the last step in

Re: [HACKERS] [PATCH] Add transforms feature

2013-07-05 Thread Josh Berkus
On 07/05/2013 09:08 AM, Peter Eisentraut wrote: On 7/3/13 7:15 PM, Josh Berkus wrote: I'm not comfortable with having all of the transform mappings in the main contrib/ directory though. Can we add a subdirectory called transforms containing all of these? I don't see any value in that.

Re: [HACKERS] GSOC13 proposal - extend RETURNING syntax

2013-07-05 Thread Karol Trzcionka
Updated patch: - include sgml - fix all compiler warnings - some cleanup - fix correctness of feature Regards, Karol diff --git a/doc/src/sgml/ref/update.sgml b/doc/src/sgml/ref/update.sgml index 90b9208..eba35f0 100644 --- a/doc/src/sgml/ref/update.sgml +++ b/doc/src/sgml/ref/update.sgml @@

[HACKERS] Review: extension template

2013-07-05 Thread Markus Wanner
Hi, I reviewed Dimitri's work on extension templates [2]. There's some discussion still ongoing and the patch has gone through several revisions since its addition to the current CF. The patch has already been marked as 'returned with feedback', and I can support that resolution (for this CF). I

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-07-05 Thread Josh Berkus
All, I think that's way over the top. Can we all just cool down a bit? I really don't see Josh as Stalin. I don't either. It is the judging others efforts that concerns me. I agree that publishing the committer portion of the list was a mistake, and will not include it in the future CFM

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-05 Thread ivan babrou
If you can figure out that postgresql is overloaded then you may decide what to do faster. In our app we have very strict limit for connect time to mysql, redis and other services, but postgresql has minimum of 2 seconds. When processing time for request is under 100ms on average sub-second

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-05 Thread Tom Lane
ivan babrou ibob...@gmail.com writes: If you can figure out that postgresql is overloaded then you may decide what to do faster. In our app we have very strict limit for connect time to mysql, redis and other services, but postgresql has minimum of 2 seconds. When processing time for request

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-05 Thread Josh Berkus
On 07/05/2013 12:26 PM, Tom Lane wrote: ivan babrou ibob...@gmail.com writes: If you can figure out that postgresql is overloaded then you may decide what to do faster. In our app we have very strict limit for connect time to mysql, redis and other services, but postgresql has minimum of 2

Re: [HACKERS] sepgsql and materialized views

2013-07-05 Thread Noah Misch
On Fri, Feb 08, 2013 at 02:51:40PM +0100, Kohei KaiGai wrote: 2013/2/7 Kevin Grittner kgri...@ymail.com: Kohei KaiGai kai...@kaigai.gr.jp wrote: So, I'd like to review two options. 1) we uses db_table object class for materialized-views for a while, until selinux-side become ready.

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-05 Thread Joshua D. Drake
On 7/5/2013 1:01 PM, Josh Berkus wrote: If you are issuing a fresh connection for each sub-100ms query, you're doing it wrong anyway ... It's fairly common with certain kinds of apps, including Rails and PHP. This is one of the reasons why we've discussed having a kind of stripped-down

Re: [HACKERS] Eliminating PD_ALL_VISIBLE, take 2

2013-07-05 Thread Jeff Davis
On Tue, 2013-07-02 at 10:12 -0700, Jeff Davis wrote: Regardless, this is at least a concrete issue that I can focus on, and I appreciate that. Are scans of small tables the primary objection to this patch, or are there others? If I solve it, will this patch make real progress? I had an idea

Re: [HACKERS] Review: query result history in psql

2013-07-05 Thread Josh Berkus
On 07/02/2013 06:16 PM, Robert Haas wrote: I'm kinda not all that convinced that this feature does anything that's actually useful. If you want to save your query results, you can just stick CREATE TEMP TABLE ans AS in front of your query. What does that not give you that this gives you?

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-05 Thread Tom Lane
Joshua D. Drake j...@commandprompt.com writes: On 7/5/2013 1:01 PM, Josh Berkus wrote: This is one of the reasons why we've discussed having a kind of stripped-down version of pgbouncer built into Postgres as a connection manager. If it weren't valuable to be able to relocate pgbouncer to

[HACKERS] Proposal: template-ify (binary) extensions

2013-07-05 Thread Markus Wanner
Hi, let me elaborate on an idea I had to streamline extension templates. As I wrote in my recent review [1], I didn't have the mental model of a template in mind for extensions, so far. However, writing the review, I came to think of it. I certainly agree that extensions which do not carry a

Re: [HACKERS] Review: extension template

2013-07-05 Thread Markus Wanner
On 07/05/2013 09:05 PM, Markus Wanner wrote: The patch has already been marked as 'returned with feedback', and I can support that resolution (for this CF). Oops.. I just realize it's only set to waiting on author, now. I guess I confused the two states. Please excuse my glitch. Dimitri, do

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-07-05 Thread Peter Geoghegan
On Thu, Jul 4, 2013 at 6:16 AM, Andrew Dunstan and...@dunslane.net wrote: You know what this reminds me of --- early communist movements. Members were scrutinized to see if they were working hard enough for the cause, and criticized/shamed/punished if they were not. The leaders became

Re: [HACKERS] sepgsql and materialized views

2013-07-05 Thread Tom Lane
Noah Misch n...@leadboat.com writes: On Fri, Feb 08, 2013 at 02:51:40PM +0100, Kohei KaiGai wrote: I'll have a discussion about new materialized_view object class on selinux list soon, then I'll submit a patch towards contrib/sepgsql according to the consensus here. Has this progressed?

Re: [HACKERS] Request for Patch Feedback: Lag Lead Window Functions Can Ignore Nulls

2013-07-05 Thread Jeff Davis
On Mon, 2013-07-01 at 07:40 -0400, Robert Haas wrote: On Sun, Jun 30, 2013 at 10:07 PM, Nicholas White n.j.wh...@gmail.com wrote: I've attached another iteration of the patch that fixes the multiple-window bug and adds ( uses) a function to create a Bitmapset using a custom allocator. I

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-07-05 Thread Jeff Janes
On Wed, Jul 3, 2013 at 12:03 PM, Christopher Browne cbbro...@gmail.comwrote: On Wed, Jul 3, 2013 at 2:24 PM, Cédric Villemain ced...@2ndquadrant.comwrote: Clearly I ticked off a bunch of people by publishing the list. On the other hand, in the 5 days succeeding the post, more than a

Re: [HACKERS] Request for Patch Feedback: Lag Lead Window Functions Can Ignore Nulls

2013-07-05 Thread Jeff Davis
On Fri, 2013-06-28 at 13:26 -0400, Robert Haas wrote: I haven't really reviewed the windowing-related code in depth; I thought Jeff might jump back in for that part of it. Jeff, is that something you're planning to do? Yes, getting back into this patch now after a bit of delay. Regards,

Re: [HACKERS] Millisecond-precision connect_timeout for libpq

2013-07-05 Thread ivan babrou
On 5 July 2013 23:26, Tom Lane t...@sss.pgh.pa.us wrote: ivan babrou ibob...@gmail.com writes: If you can figure out that postgresql is overloaded then you may decide what to do faster. In our app we have very strict limit for connect time to mysql, redis and other services, but postgresql has

[HACKERS] Re: Request for Patch Feedback: Lag Lead Window Functions Can Ignore Nulls

2013-07-05 Thread Jeff Davis
On Mon, 2013-07-01 at 18:20 -0400, Nicholas White wrote: pg_get_viewdef() needs to be updated Ah, good catch - I've fixed this in the attached. I also discovered that there's a parent-child hierarchy of WindowDefs (using relname-name), so instead of cloning the WindowDef (in parse_agg.c)

Re: [HACKERS] Preventing tuple-table leakage in plpgsql

2013-07-05 Thread Noah Misch
On Fri, Jul 05, 2013 at 02:47:06PM -0400, Tom Lane wrote: Bug #8279 exhibits an intra-transaction memory leak in a plpgsql function that repeatedly traps an error. The cause of the leak is that the SPITupleTable created during exec_stmt_execsql is never cleaned up. (It will get cleaned up at

Re: [HACKERS] Add regression tests for COLLATE

2013-07-05 Thread Andrew Dunstan
On 07/03/2013 03:16 PM, Andrew Dunstan wrote: On 07/03/2013 03:00 PM, Alvaro Herrera wrote: Robert Haas escribió: I agree. I think it'd be a good idea to get the buildfarm to run the existing collate.utf8.linux test regularly on platforms where it passes, +1 I can probably whip up a

Re: [HACKERS] Add regression tests for COLLATE

2013-07-05 Thread Andrew Dunstan
On 07/05/2013 07:44 PM, Andrew Dunstan wrote: On 07/03/2013 03:16 PM, Andrew Dunstan wrote: On 07/03/2013 03:00 PM, Alvaro Herrera wrote: Robert Haas escribió: I agree. I think it'd be a good idea to get the buildfarm to run the existing collate.utf8.linux test regularly on platforms

Re: [HACKERS] Add regression tests for COLLATE

2013-07-05 Thread Andres Freund
On 2013-07-03 14:17:20 -0400, Robert Haas wrote: I agree. I think it'd be a good idea to get the buildfarm to run the existing collate.utf8.linux test regularly on platforms where it passes, but this particular approach is valuable mostly because (supposedly) it was going to work everywhere.

Re: [HACKERS] pg_filedump 9.3: checksums (and a few other fixes)

2013-07-05 Thread Satoshi Nagayasu
Hi, I have reviewed this patch as a CF reviewer. (2013/06/27 4:07), Jeff Davis wrote: On Mon, 2013-06-24 at 20:34 -0400, Josh Kupershmidt wrote: This patch is in the current CommitFest, does it still need to be reviewed? If so, I notice that the version in pgfoundry's CVS is rather different

Re: [HACKERS] [PATCH] Fix conversion for Decimal arguments in plpython functions

2013-07-05 Thread Peter Eisentraut
On Fri, 2013-06-28 at 22:28 +0200, Szymon Guz wrote: I agree, we can check both. This is quite a nice patch now, I've reviewed it, all tests pass, works as expected. I think it is ready for committing. Committed. Very nice to get that finally fixed. -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [PATCH] Fix conversion for Decimal arguments in plpython functions

2013-07-05 Thread Peter Eisentraut
On Fri, 2013-06-28 at 17:29 -0300, Claudio Freire wrote: Why not forego checking of the type, and instead check the interface? plpy.info(x.as_tuple()) Should do. d = decimal.Decimal((0,(3,1,4),-2)) d.as_tuple() DecimalTuple(sign=0, digits=(3, 1, 4), exponent=-2) I think that

Re: [HACKERS] [PATCH] Fix conversion for Decimal arguments in plpython functions

2013-07-05 Thread Claudio Freire
On Fri, Jul 5, 2013 at 11:47 PM, Peter Eisentraut pete...@gmx.net wrote: On Fri, 2013-06-28 at 17:29 -0300, Claudio Freire wrote: Why not forego checking of the type, and instead check the interface? plpy.info(x.as_tuple()) Should do. d = decimal.Decimal((0,(3,1,4),-2)) d.as_tuple()

[HACKERS] review: WITH CHECK OPTION

2013-07-05 Thread Pavel Stehule
Hello 0) we would this feature * it is finalization of ANSI SQL feature, that is complete now * it is useful feature, than moves work with updatable views close to heaps 1) patch is cleanly applied 2) there are no new warnings 3) all regress tests was passed - there are enough tests for this

Re: [HACKERS] Changing recovery.conf parameters into GUCs

2013-07-05 Thread Michael Paquier
On Sat, Jul 6, 2013 at 3:49 AM, Josh Berkus j...@agliodbs.com wrote: Robert, Simon, All, On 04/01/2013 04:51 AM, Robert Haas wrote: On Thu, Mar 28, 2013 at 11:48 AM, Simon Riggs si...@2ndquadrant.com wrote: a) recovery parameters are made into GUCs (for which we have a patch from Fujii) b)

Re: [HACKERS] sepgsql and materialized views

2013-07-05 Thread Kohei KaiGai
Unfortunately, I could not get consensus of design on selinux policy side. Even though my opinion is to add individual security class for materialized view to implement refresh permission, other people has different opinion. So, I don't want it shall be a blocker of v9.3 to avoid waste of time.

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

2013-07-05 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: PL/Python: Convert numeric to Decimal Assorted buildfarm members don't like this patch. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] pg_filedump 9.3: checksums (and a few other fixes)

2013-07-05 Thread Jeff Davis
On Sat, 2013-07-06 at 10:30 +0900, Satoshi Nagayasu wrote: Hi, It looks fine, but I have one question here. When I run pg_filedump with -k against a database cluster which does not support checksums, pg_filedump produced checksum error as following. Is this expected or acceptable? Thank

Re: [HACKERS] [COMMITTERS] pgsql: PL/Python: Convert numeric to Decimal

2013-07-05 Thread Claudio Freire
On Sat, Jul 6, 2013 at 2:39 AM, Tom Lane t...@sss.pgh.pa.us wrote: Peter Eisentraut pete...@gmx.net writes: PL/Python: Convert numeric to Decimal Assorted buildfarm members don't like this patch. Do you have failure details? This is probably an attempt to operate decimals vs floats. Ie: