Re: [HACKERS] Column Redaction

2014-10-11 Thread Simon Riggs
On 10 October 2014 16:45, Rod Taylor rod.tay...@gmail.com wrote: On my laptop I can pull all 10,000 card numbers in less than 1 second. Right. Like I said: covert channels exist. Great example of how to exploit them, thanks. Cool SQL. What could be the use of a security feature that does not

Re: [HACKERS] jsonb contains behaviour weirdness

2014-10-11 Thread Peter Geoghegan
This was never committed... On Sat, Sep 13, 2014 at 4:31 PM, Peter Geoghegan p...@heroku.com wrote: On Fri, Sep 12, 2014 at 6:40 AM, Alexander Korotkov aekorot...@gmail.com wrote: It's likely that JB_ROOT_COUNT(val) JB_ROOT_COUNT(tmpl) should be checked only for objects, not arrays. Also,

Re: [HACKERS] Column Redaction

2014-10-11 Thread Simon Riggs
On 10 October 2014 11:27, Heikki Linnakangas hlinnakan...@vmware.com wrote: I googled for Oracle Data redaction, and found General Usage guidelines: General Usage Guidelines * Oracle Data Redaction is not intended to protect against attacks by privileged database users who run ad hoc

Re: [HACKERS] orangutan seizes up during isolation-check

2014-10-11 Thread Peter Eisentraut
On 10/11/14 1:41 AM, Noah Misch wrote: Good question. It would be nice to make the change there, for the benefit of other consumers. The patch's setlocale_native_forked() assumes it never runs in a multithreaded process, but libintl_setlocale() must not assume that. I see a few ways

Re: [HACKERS] Wait free LW_SHARED acquisition - v0.9

2014-10-11 Thread Andres Freund
Hi, On 2014-10-11 07:26:57 +0530, Amit Kapila wrote: On Sat, Oct 11, 2014 at 7:00 AM, Andres Freund and...@2ndquadrant.com And since your general performance numbers are a fair bit lower than what I see with, hopefully, the same code on the same machine... You have reported numbers at

Re: [HACKERS] Add CREATE support to event triggers

2014-10-11 Thread Michael Paquier
On Thu, Oct 9, 2014 at 8:29 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Oct 9, 2014 at 6:26 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: However, if I were to do it, I would instead create a quote.h file and would also add the quote_literal_cstr() prototype to it,

Re: [HACKERS] Wait free LW_SHARED acquisition - v0.9

2014-10-11 Thread Amit Kapila
On Sat, Oct 11, 2014 at 6:40 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-10-11 07:26:57 +0530, Amit Kapila wrote: On Sat, Oct 11, 2014 at 7:00 AM, Andres Freund and...@2ndquadrant.com And since your general performance numbers are a fair bit lower than what I see with,

Re: [HACKERS] Column Redaction

2014-10-11 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/11/2014 02:40 AM, Simon Riggs wrote: As soon as you issue the above query, you have clearly indicated your intention to steal. Receiving information is no longer accidental, it is an explicit act that is logged in the auditing system

Re: [HACKERS] Column Redaction

2014-10-11 Thread Bruce Momjian
On Sat, Oct 11, 2014 at 09:51:28AM +0100, Simon Riggs wrote: So it's not actually suitable for the example you gave. I don't think we want this feature... The full quote I read is the following... Even though Oracle Data Redaction is not intended to protect against attacks by database

[HACKERS] split builtins.h to quote.h

2014-10-11 Thread Alvaro Herrera
Started a new thread to raise awareness. Michael Paquier wrote: On Thu, Oct 9, 2014 at 8:29 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Oct 9, 2014 at 6:26 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: However, if I were to do it, I would instead create a quote.h

Re: [HACKERS] Wait free LW_SHARED acquisition - v0.9

2014-10-11 Thread Andres Freund
On 2014-10-11 15:10:45 +0200, Andres Freund wrote: Hi, On 2014-10-11 07:26:57 +0530, Amit Kapila wrote: On Sat, Oct 11, 2014 at 7:00 AM, Andres Freund and...@2ndquadrant.com And since your general performance numbers are a fair bit lower than what I see with, hopefully, the same

[HACKERS] Function array_agg(array)

2014-10-11 Thread Ali Akbar
Greetings, While looking for easier items in PostgreSQL Wiki's Todo List (this will be my 3rd patch), i found this TODO: Add a built-in array_agg(anyarray) or similar, that can aggregate 1-dimensional arrays into a 2-dimensional array. I've stumbled by this lack of array_agg(anyarray)

Re: [HACKERS] Function array_agg(array)

2014-10-11 Thread Tom Lane
Ali Akbar the.ap...@gmail.com writes: So, can't we just set the typarray of array types to its self oid? Seems dangerous as heck; certainly it would have side-effects far more wide-ranging than just making this particular function work. A safer answer is to split array_agg into two functions,

Re: [HACKERS] jsonb contains behaviour weirdness

2014-10-11 Thread Tom Lane
Peter Geoghegan p...@heroku.com writes: This was never committed... Yeah ... the discussion trailed off and I think we forgot to actually commit a fix. Will go do so. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] pg_dump refactor patch to remove global variables

2014-10-11 Thread Alvaro Herrera
Here's the complete patch in case anyone is wondering. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services diff --git a/src/bin/pg_dump/common.c b/src/bin/pg_dump/common.c index 2f855cf..17e9574 100644 ---

Re: [HACKERS] Shared memory changes in 9.4?

2014-10-11 Thread Bruce Momjian
Uh, this patch was never applied. Do we want it? --- On Thu, Jun 12, 2014 at 03:39:14PM +0200, Christoph Berg wrote: Re: Andres Freund 2014-06-12 20140612094112.gz8...@alap3.anarazel.de * Make initdb determine the best

Re: [HACKERS] uninitialized values in revised prepared xact code

2014-10-11 Thread Bruce Momjian
Uh, was this fixed. I see a cleanup commit for this C file, but this report is from June: commit 07a4a93a0e35a778c77ffbbbc18de29e859e18f0 Author: Heikki Linnakangas heikki.linnakan...@iki.fi Date: Fri May 16 09:47:50 2014 +0300 Initialize tsId and

Re: [HACKERS] No toast table for pg_shseclabel but for pg_seclabel

2014-10-11 Thread Bruce Momjian
On Fri, Jul 4, 2014 at 10:53:15AM -0400, Tom Lane wrote: Kohei KaiGai kai...@kaigai.gr.jp writes: Here is no other reason than what Alvaro mentioned in the upthread. We intended to store security label of SELinux (less than 100bytes at most), so I didn't think it leads any problem

Re: [HACKERS] Performance regression: 9.2+ vs. ScalarArrayOpExpr vs. ORDER BY

2014-10-11 Thread Bruce Momjian
Uh, did this ever get addressed? --- On Sun, Jul 6, 2014 at 08:56:00PM +0100, Andrew Gierth wrote: Tom == Tom Lane t...@sss.pgh.pa.us writes: I've experimented with the attached patch, which detects when this

Re: [HACKERS] No toast table for pg_shseclabel but for pg_seclabel

2014-10-11 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Fri, Jul 4, 2014 at 10:53:15AM -0400, Tom Lane wrote: So maybe we should get rid of the toast table for pg_seclabel. One less catalog table for a feature that hardly anyone is using seems like a fine idea to me ... Is this still an open item? I

Re: [HACKERS] Shapes on the regression test for polygon

2014-10-11 Thread Bruce Momjian
On Wed, Jul 23, 2014 at 06:12:59PM -0400, Robert Haas wrote: On Wed, Jul 23, 2014 at 4:06 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Jul 21, 2014 at 10:52 AM, Emre Hasegeli e...@hasegeli.com wrote: The first two shapes on

Re: [HACKERS] No toast table for pg_shseclabel but for pg_seclabel

2014-10-11 Thread Fabrízio de Royes Mello
On Sat, Oct 11, 2014 at 5:40 PM, Tom Lane t...@sss.pgh.pa.us wrote: Bruce Momjian br...@momjian.us writes: On Fri, Jul 4, 2014 at 10:53:15AM -0400, Tom Lane wrote: So maybe we should get rid of the toast table for pg_seclabel. One less catalog table for a feature that hardly anyone is

Re: [HACKERS] split builtins.h to quote.h

2014-10-11 Thread Noah Misch
On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: Started a new thread to raise awareness. Ref: this comes from http://www.postgresql.org/message-id/cab7npqr1ivd5r_qn_ngmkbolqmagbosj4wnpo8eybnn6we_...@mail.gmail.com Thanks. You can assume I'm -1 on every header split proposal

Re: [HACKERS] Remove comment about manually flipping attnotnull

2014-10-11 Thread Bruce Momjian
On Thu, Jul 24, 2014 at 12:51:09PM -0400, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: catalogs.sgml has this comment: This represents a not-null constraint. It is possible to change this column to enable or disable the constraint. Someone on irc just took

Re: [HACKERS] split builtins.h to quote.h

2014-10-11 Thread Bruce Momjian
On Sat, Oct 11, 2014 at 05:19:27PM -0400, Noah Misch wrote: On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: Started a new thread to raise awareness. Ref: this comes from http://www.postgresql.org/message-id/cab7npqr1ivd5r_qn_ngmkbolqmagbosj4wnpo8eybnn6we_...@mail.gmail.com

Re: [HACKERS] multixact optimization patches

2014-10-11 Thread Bruce Momjian
On Tue, Jul 29, 2014 at 03:56:19PM -0400, Alvaro Herrera wrote: I have just pushed two optimization patches for multixacts to HEAD only. I hesitate to backpatch them to 9.3 right away, but will consider doing so if people think differently. I also have a patch that supposedly fixes the

Re: [HACKERS] No toast table for pg_shseclabel but for pg_seclabel

2014-10-11 Thread Andres Freund
On 2014-10-11 18:19:05 -0300, Fabrízio de Royes Mello wrote: On Sat, Oct 11, 2014 at 5:40 PM, Tom Lane t...@sss.pgh.pa.us wrote: Bruce Momjian br...@momjian.us writes: On Fri, Jul 4, 2014 at 10:53:15AM -0400, Tom Lane wrote: So maybe we should get rid of the toast table for

Re: [HACKERS] split builtins.h to quote.h

2014-10-11 Thread Andres Freund
On 2014-10-11 17:19:27 -0400, Noah Misch wrote: On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: Started a new thread to raise awareness. Ref: this comes from http://www.postgresql.org/message-id/cab7npqr1ivd5r_qn_ngmkbolqmagbosj4wnpo8eybnn6we_...@mail.gmail.com Thanks.

Re: [HACKERS] split builtins.h to quote.h

2014-10-11 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: On Sat, Oct 11, 2014 at 05:19:27PM -0400, Noah Misch wrote: On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: Started a new thread to raise awareness. Ref: this comes from

Re: [HACKERS] pg_dump refactor patch to remove global variables

2014-10-11 Thread Fabrízio de Royes Mello
On Sat, Oct 11, 2014 at 2:56 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Here's the complete patch in case anyone is wondering. Hi, Your patch doesn't apply to master: $ git apply ~/Downloads/pg_dump_refactor_globals.6.diff /home/fabrizio/Downloads/pg_dump_refactor_globals.6.diff:10:

Re: [HACKERS] No toast table for pg_shseclabel but for pg_seclabel

2014-10-11 Thread Stephen Frost
* Andres Freund (and...@2ndquadrant.com) wrote: On 2014-10-11 18:19:05 -0300, Fabrízio de Royes Mello wrote: On Sat, Oct 11, 2014 at 5:40 PM, Tom Lane t...@sss.pgh.pa.us wrote: Bruce Momjian br...@momjian.us writes: On Fri, Jul 4, 2014 at 10:53:15AM -0400, Tom Lane wrote: So

Re: [HACKERS] split builtins.h to quote.h

2014-10-11 Thread Noah Misch
On Sat, Oct 11, 2014 at 11:43:46PM +0200, Andres Freund wrote: On 2014-10-11 17:19:27 -0400, Noah Misch wrote: On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: Started a new thread to raise awareness. Ref: this comes from

Re: [HACKERS] split builtins.h to quote.h

2014-10-11 Thread Stephen Frost
* Noah Misch (n...@leadboat.com) wrote: On Sat, Oct 11, 2014 at 11:43:46PM +0200, Andres Freund wrote: I personally wouldn't object plaing a #include for the splitof file into builtin.h to address backward compat concerns. Would imo still be an improvement. Agreed. If the patch

Re: [HACKERS] Is analyze_new_cluster.sh still useful?

2014-10-11 Thread Bruce Momjian
On Mon, Aug 4, 2014 at 10:17:40AM +0200, Christoph Berg wrote: Re: Bruce Momjian 2014-07-29 20140729094234.gc13...@momjian.us On Fri, Jun 20, 2014 at 05:15:05PM +0200, Christoph Berg wrote: Another nitpick here: What pg_upgrade outputs doesn't even work on most systems, you need to

Re: [HACKERS] Looked at TODO:Considering improving performance of computing CHAR() value lengths

2014-10-11 Thread Bruce Momjian
On Mon, Aug 4, 2014 at 11:48:38AM +0300, Heikki Linnakangas wrote: The biggest issue with the previously discussed patches was the lack of performance testing. People posted results of various micro-benchmarks that showed different aspects, but no-one comprehensively covered all the

Re: [HACKERS] [REVIEW] pg_last_xact_insert_timestamp

2014-10-11 Thread Bruce Momjian
On Wed, Aug 13, 2014 at 12:41:24PM +0900, Fujii Masao wrote: On Mon, Aug 11, 2014 at 8:27 PM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Aug 11, 2014 at 4:46 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, On 2011-10-04 20:52:59 +0900, Fujii Masao wrote: ***

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

2014-10-11 Thread Bruce Momjian
On Tue, Aug 12, 2014 at 07:08:06PM -0400, Robert Haas wrote: On Tue, Aug 12, 2014 at 12:59 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-08-12 09:42:30 -0700, Sean Chittenden wrote: One of the patches that I've been sitting on and am derelict in punting upstream is the attached

Re: [HACKERS] pg_dump refactor patch to remove global variables

2014-10-11 Thread Alvaro Herrera
Fabrízio de Royes Mello wrote: On Sat, Oct 11, 2014 at 2:56 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Here's the complete patch in case anyone is wondering. Hi, Your patch doesn't apply to master: I think your email system mangled it. I can download it from archives and

Re: [HACKERS] B-Tree support function number 3 (strxfrm() optimization)

2014-10-11 Thread Peter Geoghegan
On Mon, Sep 29, 2014 at 10:34 PM, Peter Geoghegan p...@heroku.com wrote: single sortsupport state patch. You probably noticed that I posted an independently useful patch to make all tuplesort cases use sortsupport [1] - currently, both the B-Tree and CLUSTER cases do not use the sortsupport

Re: [HACKERS] pg_dump refactor patch to remove global variables

2014-10-11 Thread Fabrízio de Royes Mello
On Sat, Oct 11, 2014 at 10:15 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Fabrízio de Royes Mello wrote: On Sat, Oct 11, 2014 at 2:56 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Here's the complete patch in case anyone is wondering. Hi, Your patch doesn't

Re: [HACKERS] psql output change in 9.4

2014-10-11 Thread Peter Eisentraut
On 10/11/14 8:25 PM, Bruce Momjian wrote: On Mon, Aug 11, 2014 at 02:28:45PM -0400, Robert Haas wrote: On Mon, Aug 11, 2014 at 1:52 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Fri, Aug 8, 2014 at 9:34 PM, Peter Eisentraut pete...@gmx.net wrote: What is

Re: [HACKERS] split builtins.h to quote.h

2014-10-11 Thread Michael Paquier
On Sun, Oct 12, 2014 at 7:09 AM, Stephen Frost sfr...@snowman.net wrote: * Noah Misch (n...@leadboat.com) wrote: On Sat, Oct 11, 2014 at 11:43:46PM +0200, Andres Freund wrote: I personally wouldn't object plaing a #include for the splitof file into builtin.h to address backward compat