Re: [HACKERS] [PATCH] server_version_num should be GUC_REPORT

2015-01-18 Thread Craig Ringer
On 9 January 2015 at 22:53, Tom Lane t...@sss.pgh.pa.us wrote: Craig Ringer cr...@2ndquadrant.com writes: While looking into client code that relies on parsing server_version instead of checking server_version_num, I was surprised to discover that server_version_num isn't sent to the

Re: [HACKERS] Reducing buildfarm disk usage: remove temp installs when done

2015-01-18 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 01/18/2015 09:20 PM, Tom Lane wrote: What I see on dromedary, which has been around a bit less than a year, is that the at-rest space consumption for all 6 active branches is 2.4G even though a single copy of the git repo is just over 400MB: $ du

Re: [HACKERS] pg_rewind in contrib

2015-01-18 Thread Michael Paquier
Heikki Linnakangas wrote: Addressed most of your comments, and Michael's. Another version attached. Looking at the set of TAP tests, I think that those lines open again the door of CVE-2014-0067 (vulnerability with make check) on Windows: # Initialize master, data checksums are mandatory

Re: [HACKERS] Async execution of postgres_fdw.

2015-01-18 Thread Kyotaro HORIGUCHI
Hello, that's a silly mistake. fetch_seize = 1 in the v4 patch. This v5 patch is fixed at the point. But the v4 patch mysteriously accelerates this query, 6.5 seconds. =# EXPLAIN (ANALYZE ON, COSTS OFF) SELECT x.a, x.c, y.c FROM ft1 AS x JOIN ft1 AS y on x.a = y.a; ... Execution

Re: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code

2015-01-18 Thread Michael Paquier
On Mon, Jan 19, 2015 at 4:10 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Jan 17, 2015 at 2:44 AM, Andres Freund and...@2ndquadrant.com wrote: Am I missing something or does this handle/affect streaming failures just the same? That might not be a bad idea, because the current

Re: Partitioning: issues/ideas (Was: Re: [HACKERS] On partitioning)

2015-01-18 Thread Ashutosh Bapat
On Fri, Jan 16, 2015 at 11:04 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Jan 14, 2015 at 9:07 PM, Amit Langote langote_amit...@lab.ntt.co.jp wrote: * It has been repeatedly pointed out that we may want to decouple partitioning from inheritance because implementing partitioning as

Re: [HACKERS] Reducing buildfarm disk usage: remove temp installs when done

2015-01-18 Thread Andrew Dunstan
On 01/18/2015 09:20 PM, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: On 01/18/2015 05:48 PM, Tom Lane wrote: One of the biggest causes of buildfarm run failures is out of disk space. That's not just because people are running buildfarm critters on small slow machines; it's

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-01-18 Thread Pavel Stehule
2015-01-19 4:54 GMT+01:00 Robert Haas robertmh...@gmail.com: On Sat, Jan 17, 2015 at 8:27 PM, Pavel Stehule pavel.steh...@gmail.com wrote: two years a operator = is marked as deprecated (from PostgreSQL 9.2). Isn't time to use it for named parameters now (for PostgreSQL 9.5) ? I'm cool

Re: [HACKERS] Parallel Seq Scan

2015-01-18 Thread Amit Kapila
On Sat, Jan 17, 2015 at 10:09 AM, Robert Haas robertmh...@gmail.com wrote: On Fri, Jan 16, 2015 at 11:27 PM, Amit Kapila amit.kapil...@gmail.com wrote: Assuming we will increment next_prefetch_block only after prefetching blocks (equivalent to prefetch_increment), won't 2 workers can

Re: [HACKERS] install libpq.dll in bin directory on Windows / Cygwin

2015-01-18 Thread Peter Eisentraut
On 1/15/15 2:37 AM, Michael Paquier wrote: On Wed, Dec 24, 2014 at 3:08 PM, Michael Paquier michael.paqu...@gmail.com wrote: Attached are two patches, one for MinGW/cygwin, a slightly modified version from Peter and the second implementing the same thing but for the MSVC scripts. The method

Re: Partitioning: issues/ideas (Was: Re: [HACKERS] On partitioning)

2015-01-18 Thread Amit Langote
On 19-01-2015 PM 12:37, Ashutosh Bapat wrote: On Fri, Jan 16, 2015 at 11:04 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Jan 14, 2015 at 9:07 PM, Amit Langote langote_amit...@lab.ntt.co.jp wrote: I wonder if we could add a clause like DISTRIBUTED BY to complement PARTITION ON that

Re: [HACKERS] pg_rewind in contrib

2015-01-18 Thread Michael Paquier
On Mon, Jan 19, 2015 at 2:38 PM, Michael Paquier michael.paqu...@gmail.com wrote: Heikki Linnakangas wrote: Addressed most of your comments, and Michael's. Another version attached. Extra thing: src/bin/pg_rewind/Makefile surely forgets to clean up the stuff from the regression tests: +clean

Re: [HACKERS] TABLESAMPLE patch

2015-01-18 Thread Amit Kapila
On Sun, Jan 18, 2015 at 12:46 AM, Petr Jelinek p...@2ndquadrant.com wrote: On 17/01/15 13:46, Amit Kapila wrote: 3. @@ -332,6 +334,11 @@ set_rel_pathlist(PlannerInfo *root, RelOptInfo *rel, /* Foreign table */ set_foreign_pathlist(root, rel, rte); } +else if (rte-tablesample != NULL) +{

Re: [HACKERS] hamerkop is stuck

2015-01-18 Thread TAKATSUKA Haruka
Hello. Sorry about giving corrupted reports. We examine what it is caused by now. regards, --- TAKATSUKA Haruka haru...@sraoss.co.jp SRA OSS, Inc. http://www.sraoss.co.jp On Fri, 16 Jan 2015 03:25:00 -0500 Noah Misch n...@leadboat.com wrote: Buildfarm member hamerkop stopped reporting

Re: [HACKERS] New CF app deployment

2015-01-18 Thread Michael Paquier
On Tue, Jan 13, 2015 at 2:35 PM, Magnus Hagander mag...@hagander.net wrote: Further status updates to come as we start working on it... Things are looking good so far. All the information has been synced up between both apps for the current CF and the next one. One the switch is done, I would

Re: [HACKERS] Re: Better way of dealing with pgstat wait timeout during buildfarm runs?

2015-01-18 Thread Robert Haas
On Sun, Jan 18, 2015 at 4:09 PM, Tom Lane t...@sss.pgh.pa.us wrote: After looking at the code, the minimum-change alternative would be more or less as attached: first, get rid of the long-obsolete proposition that autovacuum workers need fresher-than-usual stats; second, allow

Re: [HACKERS] Merging postgresql.conf and postgresql.auto.conf

2015-01-18 Thread Robert Haas
On Sat, Jan 17, 2015 at 12:19 AM, Amit Kapila amit.kapil...@gmail.com wrote: So are you telling that whenever we read, save the settings to some catalog (probably a new one)? Which process are you imagining would do this? Certainly not the postmaster. Independently of that, it sounds like

Re: [HACKERS] install libpq.dll in bin directory on Windows / Cygwin

2015-01-18 Thread Michael Paquier
On Mon, Jan 19, 2015 at 12:41 PM, Peter Eisentraut pete...@gmx.net wrote: I have committed my mingw portion, but I cannot take on the MSVC part. OK, no problem. Perhaps I should add a new entry in the next CF for the MSVC portion? -- Michael -- Sent via pgsql-hackers mailing list

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-01-18 Thread Stephen Frost
Abhijit, Apologies, I've been meaning to go through this for quite some time. * Abhijit Menon-Sen (a...@2ndquadrant.com) wrote: I've changed pgaudit to work as you suggested. Great, glad to see that. A quick note on the implementation: pgaudit was already installing an

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-01-18 Thread Robert Haas
On Sat, Jan 17, 2015 at 8:27 PM, Pavel Stehule pavel.steh...@gmail.com wrote: two years a operator = is marked as deprecated (from PostgreSQL 9.2). Isn't time to use it for named parameters now (for PostgreSQL 9.5) ? I'm cool with that. It's possible that there are installations out there

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2015-01-18 Thread Abhijit Menon-Sen
Hello Stephen. Thanks very much for having a look at the revised pgaudit. At 2015-01-18 22:28:37 -0500, sfr...@snowman.net wrote: 2. Set pgaudit.roles = 'r1, r2, …', which logs everything done by r1, r2, and any of their descendants. If these roles were the 'audit' roles as considered

Re: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code

2015-01-18 Thread Michael Paquier
On Sat, Jan 17, 2015 at 2:44 AM, Andres Freund and...@2ndquadrant.com wrote: On 2015-01-05 17:16:43 +0900, Michael Paquier wrote: + varlistentry id=restore-command-retry-interval xreflabel=restore_command_retry_interval + termvarnamerestore_command_retry_interval/varname

Re: [HACKERS] Reducing buildfarm disk usage: remove temp installs when done

2015-01-18 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 01/18/2015 05:48 PM, Tom Lane wrote: One of the biggest causes of buildfarm run failures is out of disk space. That's not just because people are running buildfarm critters on small slow machines; it's because make check-world is an enormous

Re: [HACKERS] Reducing buildfarm disk usage: remove temp installs when done

2015-01-18 Thread Andrew Dunstan
On 01/18/2015 05:48 PM, Tom Lane wrote: One of the biggest causes of buildfarm run failures is out of disk space. That's not just because people are running buildfarm critters on small slow machines; it's because make check-world is an enormous space hog. Some numbers from current HEAD:

Re: [HACKERS] moving from contrib to bin

2015-01-18 Thread Michael Paquier
On Sun, Jan 18, 2015 at 10:21 PM, Andres Freund and...@2ndquadrant.com wrote: On 2015-01-18 21:05:29 +0900, Michael Paquier wrote: On Sat, Jan 17, 2015 at 10:08 PM, Andres Freund and...@2ndquadrant.com wrote: Observations: 1) Are we sure it's a good idea to rely on pgxs.mk in src/bin

Re: [HACKERS] Re: Better way of dealing with pgstat wait timeout during buildfarm runs?

2015-01-18 Thread Noah Misch
On Sun, Jan 18, 2015 at 07:02:54PM -0500, Tom Lane wrote: Noah Misch n...@leadboat.com writes: On Sun, Jan 18, 2015 at 04:09:29PM -0500, Tom Lane wrote: After looking at the code, the minimum-change alternative would be more or less as attached: first, get rid of the long-obsolete

Re: [HACKERS] moving from contrib to bin

2015-01-18 Thread Andrew Gierth
Correct me if I'm wrong, but is it not the case that: 1) pg_standby was intended to be customizable code, even if usable as distributed, and 2) in any event it is essentially deprecated in favour of standby_mode and therefore moving it to src/bin seems like a wrong move on two counts? --

Re: [HACKERS] moving from contrib to bin

2015-01-18 Thread Andres Freund
Hi, On 2015-01-18 12:56:59 +, Andrew Gierth wrote: Correct me if I'm wrong, but is it not the case that: 1) pg_standby was intended to be customizable code, even if usable as distributed, and I don't think that really happened in reality though... 2) in any event it is essentially

Re: [HACKERS] moving from contrib to bin

2015-01-18 Thread Alvaro Herrera
Andres Freund wrote: Hi, On 2015-01-18 12:56:59 +, Andrew Gierth wrote: and therefore moving it to src/bin seems like a wrong move on two counts? I personally agree that that pg_standby shouldn't be moved. Even if we could not find agreement to remove it, there's little reason to

[HACKERS] PGCon 2015

2015-01-18 Thread Dan Langille
Is your PGCon 2015 submission going in today or tomorrow? -- Dan Langille http://langille.org/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] moving from contrib to bin

2015-01-18 Thread Peter Eisentraut
On 1/17/15 8:08 AM, Andres Freund wrote: 1) Are we sure it's a good idea to rely on pgxs.mk in src/bin programs? I am. Why not? -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] moving from contrib to bin

2015-01-18 Thread Peter Eisentraut
On 1/18/15 8:16 AM, Andres Freund wrote: On 2015-01-18 22:02:13 +0900, Michael Paquier wrote: On Sun, Jan 18, 2015 at 9:56 PM, Andrew Gierth 2) in any event it is essentially deprecated in favour of standby_mode and therefore moving it to src/bin seems like a wrong move on two counts? There

Re: [HACKERS] moving from contrib to bin

2015-01-18 Thread Michael Paquier
On Sat, Jan 17, 2015 at 10:08 PM, Andres Freund and...@2ndquadrant.com wrote: Observations: 1) Are we sure it's a good idea to rely on pgxs.mk in src/bin programs? Yeah, this seems like a bad dependency, PGXS being made for contrib modules... So corrected in the patch attached (the headers of

Re: [HACKERS] moving from contrib to bin

2015-01-18 Thread Michael Paquier
On Sun, Jan 18, 2015 at 9:56 PM, Andrew Gierth and...@tao11.riddles.org.uk wrote: Correct me if I'm wrong, but is it not the case that: 1) pg_standby was intended to be customizable code, even if usable as distributed, and I am not sure about that. 2) in any event it is essentially deprecated

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2015-01-18 Thread Ali Akbar
2015-01-18 10:44 GMT+07:00 Peter Eisentraut pete...@gmx.net: On 1/7/15 8:51 PM, Ali Akbar wrote: So now +1 for back-patching this. Done. Was a bit of work to get it into all the old versions. Wow. Thanks. Btw, for bug-fix patches like this, should the patch creator (me) also create

Re: [HACKERS] moving from contrib to bin

2015-01-18 Thread Andres Freund
On 2015-01-18 22:02:13 +0900, Michael Paquier wrote: On Sun, Jan 18, 2015 at 9:56 PM, Andrew Gierth 2) in any event it is essentially deprecated in favour of standby_mode and therefore moving it to src/bin seems like a wrong move on two counts? There were some discussions about that a couple

Re: [HACKERS] moving from contrib to bin

2015-01-18 Thread Andres Freund
On 2015-01-18 21:05:29 +0900, Michael Paquier wrote: On Sat, Jan 17, 2015 at 10:08 PM, Andres Freund and...@2ndquadrant.com wrote: Observations: 1) Are we sure it's a good idea to rely on pgxs.mk in src/bin programs? Yeah, this seems like a bad dependency, PGXS being made for contrib

Re: [HACKERS] moving from contrib to bin

2015-01-18 Thread Michael Paquier
Simon, Bruce, Ants, (CCing..) On Sun, Jan 18, 2015 at 9:05 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Sat, Jan 17, 2015 at 10:08 PM, Andres Freund and...@2ndquadrant.com wrote: 7) Are we sure that the authors in the affected contrib modules are ok with their authorship notice

Re: [HACKERS] proposal: row_to_array function

2015-01-18 Thread Pavel Stehule
2015-01-17 7:26 GMT+01:00 Pavel Stehule pavel.steh...@gmail.com: 2015-01-16 22:35 GMT+01:00 Andrew Dunstan and...@dunslane.net: On 01/16/2015 12:22 PM, Pavel Stehule wrote: There two possible transformations: row_to_array -- [[key1, value1],[key2, value2], ...]

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2015-01-18 Thread David Fetter
On Sun, Jan 18, 2015 at 06:05:05PM +0700, Ali Akbar wrote: 2015-01-18 10:44 GMT+07:00 Peter Eisentraut pete...@gmx.net: On 1/7/15 8:51 PM, Ali Akbar wrote: So now +1 for back-patching this. Done. Was a bit of work to get it into all the old versions. Wow. Thanks. Btw, for

[HACKERS] Re: Better way of dealing with pgstat wait timeout during buildfarm runs?

2015-01-18 Thread Noah Misch
On Sat, Dec 27, 2014 at 07:55:05PM -0500, Tom Lane wrote: To get back to that original complaint about buildfarm runs failing, I notice that essentially all of those failures are coming from wait timeout warnings reported by manual VACUUM commands. Now, VACUUM itself has no need to read the

Re: [HACKERS] Reducing buildfarm disk usage: remove temp installs when done

2015-01-18 Thread Michael Paquier
On Mon, Jan 19, 2015 at 7:48 AM, Tom Lane t...@sss.pgh.pa.us wrote: To make things better in the buildfarm, we'd have to back-patch this into all active branches, but I don't see any big problem with doing so. Any objections? Back-patching sounds like a good idea to me. At least this will allow

Re: [HACKERS] Re: Better way of dealing with pgstat wait timeout during buildfarm runs?

2015-01-18 Thread Noah Misch
On Sun, Jan 18, 2015 at 04:09:29PM -0500, Tom Lane wrote: Noah Misch n...@leadboat.com writes: On Sat, Dec 27, 2014 at 07:55:05PM -0500, Tom Lane wrote: Or, much more simply, we could conclude that it's not that important if pgstat_vacuum_stat() is unable to get up-to-date stats, and

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2015-01-18 Thread Michael Paquier
On Mon, Jan 19, 2015 at 2:38 AM, David Fetter da...@fetter.org wrote: On Sun, Jan 18, 2015 at 06:05:05PM +0700, Ali Akbar wrote: 2015-01-18 10:44 GMT+07:00 Peter Eisentraut pete...@gmx.net: Btw, for bug-fix patches like this, should the patch creator (me) also create patches for back branches?

Re: [HACKERS] Re: Better way of dealing with pgstat wait timeout during buildfarm runs?

2015-01-18 Thread Tom Lane
Noah Misch n...@leadboat.com writes: On Sun, Jan 18, 2015 at 04:09:29PM -0500, Tom Lane wrote: After looking at the code, the minimum-change alternative would be more or less as attached: first, get rid of the long-obsolete proposition that autovacuum workers need fresher-than-usual stats;

Re: [HACKERS] [REVIEW] Re: Fix xpath() to return namespace definitions

2015-01-18 Thread Tom Lane
Michael Paquier michael.paqu...@gmail.com writes: On Mon, Jan 19, 2015 at 2:38 AM, David Fetter da...@fetter.org wrote: On Sun, Jan 18, 2015 at 06:05:05PM +0700, Ali Akbar wrote: 2015-01-18 10:44 GMT+07:00 Peter Eisentraut pete...@gmx.net: Btw, for bug-fix patches like this, should the patch

[HACKERS] Reducing buildfarm disk usage: remove temp installs when done

2015-01-18 Thread Tom Lane
One of the biggest causes of buildfarm run failures is out of disk space. That's not just because people are running buildfarm critters on small slow machines; it's because make check-world is an enormous space hog. Some numbers from current HEAD: clean source tree: 120MB built

Re: [HACKERS] Re: Better way of dealing with pgstat wait timeout during buildfarm runs?

2015-01-18 Thread Tom Lane
Noah Misch n...@leadboat.com writes: On Sat, Dec 27, 2014 at 07:55:05PM -0500, Tom Lane wrote: To get back to that original complaint about buildfarm runs failing, I notice that essentially all of those failures are coming from wait timeout warnings reported by manual VACUUM commands. Now,