Re: [HACKERS] \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless)

2017-02-13 Thread Fabien COELHO
Maybe this can be a discussed in a follow-up patch and Corey should proceed to finalize the if patch? In the event that we can leave prompting to a later patch, here are the v12 highlights: My 0.02€ about v12: Patch applies, make check ok, psql make check ok. - created conditional.h and

[HACKERS] Walsender crash

2017-02-13 Thread Stas Kelvich
Hello. While playing with logical publications/subscriptions I’ve noted that walsender crashes when i’m trying to CREATE SUBSCRIPTION to a current server. So having one running postgres instance on a standard port: stas=# CREATE SUBSCRIPTION mysub CONNECTION 'dbname=stas host=127.0.0.1'

[HACKERS] Sum aggregate calculation for single precsion real

2017-02-13 Thread Konstantin Knizhnik
Hi hackers, I wonder why SUM aggregate is calculated for real (float4) type using floating point accumulator? It cause very confusing and unexpected behavior: -- postgres=# select sum(l_quantity) from lineitem where l_shipdate <= '1998-12-01'; sum - 1.52688e+09 (1 row)

Re: [HACKERS] Documentation improvements for partitioning

2017-02-13 Thread Amit Langote
On 2017/02/13 14:21, Amit Langote wrote: > On 2017/02/10 19:19, Simon Riggs wrote: >> * The OID inheritance needs work - you shouldn't need to specify a >> partition needs OIDS if the parent has it already. > > That sounds right. It's better to keep the behavior same as for regular >

Re: [HACKERS] WIP: [[Parallel] Shared] Hash

2017-02-13 Thread Thomas Munro
On Thu, Feb 2, 2017 at 4:57 PM, Rafia Sabih wrote: > On Thu, Feb 2, 2017 at 1:19 AM, Thomas Munro > wrote: >> On Thu, Feb 2, 2017 at 3:34 AM, Rafia Sabih >> wrote: >>> [ regressions ] >> >> Thanks Rafia.

[HACKERS] About pg_dump and recover

2017-02-13 Thread Rey
Hi all guys, I have a database named edb. In this db , I have lots of schemas. Here I use two schemas: a and b. The two schemas belong to different role. Now , I want to export all objects of schema a . And then using these export file to recover schema b. The user of the schema b can use the

Re: [HACKERS] Logical replication existing data copy - sgml fixes

2017-02-13 Thread Erik Rijkers
On 2017-02-09 02:25, Erik Rijkers wrote: On 2017-02-08 23:25, Petr Jelinek wrote: 0001-Use-asynchronous-connect-API-in-libpqwalreceiver-v2.patch 0002-Always-initialize-stringinfo-buffers-in-walsender-v2.patch 0003-Fix-after-trigger-execution-in-logical-replication-v2.patch

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

2017-02-13 Thread Michael Banck
Hi, Am Montag, den 13.02.2017, 09:31 +0100 schrieb Magnus Hagander: > On Mon, Feb 13, 2017 at 3:29 AM, Jim Nasby > wrote: > On 2/11/17 4:36 AM, Michael Banck wrote: > I guess you're right, I've moved it further down. > There is in

Re: [HACKERS] Bold itemized list entries

2017-02-13 Thread Amit Langote
On 2017/02/13 16:39, Ashutosh Bapat wrote: > Hi > Bulletted list in Devel branch are all showing up bold as seen in the > screenshot of [1] attached. But the same page for 9.6 branch shows > normal bulletted lists. If I try to bulid docs from the latest > resources (at commit

Re: [HACKERS] Push down more UPDATEs/DELETEs in postgres_fdw

2017-02-13 Thread Rushabh Lathia
Sorry for delay in the review. I started reviewing the patch again. Patch applied cleanly on latest source as well as regression pass through with the patch. I also performed few manual testing and haven't found any regression. Patch look much cleaner the earlier version, and don't have any major

Re: [HACKERS] WIP: About CMake v2

2017-02-13 Thread Yuriy Zhuravlev
2017-02-12 20:55 GMT+03:00 Vladimir Rusinov : > Overall, when things go wrong debugging cmake requires cmake knowledge, > while autotools mostly require shell knowledge which is much more common > (again, for sysadmins/packagers). It's not really true because of CMake

Re: [HACKERS] removing tsearch2

2017-02-13 Thread Magnus Hagander
On Mon, Feb 13, 2017 at 3:09 AM, Jim Nasby wrote: > On 2/10/17 2:24 PM, Andrew Dunstan wrote: > >> There's a bunch of these things in /contrib which really ought to be >>> PGXN extensions (also CUBE, earthdistance, etc.). However, one of the >>> steps in that would be

Re: [HACKERS] gitlab post-mortem: pg_basebackup waiting for checkpoint

2017-02-13 Thread Magnus Hagander
On Mon, Feb 13, 2017 at 3:29 AM, Jim Nasby wrote: > On 2/11/17 4:36 AM, Michael Banck wrote: > >> I guess you're right, I've moved it further down. There is in fact a >> message about the xlog location (unless you switch off wal entirely), >> but having another one

Re: [HACKERS] Commit fest 2017-01 will begin soon!

2017-02-13 Thread Magnus Hagander
On Mon, Feb 13, 2017 at 4:25 AM, Jim Nasby wrote: > On 2/1/17 10:39 PM, Michael Paquier wrote: > >> On Thu, Feb 2, 2017 at 1:23 PM, Amit Kapila >> wrote: >> >>> Many thanks to you for running the show. I think it might be okay if >>> one

<    1   2