Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)

Hi Thomas, Thanks for taking time and explaining the things. Postgres extensions can't rely on backends inheriting the postmaster's memory map like this (other than the main shared memory areas which the core code looks after). For one thing, new backends aren't created with fork() on

Re: [HACKERS] Logical decoding on standby

Hi, In this patch in walsender.c sendTimeLineIsHistoric is set to true when current and ThisTimeLineID are equal. sendTimeLineIsHistoric = state->currTLI == ThisTimeLineID; Shouldn't sendTimeLineIsHistoric is true when state->currTLI is less than ThisTimeLineID. When i applied the timeline

Re: [HACKERS] Getting server crash on Windows when using ICU collation

On Wed, Jun 21, 2017 at 12:15 AM, Peter Eisentraut wrote: > On 6/20/17 09:23, Amit Kapila wrote: >> To avoid that why can't we use the same icu path for executing uconv >> as we are using for linking? > > Yeah, you'd need to use prefix $self->{options}->{icu} .

Re: [HACKERS] Optional message to user when terminating/cancelling backend

On Tue, Jun 20, 2017 at 3:24 AM, Daniel Gustafsson wrote: > The message is stored in a new shmem area which is checked when the session is > aborted. To keep things simple a small buffer is kept per backend for the > message. If deemed too costly, keeping a central buffer from

[HACKERS] CREATE SUBSCRIPTION log noise

I think this should go away: ereport(NOTICE, (errmsg("created replication slot \"%s\" on publisher", slotname))); It doesn't appear to be contingent on anything other than the content of the command you just gave it. I don't

Re: [HACKERS] Missing comment for ResultRelInfo in execnodes.h

On 2017/06/21 3:30, Peter Eisentraut wrote: On 6/20/17 05:50, Etsuro Fujita wrote: Here is a small patch to add a comment on its new member PartitionRoot. The existing comment style is kind of unusual. How about the attached to clean it up a bit? +1 for that change. Best regards, Etsuro

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

On Thu, Jun 15, 2017 at 11:40:52PM -0400, Peter Eisentraut wrote: > On 6/13/17 15:49, Peter Eisentraut wrote: > > On 6/13/17 02:33, Noah Misch wrote: > >>> Steps to reproduce - > >>> X cluster -> create 100 tables , publish all tables (create publication > >>> pub > >>> for all tables); > >>> Y

[HACKERS] Broken link to DocBook XSL Stylesheets

Hi, In J.2. Tool Sets section of documentation, there is a link to DocBook XSL Stylesheets but that link seems no longer available. I got 404 error. J.2. Tool Sets As a updated next link I guess we can use the following link.

Re: [HACKERS] [BUGS] Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS

On 2017/06/21 10:15, Amit Langote wrote: > On 2017/06/21 9:42, Bruno Wolff III wrote: >> I'm not seeing an obvious error in my attempt to use CREATE STATISTICS IF >> NOT EXISTS. Given this is new, maybe there is a bug in the parser. >> >> Sample output: >> psql (10beta1) >> Type "help" for help.

Re: [HACKERS] Proposal for CSN based snapshots

On Wed, Aug 24, 2016 at 5:54 PM, Heikki Linnakangas wrote: > And here are the results on the 72 core machine (thanks again, Alexander!). > The test setup was the same as on the 32-core machine, except that I ran it > with more clients since the system has more CPU cores. In

Re: [HACKERS] Setting pd_lower in GIN metapage

On 2017/06/20 20:37, Amit Kapila wrote: > On Tue, Jun 20, 2017 at 1:50 PM, Amit Langote > wrote: >> On 2017/06/19 23:31, Tom Lane wrote: >>> I'd suggest a rule like "if pd_lower is smaller than SizeOfPageHeaderData >>> then don't trust it, but assume all of the page

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

Michael Paquier writes: > On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane wrote: >> Yeah, I thought it would work fine with Makefile-using Windows toolchains. >> But people who use MSVC need something else, no? > Are there that many anyway who care?

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

On Wed, Jun 21, 2017 at 8:43 AM, Tom Lane wrote: > Yeah, I thought it would work fine with Makefile-using Windows toolchains. > But people who use MSVC need something else, no? Are there that many anyway who care? Personally I already fallback to Linux when it comes to

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

On Wed, Jun 21, 2017 at 4:04 AM, Álvaro Hernández Tortosa wrote: > In the coming weeks, and once my PR for pgjdbc has been added, I will > work towards another patch to implement channel binding. Should be > reasonably easy now, thanks to this. So you basically have an

Re: [HACKERS] visual studio 2017 build support

On Mon, Apr 24, 2017 at 5:50 PM, Ideriha, Takeshi < ideriha.take...@jp.fujitsu.com> wrote: > Hi > > > > I’ve noticed src/tools/msvc/README also needs some fix together with your > patch. > > README discription haven’t updated since VS 2012. > Thanks for the review. Here I attached an updated

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

Andrew Dunstan writes: > On 06/20/2017 04:17 PM, Tom Lane wrote: >> There's no Windows support yet, and I won't be writing that, >> but I hope someone else will. > What extra support do you think it needs? I have built it on Cygwin > without touching a line of

Re: [HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

On 06/20/2017 04:17 PM, Tom Lane wrote: > I've set up a repo on our git server for the new improved version > of pg_bsd_indent. Please test it for portability to your favorite > platform(s) by doing > > git clone https://git.postgresql.org/git/pg_bsd_indent.git > cd pg_bsd_indent > make -s all

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

On 6/19/17 22:54, Masahiko Sawada wrote: >> It seems to me we could just take a stronger lock around >> RemoveSubscriptionRel(), so that workers can't write in there concurrently. > > Since we reduced the lock level of updating pg_subscription_rel by > commit 521fd4795e3e the same deadlock issue

Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)

On Sat, Jun 17, 2017 at 1:17 AM, Mahi Gurram wrote: >> 3. Whether you are the backend that created it or a backend that >> attached to it, I think you'll need to store the dsa_area in a global >> variable for your UDFs to access. Note that the dsa_area object will >> be

Re: [HACKERS] Regression in join selectivity estimations when using foreign keys

On 20 June 2017 at 07:49, Tom Lane wrote: > I'm not totally satisfied that there isn't any case where the smallest > selectivity hack is appropriate. In the example you're showing here, > the FK columns are independent so that we get more or less the right > answer with or

Re: [HACKERS] Is exec_simple_check_node still doing anything?

Robert Haas writes: > I'm a little mystified by exec_simple_check_node(). > ... > Did that, possibly, remove the last way in which a simple expression > could be could become non-simple? If so, between that and the new > hasTargetSRFs test, it might now be impossible for >

Re: [HACKERS] Typo in insert.sgml

On Tue, Jun 20, 2017 at 1:35 PM, Tom Lane wrote: > Robert Haas writes: >> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut >> wrote: >>> This was not a typo, this was intentional. > >> To me, Julien's change seems to

[HACKERS] Is exec_simple_check_node still doing anything?

I'm a little mystified by exec_simple_check_node(). The regression tests seem not to exercise it. It can only be reached when exec_simple_recheck_plan() finds no other reason to reject the plan, and the only case it seems to reject is the one where there's a set-returning function buried in

Re: [HACKERS] Something is rotten in publication drop

Robert Haas writes: > On Tue, Jun 20, 2017 at 3:18 PM, Tom Lane wrote: >> Robert Haas writes: >>> Should we add that to the opr_sanity tests? >> Yeah, I was wondering about that too. I can imagine that someday >> there will be

Re: [HACKERS] Typo in insert.sgml

Robert Haas writes: > On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut > wrote: >> This was not a typo, this was intentional. > To me, Julien's change seems to make it easier to understand, but > maybe I'm misunderstanding what it's

Re: [HACKERS] initdb initalization failure for collation "ja_JP"

On 18/06/2017 16:48, Tom Lane wrote: Marco Atzeri writes: Building on Cygwin latest 10 beta1 or head sourece, make check fails as: ... performing post-bootstrap initialization ... 2017-05-31 23:23:22.214 CEST [16860] FATAL: collation "ja_JP" for encoding "EUC_JP"

Re: [HACKERS] Optional message to user when terminating/cancelling backend

Agree with David on the general usefulness of this channel. Not that Azure has this implementation or proposal today, but as a managed service this channel of communication is worth. For example, DBA / service can set a policy that if certain session exceeds the resource usage DBA can kill it

Re: [HACKERS] postgresql transactons not fully isolated

On 06/20/2017 12:33 PM, Merlin Moncure wrote: > postgres=# create table ints (n int); > CREATE TABLE > postgres=# insert into ints values (1); > INSERT 0 1 > postgres=# insert into ints values (2); > INSERT 0 1 > > T1: BEGIN > T1: UPDATE ints SET n = n + 1; > T2: BEGIN > T2: DELETE FROM ints

[HACKERS] Re-indent HEAD tomorrow?

Barring objections, I'd like to reindent HEAD with the new version of pg_bsd_indent (and correspondingly updated pgindent script) tomorrow, say around 1800 UTC. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

[HACKERS] pg_bsd_indent 2.0 is available from git.postgresql.org

I've set up a repo on our git server for the new improved version of pg_bsd_indent. Please test it for portability to your favorite platform(s) by doing git clone https://git.postgresql.org/git/pg_bsd_indent.git cd pg_bsd_indent make -s all make check Note you will need a PG installation in

Re: [HACKERS] Optional message to user when terminating/cancelling backend

Hi, On 2017-06-19 20:24:43 +0200, Daniel Gustafsson wrote: > When terminating, or cancelling, a backend it’s currently not possible to let > the signalled session know *why* it was dropped. This has nagged me in the > past and now it happened to come up again, so I took a stab at this. The >

Re: [HACKERS] postgresql transactons not fully isolated

On Tue, Jun 20, 2017 at 2:34 PM, David G. Johnston wrote: > On Tue, Jun 20, 2017 at 12:22 PM, Chapman Flack wrote: >> I get the reported result (DELETE 0 and a table containing 2 and 3) >> in both 'read committed' and 'read uncommitted'. > >

Re: [HACKERS] Something is rotten in publication drop

On Tue, Jun 20, 2017 at 3:18 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Jun 19, 2017 at 9:57 PM, Tom Lane wrote: >>> Hm, patch looks okay, but while eyeballing it I started to wonder >>> why in the world is

Re: [HACKERS] Optional message to user when terminating/cancelling backend

On Tue, Jun 20, 2017 at 11:54 AM, Alvaro Herrera wrote: > Satyanarayana Narlapuram wrote: > Unless you have a lot of users running psql manually, I don't see how > this is actually very useful or actionable. What would the user do with > the information? Hopefully

Re: [HACKERS] postgresql transactons not fully isolated

On Tue, Jun 20, 2017 at 12:22 PM, Chapman Flack wrote: > I get the reported result (DELETE 0 and a table containing 2 and 3) > in both 'read committed' and 'read uncommitted'. Practically speaking those are a single transaction isolation mode.

Re: [HACKERS] postgresql transactons not fully isolated

On 06/20/2017 03:08 PM, Chapman Flack wrote: > For me (in PG 9.5 at $work), at the instant of the commit in T1, > T2 says: > ERROR: could not serialize access due to concurrent update I get that result in 'serializable' and in 'repeatable read'. I get the reported result (DELETE 0 and a table

Re: [HACKERS] Optional message to user when terminating/cancelling backend

Satyanarayana Narlapuram wrote: > +1. > > This really helps PostgreSQL Azure service as well. When we are doing > the upgrades to the service, instead of abruptly terminating the > sessions we can provide this message. I think you mean "in addition to" rather than "instead of". Unless you have

Re: [HACKERS] Something is rotten in publication drop

Robert Haas writes: > On Mon, Jun 19, 2017 at 9:57 PM, Tom Lane wrote: >> Hm, patch looks okay, but while eyeballing it I started to wonder >> why in the world is pg_get_publication_tables marked prosecdef? >> If that has any consequences at all,

Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

On 20/06/17 06:11, Michael Paquier wrote: On Tue, Jun 6, 2017 at 3:40 PM, Michael Paquier wrote: As far as I can see, there are a couple of things that I still need to work on to make people happy: - Rework the generic APIs for TLS finish and endpoint so as any

Re: [HACKERS] [GSOC][weekly report 3] Eliminate O(N^2) scaling from rw-conflict tracking in serializable transactions

On 06/20/2017 06:51 AM, Mengxing Liu wrote: But in my benchmark, the throughput decrease by 15% after the modification. Can you help me do a quick review to find if there is anything wrong? I also attached the flame graph before/after the modification for reference. Hmm. The hash table ought

Re: [HACKERS] Typo in insert.sgml

On Tuesday, June 20, 2017, Robert Haas wrote: > On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut > > wrote: > > On 6/18/17 03:16, Julien Rouhaud wrote: > >> Patch attached. > > > > This was not a typo, this was intentional.

Re: [HACKERS] UPDATE of partition key

On Tue, Jun 20, 2017 at 2:54 AM, Amit Khandekar wrote: >> I guess I don't see why it should work like this. In the INSERT case, >> we must build withCheckOption objects for each partition because those >> partitions don't appear in the plan otherwise -- but in the UPDATE

Re: [HACKERS] Typo in insert.sgml

On 20/06/2017 20:34, Peter Eisentraut wrote: > On 6/18/17 03:16, Julien Rouhaud wrote: >> Patch attached. > > This was not a typo, this was intentional. > Oh, sorry. I'm not a native english speaker, that sounded really weird. -- Julien Rouhaud http://dalibo.com - http://dalibo.org --

Re: [HACKERS] Getting server crash on Windows when using ICU collation

On 6/20/17 09:23, Amit Kapila wrote: > To avoid that why can't we use the same icu path for executing uconv > as we are using for linking? Yeah, you'd need to use prefix $self->{options}->{icu} . '\bin\uconv' or something like that. -- Peter Eisentraut http://www.2ndQuadrant.com/

Re: [HACKERS] Getting server crash on Windows when using ICU collation

On 6/19/17 23:36, Ashutosh Sharma wrote: > In this case, even if i am trying to use ICU 53 libraries but as > dll's i am using is from ICU 49 (as my system PATH is pointing to ICU > 49 bin path) the uconv -V output would be '49.1' instead of '53.1'. In > such case, the postgres installation would

Re: [HACKERS] Typo in insert.sgml

On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut wrote: > On 6/18/17 03:16, Julien Rouhaud wrote: >> Patch attached. > > This was not a typo, this was intentional. To me, Julien's change seems to make it easier to understand, but maybe I'm misunderstanding what

Re: [HACKERS] Something is rotten in publication drop

On Mon, Jun 19, 2017 at 9:57 PM, Tom Lane wrote: > Peter Eisentraut writes: >> If there are no new insights, I plan to proceed with the attached patch >> tomorrow. This leaves the existing view and function alone, adds >>

Re: [HACKERS] Typo in insert.sgml

On 6/18/17 03:16, Julien Rouhaud wrote: > Patch attached. This was not a typo, this was intentional. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Fix a typo in partition.c

On 6/19/17 23:02, Masahiko Sawada wrote: > Hi, > > Attached patch for $subject. > > s/opreator/operator/ fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] subscription worker signalling wal writer too much

On Thu, Jun 15, 2017 at 3:06 PM, Jeff Janes wrote: > > This new patch is simpler than the previous one, and more effective at > speeding up replication. I assume it would speed up pgbench with > synchronous_commit turned off (or against unlogged tables) as well, but I >

Re: [HACKERS] Missing comment for ResultRelInfo in execnodes.h

On 6/20/17 05:50, Etsuro Fujita wrote: > Here is a small patch to add a comment on its new member PartitionRoot. The existing comment style is kind of unusual. How about the attached to clean it up a bit? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] postgresql transactons not fully isolated

Merlin Moncure writes: > Michael Malis via: > http://malisper.me/postgres-transactions-arent-fully-isolated/ has > determined that postgresql transactions are not fully isolated even > when using serializable isolationl level. > If I prep a table, ints via: > postgres=#

Re: [HACKERS] PATCH: Don't downcase filepath/filename while loading libraries

QL Zhuo writes: > And, the attached new patch fixes the memory leaks. Pushed with minor adjustments --- mostly, getting rid of the now-redundant canonicalize_path() call. I also updated the documentation. I notice the documentation formerly said "All library names are

Re: [HACKERS] Broken hint bits (freeze)

Sorry, this email from June 16 didn't make it to the lists for some odd reason so I am reposting it now. I will apply a patch based on this email shortly. What is really odd is that I replied to this email already but the original wasn't posted. I think it was something about my email reader.

Re: [HACKERS] Something is rotten in publication drop

On 6/19/17 21:57, Tom Lane wrote: > Peter Eisentraut writes: >> If there are no new insights, I plan to proceed with the attached patch >> tomorrow. This leaves the existing view and function alone, adds >> pg_relation_is_publishable() and uses that in psql. >

Re: [HACKERS] Broken hint bits (freeze)

Bruce Momjian writes: > On Tue, Jun 20, 2017 at 06:42:58PM +0300, Sergey Burladyan wrote: > > If file at standby in old data directory is different from same file at > > master, but it have same size, it will be hardlinked into new data > > directory at standby and does not

Re: [HACKERS] Decimal64 and Decimal128

On Mon, Jun 19, 2017 at 3:47 PM, Peter Geoghegan wrote: > On Mon, Jun 19, 2017 at 12:19 PM, Robert Haas wrote: >> I don't have a specific use case in mind. However, datumCopy() is >> sure to be a lot faster when typByVal is true, and see also the >>

[HACKERS] postgresql transactons not fully isolated

Michael Malis via: http://malisper.me/postgres-transactions-arent-fully-isolated/ has determined that postgresql transactions are not fully isolated even when using serializable isolationl level. If I prep a table, ints via: postgres=# create table ints (n int); CREATE TABLE postgres=# insert

Re: [HACKERS] Broken hint bits (freeze)

Amit Kapila writes: > > I am not sure about rsync, in my production server I have for example > > 111 GB in pg_xlog and if I run rsync for pg_xlog it must send ~ 40GB > > of new WALs I think. > > > > Isn't the difference between old and new is just the last WAL segment >

Re: [HACKERS] Broken hint bits (freeze)

On Tue, Jun 20, 2017 at 06:42:58PM +0300, Sergey Burladyan wrote: > Bruce Momjian writes: > > > On Tue, Jun 20, 2017 at 01:10:26PM +0300, Sergey Burladyan wrote: > > > Only if missing/changed files changed in size, because rsync run with > > > --size-only it does not copy

Re: [HACKERS] PATCH: Batch/pipelining support for libpq

Andres Freund wrote: > FWIW, I still think this needs a pgbench or similar example integration, > so we can actually properly measure the benefits. Here's an updated version of the patch I made during review, adding \beginbatch and \endbatch to pgbench. The performance improvement

Re: [HACKERS] Broken hint bits (freeze)

Bruce Momjian writes: > On Tue, Jun 20, 2017 at 01:10:26PM +0300, Sergey Burladyan wrote: > > Bruce Momjian writes: > > > > Uh, as I understand it the rsync is going to copy the missing WAL file > > > > from the new master to the standby, right, and I think

Re: [HACKERS] initdb initalization failure for collation "ja_JP"

I wrote: > Marco Atzeri writes: >> Building on Cygwin latest 10 beta1 or head sourece, >> make check fails as: >> ... >> performing post-bootstrap initialization ... 2017-05-31 23:23:22.214 >> CEST [16860] FATAL: collation "ja_JP" for encoding "EUC_JP" already exists >

Re: [HACKERS] Broken hint bits (freeze)

On Tue, Jun 20, 2017 at 01:10:26PM +0300, Sergey Burladyan wrote: > Bruce Momjian writes: > > > Uh, as I understand it the rsync is going to copy the missing WAL file > > > from the new master to the standby, right, and I think pg_controldata > > > too, so it should be fine.

Re: [HACKERS] Something is rotten in publication drop

On 6/19/17 21:57, Tom Lane wrote: > but while eyeballing it I started to wonder > why in the world is pg_get_publication_tables marked prosecdef? > If that has any consequences at all, they're probably bad. > There are exactly no other built-in functions that have that set. That was quite likely

Re: [HACKERS] Broken hint bits (freeze)

On Tue, Jun 20, 2017 at 7:05 PM, Sergey Burladyan wrote: > Amit Kapila writes: > >> On Tue, Jun 20, 2017 at 3:40 PM, Sergey Burladyan >> wrote: > I use pg 9.2 and "skipping restartpoint, already performed at" is from >

Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)

On Tue, Jun 20, 2017 at 6:48 PM, Mahendranath Gurram wrote: > The steps you followed are right. May i know in which OS you tried? > Mac/Linux. > > Because, In Mac, it is working fine. just as expected. But the > problem(segmentation fault) I'm facing is with linux

Re: [HACKERS] Broken hint bits (freeze)

Amit Kapila writes: > On Tue, Jun 20, 2017 at 3:40 PM, Sergey Burladyan wrote: > > Bruce Momjian writes: > > > >> On Mon, Jun 19, 2017 at 10:59:19PM -0400, Bruce Momjian wrote: > >> > On Tue, Jun 20, 2017 at 03:50:29AM +0300,

Re: [HACKERS] Default Partition for Range

On Thu, Jun 15, 2017 at 11:20 AM, Beena Emerson wrote: > Hello, > > PFA the updated patch. > This is rebased over v21 patches of list partition. > (http://www.mail-archive.com/pgsql-hackers@postgresql.org/msg316818.html) While testing I have noticed segmentation fault

Re: [HACKERS] Getting server crash on Windows when using ICU collation

On Tue, Jun 20, 2017 at 9:06 AM, Ashutosh Sharma wrote: > Hi, > > On Tue, Jun 20, 2017 at 2:36 AM, Peter Eisentraut > wrote: >> On 6/19/17 00:42, Ashutosh Sharma wrote: If we don't find unconv, isn't it better to fall back to non-UTF8

Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)

Hi Dilip, Thanks for your response. The steps you followed are right. May i know in which OS you tried? Mac/Linux. Because, In Mac, it is working fine. just as expected. But the problem(segmentation fault) i'm facing is with linux systems. Thanks Best Regards, -Mahi Teamwork

Re: [HACKERS] Phantom segment upon promotion causing troubles.

On 06/19/2017 10:30 AM, Andres Freund wrote: Greg Burek from Heroku (CCed) reported a weird issue on IM, that was weird enough to be interesting. What he'd observed was that he promoted some PITR standby, and early clones of that node work, but later clones did not, failing to read some

Re: [HACKERS] Setting pd_lower in GIN metapage

On Tue, Jun 20, 2017 at 1:50 PM, Amit Langote wrote: > On 2017/06/19 23:31, Tom Lane wrote: >> Amit Kapila writes: >>> On Mon, Jun 19, 2017 at 11:37 AM, Amit Langote >>> wrote: What are some arguments

Re: [HACKERS] Broken hint bits (freeze)

On Tue, Jun 20, 2017 at 3:40 PM, Sergey Burladyan wrote: > Bruce Momjian writes: > >> On Mon, Jun 19, 2017 at 10:59:19PM -0400, Bruce Momjian wrote: >> > On Tue, Jun 20, 2017 at 03:50:29AM +0300, Sergey Burladyan wrote: >> > > 20 июн. 2017 г. 1:21

Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)

On Tue, Jun 20, 2017 at 3:16 PM, Mahendranath Gurram wrote: > Hi Thomas, > > Any update on this? > > Please let me know how can i proceed further. > > Thanks & Best Regards, > -Mahi I did not see the code but just tested with your code. 1) Added test_dsa to shared

Re: [HACKERS] Broken hint bits (freeze)

Bruce Momjian writes: > On Mon, Jun 19, 2017 at 10:59:19PM -0400, Bruce Momjian wrote: > > On Tue, Jun 20, 2017 at 03:50:29AM +0300, Sergey Burladyan wrote: > > > 20 июн. 2017 г. 1:21 пользователь "Bruce Momjian" > > > написал:  > > > > > > > > > We

[HACKERS] Missing comment for ResultRelInfo in execnodes.h

Here is a small patch to add a comment on its new member PartitionRoot. Best regards, Etsuro Fujita diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h index d33392f..7175a42 100644 --- a/src/include/nodes/execnodes.h +++ b/src/include/nodes/execnodes.h @@ -365,6 +365,7 @@

Re: [HACKERS] Regarding Postgres Dynamic Shared Memory (DSA)

Hi Thomas, Any update on this? Please let me know how can i proceed further. Thanks Best Regards, -Mahi On Fri, 16 Jun 2017 18:47:37 +0530 Mahi Gurram teckym...@gmail.com wrote Hi Thomas, Thanks for your response and suggestions to change the code. Now i

Re: [HACKERS] Rules on table partitions

On 2017/06/20 17:51, Dean Rasheed wrote: > On 20 June 2017 at 03:01, Amit Langote wrote: >> On 2017/06/19 20:19, Dean Rasheed wrote: >>> Perhaps we >>> should explicitly forbid this for now -- i.e., raise a "not supported" >>> error when attempting to add a rule to

Re: [HACKERS] Rules on table partitions

On 20 June 2017 at 03:01, Amit Langote wrote: > On 2017/06/19 20:19, Dean Rasheed wrote: >> Currently we allow rules to be defined on table partitions, but these >> rules only fire when the partition is accessed directly, not when it >> is accessed via the parent: >

Re: [HACKERS] ECPG: WHENEVER statement with DO CONTINUE action

Hi Sawada-san, On 2017/06/20 17:22, Masahiko Sawada wrote: On Tue, Jun 20, 2017 at 1:51 PM, vinayak wrote: On 2017/06/12 13:09, vinayak wrote: Hi, On 2017/06/10 12:23, Vinayak Pokale wrote: Thank you for your reply On Jun 9, 2017 5:39 PM, "Michael Meskes"

Re: [HACKERS] ECPG: WHENEVER statement with DO CONTINUE action

On Tue, Jun 20, 2017 at 1:51 PM, vinayak wrote: > > > On 2017/06/12 13:09, vinayak wrote: > > Hi, > > On 2017/06/10 12:23, Vinayak Pokale wrote: > > Thank you for your reply > > On Jun 9, 2017 5:39 PM, "Michael Meskes" wrote: >> >> Could

Re: [HACKERS] Setting pd_lower in GIN metapage

On 2017/06/19 23:31, Tom Lane wrote: > Amit Kapila writes: >> On Mon, Jun 19, 2017 at 11:37 AM, Amit Langote >> wrote: >>> What are some arguments against setting pd_lower in the GIN metapage as >>> follows? > >> Actually, hash index also

Re: [HACKERS] Setting pd_lower in GIN metapage

On 2017/06/19 22:59, Amit Kapila wrote: > On Mon, Jun 19, 2017 at 11:37 AM, Amit Langote > wrote: >> What are some arguments against setting pd_lower in the GIN metapage as >> follows? >> >> GinMetaPageData *metad = GinPageGetMeta(page); >> >> ((PageHeader)

Re: [HACKERS] UPDATE of partition key

On 20 June 2017 at 03:46, Robert Haas wrote: > On Thu, Jun 15, 2017 at 1:36 PM, Amit Khandekar > wrote: >> Attached patch v10 fixes the above. In the existing code, where it >> builds WCO constraints for each leaf partition; with the patch, that >>