On Wed, Dec 17, 2014 at 02:41:39PM +, Simon Riggs wrote:
Is there anything different here from work in my original patch series?
Not to my knowledge.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
On Sat, Jun 28, 2014 at 06:08:05AM +, Tom Lane wrote:
Allow pushdown of WHERE quals into subqueries with window functions.
We can allow this even without any specific knowledge of the semantics
of the window function, so long as pushed-down quals will either accept
every row in a given
Buildfarm members magpie, treepie and fulmar went absent on 2014-10-29. Since
returning on 2014-11-16, they have consistently failed with 'initdb: invalid
locale name cs_CZ.WIN-1250'. No commits in that period readily explain a
regression in this area. Did the underlying system configurations
PostgreSQL 9.2 and later support Python 3.3 and Python 3.4; PostgreSQL 9.1 and
9.0 do not. Buildfarm member raccoon upgraded from Python 2.7 to Python 3.3
for its 2013-08-18 run, and it has failed for REL9_1_STABLE and REL9_0_STABLE
ever since. Please omit --with-python for those branches.
On Tue, Dec 16, 2014 at 01:05:31AM -0300, Alvaro Herrera wrote:
Noah Misch wrote:
On Mon, Dec 15, 2014 at 12:12:10AM -0800, Michael Paquier wrote:
FWIW, I just tried that with MinGW-32 and I can see the error on Win7.
I also checked that changing now() to = now() fixed the
problem
On Mon, Dec 15, 2014 at 12:12:10AM -0800, Michael Paquier wrote:
On Wed, Dec 10, 2014 at 6:50 PM, Noah Misch n...@leadboat.com wrote:
On Mon, Dec 08, 2014 at 02:23:39AM +0100, Petr Jelinek wrote:
On 08/12/14 00:56, Noah Misch wrote:
The commit_ts test suite gives me the attached diff
On Mon, Dec 15, 2014 at 03:29:19PM -0500, Andrew Dunstan wrote:
On 12/15/2014 03:16 PM, Andres Freund wrote:
On 2014-12-15 11:52:35 -0800, Josh Berkus wrote:
On 12/15/2014 11:27 AM, Robert Haas wrote:
I feel like we used to be better at encouraging people to participate
in the CF even if they
On Mon, Dec 08, 2014 at 02:23:39AM +0100, Petr Jelinek wrote:
On 08/12/14 00:56, Noah Misch wrote:
The commit_ts test suite gives me the attached diff on a 32-bit MinGW build
running on 64-bit Windows Server 2003. I have not checked other Windows
configurations; the suite does pass on GNU
On Wed, Dec 03, 2014 at 11:54:38AM -0300, Alvaro Herrera wrote:
Pushed with some extra cosmetic tweaks.
The commit_ts test suite gives me the attached diff on a 32-bit MinGW build
running on 64-bit Windows Server 2003. I have not checked other Windows
configurations; the suite does pass on
On Thu, Dec 04, 2014 at 10:00:14AM +0530, Ashutosh Bapat wrote:
On Thu, Dec 4, 2014 at 9:05 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp
wrote:
(2014/12/03 19:35), Ashutosh Bapat wrote:
On Tue, Dec 2, 2014 at 8:29 AM, Etsuro Fujita
fujita.ets...@lab.ntt.co.jp
On Thu, Dec 04, 2014 at 02:42:41PM +0200, Heikki Linnakangas wrote:
On 10/06/2014 04:21 PM, Heikki Linnakangas wrote:
This probably needs some further cleanup before it's ready for
committing. One issues is that it creates a temporary cluster that
listens for TCP connections on localhost,
On Fri, Nov 28, 2014 at 11:43:28AM -0500, Peter Eisentraut wrote:
In light of the recent discussions about using ICU on OS X, I looked
into the Core Foundation locale functions (Core Foundation = traditional
Mac API in OS X, as opposed to the Unix/POSIX APIs).
Attached is a proof of concept
On Sat, Nov 29, 2014 at 02:09:09PM -0500, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
Revert Add libpq function PQhostaddr().
This reverts commit 9f80f4835a55a1cbffcda5d23a617917f3286c14. The
function returned the raw value of a connection parameter, a task served
by PQconninfo
On Sun, Sep 21, 2014 at 02:31:15AM -0400, Noah Misch wrote:
It then dawned on me that every Windows build of PostgreSQL already has a way
to limit connections to a particular OS user. SSPI authentication is
essentially the Windows equivalent of peer authentication. A brief trial
thereof
On Fri, Nov 28, 2014 at 07:55:29PM +0900, Fujii Masao wrote:
On Fri, Nov 28, 2014 at 3:43 AM, Noah Misch n...@leadboat.com wrote:
On Fri, Nov 28, 2014 at 03:11:06AM +0900, Fujii Masao wrote:
On Thu, Nov 27, 2014 at 12:38 PM, Noah Misch n...@leadboat.com wrote:
Sure. I'll first issue git
On Fri, Nov 28, 2014 at 03:11:06AM +0900, Fujii Masao wrote:
On Thu, Nov 27, 2014 at 12:38 PM, Noah Misch n...@leadboat.com wrote:
Sure. I'll first issue git revert 9f80f48, then apply the attached patch.
Since libpq ignores a hostaddr parameter equal to the empty string
On Tue, Nov 25, 2014 at 09:53:10PM +0900, Fujii Masao wrote:
On Tue, Nov 25, 2014 at 12:37 PM, Noah Misch n...@leadboat.com wrote:
On Wed, Jan 22, 2014 at 11:48:26PM +0900, Fujii Masao wrote:
(3) PQhost() cannot return the hostaddr.
We can fix the problem (3) by changing PQhost() so
On Wed, Jan 22, 2014 at 11:48:26PM +0900, Fujii Masao wrote:
(3) PQhost() cannot return the hostaddr.
We can fix the problem (3) by changing PQhost() so that it also
returns the hostaddr. But this change might break the existing
application using PQhost(). So, I added new libpq function
On Mon, Nov 24, 2014 at 10:49:45AM -0300, Alvaro Herrera wrote:
What's the general opinion on having test programs somewhere other than
contrib/ ?
General opinion: slightly favorable.
We currently have a number of subdirectories for test-only programs:
test_parser (a toy text search
pg_config_manual.h has been choosing gnu_printf as the PG_PRINTF_ATTRIBUTE for
every MinGW build. That invites a torrent of warnings on pre-gcc-4.4 MinGW
compilers, including the compiler on buildfarm member narwhal. I'm
increasingly using an affected compiler, because it builds twice as quickly
On Fri, Nov 21, 2014 at 08:13:17PM -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2014-11-21 03:12:14 -0500, Noah Misch wrote:
... I'm
increasingly using an affected compiler, because it builds twice as
quickly as
today's gcc.
No objections to the patch
On Fri, Nov 14, 2014 at 08:35:25AM -0500, Stephen Frost wrote:
* Tom Lane (t...@sss.pgh.pa.us) wrote:
Noah Misch n...@leadboat.com writes:
On Thu, Nov 13, 2014 at 08:24:36PM -0500, Stephen Frost wrote:
Agreed. I'll take care of both and we'll make sure the new role
attributes being
On Fri, Nov 14, 2014 at 11:24:20AM -0500, Tom Lane wrote:
Stephen Frost sfr...@snowman.net writes:
* Noah Misch (n...@leadboat.com) wrote:
I'd agree for a new design, but I see too little to gain from changing it
now.
Today's behavior is fine.
To clarify- you mean with the changes
On Fri, Nov 14, 2014 at 11:47:49AM -0500, Stephen Frost wrote:
On Fri, Nov 14, 2014 at 11:24:20AM -0500, Tom Lane wrote:
I think Noah is arguing for leaving the pg_dumpall queries as they
stand. I disagree, but he's entitled to his opinion.
Ah, ok. I'm impartial, but I do note that
On Fri, Nov 14, 2014 at 08:39:28PM -0500, Stephen Frost wrote:
* Noah Misch (n...@leadboat.com) wrote:
So, if you desire to make this consistent, I recommend using
rolreplication's
treatment as the gold standard. That is to say, when dumping from an older
version, set to false any
On Thu, Nov 13, 2014 at 08:24:36PM -0500, Stephen Frost wrote:
* Tom Lane (t...@sss.pgh.pa.us) wrote:
What's bothering me is that I see this in pg_dumpall output from a 9.4
or earlier database:
ALTER ROLE postgres WITH SUPERUSER INHERIT CREATEROLE CREATEDB LOGIN
REPLICATION
In my Windows development environment, the tablespace regression test fails
approximately half the time. Buildfarm member frogmouth failed in the same
manner at least once:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=frogmouthdt=2014-05-21%2014%3A30%3A01
Here is a briefer command
On Mon, Nov 03, 2014 at 04:40:39PM -0500, Tom Lane wrote:
Peter Eisentraut pete...@gmx.net writes:
I thank you for this research, but I suggest that we ship 9.4 as is,
that is with requiring IPC::Run and --enable-* option. All the possible
alternatives will clearly need more rounds of
On Thu, Oct 30, 2014 at 01:57:15AM -0400, Noah Misch wrote:
On Wed, Oct 29, 2014 at 08:14:07PM -0400, Peter Eisentraut wrote:
On 10/28/14 9:09 PM, Peter Eisentraut wrote:
I have looked into IPC::Cmd, but the documentation keeps telling me that
to do anything interesting I have to have IPC
On Sun, Nov 02, 2014 at 05:10:25AM +0100, Marko Tiikkaja wrote:
*** a/contrib/pgcrypto/pgp-decrypt.c
--- b/contrib/pgcrypto/pgp-decrypt.c
***
*** 1069,1075 pgp_skip_packet(PullFilter *pkt)
while (res 0)
res = pullf_read(pkt, 32 * 1024, tmp);
!
On Sun, Nov 02, 2014 at 10:53:27PM +0100, Marko Tiikkaja wrote:
On 11/2/14, 10:34 PM, Noah Misch wrote:
On Sun, Nov 02, 2014 at 05:10:25AM +0100, Marko Tiikkaja wrote:
*** a/contrib/pgcrypto/pgp-decrypt.c
--- b/contrib/pgcrypto/pgp-decrypt.c
***
*** 1069,1075 pgp_skip_packet
On Fri, Oct 31, 2014 at 10:29:53AM -0400, Robert Haas wrote:
On Thu, Oct 30, 2014 at 11:45 PM, Noah Misch n...@leadboat.com wrote:
Given the lack of prior complaints about this
loop, I'm not sure I see the need to work harder than that; corruption
of this sort must be quite rare.
Looks
On Thu, Oct 30, 2014 at 04:54:25PM +0100, Andres Freund wrote:
On 2014-10-30 01:57:15 -0400, Noah Misch wrote:
On Wed, Oct 29, 2014 at 08:14:07PM -0400, Peter Eisentraut wrote:
On 10/28/14 9:09 PM, Peter Eisentraut wrote:
I have looked into IPC::Cmd, but the documentation keeps telling
On Thu, Oct 30, 2014 at 03:52:01PM -0400, Tom Lane wrote:
Alvaro Herrera alvhe...@2ndquadrant.com writes:
Robert Haas wrote:
A colleague at EnterpriseDB today ran into a situation on PostgreSQL
9.3.5 where the server went into an infinite loop while attempting a
VACUUM FREEZE; it couldn't
On Thu, Oct 30, 2014 at 10:49:33PM -0400, Tom Lane wrote:
Andrew Dunstan and...@dunslane.net writes:
There are other issues. I am not going to enable this in the buildfarm
until the check test can work from a single install. It's insane for the
bin tests to take an order of magnitude
On Wed, Oct 29, 2014 at 10:52:38AM +0800, Craig Ringer wrote:
On 10/29/2014 10:45 AM, Tom Lane wrote:
Craig Ringer cr...@2ndquadrant.com writes:
At pgconf-eu Álvaro and I were discussing the idea of allowing 'peer'
and 'ident' authentication to fall back to md5 if the peer/ident check
On Wed, Oct 29, 2014 at 10:24:26AM -0400, Tom Lane wrote:
Dan Robinson d...@drob.us writes:
Since the table is locked to updates while the constraint is validating,
this means you have to jump through hoops if you want to add a CHECK
constraint to a large table in a production setting. This
On Wed, Oct 29, 2014 at 08:14:07PM -0400, Peter Eisentraut wrote:
On 10/28/14 9:09 PM, Peter Eisentraut wrote:
I have looked into IPC::Cmd, but the documentation keeps telling me that
to do anything interesting I have to have IPC::Run anyway. I'll give it
a try, though.
I tried this,
On Mon, Oct 27, 2014 at 08:24:15AM -0400, Robert Haas wrote:
On Sat, Oct 25, 2014 at 2:00 PM, Noah Misch n...@leadboat.com wrote:
http://www.postgresql.org/message-id/ca+tgmoy4glsxzk0tao29-ljtcuj0sl1xwcwq51xb-hfysgi...@mail.gmail.com
http://www.postgresql.org/message-id/20893.1393892
On Mon, Oct 27, 2014 at 12:31:56PM -0400, Tom Lane wrote:
Heikki Linnakangas hlinnakan...@vmware.com writes:
On 10/27/2014 05:41 PM, Robert Haas wrote:
Beyond all that, I have serious doubts about whether, even if we
eventually get these tests mostly working in most places, whether they
On Wed, Oct 22, 2014 at 12:12:36AM -0400, Noah Misch wrote:
On Mon, Oct 20, 2014 at 01:03:31AM -0400, Noah Misch wrote:
I reproduced narwhal's problem using its toolchain on another 32-bit Windows
Server 2003 system. The crash happens at the SHGetFolderPath() call in
pqGetHomeDirectory
On Fri, Oct 24, 2014 at 12:07:42PM -0400, Robert Haas wrote:
I think instead of focusing on foreign keys, we should rewind a bit
and think about the locking level required to add a trigger.
Agreed.
On Mon, Oct 20, 2014 at 01:03:31AM -0400, Noah Misch wrote:
I reproduced narwhal's problem using its toolchain on another 32-bit Windows
Server 2003 system. The crash happens at the SHGetFolderPath() call in
pqGetHomeDirectory(). A program can acquire that function via shfolder.dll or
via
On Mon, Oct 20, 2014 at 11:06:54AM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
I don't expect to understand the mechanism
behind it, but I recommend we switch back to linking libpq with shell32.dll.
The MSVC build already does that in all supported branches, and it feels
On Mon, Oct 20, 2014 at 10:24:47PM +0200, Andres Freund wrote:
On 2014-10-20 01:03:31 -0400, Noah Misch wrote:
On Wed, Oct 15, 2014 at 12:53:03AM -0400, Noah Misch wrote:
I happened to try the same contrib/dblink test suite on PostgreSQL built
with
modern MinGW-w64 (i686-4.9.1-release
On Tue, Oct 14, 2014 at 07:07:17PM -0400, Tom Lane wrote:
Dave Page dp...@pgadmin.org writes:
On Tue, Oct 14, 2014 at 11:38 PM, Tom Lane t...@sss.pgh.pa.us wrote:
I think we're hoping that somebody will step up and investigate how
narwhal's problem might be fixed.
I have planned to look at
On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote:
Started a new thread to raise awareness.
Ref: this comes from
http://www.postgresql.org/message-id/cab7npqr1ivd5r_qn_ngmkbolqmagbosj4wnpo8eybnn6we_...@mail.gmail.com
Thanks. You can assume I'm -1 on every header split proposal
On Sat, Oct 11, 2014 at 11:43:46PM +0200, Andres Freund wrote:
On 2014-10-11 17:19:27 -0400, Noah Misch wrote:
On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote:
Started a new thread to raise awareness.
Ref: this comes from
http://www.postgresql.org/message-id
On Mon, Sep 15, 2014 at 12:51:14AM -0400, Noah Misch wrote:
1. Fork, call setlocale(LC_x, ) in the child, pass back the effective locale
name through a pipe, and pass that name to setlocale() in the original
process. The short-lived child will get the extra threads
On Fri, Oct 10, 2014 at 09:14:38PM -0400, Peter Eisentraut wrote:
On 10/10/14 8:24 PM, Noah Misch wrote:
Here's an implementation thereof covering both backend and frontend use of
setlocale(). A setlocale() wrapper, pg_setlocale(), injects use of the
child
process where necessary
On Mon, Oct 06, 2014 at 08:57:54PM -0400, Tom Lane wrote:
I eventually realized that the critical difference was you'd added
CFLAGS= to the configure call. On this platform that has the net
effect of removing -O2 from the compiler flags, and apparently that
shifts around the stack layout
On Sun, Mar 02, 2014 at 11:36:41PM +0100, Magnus Hagander wrote:
On Sun, Mar 2, 2014 at 7:27 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Noah Misch n...@leadboat.com writes:
One option that would simplify things is to fix only non-Windows in the
back
branches, via socket protection
On Mon, Sep 15, 2014 at 10:11:57AM +0300, Heikki Linnakangas wrote:
On 09/15/2014 07:51 AM, Noah Misch wrote:
libintl replaces setlocale(). Its setlocale(LC_x, ) uses OS-specific APIs
to determine the default locale when $LANG and similar environment variables
are empty, as they are during
On Tue, Sep 02, 2014 at 12:25:39AM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
Buildfarm member orangutan has failed chronically on both of the branches
for
which it still reports, HEAD and REL9_1_STABLE, for over two years. The
postmaster appears to jam during isolation
On Sun, Sep 07, 2014 at 01:06:04PM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Sat, Sep 06, 2014 at 02:01:32AM +0200, Marko Tiikkaja wrote:
To do this optimization we do have to assume that CHECKs in
DOMAINs are at least STABLE, but I don't see that as a problem;
those
On Sat, Sep 06, 2014 at 02:01:32AM +0200, Marko Tiikkaja wrote:
First of all, sorry about breaking the thread; I don't subscribe to
-general so I can't copy the original email. This is in response to
the problem here:
On Sat, Sep 06, 2014 at 11:40:02PM -0400, Tom Lane wrote:
I only tried this directly on Tiger, Snow Leopard, and Mavericks. I
tested libedit-28 by compiling from source on a RHEL machine, so it's
possible that there's some difference between what I tested and what
Apple's really shipping. If
On Thu, Sep 04, 2014 at 09:54:37AM -0400, Robert Haas wrote:
One point to note is that not back-patching this doesn't really fix
anything. Will a user be annoyed when .psql_history fails to reload
properly on a new minor release, but utterly indifferent to whether it
reloads in a new major
On Thu, Sep 04, 2014 at 07:51:03AM -0700, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
I tried your patches against libedit-28. Wherever a command contains a
newline, unpatched psql writes the three bytes \^A to the history file,
and
patched psql writes the four bytes \012
On Tue, Sep 02, 2014 at 01:56:34AM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Mon, Sep 01, 2014 at 10:22:57PM -0400, Tom Lane wrote:
Also, as best I can tell, .psql_history files from older libedit versions
are not forward-compatible to current libedit versions because
On Tue, Sep 02, 2014 at 09:49:56AM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
I'm with you that far. Given a patch that does not change \s /tmp/foo and
that makes \s equivalent to \s /tmp/foo + \! cat /tmp/foo /dev/tty,
back-patch by all means. No patch posted
On Sat, Aug 30, 2014 at 07:32:26PM -0400, Bruce Momjian wrote:
On Wed, Aug 27, 2014 at 09:40:30PM -0400, Noah Misch wrote:
3. use the pg_dump binary-upgrade code when such cases happen
+1. We have the convention that, while --binary-upgrade can inject catalog
hacks, regular pg_dump
On Mon, Sep 01, 2014 at 02:05:37PM -0400, Tom Lane wrote:
Functionally this seems like a clear win over what we had, especially
since it supports using the pager. I'm inclined to think we should
not only apply this change but back-patch it.
One thing worth thinking about: should we use a
Buildfarm member orangutan has failed chronically on both of the branches for
which it still reports, HEAD and REL9_1_STABLE, for over two years. The
postmaster appears to jam during isolation-check. Dave, orangutan currently
has one such jammed postmaster for each branch. Could you gather some
On Mon, Sep 01, 2014 at 10:22:57PM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Mon, Sep 01, 2014 at 02:05:37PM -0400, Tom Lane wrote:
Functionally this seems like a clear win over what we had, especially
since it supports using the pager. I'm inclined to think we should
On Tue, Aug 26, 2014 at 10:17:05AM +0100, Dave Page wrote:
On Tue, Aug 26, 2014 at 1:46 AM, Tom Lane t...@sss.pgh.pa.us wrote:
For the last month or so, these two buildfarm animals (which I believe are
the same physical machine) have been erratically failing with errors that
reflect
On Thu, Aug 21, 2014 at 11:29:31PM -0400, Noah Misch wrote:
On Thu, Aug 21, 2014 at 09:18:22AM -0400, Andrew Dunstan wrote:
What's happening about this? Buildfarm animal jacana is consistently
red because of this.
If nobody plans to do the aforementioned analysis in the next 4-7 days, I
On Wed, Aug 27, 2014 at 11:24:53AM -0400, Tom Lane wrote:
On Wed, Aug 27, 2014 at 10:40:53AM -0400, Bruce Momjian wrote:
I looked at this issue from March and I think we need to do something.
In summary, the problem is that tables using inheritance can be dumped
and reloaded with columns
On Mon, Aug 25, 2014 at 11:46:13PM -0400, Alvaro Herrera wrote:
Tom Lane wrote:
OK, then maybe end-of-beta is too long. But how much testing will it get
during development? I know I never use SSL on development installs.
How many hackers do?
Just a reminder that I intend to backpatch
On Fri, Aug 22, 2014 at 04:58:47PM +0900, Michael Paquier wrote:
Looking more into that, I am seeing that MinGW-32 is failing to find socket
at configure, contrary to MinGW-64.
Here is what happens for MinGW-64 at configure:
configure:7638: checking for library containing socket
[...]
On Fri, Aug 22, 2014 at 09:34:42AM +0200, Andres Freund wrote:
On 2014-08-22 01:36:37 -0400, Noah Misch wrote:
On Thu, Aug 21, 2014 at 01:33:38AM +0200, Andres Freund wrote:
On 2014-07-25 18:29:53 -0400, Tom Lane wrote:
* QNX lacks sigaction SA_RESTART: I modified
src
On Wed, Aug 20, 2014 at 08:11:01PM +0900, Etsuro Fujita wrote:
(2014/07/02 11:23), Noah Misch wrote:
Your chosen ANALYZE behavior is fair, but the messaging from a database-wide
ANALYZE VERBOSE needs work:
INFO: analyzing test_foreign_inherit.parent
INFO: parent: scanned 1 of 1 pages
On Thu, Aug 21, 2014 at 09:18:22AM -0400, Andrew Dunstan wrote:
On 08/15/2014 11:00 PM, Noah Misch wrote:
On Fri, Aug 15, 2014 at 12:49:36AM -0700, Michael Paquier wrote:
Btw, how do you determine if MSVC is using HAVE_GETADDRINFO? Is it
decided by the inclusion of getaddrinfo.c
On Thu, Aug 21, 2014 at 01:33:38AM +0200, Andres Freund wrote:
On 2014-07-25 18:29:53 -0400, Tom Lane wrote:
* QNX lacks sigaction SA_RESTART: I modified src/include/port.h
to define macros to retry system calls upon EINTR (open,read,write,...)
when compiled on QNX
That's
On Mon, Aug 18, 2014 at 12:30:40PM +0100, Greg Stark wrote:
On Tue, Aug 5, 2014 at 3:41 AM, Noah Misch n...@leadboat.com wrote:
This remains open for 9.4. Your proposal to revert the feature in 9.4 and
fix
it in 9.5 sounds reasonable.
Ok, I've gone ahead and done this. I'm sorry
On Mon, Aug 18, 2014 at 09:01:20AM -0400, Robert Haas wrote:
On Sat, Aug 16, 2014 at 3:28 AM, Noah Misch n...@leadboat.com wrote:
I'd be afraid that a secondary mechanism that mostly-but-not-really
works could do more harm by allowing us to miss bugs in the primary,
pipe-based locking
On Fri, Aug 15, 2014 at 11:26:55PM -0400, Noah Misch wrote:
Barring objections, I will commit your latest patch with some comments about
why truncation is harmless for those two particular calls.
Done.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes
Committed after making several fixes, notably:
On Thu, Aug 14, 2014 at 03:59:57PM +0900, Michael Paquier wrote:
--- a/src/test/isolation/Makefile
+++ b/src/test/isolation/Makefile
@@ -6,12 +6,15 @@ subdir = src/test/isolation
top_builddir = ../../..
include
(), and we've taken pains in the past not to break such
cases. I don't see a reason to impose now (for no
data-integrity-related reason) the rule that any such processes must
not be daemons.
+1
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql
On Thu, Aug 14, 2014 at 02:50:02AM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Wed, Aug 13, 2014 at 10:21:50AM -0400, Tom Lane wrote:
I believe that we deal with this by the expedient of checking the lengths
of tablespace paths in advance, when the tablespace is created
with the former's verdict.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Sat, Aug 16, 2014 at 10:38:39AM +1200, David Rowley wrote:
On Thu, Aug 14, 2014 at 4:13 PM, Noah Misch n...@leadboat.com wrote:
I share your (Kevin's) discomfort with our use of strlcpy(). I wouldn't
mind
someone replacing most strlcpy()/snprintf() calls with calls to wrappers
type. Amid the LDAP core schema, device is the best-fitting
objectClass having the generality required. Let's convert to that, as
attached. I have verified that this works end-to-end.
Thanks,
nm
[1] http://www.postgresql.org/docs/devel/static/libpq-ldap.html
--
Noah Misch
EnterpriseDB
, xlogfpath, MAXPGPATH);
+ strlcpy(oldpath, xlogfpath, MAXPGPATH);
This one never overflows, because it's copying from one MAXPGPATH buffer to
another. Plain strcpy() would be fine, too.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via
.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
. So we'll use our
* own
*/
#undef gai_strerror
Somehow or other, we must bring these parts into agreement.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
On Tue, Aug 12, 2014 at 01:58:17PM +0900, Michael Paquier wrote:
On Tue, Aug 12, 2014 at 9:43 AM, Noah Misch n...@leadboat.com wrote:
Somehow or other, we must bring these parts into agreement.
It is interesting to see that with MinGW-32b getaddrinfo is still set
to no at configure
On Thu, Aug 07, 2014 at 09:39:57AM -0400, Robert Haas wrote:
On Wed, Aug 6, 2014 at 9:35 PM, Bruce Momjian br...@momjian.us wrote:
On Sun, Jan 12, 2014 at 12:53:40PM -0500, Noah Misch wrote:
Further study revealed a defect in the patch's memory management, and I
have
not gotten around
of the postmaster is unconstrained. At least one of those
policies has to be wrong. Like Andres and Robert, I pick the second one.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
=supgohpkm0thwmprk1...@mail.gmail.com
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Aug 05, 2014 at 09:32:59PM -0700, Peter Geoghegan wrote:
On Tue, Aug 5, 2014 at 8:55 PM, Noah Misch n...@leadboat.com wrote:
Comparator cost affects external sorts more than it affects internal sorts.
When I profiled internal and external int4 sorting, btint4cmp() was 0.37
that still change vs. 9.3?
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
notice. See src/port/fls.c for a trivial example.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql
the six
basic processes are actually running at that time.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref
On Tue, Jul 22, 2014 at 11:51:18AM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
Diagnose incompatible OpenLDAP versions during build and test.
Hmm. I'm pretty sure it is not considered good style to drop AC_DEFUN
blocks right into configure.in; at least, we have never done
contrib/dblink check many times without
ever hitting the error, but vcregress contribcheck hit it over 99% of the
time. I don't have a theory to explain that.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
diff --git a/src/tools/msvc/vcregress.pl
to your list:
5. The TAP suites don't work when $PWD contains spaces.
Thanks,
nm
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
in that area:
http://www.postgresql.org/message-id/flat/5193ab47.3070...@vmware.com
The lock VACUUM takes before truncating a relation is the main (only?) source
of spontaneous recovery conflicts not addressed by hot_standby_feedback, so
any of the above would constitute a nice step forward.
--
Noah Misch
, but
+ * there's a race condition with us removing the directory.
What's the reason for addressing that race condition in pg_regress and not
addressing it in pg_upgrade?
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list
On Thu, Jun 19, 2014 at 01:01:34PM -0400, Tom Lane wrote:
Noah Misch n...@leadboat.com writes:
On Thu, Jun 12, 2014 at 05:02:19PM -0400, Noah Misch wrote:
You can cause the at-exit crash by building PostgreSQL against OpenLDAP
2.4.31, connecting with LDAP authentication, and issuing LOAD
801 - 900 of 1905 matches
Mail list logo
