Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-04-02 Thread Venkata B Nagothi
On Fri, Mar 31, 2017 at 4:05 PM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > Thank you having a look on this. > > # I removed -bugs in CC:. > > At Fri, 31 Mar 2017 13:40:00 +1100, Venkata B Nagothi > wrote in gmail.com> > > On Fri, Mar 17, 2

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-03-30 Thread Venkata B Nagothi
On Fri, Mar 17, 2017 at 6:48 PM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > Hello, > > At Mon, 13 Mar 2017 11:06:00 +1100, Venkata B Nagothi > wrote in gmail.com> > > On Tue, Jan 17, 2017 at 9:36 PM, Kyotaro HORIGUCHI < > > horiguchi.k

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-03-30 Thread Venkata B Nagothi
On Thu, Mar 30, 2017 at 4:46 PM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > Hello, > > At Thu, 30 Mar 2017 15:59:14 +1100, Venkata B Nagothi > wrote in xwu0j05x_j...@mail.gmail.com> > > Yes, downloaded from the email on Windows and copied acros

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-03-29 Thread Venkata B Nagothi
On Thu, Mar 30, 2017 at 3:51 PM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > At Thu, 30 Mar 2017 11:12:56 +1100, Venkata B Nagothi > wrote in gmail.com> > > On Thu, Mar 30, 2017 at 10:55 AM, Michael Paquier < > michael.paqu...@gmail.com > >

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-03-29 Thread Venkata B Nagothi
On Thu, Mar 30, 2017 at 10:55 AM, Michael Paquier wrote: > On Thu, Mar 30, 2017 at 8:49 AM, Venkata B Nagothi > wrote: > > On Tue, Mar 28, 2017 at 5:51 PM, Kyotaro HORIGUCHI > > wrote: > > I tried applying this patch to latest master, it is not getting applied > >

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-03-29 Thread Venkata B Nagothi
Regards, Venkata B N Database Consultant On Tue, Mar 28, 2017 at 5:51 PM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > This conflicts with 6912acc (replication lag tracker) so just > rebased on a6f22e8. > I tried applying this patch to latest master, it is not getting applied

Re: [HACKERS] patch proposal

2017-03-26 Thread Venkata B Nagothi
Hi David, On Thu, Mar 23, 2017 at 4:21 AM, David Steele wrote: > On 3/21/17 8:45 PM, Venkata B Nagothi wrote: > >> On Tue, Mar 21, 2017 at 8:46 AM, David Steele > >> Unfortunately, I don't think the first patch (recoveryStartPoint) >> will work as curre

Re: [HACKERS] patch proposal

2017-03-21 Thread Venkata B Nagothi
On Tue, Mar 21, 2017 at 8:46 AM, David Steele wrote: > Hi Venkata, > > On 2/28/17 11:59 PM, Venkata B Nagothi wrote: > >> On Wed, Mar 1, 2017 at 1:14 AM, Venkata B Nagothi > <mailto:nag1...@gmail.com>> wrote: >> On Tue, Jan 31, 2017 at 6:49 AM, David Stee

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2017-03-12 Thread Venkata B Nagothi
On Tue, Jan 17, 2017 at 9:36 PM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > Hello. I added pgsql-hackers. > > This occurs also on git master and back to 9.4. > > At Fri, 13 Jan 2017 08:47:06 -0600, Jonathon Nelson > wrote in gmail.com> > > On Mon, Nov 28, 2016 at 1:39 PM, Jona

Re: [HACKERS] patch proposal

2017-02-28 Thread Venkata B Nagothi
On Wed, Mar 1, 2017 at 1:14 AM, Venkata B Nagothi wrote: > Hi David, > > On Tue, Jan 31, 2017 at 6:49 AM, David Steele wrote: > >> On 1/27/17 3:19 AM, Venkata B Nagothi wrote: >> >> > I will be adding the tests in >> > src/test/rec

Re: [HACKERS] patch proposal

2017-02-28 Thread Venkata B Nagothi
Hi David, On Tue, Jan 31, 2017 at 6:49 AM, David Steele wrote: > On 1/27/17 3:19 AM, Venkata B Nagothi wrote: > > > I will be adding the tests in > > src/test/recovery/t/003_recovery_targets.pl > > <http://003_recovery_targets.pl>. My tests would lo

Re: [HACKERS] Range Partitioning behaviour - query

2017-02-23 Thread Venkata B Nagothi
On Fri, Feb 24, 2017 at 12:38 PM, David G. Johnston < david.g.johns...@gmail.com> wrote: > On Thu, Feb 23, 2017 at 6:17 PM, Amit Langote < > langote_amit...@lab.ntt.co.jp> wrote: > >> On 2017/02/24 8:38, Venkata B Nagothi wrote: >> > On Thu, Feb 23,

Re: [HACKERS] Range Partitioning behaviour - query

2017-02-23 Thread Venkata B Nagothi
On Fri, Feb 24, 2017 at 1:01 PM, Amit Langote wrote: > On 2017/02/24 10:38, David G. Johnston wrote: > > On Thu, Feb 23, 2017 at 6:17 PM, Amit Langote < > langote_amit...@lab.ntt.co.jp > >> wrote: > > > >> On 2017/02/24 8:38, Venkata B Nagothi wrote: >

Re: [HACKERS] Range Partitioning behaviour - query

2017-02-23 Thread Venkata B Nagothi
On Thu, Feb 23, 2017 at 3:14 PM, Amit Langote wrote: > Hi, > > On 2017/02/23 11:55, Venkata B Nagothi wrote: > > Hi Hackers, > > > > I have noticed the following behaviour in range partitioning which i felt > > is not quite correct (i missed reporting this) - &g

[HACKERS] Range Partitioning behaviour - query

2017-02-22 Thread Venkata B Nagothi
Hi Hackers, I have noticed the following behaviour in range partitioning which i felt is not quite correct (i missed reporting this) - I have tested by creating a date ranged partition. I created the following table. db03=# CREATE TABLE orders ( o_orderkey INTEGER, o_custkey INT

Re: [HACKERS] patch proposal

2017-02-21 Thread Venkata B Nagothi
On Tue, Jan 31, 2017 at 10:41 AM, Michael Paquier wrote: > On Tue, Jan 31, 2017 at 4:49 AM, David Steele wrote: > > On 1/27/17 3:19 AM, Venkata B Nagothi wrote: > >> I have split the patch into two different > >> pieces. One is to determine if the recovery can start

Re: [HACKERS] patch proposal

2017-02-21 Thread Venkata B Nagothi
On Tue, Jan 31, 2017 at 6:49 AM, David Steele wrote: > On 1/27/17 3:19 AM, Venkata B Nagothi wrote: > > > I will be adding the tests in > > src/test/recovery/t/003_recovery_targets.pl > > <http://003_recovery_targets.pl>. My tests would look more or less > >

Re: [HACKERS] patch proposal

2017-01-27 Thread Venkata B Nagothi
Hi David, On Tue, Jan 24, 2017 at 9:22 AM, David Steele wrote: > Hi Venkata, > > On 11/8/16 5:47 PM, Venkata B Nagothi wrote: > > Attached is the 2nd version of the patch with some enhancements. > > Here's my review of the patch. > Thank you very much for reviewi

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-22 Thread Venkata B Nagothi
On Sat, Jan 14, 2017 at 5:10 AM, Vladimir Rusinov wrote: > Attached are two new version of the patch: one keeps aliases, one don't. > Both the patches (with and without aliases) are not getting applied to the latest master. Below is the error - Perhaps you used the wrong -p or --strip option? T

Re: [HACKERS] Declarative partitioning - another take

2016-12-13 Thread Venkata B Nagothi
On Mon, Dec 12, 2016 at 3:06 PM, Amit Langote wrote: > > Hi, > > On 2016/12/11 10:02, Venkata B Nagothi wrote: > > On Fri, Dec 9, 2016 at 11:11 PM, Amit Langote > > wrote: > >> On Fri, Dec 9, 2016 at 3:16 PM, Venkata B Nagothi > >> wrote: > >&

Re: [HACKERS] Declarative partitioning - another take

2016-12-10 Thread Venkata B Nagothi
Regards, Venkata B N Database Consultant On Fri, Dec 9, 2016 at 11:11 PM, Amit Langote wrote: > On Fri, Dec 9, 2016 at 3:16 PM, Venkata B Nagothi > wrote: > > Hi, > > > > I am testing the partitioning feature from the latest master and got the > > followin

Re: [HACKERS] Declarative partitioning - another take

2016-12-08 Thread Venkata B Nagothi
Hi, I am testing the partitioning feature from the latest master and got the following error while loading the data - db01=# create table orders_y1993 PARTITION OF orders FOR VALUES FROM ('1993-01-01') TO ('1993-12-31'); CREATE TABLE db01=# copy orders from '/data/orders-1993.csv' delimiter '|';

Re: [HACKERS] patch proposal

2016-11-08 Thread Venkata B Nagothi
Attached is the 2nd version of the patch with some enhancements. *Scenario 2 :* > > Generates Errors, Hints when the specified recovery target is prior to the > backup's current position (xid, time and lsn). This behaviour is integrated > with the parameters "recovery_target_time","recovery_target

Re: [HACKERS] Contents of "backup_label" and "*.backup" in pg_wal location

2016-11-04 Thread Venkata B Nagothi
> On Fri, Nov 4, 2016 at 7:04 PM, Venkata B Nagothi > wrote: > > Sure. I will look at the possibility of using XLOG_BACKUP_END in my > patch. > > I am looking at the possibility of keeping the backup_label at source > until > > pg_stop_backup() > > is executed

Re: [HACKERS] Contents of "backup_label" and "*.backup" in pg_wal location

2016-11-04 Thread Venkata B Nagothi
On Fri, Nov 4, 2016 at 3:44 PM, Michael Paquier wrote: > On Fri, Nov 4, 2016 at 1:18 PM, Venkata B Nagothi > wrote: > > I see the following contents in the file > > "00010044.0060.backup" which was generated in the > pg_wal > > lo

[HACKERS] Contents of "backup_label" and "*.backup" in pg_wal location

2016-11-03 Thread Venkata B Nagothi
Hello Hackers, I have a question regarding the contents being written to the backup_label file and the .backup file in the pg_wal location generated when the online backup is done. backup_label file contents are as follows, which do not contain backup stop position (timestamp and STOP WAL locatio

Re: [HACKERS] patch proposal

2016-10-25 Thread Venkata B Nagothi
other comments are inline On Mon, Aug 29, 2016 at 3:17 PM, Venkata B Nagothi wrote: > > On Fri, Aug 26, 2016 at 10:58 PM, Stephen Frost > wrote: > >> * Venkata B Nagothi (nag1...@gmail.com) wrote: >> > On Fri, Aug 26, 2016 at 12:30 PM, Stephen Frost >> wrot

Re: [HACKERS] pg_xlog error on the master

2016-10-23 Thread Venkata B Nagothi
On Sunday, 23 October 2016, Michael Paquier wrote: > On Sun, Oct 23, 2016 at 5:05 PM, Venkata B Nagothi > wrote: > > I just did did a "git pull" to test one of my patches and i get the > > following error : > > > > 2016-10-23 18:51:47.679 AEDT [31930]

[HACKERS] pg_xlog error on the master

2016-10-23 Thread Venkata B Nagothi
I just did did a "git pull" to test one of my patches and i get the following error : 2016-10-23 18:51:47.679 AEDT [31930] FATAL: could not open archive status directory "pg_xlog/archive_status": No such file or directory 2016-10-23 18:51:47.679 AEDT [31841] LOG: archiver process (PID 31930) exi

Re: [HACKERS] patch proposal

2016-08-28 Thread Venkata B Nagothi
On Fri, Aug 26, 2016 at 10:58 PM, Stephen Frost wrote: > * Venkata B Nagothi (nag1...@gmail.com) wrote: > > On Fri, Aug 26, 2016 at 12:30 PM, Stephen Frost > wrote: > > > * Venkata B Nagothi (nag1...@gmail.com) wrote: > > > > This behaviour will be sim

Re: [HACKERS] patch proposal

2016-08-26 Thread Venkata B Nagothi
On Fri, Aug 26, 2016 at 12:30 PM, Stephen Frost wrote: > * Venkata B Nagothi (nag1...@gmail.com) wrote: > > On Thu, Aug 25, 2016 at 10:59 PM, Stephen Frost > wrote: > > > I'm not a fan of the "recovery_target" option, particularly as it's > only >

Re: [HACKERS] patch proposal

2016-08-25 Thread Venkata B Nagothi
On Thu, Aug 25, 2016 at 10:59 PM, Stephen Frost wrote: > * Venkata B Nagothi (nag1...@gmail.com) wrote: > > *Query 1* > > > > What about the existing parameter called "recovery_target" which accepts > > only one value "immediate", which will be sim

Re: [HACKERS] patch proposal

2016-08-24 Thread Venkata B Nagothi
On Thu, Aug 18, 2016 at 3:37 PM, Michael Paquier wrote: > On Tue, Aug 16, 2016 at 11:06 PM, Stephen Frost > wrote: > > I could see supporting an additional "pause" option that means "pause at > > the end of WAL if you don't reach the recovery target point". I'd also > > be happy with a warning

Re: [HACKERS] patch proposal

2016-08-19 Thread Venkata B Nagothi
On Thu, Aug 18, 2016 at 7:20 PM, Stephen Frost wrote: > * Venkata B Nagothi (nag1...@gmail.com) wrote: > > On Wed, Aug 17, 2016 at 11:27 PM, Stephen Frost > wrote: > > > * Venkata B Nagothi (nag1...@gmail.com) wrote: > > > > Agreed. Additional option like &quo

Re: [HACKERS] patch proposal

2016-08-18 Thread Venkata B Nagothi
On Thu, Aug 18, 2016 at 3:37 PM, Michael Paquier wrote: > On Tue, Aug 16, 2016 at 11:06 PM, Stephen Frost > wrote: > > I could see supporting an additional "pause" option that means "pause at > > the end of WAL if you don't reach the recovery target point". I'd also > > be happy with a warning

Re: [HACKERS] patch proposal

2016-08-17 Thread Venkata B Nagothi
On Wed, Aug 17, 2016 at 11:27 PM, Stephen Frost wrote: > Venkata, > > * Venkata B Nagothi (nag1...@gmail.com) wrote: > > Agreed. Additional option like "pause" would. As long as there is an > option > > to ensure following happens if the recovery target is not r

Re: [HACKERS] patch proposal

2016-08-16 Thread Venkata B Nagothi
On Wed, Aug 17, 2016 at 12:06 AM, Stephen Frost wrote: > Greetings, > > * Venkata B Nagothi (nag1...@gmail.com) wrote: > > The above said parameters can be configured to pause, shutdown or prevent > > promotion only after reaching the recovery target point. > > To c

Re: [HACKERS] patch proposal

2016-08-15 Thread Venkata B Nagothi
On Tue, Aug 16, 2016 at 2:50 AM, David Steele wrote: > On 8/15/16 2:33 AM, Venkata B Nagothi wrote: > > > During the recovery process, It would be nice if PostgreSQL generates an > > error by aborting the recovery process (instead of starting-up the > > cluster) if the

[HACKERS] patch proposal

2016-08-14 Thread Venkata B Nagothi
Hi, During the recovery process, It would be nice if PostgreSQL generates an error by aborting the recovery process (instead of starting-up the cluster) if the intended recovery target point is not reached and give an option to DBA to resume the recovery process from where it exactly stopped. The