Re: [HACKERS] [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-30 Thread Tom Lane
Robert Haas writes: I'm not really for doing it that way, but I'm willing to apply the fix if there's consensus for your position. Anybody else have an opinion? > +1 from me, too. I don't see that there's enough advantage in > avoiding a catversion bump to

Re: [HACKERS] [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-30 Thread Robert Haas
On Tue, May 30, 2017 at 5:26 AM, Magnus Hagander wrote: >> > I'm not really for doing it that way, but I'm willing to apply the fix >> > if there's consensus for your position. Anybody else have an opinion? >> >> I tend to agree with Noah on this one. > > +1 +1 from me,

Re: [HACKERS] [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-30 Thread Magnus Hagander
On Tue, May 30, 2017 at 4:41 AM, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Noah Misch writes: > > > On Mon, May 29, 2017 at 03:20:41AM +, Tom Lane wrote: > > >> Annotate the fact that somebody added location fields to >

Re: [HACKERS] [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-29 Thread Amit Langote
On 2017/05/30 11:41, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Noah Misch writes: >>> On Mon, May 29, 2017 at 03:20:41AM +, Tom Lane wrote: Annotate the fact that somebody added location fields to PartitionBoundSpec and PartitionRangeDatum

Re: [HACKERS] [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-29 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Noah Misch writes: > > On Mon, May 29, 2017 at 03:20:41AM +, Tom Lane wrote: > >> Annotate the fact that somebody added location fields to PartitionBoundSpec > >> and PartitionRangeDatum but forgot to handle them in > >>

Re: [HACKERS] [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-29 Thread Tom Lane
Noah Misch writes: > On Mon, May 29, 2017 at 03:20:41AM +, Tom Lane wrote: >> Annotate the fact that somebody added location fields to PartitionBoundSpec >> and PartitionRangeDatum but forgot to handle them in >> outfuncs.c/readfuncs.c. This is fairly harmless for