Re: [HACKERS] ALTER ROLE SET/RESET for multiple options

2016-02-17 Thread Michael Paquier
On Wed, Feb 17, 2016 at 7:23 PM, Masahiko Sawada wrote: > On Wed, Feb 17, 2016 at 7:14 PM, Robert Haas wrote: >> On Wed, Feb 17, 2016 at 3:22 PM, Masahiko Sawada >> wrote: >>> On Sat, Feb 13, 2016 at 2:45 PM, Robert Haas

Re: [HACKERS] ALTER ROLE SET/RESET for multiple options

2016-02-17 Thread Masahiko Sawada
On Wed, Feb 17, 2016 at 7:14 PM, Robert Haas wrote: > On Wed, Feb 17, 2016 at 3:22 PM, Masahiko Sawada > wrote: >> On Sat, Feb 13, 2016 at 2:45 PM, Robert Haas wrote: >>> On Fri, Feb 12, 2016 at 1:35 PM, Payal Singh

Re: [HACKERS] ALTER ROLE SET/RESET for multiple options

2016-02-17 Thread Robert Haas
On Wed, Feb 17, 2016 at 3:22 PM, Masahiko Sawada wrote: > On Sat, Feb 13, 2016 at 2:45 PM, Robert Haas wrote: >> On Fri, Feb 12, 2016 at 1:35 PM, Payal Singh wrote: >>> The feature seems to work as described, but is it necessary to

Re: [HACKERS] ALTER ROLE SET/RESET for multiple options

2016-02-17 Thread Masahiko Sawada
On Sat, Feb 13, 2016 at 2:45 PM, Robert Haas wrote: > On Fri, Feb 12, 2016 at 1:35 PM, Payal Singh wrote: >> The feature seems to work as described, but is it necessary to enclose >> multiple GUC settings in a parenthesis? This seems a deviation from the

Re: [HACKERS] ALTER ROLE SET/RESET for multiple options

2016-02-12 Thread Payal Singh
The following review has been posted through the commitfest application: make installcheck-world: tested, failed Implements feature: tested, passed Spec compliant: tested, failed Documentation:not tested When running gmake installcheck for regression tests, 2 tests

Re: [HACKERS] ALTER ROLE SET/RESET for multiple options

2016-02-12 Thread Robert Haas
On Fri, Feb 12, 2016 at 1:35 PM, Payal Singh wrote: > The feature seems to work as described, but is it necessary to enclose > multiple GUC settings in a parenthesis? This seems a deviation from the usual > syntax of altering multiple settings separated with comma. Well, note

[HACKERS] ALTER ROLE SET/RESET for multiple options

2015-12-24 Thread Masahiko Sawada
Hi all, ALTER ROLE SET/RESET can set/reset only one GUC parameter per one SQL today. So when we need to set/reset multiple GUC parameter to user, it would be burdensome work. I'd like propose feature makes ALTER ROLE SET/RESET can set/reset multiple options like ALTER TABLE. ALTER USER is as