On Sat, Apr 15, 2017 at 7:38 AM, Simon Riggs wrote:
>> I waited quite a while for you to review Amit's patches on that
>> thread, but as you never did, I eventually picked it up.
>
> Sorry about that, I guess I was concentrating on things listed on the
> CF app at that time.
No problem from my en
On 14 April 2017 at 09:18, Amit Langote wrote:
>> Where shall I mention BRIN in that chapter?
>
> Maybe just append a new right below where id="ddl-partitioning-constraint-exclusion"> ends?
>
> I had included both BRIN and UNION ALL views under a sub-section titled
> "Alternative Methods" in my
On 14 April 2017 at 14:02, Robert Haas wrote:
> On Fri, Apr 14, 2017 at 3:43 AM, Simon Riggs wrote:
>> Oh, just looks very different to what we discussed, so I presumed more
>> changes were coming.
>
> I waited quite a while for you to review Amit's patches on that
> thread, but as you never did,
On Fri, Apr 14, 2017 at 3:43 AM, Simon Riggs wrote:
> Oh, just looks very different to what we discussed, so I presumed more
> changes were coming.
I waited quite a while for you to review Amit's patches on that
thread, but as you never did, I eventually picked it up.
> Where shall I mention BRI
On 2017/04/14 16:43, Simon Riggs wrote:
> On 14 April 2017 at 08:39, Amit Langote wrote:
>> On 2017/04/14 16:25, Simon Riggs wrote:
>>> On 14 April 2017 at 08:13, Amit Langote
>>> wrote:
>>>
Attached patch gets rid of a "is has".
>>>
>>> Yes, its a typo, but doesn't add missing information
On 14 April 2017 at 08:39, Amit Langote wrote:
> On 2017/04/14 16:25, Simon Riggs wrote:
>> On 14 April 2017 at 08:13, Amit Langote
>> wrote:
>>
>>> Attached patch gets rid of a "is has".
>>
>> Yes, its a typo, but doesn't add missing information or change the meaning.
>>
>> It should be fixed,
On 2017/04/14 16:25, Simon Riggs wrote:
> On 14 April 2017 at 08:13, Amit Langote wrote:
>
>> Attached patch gets rid of a "is has".
>
> Yes, its a typo, but doesn't add missing information or change the meaning.
>
> It should be fixed, but could I suggest we include that in your next
> lot of
On 14 April 2017 at 08:13, Amit Langote wrote:
> Attached patch gets rid of a "is has".
Yes, its a typo, but doesn't add missing information or change the meaning.
It should be fixed, but could I suggest we include that in your next
lot of doc changes, rather than keep making single minor chang
Attached patch gets rid of a "is has".
Thanks,
Amit
diff --git a/src/backend/catalog/partition.c b/src/backend/catalog/partition.c
index ab891f6ef2..e0d2665a91 100644
--- a/src/backend/catalog/partition.c
+++ b/src/backend/catalog/partition.c
@@ -549,7 +549,7 @@ RelationBuildPartitionDesc(Relation
