Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-29 Thread Michael Paquier
On Mon, Sep 29, 2014 at 7:50 PM, Andres Freund and...@2ndquadrant.com wrote: What about the attached patch then? Thanks for this update. This looks good. Here are a couple of small comments: 1) This sentence is correct English, but I don't recall seeing in the docs such a formulation: +

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-29 Thread Andres Freund
On 2014-09-29 21:48:08 +0900, Michael Paquier wrote: On Mon, Sep 29, 2014 at 7:50 PM, Andres Freund and...@2ndquadrant.com wrote: What about the attached patch then? Thanks for this update. This looks good. Here are a couple of small comments: 1) This sentence is correct English, but

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-29 Thread Robert Haas
On Mon, Sep 29, 2014 at 9:03 AM, Andres Freund and...@2ndquadrant.com wrote: -except that changes are returned as typebytea/type. +except that changes are returned as typebytea/type and that it can +be used on slots using output plugins that only support binary output.

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-22 Thread Robert Haas
On Thu, Sep 18, 2014 at 11:21 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Sep 18, 2014 at 9:56 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-09-18 09:50:38 -0500, Michael Paquier wrote: Do you see the difference between what your doc patch states and the

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-22 Thread Michael Paquier
On Tue, Sep 23, 2014 at 4:59 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Sep 18, 2014 at 11:21 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Sep 18, 2014 at 9:56 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-09-18 09:50:38 -0500, Michael Paquier wrote: Do

[HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-18 Thread Michael Paquier
Hi all, As there has been a dump of CATALOG_VERSION_NO on REL9_4_STABLE recently, I am coming back to the options OUTPUT_PLUGIN_* that are rather confusing for developers of decoder plugins. In short, when extracting changes from a replication slot, a decoder plugin is free to set one option that

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-18 Thread Andres Freund
Hi, On 2014-09-18 02:14:48 -0500, Michael Paquier wrote: As there has been a dump of CATALOG_VERSION_NO on REL9_4_STABLE recently, I am coming back to the options OUTPUT_PLUGIN_* that are rather confusing for developers of decoder plugins. In short, when extracting changes from a replication

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-18 Thread Michael Paquier
On Thu, Sep 18, 2014 at 2:18 AM, Andres Freund and...@2ndquadrant.com wrote: The point is that operating with byteas on SQL level is freaking painful. An example perhaps? I fail to see why it is related to the fact that a user could simply use that to fetch changes in bytea from a slot: select

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-18 Thread Andres Freund
On 2014-09-18 08:57:26 -0500, Michael Paquier wrote: On Thu, Sep 18, 2014 at 2:18 AM, Andres Freund and...@2ndquadrant.com wrote: The point is that operating with byteas on SQL level is freaking painful. An example perhaps? I fail to see why it is related to the fact that a user could

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-18 Thread Michael Paquier
On Thu, Sep 18, 2014 at 2:18 AM, Andres Freund and...@2ndquadrant.com wrote: Improving the docs here is on my roadmap, but I don't see the benefit of this. Btw, I sent a couple of weeks back a patch that was an attempt to improve this portion of the docs, feel free to have a look if that helps

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-18 Thread Andres Freund
On 2014-09-18 09:13:48 -0500, Michael Paquier wrote: On Thu, Sep 18, 2014 at 2:18 AM, Andres Freund and...@2ndquadrant.com wrote: Improving the docs here is on my roadmap, but I don't see the benefit of this. Btw, I sent a couple of weeks back a patch that was an attempt to improve this

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-18 Thread Michael Paquier
On Thu, Sep 18, 2014 at 9:23 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-09-18 09:13:48 -0500, Michael Paquier wrote: On Thu, Sep 18, 2014 at 2:18 AM, Andres Freund and...@2ndquadrant.com wrote: Improving the docs here is on my roadmap, but I don't see the benefit of this.

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-18 Thread Andres Freund
On 2014-09-18 09:50:38 -0500, Michael Paquier wrote: Do you see the difference between what your doc patch states and the explanation I've given nearby in this thread? Perhaps that's the lack of documentation... Man. I've explained it to you about three times. The previous attempts at doing

Re: [HACKERS] Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding)

2014-09-18 Thread Michael Paquier
On Thu, Sep 18, 2014 at 9:56 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-09-18 09:50:38 -0500, Michael Paquier wrote: Do you see the difference between what your doc patch states and the explanation I've given nearby in this thread? Perhaps that's the lack of documentation...