Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-07-02 Thread Fujii Masao
On Thu, Jul 2, 2015 at 8:59 PM, Michael Paquier wrote: > On Thu, Jul 2, 2015 at 8:42 PM, Fujii Masao wrote: >>> 3) Something not caused by this patch that I just noticed... But >>> pg_resetxlog does not remove .backup files in pg_xlog. Shouldn't they >>> get moved away as well? >> >> pg_resetxlog

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-07-02 Thread Michael Paquier
On Thu, Jul 2, 2015 at 8:42 PM, Fujii Masao wrote: >> 3) Something not caused by this patch that I just noticed... But >> pg_resetxlog does not remove .backup files in pg_xlog. Shouldn't they >> get moved away as well? > > pg_resetxlog doesn't remove also .history file in pg_xlog. Those remaining >

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-07-02 Thread Fujii Masao
On Thu, Jul 2, 2015 at 3:48 PM, Michael Paquier wrote: > On Thu, Jul 2, 2015 at 2:06 PM, Fujii Masao wrote: >> I implemented the patch accordingly. Patch attached. > > Cool, thanks. > > I have done some tests with pg_archivecleanup, and it works as > expected, aka if I define a backup file, the ba

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-07-01 Thread Michael Paquier
On Thu, Jul 2, 2015 at 2:06 PM, Fujii Masao wrote: > I implemented the patch accordingly. Patch attached. Cool, thanks. I have done some tests with pg_archivecleanup, and it works as expected, aka if I define a backup file, the backup file as well as the segments equal or newer than it remain. It

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-07-01 Thread Fujii Masao
On Wed, Jul 1, 2015 at 5:14 PM, Simon Riggs wrote: > On 1 July 2015 at 07:52, Michael Paquier wrote: >> >> On Wed, Jul 1, 2015 at 12:39 PM, Fujii Masao >> wrote: >> > WAL-related tools, i.e., pg_archivecleanup, pg_resetxlog and >> > pg_xlogdump don't seem to properly handle .paritial WAL file. >

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-07-01 Thread Simon Riggs
On 1 July 2015 at 07:52, Michael Paquier wrote: > On Wed, Jul 1, 2015 at 12:39 PM, Fujii Masao > wrote: > > WAL-related tools, i.e., pg_archivecleanup, pg_resetxlog and > > pg_xlogdump don't seem to properly handle .paritial WAL file. > > I think that we should fix at least pg_archivecleanup, ot

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-07-01 Thread Michael Paquier
On Wed, Jul 1, 2015 at 2:52 PM, Amit Kapila wrote: > On Wed, Jul 1, 2015 at 9:09 AM, Fujii Masao wrote: >> >> Also regarding pg_xlogdump, we can just document, for example, >> "please get rid of .paritial suffix from the WAL file name if >> you want to dump it by pg_xlogdump". >> > > Can't we ski

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-06-30 Thread Michael Paquier
On Wed, Jul 1, 2015 at 12:39 PM, Fujii Masao wrote: > WAL-related tools, i.e., pg_archivecleanup, pg_resetxlog and > pg_xlogdump don't seem to properly handle .paritial WAL file. > I think that we should fix at least pg_archivecleanup, otherwise, > in the system using pg_archivecleanup to clean up

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-06-30 Thread Amit Kapila
On Wed, Jul 1, 2015 at 9:09 AM, Fujii Masao wrote: > > Also regarding pg_xlogdump, we can just document, for example, > "please get rid of .paritial suffix from the WAL file name if > you want to dump it by pg_xlogdump". > Can't we skip such files in pg_xlogdump? With Regards, Amit Kapila. Ente

[HACKERS] WAL-related tools and .paritial WAL file

2015-06-30 Thread Fujii Masao
Hi, WAL-related tools, i.e., pg_archivecleanup, pg_resetxlog and pg_xlogdump don't seem to properly handle .paritial WAL file. I think that we should fix at least pg_archivecleanup, otherwise, in the system using pg_archivecleanup to clean up old archived files, the archived .paritial WAL file wil