Re: [HACKERS] pg_get_object_address() doesn't support composites

2017-02-19 Thread Jim Nasby
On 2/18/17 4:26 PM, Jim Nasby wrote: On 2/17/17 9:53 PM, Alvaro Herrera wrote: Jim Nasby wrote: See below. ISTM that pg_get_object_address should support everything pg_identify_object_as_address can output, no? I'm guessing the answer here is to have pg_identify_object_as_address complain if

Re: [HACKERS] pg_get_object_address() doesn't support composites

2017-02-18 Thread Jim Nasby
On 2/17/17 9:53 PM, Alvaro Herrera wrote: Jim Nasby wrote: See below. ISTM that pg_get_object_address should support everything pg_identify_object_as_address can output, no? I'm guessing the answer here is to have pg_identify_object_as_address complain if you ask it for something that's not

Re: [HACKERS] pg_get_object_address() doesn't support composites

2017-02-17 Thread Jim Nasby
On 2/17/17 9:53 PM, Alvaro Herrera wrote: Another way to think about this problem is an approach Peter E suggested not long ago, which was to change the objname/objargs representation more completely. Hrm, I didn't see that. What was the idea? BTW, I do find it odd (and might eventually find

Re: [HACKERS] pg_get_object_address() doesn't support composites

2017-02-17 Thread Alvaro Herrera
Jim Nasby wrote: > See below. ISTM that pg_get_object_address should support everything > pg_identify_object_as_address can output, no? > > I'm guessing the answer here is to have pg_identify_object_as_address > complain if you ask it for something that's not mapable. Yes, I think we should just

[HACKERS] pg_get_object_address() doesn't support composites

2017-02-17 Thread Jim Nasby
See below. ISTM that pg_get_object_address should support everything pg_identify_object_as_address can output, no? I'm guessing the answer here is to have pg_identify_object_as_address complain if you ask it for something that's not mapable. ~@decina.local/5621# CREATE TYPE comp AS (a int,