Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-30 Thread Peter Eisentraut
On Sat, 2012-09-29 at 17:52 -0400, Andrew Dunstan wrote: > It turns out that the reason is that we support collations on MSVC but > not on Mingw. The cause for that is that on Windows locale_t is called _locale_t, and there is a workaround for that in src/include/port/win32.h for the MSVC build,

Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Andrew Dunstan
On 09/29/2012 01:49 PM, Andrew Dunstan wrote: On 09/29/2012 11:49 AM, Tom Lane wrote: Andrew Dunstan writes: The recent alter generic tests have broken pg_upgrade testing on Windows and probably other non-collation-supporting platforms. Is it still broken after Alvaro added the alternate e

Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Alvaro Herrera
Excerpts from Tom Lane's message of sáb sep 29 14:57:11 -0300 2012: > > Andrew Dunstan writes: > > Well, that's a very good point. chough is actually the same machine, > > doing an MSVC build. So why would this test pass there? I'll investigate > > a bit more. Here's what the regression diffs

Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Tom Lane
Andrew Dunstan writes: > On 09/29/2012 11:49 AM, Tom Lane wrote: >> Is it still broken after Alvaro added the alternate expected file, and >> if so why? I don't see a reason that this should be failing only there. >> I also note that it seems to be passing fine on buildfarm members other >> than

Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Andrew Dunstan
On 09/29/2012 11:49 AM, Tom Lane wrote: Andrew Dunstan writes: The recent alter generic tests have broken pg_upgrade testing on Windows and probably other non-collation-supporting platforms. Is it still broken after Alvaro added the alternate expected file, and if so why? I don't see a reaso

Re: [HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Tom Lane
Andrew Dunstan writes: > The recent alter generic tests have broken pg_upgrade testing on Windows > and probably other non-collation-supporting platforms. Is it still broken after Alvaro added the alternate expected file, and if so why? I don't see a reason that this should be failing only ther

[HACKERS] pg_upgrade tests vs alter generic changes

2012-09-29 Thread Andrew Dunstan
The recent alter generic tests have broken pg_upgrade testing on Windows and probably other non-collation-supporting platforms. This can be cured by making the pg_upgrade test set up its test installs with "initdb --no-locale." as shown below (with similar changes for the MSVC build system als