Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-11-10 Thread Bruce Momjian
David Fetter wrote: > On Mon, Nov 09, 2009 at 09:01:14PM -0500, Bruce Momjian wrote: > > > > I have applied the attached patch to document that FOUND is not affected > > by EXECUTE, while GET DIAGNOSTICS is. > > One minor nit here: > > > Index: doc/src/sgml/plpgsql.sgml > > =

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-11-09 Thread David Fetter
On Mon, Nov 09, 2009 at 09:01:14PM -0500, Bruce Momjian wrote: > > I have applied the attached patch to document that FOUND is not affected > by EXECUTE, while GET DIAGNOSTICS is. One minor nit here: > Index: doc/src/sgml/plpgsql.sgml > ===

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-11-09 Thread Bruce Momjian
I have applied the attached patch to document that FOUND is not affected by EXECUTE, while GET DIAGNOSTICS is. --- Robert Haas wrote: > On Fri, Oct 23, 2009 at 12:05 PM, Pavel Stehule > wrote: > > 2009/10/23 Robert Haas :

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-23 Thread Robert Haas
On Fri, Oct 23, 2009 at 12:05 PM, Pavel Stehule wrote: > 2009/10/23 Robert Haas : >> On Fri, Oct 23, 2009 at 10:50 AM, Tom Lane wrote: >>> Robert Haas writes: On Fri, Oct 23, 2009 at 9:52 AM, Tom Lane wrote: > [shrug...]  There is also real user demand for not silently breaking > c

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-23 Thread Pavel Stehule
2009/10/23 Robert Haas : > On Fri, Oct 23, 2009 at 10:50 AM, Tom Lane wrote: >> Robert Haas writes: >>> On Fri, Oct 23, 2009 at 9:52 AM, Tom Lane wrote: [shrug...]  There is also real user demand for not silently breaking code that works now, which is what we risk anytime we change the

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-23 Thread Robert Haas
On Fri, Oct 23, 2009 at 10:50 AM, Tom Lane wrote: > Robert Haas writes: >> On Fri, Oct 23, 2009 at 9:52 AM, Tom Lane wrote: >>> [shrug...]  There is also real user demand for not silently breaking >>> code that works now, which is what we risk anytime we change the set >>> of statements that can

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-23 Thread Merlin Moncure
On Fri, Oct 23, 2009 at 11:07 AM, Kevin Grittner wrote: > Tom Lane wrote: > >> Any change here is *not* a bug fix, it is a change of clearly >> documented and not-obviously-unreasonable behavior.  We have to take >> seriously the likelihood that it will break existing code. > > Perhaps plpgsql co

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-23 Thread Kevin Grittner
Tom Lane wrote: > Any change here is *not* a bug fix, it is a change of clearly > documented and not-obviously-unreasonable behavior. We have to take > seriously the likelihood that it will break existing code. Perhaps plpgsql could support tests of SQLSTATE, and recognize '02000' (the standa

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-23 Thread Tom Lane
Robert Haas writes: > On Fri, Oct 23, 2009 at 9:52 AM, Tom Lane wrote: >> [shrug...]  There is also real user demand for not silently breaking >> code that works now, which is what we risk anytime we change the set >> of statements that can set FOUND. > We've had this discussion before and I'm s

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-23 Thread Andrew Dunstan
Robert Haas wrote: On Fri, Oct 23, 2009 at 9:52 AM, Tom Lane wrote: Dimitri Fontaine writes: I'll go search for more, meantime I'll just add the main goal of this new thread is to have -hackers know there is a real user demand for having EXECUTE set FOUND the same way it sets GET DI

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-23 Thread Robert Haas
On Fri, Oct 23, 2009 at 9:52 AM, Tom Lane wrote: > Dimitri Fontaine writes: >> I'll go search for more, meantime I'll just add the main goal of this >> new thread is to have -hackers know there is a real user demand for >> having EXECUTE set FOUND the same way it sets GET DIAGNOSTIC. > > [shrug..

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-23 Thread Tom Lane
Dimitri Fontaine writes: > I'll go search for more, meantime I'll just add the main goal of this > new thread is to have -hackers know there is a real user demand for > having EXECUTE set FOUND the same way it sets GET DIAGNOSTIC. [shrug...] There is also real user demand for not silently breaki

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-23 Thread Dimitri Fontaine
Tom Lane writes: > Dimitri Fontaine writes: >> But it will set GET DIAGNOSTIC ... = ROW_COUNT, am I being told on IRC. > > This has been discussed before, please read archives. The thread I found is pretty content free as far as answering my question goes. http://archives.postgresql.org/pgsql

Re: [HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-22 Thread Tom Lane
Dimitri Fontaine writes: > But it will set GET DIAGNOSTIC ... = ROW_COUNT, am I being told on IRC. This has been discussed before, please read archives. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subsc

[HACKERS] plpgsql EXECUTE will not set FOUND

2009-10-22 Thread Dimitri Fontaine
But it will set GET DIAGNOSTIC ... = ROW_COUNT, am I being told on IRC. I was really suprised FOUND is not set by EXECUTE in 8.3 when doing a partitioning UPDATE trigger (we partition a summary table and have to see about doing UPSERT). As I wouldn't have figured GET DIAGNOSTIC was the way to go