Re: [HACKERS] segfault on rollback

2006-08-14 Thread Jim C. Nasby
On Sun, Aug 13, 2006 at 07:01:13PM -0400, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> This reminds me that even though the V3-protocol code has been in there > >> since 7.4, we don't have nearly complete test coverage on it. It'd be a > >> good idea to hav

Re: [HACKERS] segfault on rollback

2006-08-13 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> This reminds me that even though the V3-protocol code has been in there >> since 7.4, we don't have nearly complete test coverage on it. It'd be a >> good idea to have some basic tests included somewhere in the standard or >> contrib

Re: [HACKERS] segfault on rollback

2006-08-13 Thread Alvaro Herrera
Tom Lane wrote: > I wrote: > > We could "fix" this by emitting the log message before calling > > finish_xact_command, but I think that would result in seriously > > underreporting the time required for a COMMIT. Probably the right fix > > is to copy the data we might need out of the Portal before

Re: [HACKERS] segfault on rollback

2006-08-13 Thread Tom Lane
I wrote: > We could "fix" this by emitting the log message before calling > finish_xact_command, but I think that would result in seriously > underreporting the time required for a COMMIT. Probably the right fix > is to copy the data we might need out of the Portal before committing. Patch applie

Re: [HACKERS] segfault on rollback

2006-08-13 Thread Tom Lane
"Sergey E. Koposov" <[EMAIL PROTECTED]> writes: > I'm also sending The output from strace (during the execution of the test > program which I have sent before) showing what jdbc is sending to the > backend. Great, I was just going to ask for that. I can reproduce it in HEAD pretty trivially us

Re: [HACKERS] segfault on rollback

2006-08-12 Thread Sergey E. Koposov
On Sat, 12 Aug 2006, Tom Lane wrote: "Sergey E. Koposov" <[EMAIL PROTECTED]> writes: I recently have seen the segfault with Postgres 8.1.4. I'm betting that portal->sourceText has already been deallocated when exec_execute_message tries to print the log message. Getting an actual segfault fr

Re: [HACKERS] segfault on rollback

2006-08-12 Thread Tom Lane
"Sergey E. Koposov" <[EMAIL PROTECTED]> writes: > I recently have seen the segfault with Postgres 8.1.4. I'm betting that portal->sourceText has already been deallocated when exec_execute_message tries to print the log message. Getting an actual segfault from that would very probably be hard to r