Re: [HACKERS] Another HOT thought: why do we need indcreatexid at all?

2007-09-14 Thread Pavan Deolasee
On 9/14/07, Tom Lane [EMAIL PROTECTED] wrote: I would still desperately like to get rid of indcreatexid, though, because the patch's existing mechanism for clearing it is junk. There's no guarantee that it will get cleared before it wraps around, because the clearing is attached to vacuuming

Re: [HACKERS] [GENERAL] ascii() for utf8

2007-09-14 Thread Andrew Dunstan
Actually, I am working on this as part of the fixes for invalid encoding stuff, as recently discussed. cheers andrew Bruce Momjian wrote: This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold

[HACKERS] errcontext function

2007-09-14 Thread Guillaume Lelarge
Hi, I wonder why all messages going through errcontext function are not translatable. I found this when working on PL/pgsql but it seems other functions (like COPY, see backend/commands/copy.c) call errcontext and none propose translatable messages. Can I send a patch so we can translate them ?

Re: [HACKERS] terms for database replication: synchronous vs eager

2007-09-14 Thread Markus Schiltknecht
Hello Jan, thank you for your feedback. Jan Wieck wrote: On 9/7/2007 11:01 AM, Markus Schiltknecht wrote: This violates the common understanding of synchrony, because you can't commit on a node A and then query another node B and expect it be coherent immediately. That's right. And there

Re: [HACKERS] [GENERAL] ascii() for utf8

2007-09-14 Thread Bruce Momjian
Andrew Dunstan wrote: Actually, I am working on this as part of the fixes for invalid encoding stuff, as recently discussed. OK, I have moved the item into the 8.3 queue. --- cheers andrew Bruce Momjian

Re: [HACKERS] tsearch2 documentation done

2007-09-14 Thread Bruce Momjian
Oleg Bartunov wrote: On Thu, 13 Sep 2007, Bruce Momjian wrote: I am now satisified with the tsearch2 documentation in SGML and have marked the item as complete for 8.3. what's about examples ? They certainly need updating. For example,

Re: [HACKERS] tsearch2 documentation done

2007-09-14 Thread Bruce Momjian
Tom Lane wrote: Oleg Bartunov [EMAIL PROTECTED] writes: On Thu, 13 Sep 2007, Bruce Momjian wrote: I am now satisified with the tsearch2 documentation in SGML and have marked the item as complete for 8.3. what's about examples ? They certainly need updating. Bruce might be satisfied,

Re: [HACKERS] autovacuum launcher eating too much CPU

2007-09-14 Thread Alvaro Herrera
Alvaro Herrera wrote: Darcy Buskermolen wrote: On Thursday 13 September 2007 09:16:52 Alvaro Herrera wrote: Hi, Darcy Buskermolen noticed that when one has many databases, the autovac launcher starts eating too much CPU. Don't forget the memory leak as well. after 3 or 4 days

[HACKERS] away for extended weekend

2007-09-14 Thread Alvaro Herrera
Hi, I'm going to be away until next Thursday, because of our National festivity on 17-19 Sept (normally it's just 18-19 but this year they gave the Monday off as well, just to annoy bosses and to try to calm down the rather revolted climate). I hope I applied all patches that needed to make it

Re: [HACKERS] tsearch2 documentation done

2007-09-14 Thread Oleg Bartunov
On Fri, 14 Sep 2007, Tom Lane wrote: Oleg Bartunov [EMAIL PROTECTED] writes: On Thu, 13 Sep 2007, Bruce Momjian wrote: I am now satisified with the tsearch2 documentation in SGML and have marked the item as complete for 8.3. what's about examples ? They certainly need updating. Bruce

Re: [HACKERS] [PATCHES] Linkage for escape strings

2007-09-14 Thread Bruce Momjian
Patch applied. Thanks. Your documentation changes can be viewed in five minutes using links on the developer's page, http://www.postgresql.org/developer/testing. --- Brendan Jurd wrote: Just a minor doc upgrade. I've

Re: [HACKERS] terms for database replication: synchronous vs eager

2007-09-14 Thread Chris Browne
[EMAIL PROTECTED] (Jan Wieck) writes: On 9/7/2007 11:01 AM, Markus Schiltknecht wrote: None the less, Postgres-R is eager (or pessimistic?) in the sense that it replicates *before* committing, so as to avoid divergence. In [1] I've tried to make that distinction clear, and I'm currently

Re: [HACKERS] pg_dump and insert multi-rows option

2007-09-14 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Andrew Dunstan wrote: Tom Lane wrote: David Fetter [EMAIL PROTECTED] writes: On Tue, Sep 04, 2007 at

[HACKERS] Use of global and static variables in shared libraries

2007-09-14 Thread Don Walker
I'm in the process of converting some C functions written for another system into C functions in a shared library that will be used by PostgreSQL, The key function will be the state transition function for a user-defined aggregate. From what I've read in the documentation: 1. the state value

Re: [HACKERS] autovacuum launcher eating too much CPU

2007-09-14 Thread Darcy Buskermolen
On September 14, 2007 06:36 am, Alvaro Herrera wrote: Alvaro Herrera wrote: Darcy Buskermolen wrote: On Thursday 13 September 2007 09:16:52 Alvaro Herrera wrote: Hi, Darcy Buskermolen noticed that when one has many databases, the autovac launcher starts eating too much CPU.

Re: [HACKERS] RETURNING and DO INSTEAD ... Intentional or not?

2007-09-14 Thread Josh Berkus
Tom, Those would be real users who are not on any PG mailing list? Cause I have not seen any complaints, much less any proposals for a solution... On the Hibernate user mailing list. --Josh ---(end of broadcast)--- TIP 3: Have you checked

Re: [HACKERS] RETURNING and DO INSTEAD ... Intentional or not?

2007-09-14 Thread Joshua D. Drake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Tom Lane wrote: Josh Berkus [EMAIL PROTECTED] writes: FYI, after some tinkering around, I've found that RETURNING is 100% incompatible with any table which has conditional DO INSTEAD rules; there's just no way to make it work and return any

Re: [HACKERS] tsearch2 documentation done

2007-09-14 Thread Tom Lane
Oleg Bartunov [EMAIL PROTECTED] writes: What if we prepare contrib/ts_pack with all examples from documentation and couple of useful dictionaries ? OK by me... regards, tom lane ---(end of broadcast)--- TIP 5: don't

Re: [HACKERS] invalidly encoded strings

2007-09-14 Thread Andrew Dunstan
Tom Lane wrote: I think really the technically cleanest solution would be to make convert() return bytea instead of text; then we'd not have to put restrictions on what encoding or locale it's working inside of. However, it's not clear to me whether there are valid usages that that would

Re: [HACKERS] GIN readme is out of date

2007-09-14 Thread Bruce Momjian
Patch applied. Thanks. --- Heikki Linnakangas wrote: access/gin/README describes the Gin interface, but it hasn't been updated since the change to extractQuery interface to allow no query can match return value.

Re: [HACKERS] terms for database replication: synchronous vs eager

2007-09-14 Thread Markus Schiltknecht
Hi, Chris Browne wrote: The approach that was going to be taken, in Slony-II, to apply locks as early as possible so as to find conflicts as soon as possible, rather than waiting, seems eager to me. Agreed. WRT locking, one might also call it pessimistic, but that sounds so... negative. I

Re: [HACKERS] errcontext function

2007-09-14 Thread Tom Lane
Guillaume Lelarge [EMAIL PROTECTED] writes: I wonder why all messages going through errcontext function are not translatable. I don't think it's errcontext's fault. The PLs in general don't have any translation coverage. This seems a bit difficult to fix: I don't think we'd wish to put their

Re: [HACKERS] Use of global and static variables in shared libraries

2007-09-14 Thread Tom Lane
Don Walker [EMAIL PROTECTED] writes: Since my state is fairly complex I intend to make my state value type text to give myself a block of memory in which I can manage the various pointers I need. I realize that I will need to be careful about alignment issues and intend to store the state as a

Re: [HACKERS] invalidly encoded strings

2007-09-14 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Are you wanting this done for 8.3? If so, by whom? :-) [ shrug... ] I'm not the one who's worried about closing all the holes leading to encoding problems. regards, tom lane ---(end of

Re: [HACKERS] invalidly encoded strings

2007-09-14 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan [EMAIL PROTECTED] writes: Are you wanting this done for 8.3? If so, by whom? :-) [ shrug... ] I'm not the one who's worried about closing all the holes leading to encoding problems. I can certainly have a go at it. Are

Re: [HACKERS] invalidly encoded strings

2007-09-14 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: I can certainly have a go at it. Are we still talking about Oct 1 for a possible beta? Yeah, there's still a little time left --- HOT will take at least a few more days. regards, tom lane ---(end of

Re: [HACKERS] Add function for quote_qualified_identifier?

2007-09-14 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Brendan Jurd wrote: Hi hackers, I note that we currently expose the usefulness of the quote_identifier function

[HACKERS] 8.3 version of ts_headline

2007-09-14 Thread Andreas Joseph Krogh
Hi. In 8.2 this produces an error: SELECT headline('default', 'a b c', 'c'::tsquery, 'StartSel=span class=style1, StopSel=/span'); ERROR: syntax error DETAIL: Syntax error in position 15. while this works: SELECT headline('default', 'a b c', 'c'::tsquery, 'StartSel=b, StopSel=/b'); headline

Re: [HACKERS] 8.3 version of ts_headline

2007-09-14 Thread Tom Lane
Andreas Joseph Krogh [EMAIL PROTECTED] writes: In 8.2 this produces an error: SELECT headline('default', 'a b c', 'c'::tsquery, 'StartSel=span class=style1, StopSel=/span'); ERROR: syntax error DETAIL: Syntax error in position 15. Sure you don't just need to quote the values?

Re: [HACKERS] RETURNING and DO INSTEAD ... Intentional or not?

2007-09-14 Thread Bruce Momjian
Josh Berkus wrote: All, I'll note that we currently prevent adding RETURNING to a *conditional* DO INSTEAD rule. This means that if we have a conditional DO INSTEAD rule which inserts into a different table than the final unconditional rule, we'll be RETURNING wrong or empty values.

Re: [HACKERS] RETURNING and DO INSTEAD ... Intentional or not?

2007-09-14 Thread Joshua D. Drake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruce Momjian wrote: Josh Berkus wrote: All, -- Make it possible to use RETURNING together with conditional DO INSTEAD rules, such as for partitioning setups. Added to TODO: * Make it possible to use RETURNING together with conditional DO

Re: [HACKERS] [GENERAL] AutoVacuum Behaviour Question

2007-09-14 Thread Bruce Momjian
Andrew Hammond wrote: On 9/13/07, Bruce Momjian [EMAIL PROTECTED] wrote: Alvaro Herrera wrote: Bruce Momjian wrote: Is this item closed? No, it isn't. Please add a TODO item about it: * Prevent long-lived temp tables from causing frozen-Xid advancement starvation

[HACKERS] 8.3 Open Items

2007-09-14 Thread Bruce Momjian
I have updated the patches queue to show all open items: http://momjian.us/cgi-bin/pgpatches I am looking for guidance on applying patches or keeping items for 8.4. I will keep this URL updated from now until we release 8.3. -- Bruce Momjian [EMAIL PROTECTED]

Re: [HACKERS] Use of global and static variables in shared libraries

2007-09-14 Thread Don Walker
Q1 a) I will use bytea instead of text. Q1 b) I didn't intend to imply that my state value struct would contain pointers but thanks for reminding me that I should initialize any temporary pointers into the memory area using offsets. Q2 a) If I understand you correctly the use of static or global

Re: [HACKERS] 8.3 Open Items

2007-09-14 Thread Andrew Dunstan
Bruce Momjian wrote: I have updated the patches queue to show all open items: http://momjian.us/cgi-bin/pgpatches I am looking for guidance on applying patches or keeping items for 8.4. I will keep this URL updated from now until we release 8.3. re fix for MSVC builds when

Re: [HACKERS] RETURNING and DO INSTEAD ... Intentional or not?

2007-09-14 Thread Pavel Stehule
Would it make sense to expand this to something like: Make it possible for rules to return affected tuples? I come to this because if you use a rule to create an updateable view, you never know how many rows the view actually updated. Updatable views can be (maybe) implemented with

Re: [HACKERS] MSVC build system

2007-09-14 Thread Hannes Eder
Andrew Dunstan wrote: I want to overhaul the MSVC build system somewhat and want to discuss my plans. [snip]. Apart from fixing the issue with using the systems dir command rather than using File::Find, which I will revisit, I think that's all I would do now, given how close we are to

Re: [HACKERS] Use of global and static variables in shared libraries

2007-09-14 Thread Heikki Linnakangas
Don Walker wrote: Q2 b) You seem to imply that, since the backend doesn't use threads, simultaneous single evaluations of my aggregate by different users/connections would not be a problem for the static or global variables. If 200 users want to evaluate my aggregate at the same time how does

Re: [HACKERS] 8.3 Open Items

2007-09-14 Thread August Zajonc
Andrew Dunstan wrote: Just a note: I don't find the mail archive approach to these lists optimal. A list on a wiki page with links from individual discussions, rather like the one Stefan did earlier at http://developer.postgresql.org/index.php/Todo:PatchStatus , makes things a lot clearer,