Re: [HACKERS] review: FDW API

2011-02-07 Thread Heikki Linnakangas
On 07.02.2011 08:00, Shigeru HANADA wrote: Sorry for late, attached are revised version of FDW API patches which reflect Heikki's comments except removing catalog lookup via IsForeignTable(). ISTM that the point is avoiding catalog lookup during planning, but I have not found when we can set

Re: [HACKERS] [GENERAL] Issues with generate_series using integer boundaries

2011-02-07 Thread Itagaki Takahiro
On Fri, Feb 4, 2011 at 21:32, Thom Brown t...@linux.com wrote: The issue is that generate_series will not return if the series hits either the upper or lower boundary during increment, or goes beyond it.  The attached patch fixes this behaviour, but should probably be done a better way.  The

Re: [HACKERS] A different approach to extension NO USER DATA feature

2011-02-07 Thread Dimitri Fontaine
Hi, Tom Lane t...@sss.pgh.pa.us writes: As I work through the extensions patch, the aspect of it that I like the least is the NO USER DATA clause and related functions. I think it's badly designed, badly implemented, and doesn't solve the problem. I'm not loving it either, but wanting to

[HACKERS] Where the Quals are actually 'List'ed

2011-02-07 Thread Vaibhav Kaushal
Hi, I find that ExecInitExpr creates a ExprState tree (and so say the comments above the function in the source). Also, it seems to decide which function would get called when the expression is to be evaluated when ExecQual runs, by setting the function pointer, for example:

Re: [HACKERS] Foreign servers and user mappings versus the extensions patch

2011-02-07 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: On Sat, Feb 5, 2011 at 5:41 PM, Tom Lane t...@sss.pgh.pa.us wrote: Currently, the extensions patch considers that foreign data wrappers, foreign servers, and user mapping objects can all be parts of extensions. This is slightly problematic for pg_dump,

Re: [HACKERS] A different approach to extension NO USER DATA feature

2011-02-07 Thread Richard Huxton
On 06/02/11 18:23, Tom Lane wrote: After a bit of thought I believe that we can fix this if we are willing to teach pg_dump explicitly about extension configuration tables. The behavior we want for those is for the table schema definition to never be dumped (the table should always be created by

Re: [HACKERS] SSI patch version 14

2011-02-07 Thread Heikki Linnakangas
On 05.02.2011 21:43, Kevin Grittner wrote: Kevin Grittner wrote: So now that I'm sure we actually do need code there, I'll add it. In working on this I noticed the apparent need to move two calls to PredicateLockTuple a little bit to keep them inside the buffer lock. Without at least a

Re: [HACKERS] [GENERAL] Issues with generate_series using integer boundaries

2011-02-07 Thread Thom Brown
On 7 February 2011 09:04, Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Fri, Feb 4, 2011 at 21:32, Thom Brown t...@linux.com wrote: The issue is that generate_series will not return if the series hits either the upper or lower boundary during increment, or goes beyond it.  The attached

Re: [HACKERS] SQL/MED - file_fdw

2011-02-07 Thread Itagaki Takahiro
On Mon, Feb 7, 2011 at 16:01, Shigeru HANADA han...@metrosystems.co.jp wrote: This patch is based on latest FDW API patches which are posted in another thread SQL/MED FDW API, and copy_export-20110104.patch which was posted by Itagaki-san. I have questions about estimate_costs(). * What value

[HACKERS] DROP SCHEMA xxx CASCADE: ERROR: could not open relation with OID yyy

2011-02-07 Thread strk
Hi all, I'm trying to debug an ugly error triggered from a DROP SCHEMA xxx CASCADE call inside a function. The call is the last step of the stored pl/pgsql procedure. I've verified that removing the DROP SCHEMA command from _inside_ the function body and performing it _outside_ it (right after

Re: [HACKERS] SQL/MED - file_fdw

2011-02-07 Thread Noah Misch
On Mon, Feb 07, 2011 at 03:39:39PM +0900, Itagaki Takahiro wrote: On Sun, Feb 6, 2011 at 09:01, Noah Misch n...@leadboat.com wrote: Most parse analysis-type bits of DoCopy() move to BeginCopy(). It would be possible to move more FROM-only or TO-only members in BeginCopy() into their

[HACKERS] Error attribution in foreign scans

2011-02-07 Thread Noah Misch
Suppose you create several file_fdw foreign tables, query them together, and read(2) returns EIO for one of the files: [local] postgres=# SELECT * FROM ft0, ft1, ft2; ERROR: could not read from COPY file: Input/output error The message does not show which foreign table yielded the error. We

Re: [HACKERS] Range Types

2011-02-07 Thread Dimitri Fontaine
Hi, Jeff Davis pg...@j-davis.com writes: * Should pg_range reference the btree opclass or the compare function directly? I would say yes. We use the btree opclass in other similar situations. * Should subtype_cmp default to the default btree opclass's compare function? My vote is yes

Re: [HACKERS] Problem with postgresql database connection in combination with HUAWEI data modem

2011-02-07 Thread Markus Wanner
On 02/03/2011 04:45 PM, Robert Haas wrote: Your data modem is probably doing something funky to your network stack, but I don't know what. Are other network services affected as well? In that case, I'd file a bug against the modem driver software. Regards Markus Wanner -- Sent via

[HACKERS] odd output of pg_basebackup

2011-02-07 Thread Fujii Masao
Hi, When I ran pg_basebackup with -x, -P and -v options, I encountered the following odd output. $ pg_basebackup -D hoge -x -P -v xlog start point: 0/220 33708/17322 kB (100%) 1/1 tablespaces ( )02) 02) is a part of the previously reported message, it looks odd that

Re: [HACKERS] DROP SCHEMA xxx CASCADE: ERROR: could not open relation with OID yyy

2011-02-07 Thread Dimitri Fontaine
strk s...@keybit.net writes: Do you have an idea on how to further debug this ? That usually goes with providing a self-contained test case… that is a minimum script that creates the function(s) and calls them. Regards, -- Dimitri Fontaine http://2ndQuadrant.fr PostgreSQL : Expertise,

Re: [HACKERS] Error attribution in foreign scans

2011-02-07 Thread Heikki Linnakangas
On 07.02.2011 14:17, Noah Misch wrote: Suppose you create several file_fdw foreign tables, query them together, and read(2) returns EIO for one of the files: [local] postgres=# SELECT * FROM ft0, ft1, ft2; ERROR: could not read from COPY file: Input/output error The message does not show

Re: [HACKERS] DROP SCHEMA xxx CASCADE: ERROR: could not open relation with OID yyy

2011-02-07 Thread strk
I've handled to produce a small testcase: http://strk.keybit.net/tmp/could_not_open_relation.sql It still requires postgis (svn), but if anyone has that it might help. Will try to go on with the reduction. --strk; On Mon, Feb 07, 2011 at 12:38:08PM +0100, strk wrote: Hi all, I'm trying to

Re: [HACKERS] DROP SCHEMA xxx CASCADE: ERROR: could not open relation with OID yyy

2011-02-07 Thread strk
I've uploaded also the script output ( CASCADE traces ) : http://strk.keybit.net/tmp/could_not_open_relation.sql http://strk.keybit.net/tmp/could_not_open_relation.log And realized that the relation oid is the one first requested for deletion. Ie: DROP TABLE XXX CASCADE; .. ERROR: could

Re: [HACKERS] DROP SCHEMA xxx CASCADE: ERROR: could not open relation with OID yyy

2011-02-07 Thread strk
On Mon, Feb 07, 2011 at 02:31:49PM +0100, Dimitri Fontaine wrote: strk s...@keybit.net writes: Do you have an idea on how to further debug this ? That usually goes with providing a self-contained test case… that is a minimum script that creates the function(s) and calls them. I've

Re: [HACKERS] A different approach to extension NO USER DATA feature

2011-02-07 Thread Robert Haas
On Mon, Feb 7, 2011 at 4:18 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Or do you want to keep some generality here? I think it might be slightly advantageous to keep some generality, because some people might already have catalog columns that do this (but with a different name) or might

Re: [HACKERS] [COMMITTERS] pgsql: remove tags.

2011-02-07 Thread Bruce Momjian
Robert Haas wrote: On Sun, Feb 6, 2011 at 11:12 PM, Tom Lane t...@sss.pgh.pa.us wrote: Bruce Momjian br...@momjian.us writes: Bruce Momjian wrote: remove tags. Sorry, vague commit message (I forgot squash). Can I will use git ammend to improve this message? Absolutely not.

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Robert Haas
On Sun, Jan 30, 2011 at 11:44 AM, Robert Haas robertmh...@gmail.com wrote: Time's running short - do you have an updated patch? This patch hasn't been updated in more than three weeks. I assume this should now be marked Returned with Feedback, and we'll revisit synchronous replication for 9.2?

Re: [HACKERS] little mistakes in HS/SR

2011-02-07 Thread Bruce Momjian
Robert Haas wrote: On Sun, Feb 6, 2011 at 6:44 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Thu, Jul 22, 2010 at 1:41 AM, Fujii Masao masao.fu...@gmail.com wrote: We should enclose -1 with literal tag. A quick survey of the documentation as a whole suggests that we

[HACKERS] Re: [GENERAL] Why copy ... from stdio does not return immediately when reading invalid data?

2011-02-07 Thread Nicolas Grilly
I have analyzed the PostgreSQL protocol using Wireshark (an open source packet analyzer), and I observed that the PostgreSQL backend, while doing a COPY ... FROM STDIN, reports errors as soon as possible (especially errors related to invalid data). Therefore, the late reporting of errors while

Re: [HACKERS] A different approach to extension NO USER DATA feature

2011-02-07 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Feb 7, 2011 at 4:18 AM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Or do you want to keep some generality here? I think it might be slightly advantageous to keep some generality, Yeah. I had also thought about hard-wiring the WHERE

Re: [HACKERS] A different approach to extension NO USER DATA feature

2011-02-07 Thread Tom Lane
Richard Huxton d...@archonet.com writes: Possible alternative approach? 1. Extension provides list of config tables/views/set-returning functions to be dumped via e.g. my_config_tables() 2. They get dumped, but each as a TEMP TABLE (need unique names for multiple extensions though). 3. On

Re: [HACKERS] Spread checkpoint sync

2011-02-07 Thread Cédric Villemain
2011/2/7 Greg Smith g...@2ndquadrant.com: Robert Haas wrote: With the fsync queue compaction patch applied, I think most of this is now not needed.  Attached please find an attempt to isolate the portion that looks like it might still be useful.  The basic idea of what remains here is to

Re: [HACKERS] SQL/MED - file_fdw

2011-02-07 Thread Shigeru HANADA
On Mon, 7 Feb 2011 21:00:53 +0900 Itagaki Takahiro itagaki.takah...@gmail.com wrote: On Mon, Feb 7, 2011 at 16:01, Shigeru HANADA han...@metrosystems.co.jp wrote: This patch is based on latest FDW API patches which are posted in another thread SQL/MED FDW API, and copy_export-20110104.patch

Re: [HACKERS] Spread checkpoint sync

2011-02-07 Thread Greg Smith
Cédric Villemain wrote: Is it worth a new thread with the different IO improvements done so far or on-going and how we may add new GUC(if required !!!) with intelligence between those patches ? ( For instance, hint bit IO limit needs probably a tunable to define something similar to

Re: [HACKERS] limiting hint bit I/O

2011-02-07 Thread Bruce Momjian
Robert Haas wrote: On Sat, Feb 5, 2011 at 4:31 PM, Bruce Momjian br...@momjian.us wrote: Uh, in this C comment: + ? ? ? ?* or not we want to take the time to write it. ?We allow up to 5% of + ? ? ? ?* otherwise-not-dirty pages to be written due to hint bit changes, 5% of what? ?5%

[HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Tom Lane
There are some things that the current extensions patch leaves indeterminate during a dump and reload cycle, which strikes me as a bad thing. One is ownership. Since we don't record the identity of the user who created an extension, there's no way for pg_dump to ensure that it's recreated by the

Re: [HACKERS] [PERFORM] pgbench to the MAXINT

2011-02-07 Thread Greg Smith
The update on the work to push towards a bigger pgbench is that I now have the patch running and generating databases larger than any previously possible scale: $ time pgbench -i -s 25000 pgbench ... 25 tuples done. ... real258m46.350s user14m41.970s sys0m21.310s $ psql -d

Re: [HACKERS] Varlena and binary

2011-02-07 Thread Tom Lane
=?utf-8?q?Rados=C5=82aw_Smogura?= m...@smogura.eu writes: I'm sending small patch for textsend. It reduces unnecessary copies, and memory usage for duplication of varlena data. May you look? This code will break the day that text and bytea don't have the same internal representation, which

Re: [HACKERS] Where the Quals are actually 'List'ed

2011-02-07 Thread Tom Lane
Vaibhav Kaushal vaibhavkaushal...@gmail.com writes: Hi, I find that ExecInitExpr creates a ExprState tree (and so say the comments above the function in the source). Also, it seems to decide which function would get called when the expression is to be evaluated when ExecQual runs, by setting

Re: [HACKERS] A different approach to extension NO USER DATA feature

2011-02-07 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: one I'd been thinking about a bit was OIDs of modules this one depends on. The current design doesn't cope very well with modules that depend on other ones. Or even at all. I guess here modules is referring to shared object libraries, right? Or are you

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Bruce Momjian
Robert Haas wrote: On Sun, Jan 30, 2011 at 11:44 AM, Robert Haas robertmh...@gmail.com wrote: Time's running short - do you have an updated patch? This patch hasn't been updated in more than three weeks. I assume this should now be marked Returned with Feedback, and we'll revisit

Re: [HACKERS] A different approach to extension NO USER DATA feature

2011-02-07 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: one I'd been thinking about a bit was OIDs of modules this one depends on. The current design doesn't cope very well with modules that depend on other ones. Or even at all. I guess here modules is referring

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Simon Riggs
On Mon, 2011-02-07 at 09:55 -0500, Robert Haas wrote: On Sun, Jan 30, 2011 at 11:44 AM, Robert Haas robertmh...@gmail.com wrote: Time's running short - do you have an updated patch? This patch hasn't been updated in more than three weeks. I assume this should now be marked Returned with

Re: [HACKERS] exposing COPY API

2011-02-07 Thread Andrew Dunstan
On 02/04/2011 05:49 AM, Itagaki Takahiro wrote: Here is a demonstration to support jagged input files. It's a patch on the latest patch. The new added API is: bool NextLineCopyFrom( [IN] CopyState cstate, [OUT] char ***fields, [OUT] int *nfields, [OUT] Oid *tupleOid) It

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: One is ownership. Since we don't record the identity of the user who created an extension, there's no way for pg_dump to ensure that it's recreated by the same user. I think we'll regret that in future even if you don't think it's problematic today. In

Re: [HACKERS] A different approach to extension NO USER DATA feature

2011-02-07 Thread Florian Pflug
On Feb6, 2011, at 19:23 , Tom Lane wrote: After a bit of thought I believe that we can fix this if we are willing to teach pg_dump explicitly about extension configuration tables. The behavior we want for those is for the table schema definition to never be dumped (the table should always be

Re: [HACKERS] Range Types - cache lookup failed for function

2011-02-07 Thread Jeff Davis
On Sun, 2011-02-06 at 20:10 +0100, Erik Rijkers wrote: I was trying where intrange @ integer which admittedly is not in the documentation, but does already half work, and would be really convenient to have. As it stands the construct seems to fail after ANALYZE, when there is more

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: I think we'd better add an extowner column to pg_extension. Agreed. There's no need to have it now but we will add it at some point. So if now is when that works the best for you, I'm happy to see that

Re: [HACKERS] A different approach to extension NO USER DATA feature

2011-02-07 Thread Tom Lane
Florian Pflug f...@phlo.org writes: We could avoid the need for a per-row system_data flag if we required extensions to split user-editable and system-provided configuration data into different tables. For convenient access to the configuration data, the extension could let the user-editable

Re: [HACKERS] Range Types

2011-02-07 Thread Jeff Davis
On Mon, 2011-02-07 at 13:33 +0100, Dimitri Fontaine wrote: Hi, Jeff Davis pg...@j-davis.com writes: * Should pg_range reference the btree opclass or the compare function directly? I would say yes. We use the btree opclass in other similar situations. Ok, but what should the

Re: [HACKERS] limiting hint bit I/O

2011-02-07 Thread Robert Haas
On Mon, Feb 7, 2011 at 10:48 AM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Sat, Feb 5, 2011 at 4:31 PM, Bruce Momjian br...@momjian.us wrote: Uh, in this C comment: + ? ? ? ?* or not we want to take the time to write it. ?We allow up to 5% of + ? ? ? ?*

Re: [HACKERS] OpenVMS - an effort which needs guidance and support.

2011-02-07 Thread Chris Browne
peder...@ccsscorp.com (Bill Pedersen) writes: I look forward to hearing from people in the PostgreSQL community as well as from others interested in this effort. To a number of us, it's academically interesting, though, as we don't have VMS systems, it's not likely to be super-easy to assist in

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: No, I've hacked the code enough already that merging would be painful. I'll keep working on it. I supposed so much, but got to ask :) Oh, duh, I'd forgotten about the OverrideSearchPath usage. So never mind the above claim. But I still think it'd be a

Re: [HACKERS] Range Types

2011-02-07 Thread Dimitri Fontaine
Jeff Davis pg...@j-davis.com writes: Ok, but what should the parameter to CREATE TYPE ... AS RANGE be then? CREATE TYPE foo AS RANGE ( SUBTYPE = ... SUBTYPE_BTREE_OPERATOR_CLASS = ... ); is a little verbose. Ideas? I would think CREATE TYPE foo AS RANGE (bar) USING (btree_ops);

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Robert Haas
On Mon, Feb 7, 2011 at 11:33 AM, Simon Riggs si...@2ndquadrant.com wrote: On Mon, 2011-02-07 at 09:55 -0500, Robert Haas wrote: On Sun, Jan 30, 2011 at 11:44 AM, Robert Haas robertmh...@gmail.com wrote: Time's running short - do you have an updated patch? This patch hasn't been updated in

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Robert Haas
On Mon, Feb 7, 2011 at 12:28 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Feb 7, 2011 at 11:33 AM, Simon Riggs si...@2ndquadrant.com wrote: On Mon, 2011-02-07 at 09:55 -0500, Robert Haas wrote: On Sun, Jan 30, 2011 at 11:44 AM, Robert Haas robertmh...@gmail.com wrote: Time's running

Re: [HACKERS] SSI patch version 14

2011-02-07 Thread Kevin Grittner
Kevin Grittner kgri...@wicourts.gov wrote: Kevin Grittner wrote: Jeff Davis wrote: What does PredicateLockTuple do that needs a share lock? Does a pin suffice? If one process is reading a tuple and another is writing it (e.g., UPDATE or DELETE) the concern is that we need to be able

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: ... Well, the current CommitFest ends in one week, ... Really? I thought the idea for the last CF of a development cycle was that it kept going till we'd dealt with everything. Arbitrarily rejecting stuff we haven't dealt with doesn't seem fair.

Re: [HACKERS] A different approach to extension NO USER DATA feature

2011-02-07 Thread David E. Wheeler
On Feb 7, 2011, at 8:57 AM, Tom Lane wrote: Yeah, this is another approach that one could take instead of having per-row flags. I'm not sure that it's better, much less so much better that we should force extensions to do it that way and not the other. But it's definitely another argument

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: Quite aside from search path, cross-extension dependencies simply aren't going to work unless pg_dump knows about them so it can load the extensions in the right order. I had forgotten about the earthdistance

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread David E. Wheeler
On Feb 7, 2011, at 9:20 AM, Dimitri Fontaine wrote: Also, I didn't bite this bullet, but maybe we should provide core PLs as extension. Then CREATE LANGUAGE would maybe get deprecated and only valid when used in an extension's script — or the next patch (UPGRADE) will take care of create a

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread David E. Wheeler
On Feb 7, 2011, at 9:51 AM, Tom Lane wrote: Interesting point. It's all right at the moment because I tweaked pg_dump_sort.c so that procedural languages are dumped before modules. But maybe we should convert the PLs to modules. s/modules/extensions/? David -- Sent via pgsql-hackers

Re: [HACKERS] A different approach to extension NO USER DATA feature

2011-02-07 Thread Tom Lane
David E. Wheeler da...@kineticode.com writes: On Feb 7, 2011, at 8:57 AM, Tom Lane wrote: Yeah, this is another approach that one could take instead of having per-row flags. I'm not sure that it's better, much less so much better that we should force extensions to do it that way and not the

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Tom Lane
David E. Wheeler da...@kineticode.com writes: On Feb 7, 2011, at 9:51 AM, Tom Lane wrote: Interesting point. It's all right at the moment because I tweaked pg_dump_sort.c so that procedural languages are dumped before modules. But maybe we should convert the PLs to modules.

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Simon Riggs
On Mon, 2011-02-07 at 12:39 -0500, Robert Haas wrote: I just spoke to my manager at EnterpriseDB and he cleared my schedule for the next two days to work on this. So I'll go hack on this now. I haven't read the patch yet so I don't know for sure how quite I'll be able to get up to speed on

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Robert Haas
On Mon, Feb 7, 2011 at 12:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: ... Well, the current CommitFest ends in one week, ... Really?  I thought the idea for the last CF of a development cycle was that it kept going till we'd dealt with everything.  

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Robert Haas
On Mon, Feb 7, 2011 at 12:59 PM, Simon Riggs si...@2ndquadrant.com wrote: On Mon, 2011-02-07 at 12:39 -0500, Robert Haas wrote: I just spoke to my manager at EnterpriseDB and he cleared my schedule for the next two days to work on this.  So I'll go hack on this now. I haven't read the patch

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: I think we'd better add an extowner column to pg_extension. Agreed. There's no need to have it now but we will add it at some point. So if now is when that works the best for you, I'm happy to see that

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Tom Lane
I wrote: ... So where I think we're going to end up is adding a clause along the line of USING list-of-extension-names to CREATE EXTENSION, storing those dependencies explicitly, and having the CREATE EXTENSION code set search_path to the target schema followed by the target schema(s) of the

Re: [HACKERS] WIP: RangeTypes

2011-02-07 Thread Peter Eisentraut
On sön, 2011-01-30 at 14:52 -0800, Jeff Davis wrote: * naming issues: - period - tsrange ? - periodtz - tstzrange ? - intrange - int4range Have you considered a grammar approach like for arrays, so that you would write something like CREATE TABLE ... ( foo RANGE OF int );

Re: [HACKERS] Spread checkpoint sync

2011-02-07 Thread Kevin Grittner
Greg Smith g...@2ndquadrant.com wrote: As a larger statement on this topic, I'm never very excited about redesigning here starting from any point other than saw a bottleneck doing x on a production system. There's a long list of such things already around waiting to be addressed, and I've

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: On reflection, the set of extensions that an extension depends on is obviously a property of the extension, which means it ought to be specified in the extension's control file, not in the CREATE EXTENSION command. So now I'm thinking something like

Re: [HACKERS] limiting hint bit I/O

2011-02-07 Thread Cédric Villemain
2011/2/7 Robert Haas robertmh...@gmail.com: On Mon, Feb 7, 2011 at 10:48 AM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Sat, Feb 5, 2011 at 4:31 PM, Bruce Momjian br...@momjian.us wrote: Uh, in this C comment: + ? ? ? ?* or not we want to take the time to write it. ?We

Re: [HACKERS] limiting hint bit I/O

2011-02-07 Thread Cédric Villemain
2011/2/7 Cédric Villemain cedric.villemain.deb...@gmail.com: 2011/2/7 Robert Haas robertmh...@gmail.com: On Mon, Feb 7, 2011 at 10:48 AM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Sat, Feb 5, 2011 at 4:31 PM, Bruce Momjian br...@momjian.us wrote: Uh, in this C comment:

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: done in the time available is another thing entirely. I do NOT want to still be working on the items for this CommitFest in June - that's about when I'd like to be releasing beta3. Except that's not how we work here. You want to change that with

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Joshua D. Drake
On Mon, 2011-02-07 at 17:59 +, Simon Riggs wrote: On Mon, 2011-02-07 at 12:39 -0500, Robert Haas wrote: I just spoke to my manager at EnterpriseDB and he cleared my schedule for the next two days to work on this. So I'll go hack on this now. I haven't read the patch yet so I don't

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: That said, we should do something about ALTER EXTENSION SET SCHEMA and the relocatable property. I'm thinking that an extension stops being relocatable as soon as any of its reverse dependencies (all the tree) is not relocatable. If you're

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Robert Haas
On Mon, Feb 7, 2011 at 2:09 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Robert Haas robertmh...@gmail.com writes: done in the time available is another thing entirely.  I do NOT want to still be working on the items for this CommitFest in June - that's about when I'd like to be

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Josh Berkus
I just spoke to my manager at EnterpriseDB and he cleared my schedule for the next two days to work on this. So I'll go hack on this now. I haven't read the patch yet so I don't know for sure how quite I'll be able to get up to speed on it, so if someone who is more familiar with this code

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread David E. Wheeler
On Feb 7, 2011, at 10:23 AM, Tom Lane wrote: On reflection, the set of extensions that an extension depends on is obviously a property of the extension, which means it ought to be specified in the extension's control file, not in the CREATE EXTENSION command. So now I'm thinking something

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Robert Haas
On Mon, Feb 7, 2011 at 2:56 PM, Dave Page dp...@pgadmin.org wrote: On Mon, Feb 7, 2011 at 6:55 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Feb 7, 2011 at 12:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: ... Well, the current CommitFest ends in one

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Dave Page
On Mon, Feb 7, 2011 at 6:55 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Feb 7, 2011 at 12:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: ... Well, the current CommitFest ends in one week, ... Really?  I thought the idea for the last CF of a

Re: [HACKERS] SQL/MED - file_fdw

2011-02-07 Thread Andrew Dunstan
On 02/07/2011 01:39 AM, Itagaki Takahiro wrote: file_fdw uses CopyFromErrorCallback() to give errors the proper context. The function uses template strings like COPY %s, line %d, where %s is the name of the relation being copied. Presumably file_fdw and other features using this API would

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: If you're worried about that, then it's questionable whether ALTER EXTENSION SET SCHEMA makes sense at all, ever. I don't see any reason to think that an extension is more fragile for this purpose than any other random SQL dependencies. Also, an extension

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: Dave Page dp...@pgadmin.org wrote: Robert Haas robertmh...@gmail.com wrote: Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: ... Well, the current CommitFest ends in one week, ... Really? I thought the idea for the last

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Dave Page
On Mon, Feb 7, 2011 at 8:59 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Feb 7, 2011 at 2:56 PM, Dave Page dp...@pgadmin.org wrote: On Mon, Feb 7, 2011 at 6:55 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Feb 7, 2011 at 12:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Dimitri Fontaine
Robert Haas robertmh...@gmail.com writes: I'm not trying to bypass compromising, and I don't know what makes you think otherwise. I am trying to ensure that the CommitFest wraps up Well, I'm too tired to allow myself posting such comments, sorry to have left the previous mail through. More

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Josh Berkus
On 2/7/11 11:41 AM, Robert Haas wrote: However, I don't want to prolong the CommitFest indefinitely in the face of patches that the authors are not actively working on or can't finish in the time available, or where there is no consensus that the proposed change is what we want. I believe

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Robert Haas
On Mon, Feb 7, 2011 at 3:06 PM, Dave Page dp...@pgadmin.org wrote: Rejecting stuff because we haven't gotten round to dealing with it in such a short period of time is a damn good way to limit the number of contributions we get. I don't believe we've agreed at any point that the last

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Joshua D. Drake
On Mon, 2011-02-07 at 12:24 -0800, Josh Berkus wrote: +1. I, for one, would vote against extending beta if Sync Rep isn't ready yet. There's plenty of other big features in 9.1, and Sync Rep will benefit from having additional development time given the number of major spec points we only

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Dave Page
On Mon, Feb 7, 2011 at 9:25 PM, Robert Haas robertmh...@gmail.com wrote: You're moving the bar.  It DOES say that the CommitFest will end on February 15th.  Now, if we want to have a discussion about changing that, let's have that discussion (perhaps on a thread where the subject has something

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Robert Haas
On Mon, Feb 7, 2011 at 3:14 PM, Dimitri Fontaine dimi...@2ndquadrant.fr wrote: Robert Haas robertmh...@gmail.com writes: I'm not trying to bypass compromising, and I don't know what makes you think otherwise.  I am trying to ensure that the CommitFest wraps up Well, I'm too tired to allow

[HACKERS] PgEast 2011: 3 days until close of CFP

2011-02-07 Thread Joshua D. Drake
Hello hackers, Just FYI, the CFP for PgEast in NYC closes in three days. https://www.postgresqlconference.org/talk_types Sincerely, JD -- PostgreSQL.org Major Contributor Command Prompt, Inc: http://www.commandprompt.com/ - 509.416.6579 Consulting, Training, Support, Custom Development,

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Robert Haas
On Mon, Feb 7, 2011 at 3:34 PM, Dave Page dp...@pgadmin.org wrote: On Mon, Feb 7, 2011 at 9:25 PM, Robert Haas robertmh...@gmail.com wrote: You're moving the bar.  It DOES say that the CommitFest will end on February 15th.  Now, if we want to have a discussion about changing that, let's have

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Dave Page
On Mon, Feb 7, 2011 at 9:46 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Feb 7, 2011 at 3:34 PM, Dave Page dp...@pgadmin.org wrote: On Mon, Feb 7, 2011 at 9:25 PM, Robert Haas robertmh...@gmail.com wrote: You're moving the bar.  It DOES say that the CommitFest will end on February

Re: [HACKERS] Error code for terminating connection due to conflict with recovery

2011-02-07 Thread Simon Riggs
On Wed, 2011-02-02 at 21:21 -0500, Robert Haas wrote: On Tue, Feb 1, 2011 at 3:17 AM, Simon Riggs si...@2ndquadrant.com wrote: ERRCODE_DATABASE_DROPPED57P04 looks best So I guess the only remaining issue is whether we should distinguish the error message text, as well as the error

Re: [HACKERS] More extension issues: ownership and search_path

2011-02-07 Thread Tom Lane
Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane t...@sss.pgh.pa.us writes: If you're worried about that, then it's questionable whether ALTER EXTENSION SET SCHEMA makes sense at all, ever. I don't see any reason to think that an extension is more fragile for this purpose than any

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Chris Browne
dp...@pgadmin.org (Dave Page) writes: On Mon, Feb 7, 2011 at 6:55 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Feb 7, 2011 at 12:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: ... Well, the current CommitFest ends in one week, ... Really?  I

Re: [HACKERS] Varlena and binary

2011-02-07 Thread Radosław Smogura
Just from curious may I ask in which direction this will go, and how this will affect performance of text and binary format? Actually I started to make smaller improvements, and I think about one big to encode text (when client and server encoding are different) directly to StringInfo, without

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Simon Riggs
On Mon, 2011-02-07 at 15:25 -0500, Robert Haas wrote: I would certainly appreciate it if everyone could at least credit me with acting in good faith. I think you are, if that helps. -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Spread checkpoint sync

2011-02-07 Thread Greg Smith
Kevin Grittner wrote: There are occasional posts from those wondering why their read-only queries are so slow after a bulk load, and why they are doing heavy writes. (I remember when I posted about that, as a relative newbie, and I know I've seen others.) Sure; I created

Re: [HACKERS] SSI patch version 14

2011-02-07 Thread Heikki Linnakangas
On 06.02.2011 20:30, Kevin Grittner wrote: Kevin Grittner wrote: I'm working on it now, and hope to have it all settled down today. Done and pushed to the git repo. Branch serializable on: git://git.postgresql.org/git/users/kgrittn/postgres.git Heikki: I'm back to not having any

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-07 Thread Simon Riggs
On Mon, 2011-02-07 at 11:50 -0800, Josh Berkus wrote: I just spoke to my manager at EnterpriseDB and he cleared my schedule for the next two days to work on this. So I'll go hack on this now. I haven't read the patch yet so I don't know for sure how quite I'll be able to get up to speed

Re: [HACKERS] SSI patch version 14

2011-02-07 Thread Magnus Hagander
On Mon, Feb 7, 2011 at 23:14, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 06.02.2011 20:30, Kevin Grittner wrote: Kevin Grittner  wrote: I'm working on it now, and hope to have it all settled down today. Done and pushed to the git repo.  Branch serializable on:

  1   2   >