[HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Simon Riggs
On Thu, 2011-02-17 at 00:53 +, Tom Lane wrote: Doesn't anybody around here pay attention to compiler warnings? If you see one, then I accept one was there. I didn't see one, and a full make distclean and re-compile doesn't show a compiler warning for that either. So I guess I'm doing

Re: [HACKERS] Fix corner case for binary upgrade: extension functions in pg_catalog.

2011-02-17 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: Dimitri Fontaine dimi...@2ndquadrant.fr writes: Tom Lane p...@gwene.org writes: Fix corner case for binary upgrade: extension functions in pg_catalog. Do we only want to care about functions here? Yes. Functions/aggregates are the only object type where

Re: [HACKERS] Usability tweaks for extension commands

2011-02-17 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: I'm just wondering whether applying that theory is leading to the right choices here. In particular, the default behavior if you didn't say SCHEMA something would be to automatically move the extension into whatever random schema happens to be the front of

Re: [HACKERS] btree_gist (was: CommitFest progress - or lack thereof)

2011-02-17 Thread Oleg Bartunov
We need to fix inet support as Tom complained and then will commit. Oleg On Wed, 16 Feb 2011, Robert Haas wrote: On Sat, Feb 12, 2011 at 8:19 AM, Robert Haas robertmh...@gmail.com wrote: On Sat, Feb 12, 2011 at 7:47 AM, Stephen Frost sfr...@snowman.net wrote: Oleg, * Oleg Bartunov

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread rsmogura
Something like this, Everything must be done on call, due to polymorphic signatures, this can be kept in short living cache, but bear in mind user can alter procedure in meantime. When JDBC driver will detect if procedure call statement is created. 1. Determine procedure oid - how?

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Florian Pflug
On Feb17, 2011, at 01:14 , Oliver Jowett wrote: Any suggestions about how the JDBC driver can express the query to get the behavior that it wants? Specifically, the driver wants to call a particular function with N OUT or INOUT parameters (and maybe some other IN parameters too) and get a

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Florian Pflug
On Feb17, 2011, at 10:30 , rsmogura wrote: When JDBC driver will detect if procedure call statement is created. 1. Determine procedure oid - how? procedures may have not qualified name. Is any function on backend that will deal with schema search path? You may need to pass procedure

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Pavel Stehule
2011/2/17 Florian Pflug f...@phlo.org: On Feb17, 2011, at 10:30 , rsmogura wrote: When JDBC driver will detect if procedure call statement is created. 1. Determine procedure oid - how? procedures may have not qualified name. Is any function on backend that will deal with schema search path?

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Andrea Suisani
On 02/10/2011 11:34 PM, Joshua D. Drake wrote: Hello, Per: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=607109 It seems we may have a problem to consider. As far as I know, we are the only major platform that supports libedit but our default is readline. Unfortunately readline is not

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread rsmogura
Yes new node should be created and added for 8.x and 9.x releases... On Thu, 17 Feb 2011 10:53:19 +0100, Pavel Stehule wrote: 2011/2/17 Florian Pflug f...@phlo.org: On Feb17, 2011, at 10:30 , rsmogura wrote: When JDBC driver will detect if procedure call statement is created. 1. Determine

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Oliver Jowett
Lukas Eder wrote: The result set meta data correctly state that there are 6 OUT columns. But only the first 2 are actually fetched (because of a nested UDT)... The data mangling was just a plpgsql syntactic issue, wasn't it? Oliver -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread rsmogura
Maybe change in backend to treat complex types marked in relation as COMPLEX in same way as scalar values is solution, actually I don't know. This can be determined by GUC variable so every one can be happy :) On Thu, 17 Feb 2011 23:08:13 +1300, Oliver Jowett wrote: Lukas Eder wrote: The

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Oliver Jowett
Florian Pflug wrote: On Feb17, 2011, at 01:14 , Oliver Jowett wrote: Any suggestions about how the JDBC driver can express the query to get the behavior that it wants? Specifically, the driver wants to call a particular function with N OUT or INOUT parameters (and maybe some other IN parameters

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Pavel Stehule
2011/2/17 rsmogura rsmog...@softperience.eu: Yes new node should be created and added for 8.x and 9.x releases... what node? Pavel On Thu, 17 Feb 2011 10:53:19 +0100, Pavel Stehule wrote: 2011/2/17 Florian Pflug f...@phlo.org: On Feb17, 2011, at 10:30 , rsmogura wrote: When JDBC driver

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread rsmogura
Yes, but driver checks number of declared out parameters and number of resulted parameters (even check types of those), to prevent programming errors. On Thu, 17 Feb 2011 23:15:07 +1300, Oliver Jowett wrote: Florian Pflug wrote: On Feb17, 2011, at 01:14 , Oliver Jowett wrote: Any suggestions

Re: [HACKERS] tsearch Parser Hacking

2011-02-17 Thread Jesper Krogh
On 16 Feb 2011, at 23:22, David E. Wheeler da...@kineticode.com wrote: On Feb 14, 2011, at 11:44 PM, Oleg Bartunov wrote: IMO, sooner or later we need to trash that code and replace it with something a bit more modification-friendly. We thought about configurable parser, but AFAIR, we

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Magnus Hagander
On Thu, Feb 17, 2011 at 05:23, Joshua D. Drake j...@commandprompt.com wrote: On Wed, 2011-02-16 at 22:53 -0500, Bruce Momjian wrote: Stephen Frost wrote: -- Start of PGP signed section. * Greg Stark (gsst...@mit.edu) wrote: Well for what it's worth we want to support both. At least the

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Dave Page
On Thu, Feb 17, 2011 at 10:36 AM, Magnus Hagander mag...@hagander.net wrote: On Thu, Feb 17, 2011 at 05:23, Joshua D. Drake j...@commandprompt.com wrote: On Wed, 2011-02-16 at 22:53 -0500, Bruce Momjian wrote: Stephen Frost wrote: -- Start of PGP signed section. * Greg Stark

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Oliver Jowett
On 17/02/11 23:18, rsmogura wrote: Yes, but driver checks number of declared out parameters and number of resulted parameters (even check types of those), to prevent programming errors. And..? Oliver -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Greg Stark
On Thu, Feb 17, 2011 at 4:50 AM, Jason Earl je...@notengoamigos.org wrote: This will be a significant advantage for        further free software development, and some projects will decide        to make software free in order to use these libraries. You've misread this paragraph. Postgres is

Re: [HACKERS] btree_gist (was: CommitFest progress - or lack thereof)

2011-02-17 Thread Robert Haas
2011/2/17 Oleg Bartunov o...@sai.msu.su: We need to fix inet support as Tom complained and then will commit. I think those are two separate issues. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread rsmogura
On Fri, 18 Feb 2011 00:06:22 +1300, Oliver Jowett wrote: On 17/02/11 23:18, rsmogura wrote: Yes, but driver checks number of declared out parameters and number of resulted parameters (even check types of those), to prevent programming errors. And..? Oliver And it will throw exception

Re: [HACKERS] sepgsql contrib module

2011-02-17 Thread Robert Haas
On Thu, Feb 17, 2011 at 3:56 AM, Kohei Kaigai kohei.kai...@eu.nec.com wrote: The attached patch removes rules to build a policy package for regression test and modifies documentation part to introduce steps to run the test. Committed. Incidentally, on my Ubuntu system: $ find

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Greg Stark
On Thu, Feb 17, 2011 at 3:39 AM, Stephen Frost sfr...@snowman.net wrote: * Greg Stark (gsst...@mit.edu) wrote: Well for what it's worth we want to support both. At least the project philosophy has been that commercial derivatives are expected and acceptable so things like EDB's products, or

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Oliver Jowett
On 18/02/11 00:37, rsmogura wrote: On Fri, 18 Feb 2011 00:06:22 +1300, Oliver Jowett wrote: On 17/02/11 23:18, rsmogura wrote: Yes, but driver checks number of declared out parameters and number of resulted parameters (even check types of those), to prevent programming errors. And..?

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Magnus Hagander
On Thu, Feb 17, 2011 at 11:49, Dave Page dp...@pgadmin.org wrote: On Thu, Feb 17, 2011 at 10:36 AM, Magnus Hagander mag...@hagander.net wrote: On Thu, Feb 17, 2011 at 05:23, Joshua D. Drake j...@commandprompt.com wrote: On Wed, 2011-02-16 at 22:53 -0500, Bruce Momjian wrote: Stephen Frost

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Dave Page
On Thu, Feb 17, 2011 at 11:45 AM, Magnus Hagander mag...@hagander.net wrote: On Thu, Feb 17, 2011 at 11:49, Dave Page dp...@pgadmin.org wrote: Depends on your definition of distribute (and what part you are specifically referring to). There's no tarball, but the installer sources are on

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread rsmogura
On Fri, 18 Feb 2011 00:44:07 +1300, Oliver Jowett wrote: On 18/02/11 00:37, rsmogura wrote: On Fri, 18 Feb 2011 00:06:22 +1300, Oliver Jowett wrote: On 17/02/11 23:18, rsmogura wrote: Yes, but driver checks number of declared out parameters and number of resulted parameters (even check types

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Oliver Jowett
On 18/02/11 00:52, rsmogura wrote: On Fri, 18 Feb 2011 00:44:07 +1300, Oliver Jowett wrote: On 18/02/11 00:37, rsmogura wrote: On Fri, 18 Feb 2011 00:06:22 +1300, Oliver Jowett wrote: On 17/02/11 23:18, rsmogura wrote: Yes, but driver checks number of declared out parameters and number of

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Florian Pflug
On Feb17, 2011, at 11:15 , Oliver Jowett wrote: Florian Pflug wrote: On Feb17, 2011, at 01:14 , Oliver Jowett wrote: Any suggestions about how the JDBC driver can express the query to get the behavior that it wants? Specifically, the driver wants to call a particular function with N OUT or

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Oliver Jowett
On 18/02/11 01:08, Florian Pflug wrote: Well, the JDBC driver does know how many OUT parameters there are before execution happens, so it could theoretically do something different for 1 OUT vs. many OUT parameters. Right, I had forgotten that JDBC must be told about OUT parameter with

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread rsmogura
snip testdb=# CREATE FUNCTION p_enhance_address4 (address OUT u_address_type) AS $$ BEGIN address := (SELECT t_author.address FROM t_author WHERE first_name = 'George'); END; $$ LANGUAGE plpgsql; CREATE FUNCTION testdb=# SELECT * FROM p_enhance_address4(); street | zip |

Re: [HACKERS] Fix for Index Advisor related hooks

2011-02-17 Thread Gurjeet Singh
On Wed, Feb 16, 2011 at 6:37 PM, Tom Lane t...@sss.pgh.pa.us wrote: Gurjeet Singh singh.gurj...@gmail.com writes: On Wed, Feb 16, 2011 at 10:25 AM, Tom Lane t...@sss.pgh.pa.us wrote: The only reason you'd need that code is if you were trying to construct a fake Relation structure, which

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-17 Thread Peter Eisentraut
On fre, 2011-02-11 at 14:19 -0500, Tom Lane wrote: But now, let's make it harder. I've found a grave bug in 1.1, which causes the PG backend to segfault. Easy fix, good thing, so now I release 1.2: Unless the bug is such that you have to change the installation script file, there is no

Re: [HACKERS] why two dashes in extension load files

2011-02-17 Thread Peter Eisentraut
On tis, 2011-02-15 at 15:32 -0500, Tom Lane wrote: I can't claim close familiarity with Debian's conventions in this matter, but I do know about RPM's, and I'm uneager to duplicate that silliness. Magic conversion of dots to underscores (sometimes), complete inability to determine which part

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Peter Geoghegan
On 17 February 2011 08:30, Simon Riggs si...@2ndquadrant.com wrote: In file included from gram.y:12758: scan.c: In function ‘yy_try_NUL_trans’: scan.c:16256: warning: unused variable ‘yyg’ Lots of people have reported that one. It's been around since August of last year, if not earlier. --

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Simon Riggs
On Thu, 2011-02-17 at 14:37 +, Peter Geoghegan wrote: On 17 February 2011 08:30, Simon Riggs si...@2ndquadrant.com wrote: In file included from gram.y:12758: scan.c: In function ‘yy_try_NUL_trans’: scan.c:16256: warning: unused variable ‘yyg’ Lots of people have reported that one.

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Robert Haas
On Thu, Feb 17, 2011 at 9:50 AM, Simon Riggs si...@2ndquadrant.com wrote: On Thu, 2011-02-17 at 14:37 +, Peter Geoghegan wrote: On 17 February 2011 08:30, Simon Riggs si...@2ndquadrant.com wrote: In file included from gram.y:12758: scan.c: In function ‘yy_try_NUL_trans’: scan.c:16256:

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On Thu, 2011-02-17 at 00:53 +, Tom Lane wrote: Doesn't anybody around here pay attention to compiler warnings? If you see one, then I accept one was there. I didn't see one, and a full make distclean and re-compile doesn't show a compiler warning

Re: [HACKERS] btree_gist (was: CommitFest progress - or lack thereof)

2011-02-17 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: 2011/2/17 Oleg Bartunov o...@sai.msu.su: We need to fix inet support as Tom complained and then will commit. I think those are two separate issues. Yeah ... also, fixing the inet problem looked to me like it'd probably be a major compatibility break

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Bruce Momjian
Dave Page wrote: On Thu, Feb 17, 2011 at 11:45 AM, Magnus Hagander mag...@hagander.net wrote: On Thu, Feb 17, 2011 at 11:49, Dave Page dp...@pgadmin.org wrote: Depends on your definition of distribute (and what part you are specifically referring to). There's no tarball, but the installer

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Bruce Momjian
Stephen Frost wrote: -- Start of PGP signed section. * Bruce Momjian (br...@momjian.us) wrote: Joshua D. Drake wrote: Probably readline but does it matter? We distribute the source to the click installers. Well, there is what the community is risking, and there is what the

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: Well, we are going down a slippery slope if we think the click-through installers are OK to use readline and distribute because we supply the source for the installers --- that then requires anyone using the binaries (or libraries) in those installers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Simon Riggs
On Thu, 2011-02-17 at 10:09 -0500, Tom Lane wrote: Simon Riggs si...@2ndquadrant.com writes: On Thu, 2011-02-17 at 00:53 +, Tom Lane wrote: Doesn't anybody around here pay attention to compiler warnings? If you see one, then I accept one was there. I didn't see one, and a full make

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: I just posted on this. The risk is to people using the packages --- the packages themselves include the source as an option, so they are fine, but everyone using those packages would also be required to distribute source, which is a restriction we

Re: [HACKERS] Add support for logging the current role

2011-02-17 Thread Robert Haas
On Wed, Feb 16, 2011 at 9:52 PM, Stephen Frost sfr...@snowman.net wrote: * Robert Haas (robertmh...@gmail.com) wrote: Ah, so it does.  Sounds like you win.  Have we a patch implementing the sounds-like-its-agreed change, then? Patch attached, rebased to current master. Ugg, wait a minute.

Re: [HACKERS] Add support for logging the current role

2011-02-17 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Ugg, wait a minute. This not only adds %U; it also changes the behavior of %u, which I don't think we've agreed on. Also, emitting 'none' when not SET ROLE has been done is pretty ugly. I'm back to thinking we need to push this out to 9.2 and take

Re: [HACKERS] Add support for logging the current role

2011-02-17 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: Ugg, wait a minute. This not only adds %U; it also changes the behavior of %u, which I don't think we've agreed on. Also, emitting 'none' when not SET ROLE has been done is pretty ugly. I'm back to thinking we need to push this out to 9.2 and

Re: [HACKERS] Add support for logging the current role

2011-02-17 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: Robert Haas robertmh...@gmail.com writes: Ugg, wait a minute. This not only adds %U; it also changes the behavior of %u, which I don't think we've agreed on. Also, emitting 'none' when not SET ROLE has been done is pretty ugly. I'm back to

Re: [HACKERS] ALTER EXTENSION UPGRADE, v3

2011-02-17 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On fre, 2011-02-11 at 14:19 -0500, Tom Lane wrote: Unless the bug is such that you have to change the installation script file, there is no reason to bump the version number at all. These version numbers apply to the install SQL script, not the

Re: [HACKERS] Add support for logging the current role

2011-02-17 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: * Tom Lane (t...@sss.pgh.pa.us) wrote: Yeah, I thought what was supposed to be emitted was the value of current_user, not SQL's weird definition of what SET ROLE means. current_user uses GetUserNameFromId() and goes through the cache lookups to get

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: It might be worth trying to clean up those warn_unused_result things, if other people are seeing those. In `make world` I'm seeing: scan.c: In function *yy_try_NUL_trans*: scan.c:16256: warning: unused variable *yyg* -- elog.c: In function

Re: [HACKERS] Add support for logging the current role

2011-02-17 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: Well, that just doesn't seem useful to me in the real world. If I were using this, I would expect it to emit a real user name that matches the currently applied permissions checking. All the time. I wouldn't have ever thought to use %U w/o %u, to be

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Bruce Momjian
Stephen Frost wrote: -- Start of PGP signed section. * Bruce Momjian (br...@momjian.us) wrote: Well, we are going down a slippery slope if we think the click-through installers are OK to use readline and distribute because we supply the source for the installers --- that then requires

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Bruce Momjian
Stephen Frost wrote: -- Start of PGP signed section. * Bruce Momjian (br...@momjian.us) wrote: I just posted on this. The risk is to people using the packages --- the packages themselves include the source as an option, so they are fine, but everyone using those packages would also be

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Tom Lane t...@sss.pgh.pa.us wrote: It might be worth trying to clean up those warn_unused_result things, if other people are seeing those. elog.c: In function *write_console*: elog.c:1708: warning: ignoring return value of *write*, declared

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: psql used to use the native Windows line editing ability --- has that changed? *that* I couldn't tell you.. Thanks, Stephen signature.asc Description: Digital signature

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Would you check whether just casting the function result to (void) shuts it up? Casting the result to (void) didn't change the warning. It shut up when I declared a local variable and assigned the value to it (which was then never used). -Kevin -- Sent

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Andrew Dunstan
On 02/17/2011 11:22 AM, Bruce Momjian wrote: psql used to use the native Windows line editing ability --- has that changed? When did it? Ad what native windows line editing ability are you referring to? cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Bruce Momjian
Andrew Dunstan wrote: On 02/17/2011 11:22 AM, Bruce Momjian wrote: psql used to use the native Windows line editing ability --- has that changed? When did it? Ad what native windows line editing ability are you referring to? There is native Windows editing like arrows, etc and

Re: [HACKERS] Add support for logging the current role

2011-02-17 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: Ugg, wait a minute. This not only adds %U; it also changes the behavior of %u, which I don't think we've agreed on. Also, emitting 'none' when not SET ROLE has been done is pretty ugly. I'm back to thinking we need to push this out to 9.2 and

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Andrew Dunstan
On 02/17/2011 11:44 AM, Bruce Momjian wrote: Andrew Dunstan wrote: On 02/17/2011 11:22 AM, Bruce Momjian wrote: psql used to use the native Windows line editing ability --- has that changed? When did it? Ad what native windows line editing ability are you referring to? There is native

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Bruce Momjian
Andrew Dunstan wrote: On 02/17/2011 11:44 AM, Bruce Momjian wrote: Andrew Dunstan wrote: On 02/17/2011 11:22 AM, Bruce Momjian wrote: psql used to use the native Windows line editing ability --- has that changed? When did it? Ad what native windows line editing ability are you

Re: [HACKERS] sepgsql contrib module

2011-02-17 Thread Kohei Kaigai
The attached patch removes rules to build a policy package for regression test and modifies documentation part to introduce steps to run the test. Thanks, -- NEC Europe Ltd, Global Competence Center KaiGai Kohei kohei.kai...@eu.nec.com -Original Message- From: Kohei Kaigai Sent: 15

Re: [HACKERS] Fwd: [JDBC] Weird issues when reading UDT from stored function

2011-02-17 Thread Lukas Eder
2011/2/17 Florian Pflug f...@phlo.org On Feb17, 2011, at 01:14 , Oliver Jowett wrote: Any suggestions about how the JDBC driver can express the query to get the behavior that it wants? Specifically, the driver wants to call a particular function with N OUT or INOUT parameters (and maybe

[HACKERS] rewrite of RECENTLY DEAD tuples

2011-02-17 Thread Benjamin S.
Hello list, ATRewriteTable in tablecmds.c uses SnapshotNow to rewrite and thus does not copy RECENTLY DEAD tuples. But copy_heap_data in cluster.c uses SnapshotAny and copys RECENTLY DEAD tuples to the new heap file. I don't understand why it is not needed in the first case. In the second case

Re: [HACKERS] SSI bug?

2011-02-17 Thread YAMAMOTO Takashi
hi, YAMAMOTO Takashi wrote: with your previous patch or not? With, thanks. i tried. unfortunately i can still reproduce the original loop problem. WARNING: [0] target 0xbb51ef18 tag 4000:4017:7e3:78:0 prior 0xbb51f148 next 0xb b51edb0 WARNING: [1] target 0xbb51f148 tag

Re: [HACKERS] SSI bug?

2011-02-17 Thread YAMAMOTO Takashi
hi, YAMAMOTO Takashi wrote: might be unrelated to the loop problem, but... Aha! I think it *is* related. There were several places where data was uninitialized here; mostly because Dan was working on this piece while I was working on separate issues which added the new fields. I

Re: [HACKERS] SSI bug?

2011-02-17 Thread YAMAMOTO Takashi
hi, might be unrelated to the loop problem, but... i got the following SEGV when runnning vacuum on a table. (the line numbers in predicate.c is different as i have local modifications.) oldlocktag.myTarget was NULL. it seems that TransferPredicateLocksToNewTarget sometimes use stack garbage for

[HACKERS] default_tablespace

2011-02-17 Thread carl clemens
Hi Hackers, After reviewing docs and searching web cannot find out how to determine the default tablespace of a user? Like: select spcname from blab where roloid = ; Is this possible? Thank you for your time. -- Sent via pgsql-hackers mailing list

Re: [HACKERS] pika failing since the per-column collation patch

2011-02-17 Thread Rémi Zara
Le 14 févr. 2011 à 19:27, Rémi Zara a écrit : Le 12 févr. 2011 à 18:51, Peter Eisentraut a écrit : It's only failing on this one machine, but there isn't anything platform-specific in this code, so I'd look for memory management faults on the code or a compiler problem. Try with lower

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: In at least some of these cases, I think ignoring the write() result is intentional, because there's really nothing useful we can do about it if it fails (oh, you wish we'd log a failure to write to the log?). I know that in Java you can get a positive

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Andrew Dunstan
On 02/17/2011 11:58 AM, Bruce Momjian wrote: Andrew Dunstan wrote: On 02/17/2011 11:44 AM, Bruce Momjian wrote: Andrew Dunstan wrote: On 02/17/2011 11:22 AM, Bruce Momjian wrote: psql used to use the native Windows line editing ability --- has that changed? When did it? Ad what native

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Bruce Momjian
Andrew Dunstan wrote: On 02/17/2011 11:58 AM, Bruce Momjian wrote: Andrew Dunstan wrote: On 02/17/2011 11:44 AM, Bruce Momjian wrote: Andrew Dunstan wrote: On 02/17/2011 11:22 AM, Bruce Momjian wrote: psql used to use the native Windows line editing ability --- has that changed?

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-17 Thread Tom Lane
So, after some testing, attached are two different fixed-up versions of pg_tgrm's update-from-unpackaged script. The first one leaves the parameter lists of some GIN support functions different from what they would be if you installed pg_trgrm fresh in 9.1. The second one fixes the parameter

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: Tom Lane t...@sss.pgh.pa.us wrote: Would you check whether just casting the function result to (void) shuts it up? Casting the result to (void) didn't change the warning. It shut up when I declared a local variable and assigned the value

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Tom Lane
Kevin Grittner kevin.gritt...@wicourts.gov writes: I know that in Java you can get a positive number less than the full size as an indication that part of the block was written, and you must loop to write until you get all of it written (or get an error return). At this page, it appears that

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: OK, I was only responding to Stephen Frost who said psql did not behave like other Windows apps. I don't actually run psql or PG on Windows at all, I just presumed it did since you were bringing up concerns about it in the Windows installers. Ah well,

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Andrew Dunstan
On 02/17/2011 12:13 PM, Bruce Momjian wrote: FWIW, the only interactively usable version of psql for windows I know of is the one that runs under Cygwin. It can be build with readline and works as expected. Uh, don't we have a psql built via MSVC? Doesn't it work interactively? Not if

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Andrew Dunstan
On 02/17/2011 12:19 PM, Tom Lane wrote: Kevin Grittnerkevin.gritt...@wicourts.gov writes: Tom Lanet...@sss.pgh.pa.us wrote: Would you check whether just casting the function result to (void) shuts it up? Casting the result to (void) didn't change the warning. It shut up when I declared

Re: [HACKERS] default_tablespace

2011-02-17 Thread David Kerr
On Wed, Feb 16, 2011 at 03:59:13PM -0800, carl clemens wrote: - Hi Hackers, - - After reviewing docs and searching web - cannot find out how to determine the default tablespace - of a user? - - Like: - - select spcname from blab where roloid = ; - - Is this possible? - - Thank you for

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Bruce Momjian
Stephen Frost wrote: -- Start of PGP signed section. * Bruce Momjian (br...@momjian.us) wrote: I just posted on this. The risk is to people using the packages --- the packages themselves include the source as an option, so they are fine, but everyone using those packages would also be

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Bruce Momjian
Andrew Dunstan wrote: On 02/17/2011 12:13 PM, Bruce Momjian wrote: FWIW, the only interactively usable version of psql for windows I know of is the one that runs under Cygwin. It can be build with readline and works as expected. Uh, don't we have a psql built via MSVC? Doesn't it

Re: [HACKERS] rewrite of RECENTLY DEAD tuples

2011-02-17 Thread Noah Misch
On Thu, Feb 17, 2011 at 09:38:51AM +0100, Benjamin S. wrote: ATRewriteTable in tablecmds.c uses SnapshotNow to rewrite and thus does not copy RECENTLY DEAD tuples. But copy_heap_data in cluster.c uses SnapshotAny and copys RECENTLY DEAD tuples to the new heap file. I don't understand why it

Re: [HACKERS] patch (for 9.1) string functions ( correct patch attached )

2011-02-17 Thread Bruce Momjian
Erik Rijkers wrote: On Thu, July 29, 2010 22:43, Erik Rijkers wrote: Hi Pavel, In xfunc.sgml, I came across a function example (for use of VARIADIC in polymorphic functions), where the function name is concat(): (in the manual: 35.4.10. Polymorphic SQL Functions). Although that

Re: [HACKERS] ECPG dynamic cursor fix for UPDATE/DELETE ... WHERE CURRENT OF :curname

2011-02-17 Thread Bruce Momjian
Boszormenyi Zoltan wrote: Kevin Grittner ?rta: Michael Meskes mich...@fam-meskes.de wrote: All prior ECPG versions were fine because dynamic cursor names were only added in 9.0. Apparently only this one place was missed. So this is a bug in the new feature, however not such a

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Kevin Grittner
Andrew Dunstan and...@dunslane.net wrote: Ugh. Isn't there some sort of pragma or similar we can use to shut it up? If that fails, maybe use some function like the below? That would also have the advantage of not relying on assumptions beyond the documented API, which I tend to feel good

Re: [HACKERS] Rewrite, normal execution vs. EXPLAIN ANALYZE

2011-02-17 Thread Bruce Momjian
Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Wed, Aug 4, 2010 at 2:45 PM, Tom Lane t...@sss.pgh.pa.us wrote: I seriously doubt that there are many applications out there that are actually depending on this aspect of rule execution; if anything, there are probably more that

Re: [HACKERS] Rewrite, normal execution vs. EXPLAIN ANALYZE

2011-02-17 Thread Robert Haas
On Thu, Feb 17, 2011 at 1:04 PM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Wed, Aug 4, 2010 at 2:45 PM, Tom Lane t...@sss.pgh.pa.us wrote: I seriously doubt that there are many applications out there that are actually depending on

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Joshua D. Drake
On Thu, 2011-02-17 at 10:49 +, Dave Page wrote: On Thu, Feb 17, 2011 at 10:36 AM, Magnus Hagander mag...@hagander.net wrote: Probably readline but does it matter? We distribute the source to the click installers. Actually, we don't. We used to, but we don't at this point. Depends

Re: [HACKERS] Debian readline/libedit breakage

2011-02-17 Thread Andrew Dunstan
On 02/17/2011 12:34 PM, Bruce Momjian wrote: Andrew Dunstan wrote: On 02/17/2011 12:13 PM, Bruce Momjian wrote: FWIW, the only interactively usable version of psql for windows I know of is the one that runs under Cygwin. It can be build with readline and works as expected. Uh, don't we

Re: [HACKERS] Rewrite, normal execution vs. EXPLAIN ANALYZE

2011-02-17 Thread Bruce Momjian
Robert Haas wrote: On Thu, Feb 17, 2011 at 1:04 PM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Wed, Aug 4, 2010 at 2:45 PM, Tom Lane t...@sss.pgh.pa.us wrote: I seriously doubt that there are many applications out there that are

Re: [HACKERS] remove upsert example from docs

2011-02-17 Thread Bruce Momjian
Marko Tiikkaja wrote: On 8/5/2010 9:44 PM, Merlin Moncure wrote: On Thu, Aug 5, 2010 at 2:09 PM, Tom Lanet...@sss.pgh.pa.us wrote: I was not persuaded that there's a real bug in practice. IMO, his problem was a broken trigger not broken upsert logic. Even if we conclude this is unsafe,

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-17 Thread Robert Haas
On Thu, Feb 17, 2011 at 12:16 PM, Tom Lane t...@sss.pgh.pa.us wrote: So, after some testing, attached are two different fixed-up versions of pg_tgrm's update-from-unpackaged script.  The first one leaves the parameter lists of some GIN support functions different from what they would be if you

Re: [HACKERS] remove upsert example from docs

2011-02-17 Thread Marko Tiikkaja
On 2011-02-17 8:37 PM +0200, Bruce Momjian wrote: Marko Tiikkaja wrote: The problem with the safe way is that it's not safe if called in a transaction with isolation level set to SERIALIZABLE. Good analysis. Documentation patch attached and applied. The safe way I was referring to above

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-17 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Feb 17, 2011 at 12:16 PM, Tom Lane t...@sss.pgh.pa.us wrote: It's worth noting that both versions still leave the pg_trgm opclasses a bit different from a fresh install, because the added operators are loose in the opfamily rather than being

Re: [HACKERS] COPY ENCODING revisited

2011-02-17 Thread Robert Haas
On Wed, Feb 16, 2011 at 10:45 PM, Itagaki Takahiro itagaki.takah...@gmail.com wrote: COPY ENCODING patch was returned with feedback,  https://commitfest.postgresql.org/action/patch_view?id=501 but we still need it for file_fdw.  Using client_encoding at runtime is reasonable for one-time COPY

Re: [HACKERS] contrib loose ends: 9.0 to 9.1 incompatibilities

2011-02-17 Thread Robert Haas
On Thu, Feb 17, 2011 at 1:53 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Feb 17, 2011 at 12:16 PM, Tom Lane t...@sss.pgh.pa.us wrote: It's worth noting that both versions still leave the pg_trgm opclasses a bit different from a fresh install,

Re: [HACKERS] COPY ENCODING revisited

2011-02-17 Thread Hitoshi Harada
2011/2/17 Itagaki Takahiro itagaki.takah...@gmail.com: Base on the latest patch,  http://archives.postgresql.org/pgsql-hackers/2011-01/msg02903.php I added pg_any_to_server() and pg_server_to_any() functions instead of exposing FmgrInfo in pg_wchar.h.  They are same as pg_client_to_server()

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Andrew Dunstan
On 02/17/2011 12:54 PM, Kevin Grittner wrote: Andrew Dunstanand...@dunslane.net wrote: Ugh. Isn't there some sort of pragma or similar we can use to shut it up? If that fails, maybe use some function like the below? That would also have the advantage of not relying on assumptions beyond

  1   2   >