Re: [HACKERS] pg_stats_recovery view

2012-02-02 Thread Fujii Masao
On Thu, Feb 2, 2012 at 4:26 PM, Jaime Casanova ja...@2ndquadrant.com wrote: On Wed, Feb 1, 2012 at 9:18 PM, Fujii Masao masao.fu...@gmail.com wrote: --On 15. Januar 2012 02:50:00 -0500 Jaime Casanova ja...@2ndquadrant.com wrote: Attached is a patch thats implements a pg_stat_recovery view

Re: [HACKERS] pg_stats_recovery view

2012-02-02 Thread Fujii Masao
On Thu, Feb 2, 2012 at 4:32 PM, Magnus Hagander mag...@hagander.net wrote: On Thu, Feb 2, 2012 at 08:26, Jaime Casanova ja...@2ndquadrant.com wrote: On Wed, Feb 1, 2012 at 9:18 PM, Fujii Masao masao.fu...@gmail.com wrote: --On 15. Januar 2012 02:50:00 -0500 Jaime Casanova ja...@2ndquadrant.com

Re: [HACKERS] pgsql_fdw, FDW for PostgreSQL server

2012-02-02 Thread Marko Kreen
On Tue, Jan 31, 2012 at 8:56 PM, Robert Haas robertmh...@gmail.com wrote: 2012/1/29 Kohei KaiGai kai...@kaigai.gr.jp:     Remote SQL: DECLARE pgsql_fdw_cursor_0 SCROLL CURSOR FOR SELECT a, b FROM public.t1 WHERE (a 2)  (3 rows) Shouldn't we be using protocol-level cursors rather than

Re: [HACKERS] Refactoring log_newpage

2012-02-02 Thread Simon Riggs
On Thu, Feb 2, 2012 at 7:26 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Well, you can obviously check the catalogs for that, but you must be assuming that you don't have access to the catalogs or this would be a non-issue. You can also identify the kind of page by

Re: [HACKERS] JSON output functions.

2012-02-02 Thread Abhijit Menon-Sen
At 2012-02-01 18:48:28 -0500, andrew.duns...@pgexperts.com wrote: For now I'm inclined not to proceed with that, and leave it as an optimization to be considered later if necessary. Thoughts? I agree, there doesn't seem to be a pressing need to do it now. -- ams -- Sent via pgsql-hackers

Re: [HACKERS] Index-only scan performance regression

2012-02-02 Thread Dean Rasheed
On 2 February 2012 01:40, Robert Haas robertmh...@gmail.com wrote: On Wed, Feb 1, 2012 at 7:44 PM, Robert Haas robertmh...@gmail.com wrote: So, I guess the trade-off here is that, since sinval messages aren't processed immediately, we often won't notice the VM extension until the next

Re: [HACKERS] Refactoring log_newpage

2012-02-02 Thread Heikki Linnakangas
On 02.02.2012 11:35, Simon Riggs wrote: On Thu, Feb 2, 2012 at 7:26 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Well, you can obviously check the catalogs for that, but you must be assuming that you don't have access to the catalogs or this would be a non-issue. You can

Re: [HACKERS] JSON for PG 9.2

2012-02-02 Thread Abhijit Menon-Sen
At 2012-02-01 11:28:50 -0500, robertmh...@gmail.com wrote: It's also pretty clear that JSON string - PG text data type is going to admit of a number of error conditions (transcoding errors and perhaps invalid surrogate pairs) so throwing one more on the pile doesn't cost much. Hi Robert.

Re: [HACKERS] [PATCH] Fix float8 parsing of denormal values (on some platforms?)

2012-02-02 Thread Marti Raudsepp
On Wed, Feb 1, 2012 at 20:17, Tom Lane t...@sss.pgh.pa.us wrote: Applied with minor revisions. Thanks! :) We're already seeing first buildfarm failures, on system narwhal using an msys/mingw compiler. http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=narwhaldt=2012-02-02%2005%3A00%3A02 No idea

Re: [HACKERS] Patch pg_is_in_backup()

2012-02-02 Thread Marti Raudsepp
On Mon, Jan 30, 2012 at 20:33, Gilles Darold gilles.dar...@dalibo.com wrote: After some time searching for a Pg system administration function like pg_is_in_recovery(), let's say pg_is_in_backup(), I couldn't find one. The minor patch attached here adds this administrative function that can be

Re: [HACKERS] [GENERAL] pg_dump -s dumps data?!

2012-02-02 Thread hubert depesz lubaczewski
On Wed, Feb 01, 2012 at 10:02:14PM +0100, Dimitri Fontaine wrote: The case for a table that is partly user data and partly extension data is very thin, I think that if I had this need I would use inheritance and a CHECK(user_data is true/false) constraint to filter the data. definitely agree.

Re: [HACKERS] Patch pg_is_in_backup()

2012-02-02 Thread Pavel Stehule
2012/2/2 Marti Raudsepp ma...@juffo.org: On Mon, Jan 30, 2012 at 20:33, Gilles Darold gilles.dar...@dalibo.com wrote: After some time searching for a Pg system administration function like pg_is_in_recovery(), let's say pg_is_in_backup(), I couldn't find one. The minor patch attached here adds

Re: [HACKERS] spgist text_ops and LIKE

2012-02-02 Thread Robert Haas
On Wed, Feb 1, 2012 at 10:57 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Is spgist intended to support prefix searches with LIKE? Too lazy to look at the code right now, but I think indxpath.c contains hardwired assumptions that LIKE prefix optimizations

Re: [HACKERS] JSON for PG 9.2

2012-02-02 Thread Robert Haas
On Thu, Feb 2, 2012 at 4:54 AM, Abhijit Menon-Sen a...@toroid.org wrote: At 2012-02-01 11:28:50 -0500, robertmh...@gmail.com wrote: It's also pretty clear that JSON string - PG text data type is going to admit of a number of error conditions (transcoding errors and perhaps invalid surrogate

Re: [HACKERS] Progress on fast path sorting, btree index creation time

2012-02-02 Thread k...@rice.edu
On Wed, Feb 01, 2012 at 04:12:58PM -0600, Jim Nasby wrote: On Jan 26, 2012, at 9:32 PM, Robert Haas wrote: But if we want to put it on a diet, the first thing I'd probably be inclined to lose is the float4 specialization. Some members of the audience will recall that I take dim view of

Re: [HACKERS] freezing multixacts

2012-02-02 Thread Robert Haas
On Wed, Feb 1, 2012 at 11:33 PM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: So freezing multixacts is not all that easy.  I mean, you just scan the page looking for multis lesser than the cutoff; for those that are dead, they can just be removed completely, but what about ones that still

Re: [HACKERS] heap_tuple_needs_freeze false positive

2012-02-02 Thread Robert Haas
On Wed, Feb 1, 2012 at 8:01 PM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: Suggested patch attached.  I'd backpatch this as far as it applies cleanly. This is new code in 9.2, but it's modelled on heap_freeze_tuple(), which is old. I'm not convinced that it's a bug. Suppose that xmax is

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-02 Thread Marko Kreen
On Thu, Feb 02, 2012 at 04:51:37PM +0900, Kyotaro HORIGUCHI wrote: Hello, This is new version of dblink.c - Memory is properly freed when realloc returns NULL in storeHandler(). - The bug that free() in finishStoreInfo() will be fed with garbage pointer when malloc for sinfo-valbuflen

Re: [HACKERS] keywords in initdb are case-sensitive?

2012-02-02 Thread Robert Haas
On Wed, Feb 1, 2012 at 11:45 PM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: In miracee's review of Peter's patch for new -A options in initdb (in commitfest app only), it is noted that pg_hba.conf keyword parsing is done in a case sensitive manner.  So if you write Trust rather than trust,

Re: [HACKERS] patch for implementing SPI_gettypemod()

2012-02-02 Thread Robert Haas
On Wed, Feb 1, 2012 at 5:23 AM, Chetan Suttraway chetan.suttra...@enterprisedb.com wrote: Hi All, This is regarding the TODO item : Add SPI_gettypmod() to return a field's typemod from a TupleDesc The related message is: http://archives.postgresql.org/pgsql-hackers/2005-11/msg00250.php

Re: [HACKERS] JSON for PG 9.2

2012-02-02 Thread Abhijit Menon-Sen
At 2012-02-02 08:54:32 -0500, robertmh...@gmail.com wrote: Someone is eventually going to propose a function with a name like json_to_string() which, when given this JSON object, returns a three-character string with the PostgreSQL text type. Ah, that's the bit I was missing. I thought you

Re: [HACKERS] keywords in initdb are case-sensitive?

2012-02-02 Thread Alvaro Herrera
Excerpts from Robert Haas's message of jue feb 02 11:39:29 -0300 2012: On Wed, Feb 1, 2012 at 11:45 PM, Alvaro Herrera alvhe...@alvh.no-ip.org wrote: In miracee's review of Peter's patch for new -A options in initdb (in commitfest app only), it is noted that pg_hba.conf keyword parsing is

Re: [HACKERS] JSON output functions.

2012-02-02 Thread Andrew Dunstan
On 02/02/2012 04:35 AM, Abhijit Menon-Sen wrote: At 2012-02-01 18:48:28 -0500, andrew.duns...@pgexperts.com wrote: For now I'm inclined not to proceed with that, and leave it as an optimization to be considered later if necessary. Thoughts? I agree, there doesn't seem to be a pressing need

Re: [HACKERS] double writes using double-write buffer approach [WIP]

2012-02-02 Thread Robert Haas
On Fri, Jan 27, 2012 at 5:31 PM, Dan Scales sca...@vmware.com wrote: I've been prototyping the double-write buffer idea that Heikki and Simon had proposed (as an alternative to a previous patch that only batched up writes by the checkpointer).  I think it is a good idea, and can help

Re: [HACKERS] Refactoring log_newpage

2012-02-02 Thread Tom Lane
Simon Riggs si...@2ndquadrant.com writes: On Wed, Feb 1, 2012 at 10:42 PM, Jim Nasby j...@nasby.net wrote: But we already had RelFileNode; wouldn't that be enough to tell what rmgr was responsible for the new page? Can 2 different rmgrs write to the same file node? No, but which one? No

Re: [HACKERS] heap_tuple_needs_freeze false positive

2012-02-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I'm not convinced that it's a bug. Suppose that xmax is set but is hinted as invalid. XMAX_INVALID is not a hint. When it's set, the contents of the field must be presumed to be garbage. Any code failing to adhere to that rule is broken. We process

Re: [HACKERS] Vacuum rate limit in KBps

2012-02-02 Thread Jeff Janes
On Sun, Jan 15, 2012 at 12:24 AM, Greg Smith g...@2ndquadrant.com wrote: So far the reaction I've gotten from my recent submission to make autovacuum log its read/write in MB/s has been rather positive.  I've been surprised at the unprecedented (to me at least) amount of backporting onto big

Re: [HACKERS] keywords in pg_hba.conf are case-sensitive?

2012-02-02 Thread Tom Lane
[ adjusting thread title to have something to do with reality ] Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Robert Haas's message of jue feb 02 11:39:29 -0300 2012: We have lots of things that are case-sensitive; I don't particularly see why this one should be different.

Re: [HACKERS] spgist text_ops and LIKE

2012-02-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Wed, Feb 1, 2012 at 10:57 PM, Tom Lane t...@sss.pgh.pa.us wrote: Too lazy to look at the code right now, but I think indxpath.c contains hardwired assumptions that LIKE prefix optimizations are only possible with btree indexes. Possibly it would be

Re: [HACKERS] JSON output functions.

2012-02-02 Thread Pavel Stehule
2012/2/2 Andrew Dunstan and...@dunslane.net: On 02/02/2012 04:35 AM, Abhijit Menon-Sen wrote: At 2012-02-01 18:48:28 -0500, andrew.duns...@pgexperts.com wrote: For now I'm inclined not to proceed with that, and leave it as an optimization to be considered later if necessary. Thoughts? I

Re: [HACKERS] heap_tuple_needs_freeze false positive

2012-02-02 Thread Robert Haas
On Thu, Feb 2, 2012 at 11:27 AM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I'm not convinced that it's a bug.  Suppose that xmax is set but is hinted as invalid. XMAX_INVALID is not a hint.  When it's set, the contents of the field must be presumed to be

Re: [HACKERS] Patch pg_is_in_backup()

2012-02-02 Thread Gilles Darold
Le 02/02/2012 12:23, Marti Raudsepp a écrit : On Mon, Jan 30, 2012 at 20:33, Gilles Darold gilles.dar...@dalibo.com wrote: After some time searching for a Pg system administration function like pg_is_in_recovery(), let's say pg_is_in_backup(), I couldn't find one. The minor patch attached here

[HACKERS] ecpglib use PQconnectdbParams

2012-02-02 Thread Peter Eisentraut
I noticed ecpglib still uses PQconnectdb() with a craftily assembled connection string. Here is a patch to use PQconnectdbParams() instead. diff --git i/src/interfaces/ecpg/ecpglib/connect.c w/src/interfaces/ecpg/ecpglib/connect.c index 909ba70..ea69e15 100644 ---

Re: [HACKERS] heap_tuple_needs_freeze false positive

2012-02-02 Thread Robert Haas
On Thu, Feb 2, 2012 at 12:45 PM, Robert Haas robertmh...@gmail.com wrote: I believe the adequate defense that we have is precisely the logic you are proposing to change.  Regardless of whether you want to call XMAX_INVALID a hint or, say, a giant tortoise, I am fairly sure that we don't

Re: [HACKERS] keywords in pg_hba.conf are case-sensitive?

2012-02-02 Thread Robert Haas
On Thu, Feb 2, 2012 at 10:10 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: Err, postgresql.conf processing is case insensitive, which is the most closely related example.  Are you saying we should make that case sensitive as well?  What I'm saying is that I see no good reason for

Re: [HACKERS] spgist text_ops and LIKE

2012-02-02 Thread Robert Haas
On Thu, Feb 2, 2012 at 12:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Wed, Feb 1, 2012 at 10:57 PM, Tom Lane t...@sss.pgh.pa.us wrote: Too lazy to look at the code right now, but I think indxpath.c contains hardwired assumptions that LIKE prefix

Re: [HACKERS] spgist text_ops and LIKE

2012-02-02 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I'm having trouble figuring out under what set of circumstances spgist is expected to be the best available alternative. It only supports a small subset of the data types that GiST does, so I suppose the point is that it should be faster for the cases

Re: [HACKERS] spgist text_ops and LIKE

2012-02-02 Thread Alexander Korotkov
On Thu, Feb 2, 2012 at 10:21 PM, Robert Haas robertmh...@gmail.com wrote: I'm having trouble figuring out under what set of circumstances spgist is expected to be the best available alternative. It only supports a small subset of the data types that GiST does, so I suppose the point is that

Re: [HACKERS] keywords in pg_hba.conf are case-sensitive?

2012-02-02 Thread Magnus Hagander
On Feb 2, 2012 5:34 PM, Tom Lane t...@sss.pgh.pa.us wrote: [ adjusting thread title to have something to do with reality ] Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Robert Haas's message of jue feb 02 11:39:29 -0300 2012: We have lots of things that are

Re: [HACKERS] Fast GiST index build - further improvements

2012-02-02 Thread Alexander Korotkov
On Thu, Sep 8, 2011 at 8:35 PM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Now that the main GiST index build patch has been committed, there's a few further improvements that could make it much faster still: Better management of the buffer pages on disk. At the moment,

Re: [HACKERS] pg_stats_recovery view

2012-02-02 Thread Bernd Helmle
--On 2. Februar 2012 17:12:11 +0900 Fujii Masao masao.fu...@gmail.com wrote: If only core developer is interested in this view, ISTM that short description for each WAL record is not required because he or she can know the meaning of each WAL record by reading the source code. No? Adding

[HACKERS] NULL's support in SP-GiST

2012-02-02 Thread Oleg Bartunov
Hi there, attached patch introduces NULLs indexing for SP-GiST. With this patch Sp-GiST supports IS NULL, IS NOT NULL clauses, as well as full index scan. We added boolean satisfyAll field in spgInnerConsistentIn and spgLeafConsistentIn structures, which informs the user-defined methods, that

Re: [HACKERS] Patch pg_is_in_backup()

2012-02-02 Thread Bernd Helmle
--On 2. Februar 2012 18:47:35 +0100 Gilles Darold gilles.dar...@dalibo.com wrote: For now the internal function BackupInProgress() only return a boolean. I like the idea that pg_is_in_backup() just works as pg_is_in_recovery() do. I mean it doesn't return the timestamp of the recovery

Re: [HACKERS] Patch pg_is_in_backup()

2012-02-02 Thread Magnus Hagander
On Thu, Feb 2, 2012 at 12:23, Marti Raudsepp ma...@juffo.org wrote: On Mon, Jan 30, 2012 at 20:33, Gilles Darold gilles.dar...@dalibo.com wrote: After some time searching for a Pg system administration function like pg_is_in_recovery(), let's say pg_is_in_backup(), I couldn't find one. The

Re: [HACKERS] Patch: Allow SQL-language functions to reference parameters by parameter name

2012-02-02 Thread Tom Lane
[ working on this patch now ... ] Matthew Draper matt...@trebex.net writes: On 25/01/12 18:37, Hitoshi Harada wrote: Should we throw an error in such ambiguity? Or did you make it happen intentionally? If latter, we should also mention the rule in the manual. I did consider it, and felt it

[HACKERS] Hot standby fails if any backend crashes

2012-02-02 Thread Tom Lane
I'm currently working with Duncan Rance's test case for bug #6425, and I am observing a very nasty behavior in HEAD: once one of the hot-standby query backends crashes, the standby postmaster SIGQUIT's all its children and then just quits itself, with no log message and apparently no effort to

Re: [HACKERS] JSON output functions.

2012-02-02 Thread Andrew Dunstan
On 02/02/2012 12:20 PM, Pavel Stehule wrote: 2012/2/2 Andrew Dunstanand...@dunslane.net: On 02/02/2012 04:35 AM, Abhijit Menon-Sen wrote: At 2012-02-01 18:48:28 -0500, andrew.duns...@pgexperts.com wrote: For now I'm inclined not to proceed with that, and leave it as an optimization to be

Re: [HACKERS] show Heap Fetches in EXPLAIN for index-only scans

2012-02-02 Thread Noah Misch
On Wed, Jan 25, 2012 at 08:42:05PM -0500, Robert Haas wrote: Only the first pass of vacuum knows how to mark pages all-visible. After the update, the first pass of the first vacuum sees a dead tuple on the old page and truncates it to a dead line pointer. When it comes to the new page, it

Re: [HACKERS] patch for parallel pg_dump

2012-02-02 Thread Joachim Wieland
On Wed, Feb 1, 2012 at 12:24 PM, Robert Haas robertmh...@gmail.com wrote: I think we're more-or-less proposing to rename Archive to Connection, aren't we? And then ArchiveHandle can store all the things that aren't related to a specific connection. How about something like that: (Hopefully

Re: [HACKERS] Patch pg_is_in_backup()

2012-02-02 Thread Euler Taveira de Oliveira
On 02-02-2012 20:06, Magnus Hagander wrote: If there is more than one concurrent backup running, which one do you return? The first one or the latest one? Or perhaps you need an interface thta can return them all... IMHO, pg_is_in_backup() should return true if one or more backup copies are

Re: [HACKERS] Speed dblink using alternate libpq tuple storage

2012-02-02 Thread Kyotaro HORIGUCHI
Hello, Thanks, merged. I also did some minor coding style cleanups. Thank you for editing many comments and some code I'd left unchanged from my carelessness, and lack of understanding your comments. I'll be more careful about that... There is some potential for experimenting with more

Re: [HACKERS] Patch pg_is_in_backup()

2012-02-02 Thread Fujii Masao
On Fri, Feb 3, 2012 at 11:31 AM, Euler Taveira de Oliveira eu...@timbira.com wrote: On 02-02-2012 20:06, Magnus Hagander wrote: If there is more than one concurrent backup running, which one do you return? The first one or the latest one? Or perhaps you need an interface thta can return them

Re: [HACKERS] Hot standby fails if any backend crashes

2012-02-02 Thread Tom Lane
I wrote: I'm currently working with Duncan Rance's test case for bug #6425, and I am observing a very nasty behavior in HEAD: once one of the hot-standby query backends crashes, the standby postmaster SIGQUIT's all its children and then just quits itself, with no log message and apparently no

Re: [HACKERS] Hot standby fails if any backend crashes

2012-02-02 Thread Fujii Masao
On Fri, Feb 3, 2012 at 1:48 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: I'm currently working with Duncan Rance's test case for bug #6425, and I am observing a very nasty behavior in HEAD: once one of the hot-standby query backends crashes, the standby postmaster SIGQUIT's all its