Re: [HACKERS] jsonb and nested hstore

2014-02-09 Thread Craig Ringer
On 02/06/2014 01:48 AM, Tom Lane wrote: > Andrew Dunstan writes: >> On 02/05/2014 11:40 AM, Tom Lane wrote: >>> switching to "binary is the same as text" may well be the most prudent >>> path here. > >> If we do that we're going to have to live with that forever, aren't we? > > Yeah, but the ot

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-09 Thread Craig Ringer
On 02/10/2014 01:59 PM, Amit Kapila wrote: > On Mon, Feb 10, 2014 at 8:51 AM, Craig Ringer wrote: >> On 02/05/2014 01:52 PM, Tom Lane wrote: >>> Craig Ringer writes: On 02/05/2014 06:29 AM, Tom Lane wrote: > I had been okay with the manual PGDLLIMPORT-sprinkling approach > (not happy

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-09 Thread Amit Kapila
On Mon, Feb 10, 2014 at 8:51 AM, Craig Ringer wrote: > On 02/05/2014 01:52 PM, Tom Lane wrote: >> Craig Ringer writes: >>> On 02/05/2014 06:29 AM, Tom Lane wrote: I had been okay with the manual PGDLLIMPORT-sprinkling approach (not happy with it, of course, but prepared to tolerate it)

Re: [HACKERS] New option for pg_basebackup, to specify a different directory for pg_xlog

2014-02-09 Thread Haribabu Kommi
On Sat, Feb 8, 2014 at 12:10 PM, Peter Eisentraut wrote: > On 1/29/14, 7:37 PM, Haribabu Kommi wrote: > > > > On Tue, Jan 28, 2014 at 1:17 PM, Peter Eisentraut wrote: > > > > On 11/30/13, 6:59 AM, Haribabu kommi wrote: > > > To detect provided data and xlog directories are same or not, I

Re: [HACKERS] Inconsistency between pg_stat_activity and log_duration

2014-02-09 Thread Amit Kapila
On Fri, Feb 7, 2014 at 2:44 PM, Tatsuo Ishii wrote: >>> One idea is, calling pgstat_report_activity(STATE_IDLE) in >>> exec_execute_message() of postgres.c. The function has already called >>> pgstat_report_activity(STATE_RUNNING) which shows "active" state in >>> pg_stat_actviity view. So why can

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-09 Thread Craig Ringer
On 02/05/2014 01:52 PM, Tom Lane wrote: > Craig Ringer writes: >> On 02/05/2014 06:29 AM, Tom Lane wrote: >>> I had been okay with the manual PGDLLIMPORT-sprinkling approach >>> (not happy with it, of course, but prepared to tolerate it) as long >>> as I believed the buildfarm would reliably tell

Re: [HACKERS] Breaking compile-time dependency cycles of Postgres subdirs?

2014-02-09 Thread Robert Haas
On Fri, Feb 7, 2014 at 7:39 AM, Christian Convey wrote: > This question is mostly just curiosity... > > There are build-time dependency cycles between some of Postgres' code > subdirectories. For example, "storage" and "access" have such a cycle: > storage/buffpage.h #includes access/xlogdefs.h >

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-02-09 Thread Robert Haas
On Sun, Feb 9, 2014 at 6:33 PM, Jeff Janes wrote: > On Wed, Jul 4, 2012 at 12:41 PM, Robert Haas wrote: >> On Tue, Jul 3, 2012 at 11:36 PM, Amit Kapila >> wrote: >> > Hi Shigeru/Robert, >> > >> >> The way fixing oid2name and pgbench seems reasonable, so applying it to >> >> vacuumlo (as Peter me

Re: [HACKERS] WIP patch for Todo Item : Provide fallback_application_name in contrib/pgbench, oid2name, and dblink

2014-02-09 Thread Jeff Janes
On Wed, Jul 4, 2012 at 12:41 PM, Robert Haas wrote: > On Tue, Jul 3, 2012 at 11:36 PM, Amit Kapila > wrote: > > Hi Shigeru/Robert, > > > >> The way fixing oid2name and pgbench seems reasonable, so applying it to > >> vacuumlo (as Peter mentioned) would be enough for this issue. > > > > Shall I c

Re: [HACKERS] GIN improvements part2: fast scan

2014-02-09 Thread Tomas Vondra
On 9.2.2014 22:51, Erik Rijkers wrote: > On Sun, February 9, 2014 22:35, Tomas Vondra wrote: >> On 3.2.2014 07:53, Oleg Bartunov wrote: >>> PS. I used data delicious-rss-1250k.gz from >>> http://randomwalker.info/data/delicious/ >> >> I'm working on extending the GIN testing to include this test (a

Re: [HACKERS] GIN improvements part2: fast scan

2014-02-09 Thread Erik Rijkers
On Sun, February 9, 2014 22:35, Tomas Vondra wrote: > On 3.2.2014 07:53, Oleg Bartunov wrote: >> PS. I used data delicious-rss-1250k.gz from >> http://randomwalker.info/data/delicious/ > > I'm working on extending the GIN testing to include this test (and I'll > use it to test both for GIN and hsto

Re: [HACKERS] GIN improvements part2: fast scan

2014-02-09 Thread Tomas Vondra
On 3.2.2014 07:53, Oleg Bartunov wrote: > Tomasa, it'd be nice if you use real data in your testing. > > One very good application of gin fast-scan is dramatic performance > improvement of hstore/jsonb @> operator, see slides 57, 58 > http://www.sai.msu.su/~megera/postgres/talks/hstore-dublin-201

Re: [HACKERS] proposal, patch: allow multiple plpgsql plugins

2014-02-09 Thread Pavel Stehule
Hello updated patch - now plugin_info is per plpgsq_estate/plugin again. Regards Pavel 2014-01-17 20:26 GMT+01:00 Pavel Stehule : > > > > 2014/1/16 Marko Tiikkaja > >> Hi Pavel, >> >> First of all, thanks for working on this! >> >> >> On 1/12/14, 8:58 PM, Pavel Stehule wrote: >> >>> I still

Re: [HACKERS] trgm regex index peculiarity

2014-02-09 Thread Tom Lane
Alexander Korotkov writes: > On Thu, Jan 16, 2014 at 3:34 AM, Tom Lane wrote: >> I looked at this patch a bit. It seems like this: >> + *BLANK_COLOR_SIZE - How much blank character is more frequent than >> + * other character in average >> + #define BLANK_COLOR_SIZE

Re: [HACKERS] trgm regex index peculiarity

2014-02-09 Thread Alexander Korotkov
On Thu, Jan 16, 2014 at 3:34 AM, Tom Lane wrote: > Alexander Korotkov writes: > > Revised version of patch with necessary comments. > > I looked at this patch a bit. It seems like this: > > + *BLANK_COLOR_SIZE - How much blank character is more frequent than > + * ot

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-09 Thread Tom Lane
Amit Kapila writes: > On Sun, Feb 9, 2014 at 4:04 AM, Tom Lane wrote: >> In the meantime, here's a short patch trying the "#define extern" approach. >> Anyone want to try this on a Windows machine or two? > There are quite a few warnings and errors in build: Hmm. Looks like the #define is mess

Re: [HACKERS] specifying repeatable read in PGOPTIONS

2014-02-09 Thread Andres Freund
On 2014-02-09 12:38:18 -0500, Tom Lane wrote: > Robert Haas writes: > > On Sun, Feb 9, 2014 at 12:10 PM, Andres Freund > > wrote: > >> Why? We do have other options with aliases for option values and all > >> other enum option has taken care not to need spaces. > > > I think that's probably mos

Re: [HACKERS] specifying repeatable read in PGOPTIONS

2014-02-09 Thread Tom Lane
Robert Haas writes: > On Sun, Feb 9, 2014 at 12:10 PM, Andres Freund wrote: >> Why? We do have other options with aliases for option values and all >> other enum option has taken care not to need spaces. > I think that's probably mostly a happy coincidence; I'm not committed > to a policy of ens

Re: [HACKERS] PoC: Partial sort

2014-02-09 Thread Alexander Korotkov
On Thu, Feb 6, 2014 at 12:39 PM, Marti Raudsepp wrote: > On Thu, Feb 6, 2014 at 5:31 AM, Robert Haas wrote: > > Hmm, sounds a little steep. Why is it so expensive? I'm probably > > missing something here, because I would have thought that planner > > support for partial sorts would consist mos

Re: [HACKERS] specifying repeatable read in PGOPTIONS

2014-02-09 Thread Robert Haas
On Sun, Feb 9, 2014 at 12:10 PM, Andres Freund wrote: > On 2014-02-09 12:00:02 -0500, Robert Haas wrote: >> On Fri, Feb 7, 2014 at 5:06 AM, Andres Freund wrote: >> > So I still think we should add read_committed, repeatable_read as aliases. >> >> Like Tom, I'm -1 on this. This is fixing the prob

Re: [HACKERS] specifying repeatable read in PGOPTIONS

2014-02-09 Thread Andres Freund
On 2014-02-09 12:00:02 -0500, Robert Haas wrote: > On Fri, Feb 7, 2014 at 5:06 AM, Andres Freund wrote: > > So I still think we should add read_committed, repeatable_read as aliases. > > Like Tom, I'm -1 on this. This is fixing the problem from the wrong end. Why? We do have other options with

Re: [HACKERS] specifying repeatable read in PGOPTIONS

2014-02-09 Thread Robert Haas
On Fri, Feb 7, 2014 at 5:06 AM, Andres Freund wrote: > On 2014-02-04 12:02:45 -0500, Tom Lane wrote: >> Andres Freund writes: >> > On 2014-02-04 11:36:22 -0500, Tom Lane wrote: >> >> -1. This is not a general solution to the problem. There are other >> >> GUCs for which people might want spaces

Re: [HACKERS] Minor performance improvement in transition to external sort

2014-02-09 Thread Robert Haas
On Fri, Feb 7, 2014 at 4:28 PM, Jeremy Harris wrote: > On 06/02/14 22:12, Jeremy Harris wrote: >>> Did you try sorting already-sorted, reverse >>> sorted, or pipe-organ shaped data sets? > > Summary (low numbers better): > > Random ints: 83% compares, level on time. > Sorted ints:

Re: [HACKERS] [PATCH] Store Extension Options

2014-02-09 Thread Fabrízio de Royes Mello
On Sat, Jan 11, 2014 at 2:47 AM, Peter Eisentraut wrote: > > On Sat, 2014-01-11 at 00:48 -0200, Fabrízio de Royes Mello wrote: > > > Now, if bdr is installed but the validation doesn't happen unless > > bdr > > > is "loaded" in some sense, then that is an implementation deficiency > > > that I thi

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-09 Thread Marco Atzeri
On 09/02/2014 14:10, Andrew Dunstan wrote: On 02/09/2014 01:12 AM, Marco Atzeri wrote: On 09/02/2014 00:06, Andrew Dunstan wrote: On 02/08/2014 05:34 PM, Tom Lane wrote: Hiroshi Inoue writes: Though I'm not a MINGW expert at all, I know dllwrap is a deprecated tool and dlltool is almos

Re: [HACKERS] jsonb and nested hstore

2014-02-09 Thread Erik Rijkers
On Fri, February 7, 2014 00:47, Andrew Dunstan wrote: > > Attached are updated patches. > > jsonb-10.patch.gz > nested-hstore-10.patch.gz Small changes to json documentation, mostly of typo caliber. Thanks, Erik Rijkers --- doc/src/sgml/datatype.sgml.orig 2014-02-09 14:27:55.264512678 +0100 +++

Re: [HACKERS] Recovery inconsistencies, standby much larger than primary

2014-02-09 Thread Greg Stark
On Thu, Feb 6, 2014 at 11:41 PM, Greg Stark wrote: > > That doesn't explain the other instance or the other copies of this > database. I think the most productive thing I can do is switch my > attention to the other database to see if it really looks like the > same problem. So here's an instance

Re: [DOCS] [HACKERS] Viability of text HISTORY/INSTALL/regression README files (was Re: [COMMITTERS] pgsql: Document a few more regression test hazards.)

2014-02-09 Thread Robert Haas
On Sat, Feb 8, 2014 at 4:41 PM, Tom Lane wrote: > I wrote: >> Gavin Flower writes: >>> How about adding URL's for the online versions of HISTORY & README's (or >>> their rough equivalents - perhaps the online version of the latest >>> 'Appendix E. Release Notes' would be sufficient?) to the INSTA

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-09 Thread Andrew Dunstan
On 02/09/2014 01:12 AM, Marco Atzeri wrote: On 09/02/2014 00:06, Andrew Dunstan wrote: On 02/08/2014 05:34 PM, Tom Lane wrote: Hiroshi Inoue writes: Though I'm not a MINGW expert at all, I know dllwrap is a deprecated tool and dlltool is almost a deprecated tool. Cygwin port is removing t

Re: [HACKERS] gaussian distribution pgbench

2014-02-09 Thread Fabien COELHO
Hello, I revise my gaussian pgbench patch which wss requested from community. With a lot of delay for which I apologise, please find hereafter the review. Gaussian Pgbench v3 patch by Mitsumasa KONDO review * The purpose of the patch is to allow a pgbench script to draw from normally di

[HACKERS] Terminating pg_basebackup background streamer

2014-02-09 Thread Magnus Hagander
If an error occurs in the foreground (backup) process of pg_basebackup, and we exit in a controlled way, the background process (streaming xlog process) would stay around and keep streaming. This can happen for example if disk space runs out and there is very low activity on the server. (If there

[HACKERS] notify duplicate elimination

2014-02-09 Thread Hardy Falk
I have prepared a patch to backends/commands/async,c to speed up duplicate elimination. rdtsc timing results are sent back via ereport. *** a/src/backend/commands/async.c --- b/src/backend/commands/async.c *** *** 326,337 typedef struct Notification --- 326,353 { char

Re: [HACKERS] [PATCH] pg_basebackup: progress report max once per second

2014-02-09 Thread Magnus Hagander
On Mon, Feb 3, 2014 at 4:14 AM, Sawada Masahiko wrote: > On Sat, Feb 1, 2014 at 8:29 PM, Oskari Saarenmaa wrote: > > 31.01.2014 10:59, Sawada Masahiko kirjoitti: > > > > I think the idea in the new progress_report() call (with force == true) > is > > to make sure that there is at least one progre

Re: [HACKERS] Small GIN optimizations (after 9.4)

2014-02-09 Thread Alexander Korotkov
On Thu, Feb 6, 2014 at 3:36 PM, Heikki Linnakangas wrote: > While hacking on the GIN patches, I've come up with a few different ideas > for improving performance. It's too late for 9.4, but I'll list them here > if someone wants to work on them later: > > * Represent ItemPointers as uint64's, to s

Re: [HACKERS] Small GIN optimizations (after 9.4)

2014-02-09 Thread Alexander Korotkov
On Thu, Feb 6, 2014 at 8:31 PM, PostgreSQL - Hans-Jürgen Schönig < postg...@cybertec.at> wrote: > i think there is one more thing which would be really good in GIN and > which would solve a ton of issues. > atm GIN entries are sorted by item pointer. > if we could sort them by a "column" it would

Re: [HACKERS] GIN improvements part2: fast scan

2014-02-09 Thread Alexander Korotkov
On Fri, Feb 7, 2014 at 5:33 PM, Heikki Linnakangas wrote: > On 02/06/2014 01:22 PM, Alexander Korotkov wrote: > >> Difference is very small. For me, it looks ready for commit. >> > > Great, committed! > > Now, to review the catalog changes... I've rebased catalog changes with last master. Patch