Re: [HACKERS] 9.2.1 index-only scans : abnormal heap fetches after VACUUM FULL

2014-02-16 Thread Andres Freund
On 2014-02-15 21:34:15 -0500, Bruce Momjian wrote: Thank you for the thorough review. Unless someone else can complete this, I think it should be marked as returned with feedback. I don't think I am going to learn enough to complete this during the commit-fest. Agreed. Marked it as such.

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-16 Thread Andres Freund
Marco, Andrew: On 2014-02-15 22:11:37 +0100, Marco Atzeri wrote: ../../src/timezone/localtime.o ../../src/timezone/strftime.o ../../src/timezone/pgtz.o ../../src/port/libpgport_srv.a ../../src/common/libpgcommon_srv.a -lintl -lssl -lcrypto -lcrypt -lldap -o postgres

Re: [HACKERS] Recovery inconsistencies, standby much larger than primary

2014-02-16 Thread Greg Stark
On Sat, Feb 15, 2014 at 11:45 AM, Andres Freund and...@2ndquadrant.com wrote: I guess the theoretically correct thing would be to make all WAL records about truncation and unlinking contain the current size of the relation, but especially with deletions and forks that will probably turn out to

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-16 Thread Tom Lane
Hiroshi Inoue in...@tpf.co.jp writes: (2014/02/15 2:32), Tom Lane wrote: And what happens is this: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=narwhaldt=2014-02-14%2017%3A00%3A02 namely, it gets through plperl now and then chokes with the same symptoms on pltcl. So I guess we need

Re: [HACKERS] Problem with displaying wide tables in psql

2014-02-16 Thread Sergey Muraviov
Hi. Thanks for your review. 2014-02-15 20:08 GMT+04:00 Emre Hasegeli e...@hasegeli.com: Hi, This is my review about 3th version of the patch. It is an useful improvement in my opinion. It worked well on my environment. 2013-12-11 17:43:06, Sergey Muraviov sergey.k.murav...@gmail.com: It

Re: [HACKERS] Changeset Extraction v7.6.1

2014-02-16 Thread Andres Freund
On 2014-02-15 17:29:04 -0500, Robert Haas wrote: On Fri, Feb 14, 2014 at 4:55 AM, Andres Freund and...@2ndquadrant.com wrote: [ new patches ] 0001 already needs minor + * copied stuff from tuptoaster.c. Perhaps there should be toast_internal.h? Yes, please. If you can submit a

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-16 Thread Marco Atzeri
On 16/02/2014 15:43, Andres Freund wrote: Marco, Andrew: On 2014-02-15 22:11:37 +0100, Marco Atzeri wrote: ../../src/timezone/localtime.o ../../src/timezone/strftime.o ../../src/timezone/pgtz.o ../../src/port/libpgport_srv.a ../../src/common/libpgcommon_srv.a -lintl -lssl -lcrypto -lcrypt

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-16 Thread Tom Lane
Marco Atzeri marco.atz...@gmail.com writes: On 16/02/2014 15:43, Andres Freund wrote: Could either of you try whether compiling with the attached hack fixes anything on cygwin? on cygwin32 bit it works, but it stops later on --- sl -lcrypto -lz

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-16 Thread Andres Freund
On 2014-02-16 12:57:46 -0500, Tom Lane wrote: Marco Atzeri marco.atz...@gmail.com writes: On 16/02/2014 15:43, Andres Freund wrote: Could either of you try whether compiling with the attached hack fixes anything on cygwin? on cygwin32 bit it works, but it stops later on

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-16 Thread Tom Lane
Andres Freund and...@2ndquadrant.com writes: On 2014-02-16 12:57:46 -0500, Tom Lane wrote: I'm starting to get the feeling that we're going to have to admit defeat and not try to use --disable-auto-import on cygwin builds. That platform is evidently not capable of supporting it. Agreed. It's

Re: [HACKERS] narwhal and PGDLLIMPORT

2014-02-16 Thread Andres Freund
On 2014-02-16 13:25:58 -0500, Tom Lane wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-02-16 12:57:46 -0500, Tom Lane wrote: I'm starting to get the feeling that we're going to have to admit defeat and not try to use --disable-auto-import on cygwin builds. That platform is

Re: [HACKERS] New hook after raw parsing, before analyze

2014-02-16 Thread David Beck
There is a hook post_parse_analyze_hook but I think it comes too late as it comes after the analyze step which is when Postgres looks up the schema information for every relation mentioned in the query. What you would need is a post_parse_hook which would work on the raw parse tree before the

[HACKERS] Draft release notes up for review

2014-02-16 Thread Tom Lane
Draft release notes for 9.3.3 are committed and can be read at http://www.postgresql.org/docs/devel/static/release-9-3-3.html Any comments before I start transposing them into the back branches? regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] 9.2.1 index-only scans : abnormal heap fetches after VACUUM FULL

2014-02-16 Thread Jim Nasby
On 1/24/14, 3:52 PM, Jaime Casanova wrote: On Tue, Dec 3, 2013 at 11:25 AM, Bruce Momjianbr...@momjian.us wrote: Is everyone else OK with this approach? Updated patch attached. Hi, I started to look at this patch and i found that it fails an assertion as soon as you run a VACUUM FULL

Re: [HACKERS] HBA files w/include support?

2014-02-16 Thread Jim Nasby
On 2/14/14, 8:36 AM, Stephen Frost wrote: * Bruce Momjian (br...@momjian.us) wrote: In an ideal world we would have a tool where you could plug in a username, database, IP address, and test pg_hba.conf file and it would report what line is matched. That's not a bad idea, but we don't expose

Re: [HACKERS] HBA files w/include support?

2014-02-16 Thread Jim Nasby
On 2/14/14, 1:06 PM, Jeff Janes wrote: On Fri, Feb 14, 2014 at 6:33 AM, Bruce Momjian br...@momjian.us mailto:br...@momjian.us wrote: On Fri, Feb 14, 2014 at 03:28:23AM -0500, Stephen Frost wrote: Bruce, Having @include and directory.d-style capabilities for pg_hba.conf *and*

Re: [HACKERS] HBA files w/include support?

2014-02-16 Thread Jim Nasby
On 2/14/14, 10:14 AM, Andres Freund wrote: I was asking for use-cases so we could figure out what's the right thing;-) The argument about wanting to assemble a pg_hba file from separately managed configuration pieces seems to have some merit, but the weak spot there is how do you define the

Re: [HACKERS] HBA files w/include support?

2014-02-16 Thread Stephen Frost
* Jim Nasby (j...@nasby.net) wrote: On 2/14/14, 8:36 AM, Stephen Frost wrote: * Bruce Momjian (br...@momjian.us) wrote: In an ideal world we would have a tool where you could plug in a username, database, IP address, and test pg_hba.conf file and it would report what line is matched.

Re: [HACKERS] HBA files w/include support?

2014-02-16 Thread Stephen Frost
* Jim Nasby (j...@nasby.net) wrote: Would the inclusion of the entire directory be done via a single #include (or whatever syntax) directive in pg_hba.conf? Not sure we've even figured that out yet, but probably. I think that's probably OK. But if we're talking about something like hey, if

Re: [HACKERS] HBA files w/include support?

2014-02-16 Thread Jeff Janes
On Sunday, February 16, 2014, Jim Nasby j...@nasby.net wrote: On 2/14/14, 1:06 PM, Jeff Janes wrote: On Fri, Feb 14, 2014 at 6:33 AM, Bruce Momjian br...@momjian.us mailto: br...@momjian.us wrote: On Fri, Feb 14, 2014 at 03:28:23AM -0500, Stephen Frost wrote: Bruce,

Re: [HACKERS] Auto-tuning work_mem and maintenance_work_mem

2014-02-16 Thread Robert Haas
On Thu, Feb 13, 2014 at 3:34 PM, Bruce Momjian br...@momjian.us wrote: On Fri, Oct 11, 2013 at 03:39:51PM -0700, Kevin Grittner wrote: Josh Berkus j...@agliodbs.com wrote: On 10/11/2013 01:11 PM, Bruce Momjian wrote: In summary, I think we need to: * decide on new defaults for work_mem

Re: [HACKERS] Auto-tuning work_mem and maintenance_work_mem

2014-02-16 Thread Josh Berkus
On 02/16/2014 09:26 PM, Robert Haas wrote: I don't really know about cpu_tuple_cost. Kevin's often advocated raising it, but I haven't heard anyone else advocate for that. I think we need data points from more people to know whether or not that's a good idea in general. In 10 years of

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2014-02-16 Thread Amit Kapila
On Sat, Feb 1, 2014 at 12:31 PM, Amit Kapila amit.kapil...@gmail.com wrote: I think it's just a very minor coding style thing, so I am marking this patch as Ready For Committer. I could see that this patch has been marked as Needs Review in CF app. suggesting that it should be rejected based

Re: [HACKERS] Draft release notes up for review

2014-02-16 Thread Josh Berkus
On 02/16/2014 03:41 PM, Tom Lane wrote: Draft release notes for 9.3.3 are committed and can be read at http://www.postgresql.org/docs/devel/static/release-9-3-3.html Any comments before I start transposing them into the back branches? Major: Do we have an explantion of what a multixact is,

Re: [HACKERS] CREATE FOREIGN TABLE ( ... LIKE ... )

2014-02-16 Thread David Fetter
On Sat, Feb 15, 2014 at 03:14:03PM +0100, Andres Freund wrote: On 2014-01-31 18:16:18 +0100, Vik Fearing wrote: On 01/25/2014 06:25 AM, David Fetter wrote: Please find attached the next rev :) This version looks committable to me, so I am marking it as such. This doesn't contain a

Re: [HACKERS] Auto-tuning work_mem and maintenance_work_mem

2014-02-16 Thread Gavin Flower
On 17/02/14 15:26, Robert Haas wrote: On Thu, Feb 13, 2014 at 3:34 PM, Bruce Momjian br...@momjian.us wrote: On Fri, Oct 11, 2013 at 03:39:51PM -0700, Kevin Grittner wrote: Josh Berkus j...@agliodbs.com wrote: On 10/11/2013 01:11 PM, Bruce Momjian wrote: In summary, I think we need to: *

Re: [HACKERS] Retain dynamic shared memory segments for postmaster lifetime

2014-02-16 Thread Kyotaro HORIGUCHI
Thank you for letting me know of that. Using MSVC. We have gendef.pl which can do it. Mmm.. My eyes skipped over it. Everything became clear for me. Thank you. Example in Postgres project properties, in Configuration Properties-Build Events-Pre-Link Event, there is a Command Line like