Re: [HACKERS] inherit support for foreign tables

2014-02-21 Thread Kyotaro HORIGUCHI
Hello, At Fri, 21 Feb 2014 16:33:32 +0900, Etsuro Fujita wrote (2014/02/21 15:23), Kyotaro HORIGUCHI wrote: NOTICE: Child foregn table child01 is affected. NOTICE: Child foregn table child02 is affected NOTICE: Child foregn table child03 rejected 'alter tempmin set default' It says

Re: [HACKERS] walsender doesn't send keepalives when writes are pending

2014-02-21 Thread Andres Freund
On 2014-02-21 10:08:44 +0530, Amit Kapila wrote: On Fri, Feb 14, 2014 at 5:35 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, In WalSndLoop() we do: wakeEvents = WL_LATCH_SET | WL_POSTMASTER_DEATH | WL_TIMEOUT | WL_SOCKET_READABLE; if (pq_is_send_pending())

[HACKERS] Uninterruptable regexp_replace in 9.3.1 ?

2014-02-21 Thread Sandro Santilli
The following snippet reveals that 9.3.1 has a bug in regexp_matches, which uninterruptably keeps CPU spinning for minutes: -8--- \timing SET statement_timeout = 2; -- this is only to show statement_timeout is effective here SELECT count(*)

Re: [HACKERS] Uninterruptable regexp_replace in 9.3.1 ?

2014-02-21 Thread Sandro Santilli
I've just tested 9.3.3 and it is _also_ affected. Should I report the regression somewhere else ? --strk; On Fri, Feb 21, 2014 at 10:17:59AM +0100, Sandro Santilli wrote: The following snippet reveals that 9.3.1 has a bug in regexp_matches, which uninterruptably keeps CPU spinning for

[HACKERS] Proposal: IMPORT FOREIGN SCHEMA statement.

2014-02-21 Thread Ronan Dunklau
Hello, The SQL-MED specification defines the IMPORT FOREIGN SCHEMA statement. This adds discoverability to foreign servers. The structure of the statement as I understand it is simple enough: IMPORT FOREIGN SCHEMA remote_schema FROM SERVER some_server [ (LIMIT TO | EXCEPT) table_list ] INTO

Re: [HACKERS] Display oprcode and its volatility in \do+

2014-02-21 Thread Marti Raudsepp
On Thu, Jan 16, 2014 at 5:22 PM, Tom Lane t...@sss.pgh.pa.us wrote: but adding volatility here seems like probably a waste of valuable terminal width. I think that the vast majority of operators have immutable or at worst stable underlying functions, so this doesn't seem like the first bit of

Re: [HACKERS] Proposal: IMPORT FOREIGN SCHEMA statement.

2014-02-21 Thread Atri Sharma
On Fri, Feb 21, 2014 at 4:01 PM, Ronan Dunklau ronan.dunk...@dalibo.comwrote: Hello, The SQL-MED specification defines the IMPORT FOREIGN SCHEMA statement. This adds discoverability to foreign servers. The structure of the statement as I understand it is simple enough: IMPORT FOREIGN

Re: [HACKERS] Changeset Extraction v7.6.1

2014-02-21 Thread Andres Freund
Hi, On 2014-02-19 13:01:02 -0500, Robert Haas wrote: I think it should be fairly easy to relax the restriction to creating a slot, but not getting data from it. Do you think that would that be sufficient? That would be a big improvement, for sure, and might be entirely sufficient.

Re: [HACKERS] Proposal: IMPORT FOREIGN SCHEMA statement.

2014-02-21 Thread Ronan Dunklau
I havent had a look at the patch yet since I dont have a nice editor right now, but how do you handle inter operability between datatypes? Specifically, how do you handle those datatypes which have a different name from the PostgreSQL name for them and/or are stored in a different manner? Do

Re: [HACKERS] Changeset Extraction v7.6.1

2014-02-21 Thread Andres Freund
On 2014-02-19 13:31:06 -0500, Robert Haas wrote: TBH, as compared to what you've got now, I think this mostly boils down to a question of quoting and escaping. I'm not really concerned with whether we ship something that's perfectly efficient, or that has filtering capabilities, or that has a

[HACKERS] Public header files change

2014-02-21 Thread Pavel Raiskup
It seems to be unlikely to me, but are the changed symbols mentioned in git-log commit message 5f173040e324 supposed to be used other than internally? Snip: Avoid repeated name lookups during table and index DDL. ... to the Constraint node (FkConstraint in 8.4). Third-party code

Re: [HACKERS] Proposal: IMPORT FOREIGN SCHEMA statement.

2014-02-21 Thread Atri Sharma
On Fri, Feb 21, 2014 at 4:39 PM, Ronan Dunklau ronan.dunk...@dalibo.comwrote: I havent had a look at the patch yet since I dont have a nice editor right now, but how do you handle inter operability between datatypes? Specifically, how do you handle those datatypes which have a different

Re: [HACKERS] Public header files change

2014-02-21 Thread Andres Freund
Hi, On 2014-02-21 12:11:42 +0100, Pavel Raiskup wrote: It seems to be unlikely to me, but are the changed symbols mentioned in git-log commit message 5f173040e324 supposed to be used other than internally? Snip: These seem to be pretty internal symbols to me, but I rather asking

Re: [HACKERS] Proposal: IMPORT FOREIGN SCHEMA statement.

2014-02-21 Thread Ronan Dunklau
Le vendredi 21 février 2014 16:45:20 Atri Sharma a écrit : On Fri, Feb 21, 2014 at 4:39 PM, Ronan Dunklau ronan.dunk...@dalibo.comwrote: I havent had a look at the patch yet since I dont have a nice editor right now, but how do you handle inter operability between datatypes?

Re: [HACKERS] Patch: show relation and tuple infos of a lock to acquire

2014-02-21 Thread Christian Kruse
Hi, On 19.02.2014 08:11, Amit Kapila wrote: I have looked into this patch. Below are some points which I think should be improved in this patch: Thank you for your review. 1. New context added by this patch is display at wrong place […] Do this patch expect to print the context at cancel

Re: [HACKERS] Proposal: IMPORT FOREIGN SCHEMA statement.

2014-02-21 Thread Atri Sharma
On Fri, Feb 21, 2014 at 4:56 PM, Ronan Dunklau ronan.dunk...@dalibo.comwrote: Le vendredi 21 février 2014 16:45:20 Atri Sharma a écrit : On Fri, Feb 21, 2014 at 4:39 PM, Ronan Dunklau ronan.dunk...@dalibo.comwrote: I havent had a look at the patch yet since I dont have a nice editor

Re: [HACKERS] Changeset Extraction v7.6.1

2014-02-21 Thread Andres Freund
On 2014-02-19 13:07:11 -0500, Robert Haas wrote: On Tue, Feb 18, 2014 at 4:07 AM, Andres Freund and...@2ndquadrant.com wrote: 2. I think the snapshot-export code is fundamentally misdesigned. As I said before, the idea that we're going to export one single snapshot at one particular point

Re: [HACKERS] Proposal: IMPORT FOREIGN SCHEMA statement.

2014-02-21 Thread Florian Pflug
On Feb21, 2014, at 12:09 , Ronan Dunklau ronan.dunk...@dalibo.com wrote: I havent had a look at the patch yet since I dont have a nice editor right now, but how do you handle inter operability between datatypes? Specifically, how do you handle those datatypes which have a different name from

Re: [HACKERS] Proposal: IMPORT FOREIGN SCHEMA statement.

2014-02-21 Thread Ronan Dunklau
Who says that the OIDs are the same on the local and the remove postgres instance? For user-defined types, that's certainly not going to be true... That's why the the result is casted as regtype[], and parsed as such. The oid is not transmitted over the wire, but set by regtype_in. Also,

[HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread firoz e v
Hi, Is there a way to store the password in .pgpass file in an encrypted format (for example, to be used by pg_dump). Even though, there are ways to set the permissions on .pgpass, to disallow any access to world or group, the security rules of many organizations disallow to hold any kind of

Re: [HACKERS] Patch: show xid and xmin in pg_stat_activity and pg_stat_replication

2014-02-21 Thread Andres Freund
On 2014-02-21 13:40:59 +0100, Christian Kruse wrote: diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c index a4f31cf..e65b079 100644 --- a/src/backend/utils/adt/pgstatfuncs.c +++ b/src/backend/utils/adt/pgstatfuncs.c @@ -536,7 +536,7 @@

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Szymon Guz
On 21 February 2014 13:49, firoz e v firoz...@huawei.com wrote: Hi, Is there a way to store the password in “.pgpass” file in an encrypted format (for example, to be used by pg_dump). Even though, there are ways to set the permissions on .pgpass, to disallow any access to world or

Re: [HACKERS] Changeset Extraction v7.6.1

2014-02-21 Thread Robert Haas
On Fri, Feb 21, 2014 at 6:07 AM, Andres Freund and...@2ndquadrant.com wrote: I can sympathize with the too much during init argument, but I don't see how moving stuff to the first call would get rid of the problems. If we fail later it's going to be just as confusing. No, it isn't. If you

Re: [HACKERS] Changeset Extraction v7.6.1

2014-02-21 Thread Andres Freund
On 2014-02-21 08:16:59 -0500, Robert Haas wrote: On Fri, Feb 21, 2014 at 6:07 AM, Andres Freund and...@2ndquadrant.com wrote: I can sympathize with the too much during init argument, but I don't see how moving stuff to the first call would get rid of the problems. If we fail later it's

Re: [HACKERS] walsender doesn't send keepalives when writes are pending

2014-02-21 Thread Amit Kapila
On Fri, Feb 21, 2014 at 2:36 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-21 10:08:44 +0530, Amit Kapila wrote: I think the main reason of ping is to detect n/w break sooner. On a busy server, wouldn't WALSender can detect it when next time it will try to send the remaining

Re: [HACKERS] walsender doesn't send keepalives when writes are pending

2014-02-21 Thread Andres Freund
On 2014-02-21 19:03:29 +0530, Amit Kapila wrote: On Fri, Feb 21, 2014 at 2:36 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-21 10:08:44 +0530, Amit Kapila wrote: I think the main reason of ping is to detect n/w break sooner. On a busy server, wouldn't WALSender can detect it

Re: [HACKERS] WAL Rate Limiting

2014-02-21 Thread Robert Haas
On Thu, Feb 20, 2014 at 12:07 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: I think bulk (maintenance) operations should legitimately configured separately from regular UPDATE etc operations. For the latter I think it's pretty reasonable to assume that users are going to want to tweak

Re: [HACKERS] Changeset Extraction v7.6.1

2014-02-21 Thread Robert Haas
On Fri, Feb 21, 2014 at 8:27 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-21 08:16:59 -0500, Robert Haas wrote: On Fri, Feb 21, 2014 at 6:07 AM, Andres Freund and...@2ndquadrant.com wrote: I can sympathize with the too much during init argument, but I don't see how moving

Re: [HACKERS] WAL Rate Limiting

2014-02-21 Thread Alvaro Herrera
It's clear now that if what Greg wants is an uncontroversial patch to commit, this is not it. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Changeset Extraction v7.6.1

2014-02-21 Thread Andres Freund
On 2014-02-21 08:51:03 -0500, Robert Haas wrote: On Fri, Feb 21, 2014 at 8:27 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-21 08:16:59 -0500, Robert Haas wrote: On Fri, Feb 21, 2014 at 6:07 AM, Andres Freund and...@2ndquadrant.com wrote: I can sympathize with the too much

[HACKERS] Cost estimation in foreign data wrappers

2014-02-21 Thread Hadi Moshayedi
Hello, There is a callback function in fdw's which should also set estimates for startup and total costs for each path. Assume a fdw adds only one path (e.g. in file_fdw). I am trying to understand what can go wrong if we do a bad job in estimating these costs. Since we have only one scan path

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Alvaro Herrera
firoz e v wrote: Hi, Is there a way to store the password in .pgpass file in an encrypted format (for example, to be used by pg_dump). Even though, there are ways to set the permissions on .pgpass, to disallow any access to world or group, the security rules of many organizations

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Christian Kruse
Hi, On 21/02/14 11:15, Alvaro Herrera wrote: Maybe you can memfrob() the password to encrypt it before writing, and then memfrob() it back before applying it. Would that be secure? From `man memfrob`: Note that this function is not a proper encryption routine as the XOR constant is fixed,

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Euler Taveira
On 21-02-2014 09:49, firoz e v wrote: Even though, there are ways to set the permissions on .pgpass, to disallow any access to world or group, the security rules of many organizations disallow to hold any kind of passwords, as plain text. Is your goal hiding the password in .pgpass? You

Re: [HACKERS] Cost estimation in foreign data wrappers

2014-02-21 Thread Tom Lane
Hadi Moshayedi h...@moshayedi.net writes: There is a callback function in fdw's which should also set estimates for startup and total costs for each path. Assume a fdw adds only one path (e.g. in file_fdw). I am trying to understand what can go wrong if we do a bad job in estimating these

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Alvaro Herrera
Euler Taveira wrote: On 21-02-2014 09:49, firoz e v wrote: Even though, there are ways to set the permissions on .pgpass, to disallow any access to world or group, the security rules of many organizations disallow to hold any kind of passwords, as plain text. Is your goal hiding the

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Andres Freund
On 2014-02-21 12:04:47 -0300, Alvaro Herrera wrote: You could instead try to have an authentication agent that stores an encrypted password or certificate and asks the user to supply the key to decrypt it when trying to establish a connection; but that would force you to require user

Re: [HACKERS] Uninterruptable regexp_replace in 9.3.1 ?

2014-02-21 Thread Craig Ringer
On 02/21/2014 05:17 PM, Sandro Santilli wrote: The following snippet reveals that 9.3.1 has a bug in regexp_matches, which uninterruptably keeps CPU spinning for minutes: Huh. So it does. That's interesting. (You should generally report things to pgsql-b...@postgresql.org btw, not -hackers)

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Christopher Browne
On Fri, Feb 21, 2014 at 7:49 AM, firoz e v firoz...@huawei.com wrote: Hi, Is there a way to store the password in .pgpass file in an encrypted format (for example, to be used by pg_dump). Even though, there are ways to set the permissions on .pgpass, to disallow any access to world or

[HACKERS] SPI_connect on multi-threaded app

2014-02-21 Thread John Williams
I'm writing a pgsql extension in C, which is multithreaded. The SPI connection is global, so do I have to implement a lock to make sql queries in each thread, or can I make a connection on a per-thread basis?

Re: [HACKERS] Uninterruptable regexp_replace in 9.3.1 ?

2014-02-21 Thread Florian Pflug
On Feb21, 2014, at 16:46 , Craig Ringer cr...@2ndquadrant.com wrote: The real question IMO is why it's taking so long. It looks like cfindloop(...) is being called multiple times, with each call taking a couple of seconds. Yeah, I wondered about this too. I've shortened the example a bit -

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Jeff Janes
On Fri, Feb 21, 2014 at 7:04 AM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: Euler Taveira wrote: On 21-02-2014 09:49, firoz e v wrote: Even though, there are ways to set the permissions on .pgpass, to disallow any access to world or group, the security rules of many organizations

Re: [HACKERS] SPI_connect on multi-threaded app

2014-02-21 Thread Florian Pflug
On Feb21, 2014, at 13:44 , John Williams jdwilliams1...@gmail.com wrote: I'm writing a pgsql extension in C, which is multithreaded. The SPI connection is global, so do I have to implement a lock to make sql queries in each thread, or can I make a connection on a per-thread basis? Postgres

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Alvaro Herrera
Jeff Janes escribió: On Fri, Feb 21, 2014 at 7:04 AM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: If you were to have a mechanism by which libpq can store an md5'd password (or whatever hash) and send that md5 to the server and have the server accept it to grant a connection, then

Re: [HACKERS] Warning in pg_backup_archiver.c

2014-02-21 Thread Stephen Frost
Michael, * Michael Paquier (michael.paqu...@gmail.com) wrote: While compiling on clang, I noticed the following warning: pg_backup_archiver.c:1950:32: warning: comparison of constant -1 with expression of type 'ArchiveFormat' (aka 'enum _archiveFormat') is always false

Re: [HACKERS] Uninterruptable regexp_replace in 9.3.1 ?

2014-02-21 Thread Craig Ringer
On 02/22/2014 12:04 AM, Florian Pflug wrote: On Feb21, 2014, at 16:46 , Craig Ringer cr...@2ndquadrant.com wrote: The real question IMO is why it's taking so long. It looks like cfindloop(...) is being called multiple times, with each call taking a couple of seconds. Yeah, I wondered about

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Craig Ringer
On 02/22/2014 12:20 AM, Alvaro Herrera wrote: Jeff Janes escribió: On Fri, Feb 21, 2014 at 7:04 AM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: If you were to have a mechanism by which libpq can store an md5'd password (or whatever hash) and send that md5 to the server and have the

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Craig Ringer
On 02/21/2014 11:52 PM, Christopher Browne wrote: The thing you could do instead that would *look* like it is encrypted is to use a certificate (e.g. - SSL). The certificate that you'd need to put on the client still needs to be in something that is effectively plain text (however much it

Re: [HACKERS] Uninterruptable regexp_replace in 9.3.1 ?

2014-02-21 Thread Florian Pflug
On Feb21, 2014, at 17:29 , Craig Ringer cr...@2ndquadrant.com wrote: The problem report claims that the issue does not occur on 9.1, but yet: git diff REL9_1_STABLE master -- ./src/backend/utils/adt/regexp.c is utterly trivial; a copyright date line change, and 1609797c which just tweaks

Re: [HACKERS] Uninterruptable regexp_replace in 9.3.1 ?

2014-02-21 Thread Tom Lane
Craig Ringer cr...@2ndquadrant.com writes: So I'd like to confirm that this issue doesn't affect 9.1. It doesn't. I suspect it has something to do with 173e29aa5 or one of the nearby commits in backend/regex/. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Tomas Vondra
Hi, On 21 Únor 2014, 16:52, Christopher Browne wrote: On Fri, Feb 21, 2014 at 7:49 AM, firoz e v firoz...@huawei.com wrote: Hi, Is there a way to store the password in .pgpass file in an encrypted format (for example, to be used by pg_dump). Even though, there are ways to set the

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Jeff Janes
On Fri, Feb 21, 2014 at 8:42 AM, Craig Ringer cr...@2ndquadrant.com wrote: On 02/22/2014 12:20 AM, Alvaro Herrera wrote: Jeff Janes escribió: On Fri, Feb 21, 2014 at 7:04 AM, Alvaro Herrera alvhe...@2ndquadrant.comwrote: If you were to have a mechanism by which libpq can store an

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Alvaro Herrera
I think this thread deserves more attention: http://www.postgresql.org/message-id/caazkufajufddfp1_vghbdfyru0sj6msovvkrp87acq53ov6...@mail.gmail.com -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers

Re: [HACKERS] WAL Rate Limiting

2014-02-21 Thread Jim Nasby
On 1/16/14, 9:19 PM, Craig Ringer wrote: On 01/16/2014 11:52 PM, Tom Lane wrote: Heikki Linnakangas hlinnakan...@vmware.com writes: On 01/16/2014 05:39 PM, Andres Freund wrote: Do you see a reasonable way to implement this generically for all commands? I don't. In suitable safe places,

Re: [HACKERS] Changeset Extraction v7.6.1

2014-02-21 Thread Jim Nasby
On 2/17/14, 7:31 PM, Robert Haas wrote: But do you really want to keep that snapshot around long enough to copy the entire database? I bet you don't: if the database is big, holding back xmin for long enough to copy the whole thing isn't likely to be fun. I can confirm that this would be epic

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Daniel Farina
On Fri, Feb 21, 2014 at 10:42 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: I think this thread deserves more attention: http://www.postgresql.org/message-id/caazkufajufddfp1_vghbdfyru0sj6msovvkrp87acq53ov6...@mail.gmail.com (I wrote that mail) I'm still in interested in this idea and

Re: [HACKERS] Re: BUG #9210: PostgreSQL string store bug? not enforce check with correct characterSET/encoding

2014-02-21 Thread Tom Lane
Noah Misch n...@leadboat.com writes: On Wed, Feb 19, 2014 at 08:22:13PM -0500, Tom Lane wrote: How much of this is back-patch material, do you think? None of it. While many of the failures to validate against a character encoding are clear bugs, applications hum along in spite of such bugs

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Josh Berkus
On 02/21/2014 09:11 AM, Tomas Vondra wrote: What I think might be useful and safe at the same time is encrypted .pgpass with tools asking for the encryption key. Think of it as a simple passord wallet - not really useful if you're connecting to a single database, very useful if you have many

Re: [HACKERS] Re: BUG #9210: PostgreSQL string store bug? not enforce check with correct characterSET/encoding

2014-02-21 Thread Noah Misch
On Fri, Feb 21, 2014 at 05:20:06PM -0500, Tom Lane wrote: Noah Misch n...@leadboat.com writes: On Wed, Feb 19, 2014 at 08:22:13PM -0500, Tom Lane wrote: How much of this is back-patch material, do you think? None of it. While many of the failures to validate against a character

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Tomas Vondra
On 22.2.2014 00:02, Josh Berkus wrote: On 02/21/2014 09:11 AM, Tomas Vondra wrote: What I think might be useful and safe at the same time is encrypted .pgpass with tools asking for the encryption key. Think of it as a simple passord wallet - not really useful if you're connecting to a single

[HACKERS] pg_stat_tmp files for dropped databases

2014-02-21 Thread Thom Brown
Hi, I've noticed that files for dropped databases aren't removed from pg_stat_tmp. After a cluster-wide VACUUM ANALYSE, and restarting Postgres, all the old database pg_stat_tmp files remain. Shouldn't these be cleaned up? -- Thom

Re: [HACKERS] [review] PostgreSQL Service on Windows does not start if data directory given is relative path

2014-02-21 Thread MauMau
Hi Rajeev, From: Rajeev rastogi rajeev.rast...@huawei.com Changed the patch as per your suggestion. Now only one version of make_absolute_path there defined in src/port/path.c Found one small memory leak in the existing function make_absolute_path(miscinit.c), fixed the same. Thanks for

Re: [HACKERS] pg_stat_tmp files for dropped databases

2014-02-21 Thread Tomas Vondra
Hi, On 22.2.2014 01:13, Thom Brown wrote: Hi, I've noticed that files for dropped databases aren't removed from pg_stat_tmp. After a cluster-wide VACUUM ANALYSE, and restarting Postgres, all the old database pg_stat_tmp files remain. Shouldn't these be cleaned up? Yeah, that's a bug in

Re: [HACKERS] Uninterruptable regexp_replace in 9.3.1 ?

2014-02-21 Thread Tom Lane
I wrote: Craig Ringer cr...@2ndquadrant.com writes: So I'd like to confirm that this issue doesn't affect 9.1. It doesn't. I suspect it has something to do with 173e29aa5 or one of the nearby commits in backend/regex/. Indeed, git bisect fingers that commit as introducing the problem. What

Re: [HACKERS] pg_stat_tmp files for dropped databases

2014-02-21 Thread Thom Brown
On 22 February 2014 01:07, Tomas Vondra t...@fuzzy.cz wrote: Hi, On 22.2.2014 01:13, Thom Brown wrote: Hi, I've noticed that files for dropped databases aren't removed from pg_stat_tmp. After a cluster-wide VACUUM ANALYSE, and restarting Postgres, all the old database pg_stat_tmp

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Greg Stark
On Fri, Feb 21, 2014 at 10:18 PM, Daniel Farina dan...@heroku.com wrote: I'm still in interested in this idea and haven't found a good reason to rescind the general thinking there. It's an interesting idea. I wonder if it would be possible to make it compatible with existing tools like

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Josh Berkus
On 02/21/2014 03:54 PM, Tomas Vondra wrote: Depends on how you define external utility. It certainly needs to be somehow integrated with the tools using .pgpass. Do you have something particular in mind? Yeah, I was thinking that the ideal would to be to make this generically pluggable, like

Re: [HACKERS] Storing the password in .pgpass file in an encrypted format

2014-02-21 Thread Daniel Farina
On Fri, Feb 21, 2014 at 6:15 PM, Greg Stark st...@mit.edu wrote: On Fri, Feb 21, 2014 at 10:18 PM, Daniel Farina dan...@heroku.com wrote: I'm still in interested in this idea and haven't found a good reason to rescind the general thinking there. It's an interesting idea. I wonder if it would

Re: [HACKERS] walsender doesn't send keepalives when writes are pending

2014-02-21 Thread Amit Kapila
On Fri, Feb 21, 2014 at 7:10 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-21 19:03:29 +0530, Amit Kapila wrote: On Fri, Feb 21, 2014 at 2:36 PM, Andres Freund and...@2ndquadrant.com wrote: Well, especially on a pipelined connection, that can take a fair bit. TCP timeouts

Re: [HACKERS] [bug fix] postgres.exe fails to start on Windows Server 2012 due to ASLR

2014-02-21 Thread MauMau
From: Magnus Hagander mag...@hagander.net Does somebody want to look at backpatching this to 9.1 and earlier, or should we just say that it's not fully supported on those Windows versions unless you apply the registry workaround? Please use the attached patch. It applies cleanly to both 9.1

Re: [HACKERS] Patch: show relation and tuple infos of a lock to acquire

2014-02-21 Thread Amit Kapila
On Fri, Feb 21, 2014 at 4:55 PM, Christian Kruse christ...@2ndquadrant.com wrote: Hi, 1. New context added by this patch is display at wrong place [...] Do this patch expect to print the context at cancel request as well? To be honest, I don't see a problem here. If you cancel the request