Re: [HACKERS] Securing "make check" (CVE-2014-0067)

2014-03-29 Thread Christoph Berg
Re: Noah Misch 2014-03-24 <20140323230420.ga4139...@tornado.leadboat.com> > On Thu, Mar 06, 2014 at 11:52:22PM -0500, Noah Misch wrote: > > On Thu, Mar 06, 2014 at 12:44:34PM -0500, Tom Lane wrote: > > > I'm inclined to suggest that we should put the socket under $CWD by > > > default, but provide

Re: [HACKERS] psql \d+ and oid display

2014-03-29 Thread Robert Haas
On Mar 28, 2014, at 2:41 PM, Tom Lane wrote: > Bruce Momjian writes: >> On Thu, Mar 27, 2014 at 02:54:26PM -0400, Stephen Frost wrote: >>> I believe Bruce was suggesting to show it when it is set to *not* the >>> default, which strikes me as perfectly reasonable. > >> We seem to be split on the

Re: [HACKERS] psql \d+ and oid display

2014-03-29 Thread Bruce Momjian
On Fri, Mar 28, 2014 at 03:53:32PM -0300, Fabrízio de Royes Mello wrote: > On Fri, Mar 28, 2014 at 3:41 PM, Tom Lane wrote: > > > > Bruce Momjian writes: > > > On Thu, Mar 27, 2014 at 02:54:26PM -0400, Stephen Frost wrote: > > >> I believe Bruce was suggesting to show it when it is set to *not* t

Re: [HACKERS] psql \d+ and oid display

2014-03-29 Thread David Johnston
Bruce Momjian wrote > On Fri, Mar 28, 2014 at 03:53:32PM -0300, Fabrízio de Royes Mello wrote: >> On Fri, Mar 28, 2014 at 3:41 PM, Tom Lane < > tgl@.pa > > wrote: >> > >> > Bruce Momjian < > bruce@ > > writes: >> > > On Thu, Mar 27, 2014 at 02:54:26PM -0400, Stephen Frost wrote: >> > >> I belie

[HACKERS] separate output dirs for test decoding pieces.

2014-03-29 Thread Andrew Dunstan
"make check" in contrib/test_decoding actually does two regression runs, one with pg_regress and one with pg_isolation_regress. These both use the same (default) outputdir, so one overwrites the other, which is a bit unfortunate from the buildfarm's point of view. I propose to make them use s

Re: [HACKERS] Composite Datums containing toasted fields are a bad idea(?)

2014-03-29 Thread Noah Misch
Interesting bug. On Fri, Mar 28, 2014 at 04:34:41PM -0400, Tom Lane wrote: > I think we might be better off to get rid of toast_flatten_tuple_attribute > and instead insist that composite Datums never contain any external toast > pointers in the first place. That is, places that call heap_form_tu

Re: [HACKERS] PQputCopyData dont signal error

2014-03-29 Thread steve k
I realize this is an old thread, but seems to be the only discussion I can find on this topic "I have a problem with PQputCopyData function. It doesn't signal some error. " I am using from within a c++ program: PQexec(m_pConn, "COPY... ...FROM stdin"), followed by PQputCopyData(m_p

Re: [HACKERS] PQputCopyData dont signal error

2014-03-29 Thread Tom Lane
steve k writes: > I realize this is an old thread, but seems to be the only discussion I can > find on this topic "I have a problem with PQputCopyData function. It doesn't > signal some error. " PQputCopyData/PQputCopyEnd are only concerned with transferring data. After you're done with that, y

Re: [HACKERS] psql \d+ and oid display

2014-03-29 Thread Bruce Momjian
On Sat, Mar 29, 2014 at 09:59:36AM -0700, David Johnston wrote: > As my belief is that 99% of the uses of \d are for human consumption > (because machines should in most cases hit the catalogs directly) then > strictly displaying "Includes OIDs" when appropriate has my +1. > > Uses of \d+ in regre

Re: [HACKERS] psql \d+ and oid display

2014-03-29 Thread Andrew Dunstan
On 03/29/2014 04:49 PM, Bruce Momjian wrote: On Sat, Mar 29, 2014 at 09:59:36AM -0700, David Johnston wrote: As my belief is that 99% of the uses of \d are for human consumption (because machines should in most cases hit the catalogs directly) then strictly displaying "Includes OIDs" when appro

Re: [HACKERS] [RFC] What should we do for reliable WAL archiving?

2014-03-29 Thread Jeff Janes
On Fri, Mar 21, 2014 at 2:22 PM, MauMau wrote: > From: "Jeff Janes" > > Do people really just copy the files from one directory of local storage >> to >> another directory of local storage? I don't see the point of that. >> > > It makes sense to archive WAL to a directory of local storage for

Re: [HACKERS] [RFC] What should we do for reliable WAL archiving?

2014-03-29 Thread Tom Lane
Jeff Janes writes: > But, it is hard to tell what the real solution is, because the doc doesn't > explain why it should refuse (and fail) to overwrite an existing file. The > only reason I can think of to make that recommendation is because it is > easy to accidentally configure two clusters to a

Re: [HACKERS] psql \d+ and oid display

2014-03-29 Thread Bruce Momjian
On Sat, Mar 29, 2014 at 05:10:49PM -0400, Andrew Dunstan wrote: > > On 03/29/2014 04:49 PM, Bruce Momjian wrote: > >On Sat, Mar 29, 2014 at 09:59:36AM -0700, David Johnston wrote: > >>As my belief is that 99% of the uses of \d are for human consumption > >>(because machines should in most cases hi

Re: [HACKERS] psql \d+ and oid display

2014-03-29 Thread Andrew Dunstan
On 03/29/2014 06:10 PM, Bruce Momjian wrote: On Sat, Mar 29, 2014 at 05:10:49PM -0400, Andrew Dunstan wrote: On 03/29/2014 04:49 PM, Bruce Momjian wrote: On Sat, Mar 29, 2014 at 09:59:36AM -0700, David Johnston wrote: As my belief is that 99% of the uses of \d are for human consumption (becau

Re: [HACKERS] psql \d+ and oid display

2014-03-29 Thread Tom Lane
Bruce Momjian writes: > Are you saying most people like "Has OIDs: yes", or the idea of just > displaying _a_ line if there are OIDs? Based on default_with_oids, > perhaps we should display "With OIDs". > I agree it is no unanimous. I am curious how large the majority has to > be to change a ps

[HACKERS] Re: [COMMITTERS] pgsql: Revert "Secure Unix-domain sockets of "make check" temporary clu

2014-03-29 Thread Noah Misch
On Sat, Mar 29, 2014 at 01:48:33PM -0400, Andrew Dunstan wrote: > On 03/29/2014 01:22 PM, Noah Misch wrote: > >http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dromedary&dt=2014-03-29%2007%3A02%3A48 > > Hmm. Can we use a location with a bit more head room than the > tmp_check/data directory?

Re: [HACKERS] PQputCopyData dont signal error

2014-03-29 Thread David Johnston
steve k wrote > I realize this is an old thread, but seems to be the only discussion I can > find on this topic "I have a problem with PQputCopyData function. It > doesn't signal some error. " > > I am using from within a c++ program: > PQexec(m_pConn, "COPY... ...FROM stdin"), > >

Re: [HACKERS] psql \d+ and oid display

2014-03-29 Thread Bruce Momjian
On Sat, Mar 29, 2014 at 06:16:19PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Are you saying most people like "Has OIDs: yes", or the idea of just > > displaying _a_ line if there are OIDs? Based on default_with_oids, > > perhaps we should display "With OIDs". > > > I agree it is no unan

Re: [HACKERS] Useless "Replica Identity: NOTHING" noise from psql \d

2014-03-29 Thread Bruce Momjian
On Thu, Mar 27, 2014 at 11:02:55AM -0400, Bruce Momjian wrote: > On Thu, Mar 27, 2014 at 10:30:59AM -0400, Bruce Momjian wrote: > > On Thu, Mar 27, 2014 at 10:13:36AM -0400, Tom Lane wrote: > > > Bruce Momjian writes: > > > > On Thu, Mar 27, 2014 at 02:41:40PM +0100, Christoph Berg wrote: > > > >>

Re: [HACKERS] [RFC] What should we do for reliable WAL archiving?

2014-03-29 Thread Jeff Janes
On Saturday, March 29, 2014, Tom Lane wrote: > Jeff Janes > writes: > > But, it is hard to tell what the real solution is, because the doc > doesn't > > explain why it should refuse (and fail) to overwrite an existing file. > The > > only reason I can think of to make that recommendation is beca

Re: [HACKERS] Securing "make check" (CVE-2014-0067)

2014-03-29 Thread Noah Misch
On Sat, Mar 29, 2014 at 10:04:55AM +0100, Christoph Berg wrote: > Fwiw, to relocate the pg_regress socket dir, there is already the > possibility to run make check EXTRA_REGRESS_OPTS="--host=/tmp". (With > the pending fix I sent yesterday to extend this to contrib/test_decoding.) That doesn't work

Re: Fwd: [HACKERS] Proposal: variant of regclass

2014-03-29 Thread Amit Kapila
On Sat, Mar 22, 2014 at 1:17 PM, Amit Kapila wrote: > On Wed, Feb 26, 2014 at 11:56 AM, Yugo Nagata wrote: >> Thanks for your a lot of comments. I revised the patch according to >> comments from Robert Haas and Marti Raudsepp. > > I have started looking into this patch and below are my > initial

[HACKERS] MultiXactId error after upgrade to 9.3.4

2014-03-29 Thread Stephen Frost
Greetings, Looks like we might not be entirely out of the woods yet regarding MultiXactId's. After doing an upgrade from 9.2.6 to 9.3.4, we saw the following: ERROR: MultiXactId 6849409 has not been created yet -- apparent wraparound The table contents can be select'd out and match t