Re: [HACKERS] split builtins.h to quote.h

On Sun, Oct 12, 2014 at 7:09 AM, Stephen Frost wrote: > * Noah Misch (n...@leadboat.com) wrote: >> On Sat, Oct 11, 2014 at 11:43:46PM +0200, Andres Freund wrote: >> > I personally wouldn't object plaing a #include for the splitof file into >> > builtin.h to address backward compat concerns. Would

Re: [HACKERS] psql output change in 9.4

On 10/11/14 8:25 PM, Bruce Momjian wrote: > On Mon, Aug 11, 2014 at 02:28:45PM -0400, Robert Haas wrote: >> On Mon, Aug 11, 2014 at 1:52 PM, Tom Lane wrote: >>> Robert Haas writes: On Fri, Aug 8, 2014 at 9:34 PM, Peter Eisentraut wrote: > What is the point of that change? >>> I thi

Re: [HACKERS] pg_dump refactor patch to remove global variables

On Sat, Oct 11, 2014 at 10:15 PM, Alvaro Herrera wrote: > > Fabrízio de Royes Mello wrote: > > On Sat, Oct 11, 2014 at 2:56 PM, Alvaro Herrera < alvhe...@2ndquadrant.com> > > wrote: > > > > > Here's the complete patch in case anyone is wondering. > > > > > > > > Hi, > > > > Your patch doesn't appl

Re: [HACKERS] multixact optimization patches

Bruce Momjian wrote: > On Tue, Jul 29, 2014 at 03:56:19PM -0400, Alvaro Herrera wrote: > > I have just pushed two optimization patches for multixacts to HEAD only. > > I hesitate to backpatch them to 9.3 right away, but will consider doing > > so if people think differently. > > > > I also have a

Re: [HACKERS] B-Tree support function number 3 (strxfrm() optimization)

On Mon, Sep 29, 2014 at 10:34 PM, Peter Geoghegan wrote: > . You probably noticed that I posted an independently useful patch to make all tuplesort cases use sortsupport [1] - currently, both the B-Tree and CLUSTER cases do not use the sortsupport infrastructure more or less for no good reason. T

Re: [HACKERS] pg_dump refactor patch to remove global variables

Fabrízio de Royes Mello wrote: > On Sat, Oct 11, 2014 at 2:56 PM, Alvaro Herrera > wrote: > > > Here's the complete patch in case anyone is wondering. > > > > > Hi, > > Your patch doesn't apply to master: I think your email system mangled it. I can download it from archives and apply it just

Re: [HACKERS] [PATCH] PostgreSQL 9.4 mmap(2) performance regression on FreeBSD...

On Tue, Aug 12, 2014 at 07:08:06PM -0400, Robert Haas wrote: > On Tue, Aug 12, 2014 at 12:59 PM, Andres Freund > wrote: > > On 2014-08-12 09:42:30 -0700, Sean Chittenden wrote: > >> One of the patches that I've been sitting on and am derelict in punting > >> upstream is the attached mmap(2) flags

Re: [HACKERS] [REVIEW] pg_last_xact_insert_timestamp

On Wed, Aug 13, 2014 at 12:41:24PM +0900, Fujii Masao wrote: > On Mon, Aug 11, 2014 at 8:27 PM, Fujii Masao wrote: > > On Mon, Aug 11, 2014 at 4:46 PM, Andres Freund > > wrote: > >> Hi, > >> > >> On 2011-10-04 20:52:59 +0900, Fujii Masao wrote: > >>> *** a/src/backend/access/transam/xact.c > >>>

Re: [HACKERS] psql output change in 9.4

On Mon, Aug 11, 2014 at 02:28:45PM -0400, Robert Haas wrote: > On Mon, Aug 11, 2014 at 1:52 PM, Tom Lane wrote: > > Robert Haas writes: > >> On Fri, Aug 8, 2014 at 9:34 PM, Peter Eisentraut wrote: > >>> What is the point of that change? > > > >> I think the output could justly be criticized for

Re: [HACKERS] Append to a GUC parameter ?

On Thu, Aug 7, 2014 at 10:04:47AM -0400, Alvaro Herrera wrote: > Fabrízio de Royes Mello wrote: > > On Tue, Aug 5, 2014 at 10:55 PM, Tom Lane wrote: > > > > > Josh Berkus writes: > > > > BTW, while there's unlikely to be a good reason to put search_path in > > > > pg.conf with appends, there ar

Re: [HACKERS] pg_ctl non-idempotent behavior change

On Mon, Aug 4, 2014 at 05:07:47PM -0400, Alvaro Herrera wrote: > Tom Lane wrote: > > Jeff Janes writes: > > > After 87306184580c9c49717, if the postmaster dies without cleaning up > > > (i.e. > > > power outage), running "pg_ctl start" just gives this message and then > > > exits: > > > > > pg_

Re: [HACKERS] Looked at TODO:Considering improving performance of computing CHAR() value lengths

On Mon, Aug 4, 2014 at 11:48:38AM +0300, Heikki Linnakangas wrote: > The biggest issue with the previously discussed patches was the lack > of performance testing. People posted results of various > micro-benchmarks that showed different aspects, but no-one > comprehensively covered all the intere

Re: [HACKERS] Is analyze_new_cluster.sh still useful?

On Mon, Aug 4, 2014 at 10:17:40AM +0200, Christoph Berg wrote: > Re: Bruce Momjian 2014-07-29 <20140729094234.gc13...@momjian.us> > > On Fri, Jun 20, 2014 at 05:15:05PM +0200, Christoph Berg wrote: > > > Another nitpick here: What pg_upgrade outputs doesn't even work on > > > most systems, you nee

Re: [HACKERS] split builtins.h to quote.h

* Noah Misch (n...@leadboat.com) wrote: > On Sat, Oct 11, 2014 at 11:43:46PM +0200, Andres Freund wrote: > > I personally wouldn't object plaing a #include for the splitof file into > > builtin.h to address backward compat concerns. Would imo still be an > > improvement. > > Agreed. If the patch

Re: [HACKERS] split builtins.h to quote.h

On Sat, Oct 11, 2014 at 11:43:46PM +0200, Andres Freund wrote: > On 2014-10-11 17:19:27 -0400, Noah Misch wrote: > > On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: > > > Started a new thread to raise awareness. > > > > > Ref: this comes from > > > http://www.postgresql.org/message

Re: [HACKERS] No toast table for pg_shseclabel but for pg_seclabel

* Andres Freund (and...@2ndquadrant.com) wrote: > On 2014-10-11 18:19:05 -0300, Fabrízio de Royes Mello wrote: > > On Sat, Oct 11, 2014 at 5:40 PM, Tom Lane wrote: > > > > > > Bruce Momjian writes: > > > > On Fri, Jul 4, 2014 at 10:53:15AM -0400, Tom Lane wrote: > > > >> So maybe we should get r

Re: [HACKERS] pg_dump refactor patch to remove global variables

On Sat, Oct 11, 2014 at 2:56 PM, Alvaro Herrera wrote: > Here's the complete patch in case anyone is wondering. > > Hi, Your patch doesn't apply to master: $ git apply ~/Downloads/pg_dump_refactor_globals.6.diff /home/fabrizio/Downloads/pg_dump_refactor_globals.6.diff:10: trailing whitespace.

Re: [HACKERS] split builtins.h to quote.h

* Bruce Momjian (br...@momjian.us) wrote: > On Sat, Oct 11, 2014 at 05:19:27PM -0400, Noah Misch wrote: > > On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: > > > Started a new thread to raise awareness. > > > > > Ref: this comes from > > > http://www.postgresql.org/message-id/cab7n

Re: [HACKERS] split builtins.h to quote.h

On 2014-10-11 17:19:27 -0400, Noah Misch wrote: > On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: > > Started a new thread to raise awareness. > > > Ref: this comes from > > http://www.postgresql.org/message-id/cab7npqr1ivd5r_qn_ngmkbolqmagbosj4wnpo8eybnn6we_...@mail.gmail.com > >

Re: [HACKERS] No toast table for pg_shseclabel but for pg_seclabel

On 2014-10-11 18:19:05 -0300, Fabrízio de Royes Mello wrote: > On Sat, Oct 11, 2014 at 5:40 PM, Tom Lane wrote: > > > > Bruce Momjian writes: > > > On Fri, Jul 4, 2014 at 10:53:15AM -0400, Tom Lane wrote: > > >> So maybe we should get rid of the toast table for pg_seclabel. One > less > > >> ca

Re: [HACKERS] multixact optimization patches

On Tue, Jul 29, 2014 at 03:56:19PM -0400, Alvaro Herrera wrote: > I have just pushed two optimization patches for multixacts to HEAD only. > I hesitate to backpatch them to 9.3 right away, but will consider doing > so if people think differently. > > I also have a patch that supposedly fixes the p

Re: [HACKERS] split builtins.h to quote.h

On Sat, Oct 11, 2014 at 05:19:27PM -0400, Noah Misch wrote: > On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: > > Started a new thread to raise awareness. > > > Ref: this comes from > > http://www.postgresql.org/message-id/cab7npqr1ivd5r_qn_ngmkbolqmagbosj4wnpo8eybnn6we_...@mail.gm

Re: [HACKERS] Remove comment about manually flipping attnotnull

On Thu, Jul 24, 2014 at 12:51:09PM -0400, Tom Lane wrote: > Andres Freund writes: > > catalogs.sgml has this comment: > >This represents a not-null constraint. It is possible to > >change this column to enable or disable the constraint. > > > Someone on irc just took that as "per

Re: [HACKERS] split builtins.h to quote.h

On Sat, Oct 11, 2014 at 10:44:39AM -0300, Alvaro Herrera wrote: > Started a new thread to raise awareness. > Ref: this comes from > http://www.postgresql.org/message-id/cab7npqr1ivd5r_qn_ngmkbolqmagbosj4wnpo8eybnn6we_...@mail.gmail.com Thanks. You can assume I'm -1 on every header split proposal

Re: [HACKERS] No toast table for pg_shseclabel but for pg_seclabel

On Sat, Oct 11, 2014 at 5:40 PM, Tom Lane wrote: > > Bruce Momjian writes: > > On Fri, Jul 4, 2014 at 10:53:15AM -0400, Tom Lane wrote: > >> So maybe we should get rid of the toast table for pg_seclabel. One less > >> catalog table for a feature that hardly anyone is using seems like a fine > >

Re: [HACKERS] Shapes on the regression test for polygon

On Wed, Jul 23, 2014 at 06:12:59PM -0400, Robert Haas wrote: > On Wed, Jul 23, 2014 at 4:06 PM, Tom Lane wrote: > > Robert Haas writes: > >> On Mon, Jul 21, 2014 at 10:52 AM, Emre Hasegeli wrote: > >>> The first two shapes on src/test/regress/sql/polygon.sql do not make > >>> sense to me. > > >

Re: [HACKERS] No toast table for pg_shseclabel but for pg_seclabel

Bruce Momjian writes: > On Fri, Jul 4, 2014 at 10:53:15AM -0400, Tom Lane wrote: >> So maybe we should get rid of the toast table for pg_seclabel. One less >> catalog table for a feature that hardly anyone is using seems like a fine >> idea to me ... > Is this still an open item? I haven't don

Re: [HACKERS] Performance regression: 9.2+ vs. ScalarArrayOpExpr vs. ORDER BY

Uh, did this ever get addressed? --- On Sun, Jul 6, 2014 at 08:56:00PM +0100, Andrew Gierth wrote: > > "Tom" == Tom Lane writes: > > >> I've experimented with the attached patch, which detects when this > >> situati

Re: [HACKERS] No toast table for pg_shseclabel but for pg_seclabel

On Fri, Jul 4, 2014 at 10:53:15AM -0400, Tom Lane wrote: > Kohei KaiGai writes: > > Here is no other reason than what Alvaro mentioned in the upthread. > > We intended to store security label of SELinux (less than 100bytes at most), > > so I didn't think it leads any problem actually. > > > On t

Re: [HACKERS] uninitialized values in revised prepared xact code

Uh, was this fixed. I see a cleanup commit for this C file, but this report is from June: commit 07a4a93a0e35a778c77ffbbbc18de29e859e18f0 Author: Heikki Linnakangas Date: Fri May 16 09:47:50 2014 +0300 Initialize tsId and dbId fields in WAL record

Re: [HACKERS] Shared memory changes in 9.4?

Uh, this patch was never applied. Do we want it? --- On Thu, Jun 12, 2014 at 03:39:14PM +0200, Christoph Berg wrote: > Re: Andres Freund 2014-06-12 <20140612094112.gz8...@alap3.anarazel.de> > > > * Make initdb determine the

Re: [HACKERS] pg_dump refactor patch to remove global variables

Here's the complete patch in case anyone is wondering. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services diff --git a/src/bin/pg_dump/common.c b/src/bin/pg_dump/common.c index 2f855cf..17e9574 100644 --- a/src/bin/pg_dump/common

Re: [HACKERS] jsonb contains behaviour weirdness

Peter Geoghegan writes: > This was never committed... Yeah ... the discussion trailed off and I think we forgot to actually commit a fix. Will go do so. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your sub

Re: [HACKERS] Function array_agg(array)

Ali Akbar writes: > So, can't we just set the typarray of array types to its self oid? Seems dangerous as heck; certainly it would have side-effects far more wide-ranging than just making this particular function work. A safer answer is to split array_agg into two functions, array_agg(an

[HACKERS] Function array_agg(array)

Greetings, While looking for easier items in PostgreSQL Wiki's Todo List (this will be my 3rd patch), i found this TODO: Add a built-in array_agg(anyarray) or similar, that can aggregate > 1-dimensional arrays into a 2-dimensional array. > I've stumbled by this lack of array_agg(anyarray) someti

Re: [HACKERS] Wait free LW_SHARED acquisition - v0.9

On 2014-10-11 15:10:45 +0200, Andres Freund wrote: > Hi, > > On 2014-10-11 07:26:57 +0530, Amit Kapila wrote: > > On Sat, Oct 11, 2014 at 7:00 AM, Andres Freund > > > And since > > > your general performance numbers are a fair bit lower than what I see > > > with, hopefully, the same code on the

[HACKERS] split builtins.h to quote.h

Started a new thread to raise awareness. Michael Paquier wrote: > On Thu, Oct 9, 2014 at 8:29 AM, Michael Paquier > wrote: > > On Thu, Oct 9, 2014 at 6:26 AM, Alvaro Herrera > > wrote: > >> However, if I were to do it, I would instead create a quote.h file and > >> would also add the quote_liter

Re: [HACKERS] Column Redaction

On Sat, Oct 11, 2014 at 09:51:28AM +0100, Simon Riggs wrote: > > So it's not actually suitable for the example you gave. I don't think we > > want this feature... > > The full quote I read is the following... > > "Even though Oracle Data Redaction is not intended to protect against > attacks by d

Re: [HACKERS] Column Redaction

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/11/2014 02:40 AM, Simon Riggs wrote: > As soon as you issue the above query, you have clearly indicated > your intention to steal. Receiving information is no longer > accidental, it is an explicit act that is logged in the auditing > system a

Re: [HACKERS] Wait free LW_SHARED acquisition - v0.9

On Sat, Oct 11, 2014 at 6:40 PM, Andres Freund wrote: > On 2014-10-11 07:26:57 +0530, Amit Kapila wrote: > > On Sat, Oct 11, 2014 at 7:00 AM, Andres Freund > > > And since > > > your general performance numbers are a fair bit lower than what I see > > > with, hopefully, the same code on the same

Re: [HACKERS] Add CREATE support to event triggers

On Thu, Oct 9, 2014 at 8:29 AM, Michael Paquier wrote: > On Thu, Oct 9, 2014 at 6:26 AM, Alvaro Herrera > wrote: >> However, if I were to do it, I would instead create a quote.h file and >> would also add the quote_literal_cstr() prototype to it, perhaps even >> move the implementations from thei

Re: [HACKERS] Wait free LW_SHARED acquisition - v0.9

Hi, On 2014-10-11 07:26:57 +0530, Amit Kapila wrote: > On Sat, Oct 11, 2014 at 7:00 AM, Andres Freund > > And since > > your general performance numbers are a fair bit lower than what I see > > with, hopefully, the same code on the same machine... > > You have reported numbers at 1000 scale fact

Re: [HACKERS] orangutan seizes up during isolation-check

On 10/11/14 1:41 AM, Noah Misch wrote: > Good question. It would be nice to make the change there, for the benefit of > other consumers. The patch's setlocale_native_forked() assumes it never runs > in a multithreaded process, but libintl_setlocale() must not assume that. I > see a few ways libi

Re: [HACKERS] Column Redaction

On 10 October 2014 11:27, Heikki Linnakangas wrote: > I googled for Oracle Data redaction, and found "General Usage guidelines": > >> General Usage Guidelines >> >> * Oracle Data Redaction is not intended to protect against attacks by >> privileged database users who run ad hoc queries directly a

Re: [HACKERS] jsonb contains behaviour weirdness

This was never committed... On Sat, Sep 13, 2014 at 4:31 PM, Peter Geoghegan wrote: > On Fri, Sep 12, 2014 at 6:40 AM, Alexander Korotkov > wrote: >> It's likely that "JB_ROOT_COUNT(val) < JB_ROOT_COUNT(tmpl)" should be >> checked only for objects, not arrays. Also, should JsonbDeepContains does

Re: [HACKERS] Column Redaction

On 10 October 2014 16:45, Rod Taylor wrote: > On my laptop I can pull all 10,000 card numbers in less than 1 second. Right. Like I said: covert channels exist. Great example of how to exploit them, thanks. Cool SQL. What could be the use of "a security feature that does not prevent security"?