Re: [HACKERS] Parallel Seq Scan

2015-01-22 Thread Amit Kapila
On Thu, Jan 22, 2015 at 7:23 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jan 22, 2015 at 5:57 AM, Amit Kapila amit.kapil...@gmail.com wrote: 1. Scanning block-by-block has negative impact on performance and I thin it will degrade more if we increase parallel count as that can lead

Re: [HACKERS] delta relations in AFTER triggers

2015-01-22 Thread Robert Haas
On Thu, Oct 23, 2014 at 11:19 AM, Robert Haas robertmh...@gmail.com wrote: So what I'm imagining now is: 1. During parse analysis, p_tableref_hook gets control and calls addRangeTableEntryForTuplestore(), creating an RTE of type RTE_TUPLESTORE. The RTE stores an integer parameter-index. 2.

Re: [HACKERS] New CF app: changing email sender

2015-01-22 Thread Kyotaro HORIGUCHI
Lovely! I've just pushed a change to the main website which now lets you change the email address there. That meas you can go to https://www.postgresql.org/account/profile/ and change the email. After you have confirmed the change (an email will be sent to your new address when you change

Re: [HACKERS] Parallel Seq Scan

2015-01-22 Thread Robert Haas
On Thu, Jan 22, 2015 at 9:02 AM, Amit Kapila amit.kapil...@gmail.com wrote: I'm confused. Your actual test numbers seem to show that the performance with the block-by-block approach was slightly higher with parallelism than without, where as the performance with the chunk-by-chunk approach

Re: [HACKERS] Parallel Seq Scan

2015-01-22 Thread Robert Haas
On Thu, Jan 22, 2015 at 5:57 AM, Amit Kapila amit.kapil...@gmail.com wrote: 1. Scanning block-by-block has negative impact on performance and I thin it will degrade more if we increase parallel count as that can lead to more randomness. 2. Scanning in fixed chunks improves the performance.

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-01-22 Thread Marko Tiikkaja
Hello, I just heard that there's going to be a fifth CF for 9.5 so I'm trying to gather all the patches I'd like to see in 9.5.. On 8/23/13 10:36 AM, I wrote: My opinion at this very moment is that we should leave the the DEFAULT verbosity alone and add a new one (call it COMPACT or such)

[HACKERS] [POC] FETCH limited by bytes.

2015-01-22 Thread Kyotaro HORIGUCHI
Hello, as the discuttion on async fetching on postgres_fdw, FETCH with data-size limitation would be useful to get memory usage stability of postgres_fdw. Is such a feature and syntax could be allowed to be added? == Postgres_fdw fetches tuples from remote servers using cursor. The transfer

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-01-22 Thread Pavel Stehule
2015-01-22 12:37 GMT+01:00 Marko Tiikkaja ma...@joh.to: Hello, I just heard that there's going to be a fifth CF for 9.5 so I'm trying to gather all the patches I'd like to see in 9.5.. On 8/23/13 10:36 AM, I wrote: My opinion at this very moment is that we should leave the the DEFAULT

Re: [HACKERS] collate test now failing

2015-01-22 Thread Robert Haas
On Thu, Jan 22, 2015 at 11:53 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jan 22, 2015 at 11:50 AM, Kevin Grittner kgri...@ymail.com wrote: Kevin Grittner kgri...@ymail.com wrote: I think this may have just started with: b529b65d1bf8537ca7fa024760a9782d7c8b66e5 Confirmed that I get

Re: [HACKERS] Parallel Seq Scan

2015-01-22 Thread Amit Kapila
On Mon, Jan 19, 2015 at 6:50 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Jan 19, 2015 at 2:24 AM, Amit Kapila amit.kapil...@gmail.com wrote: Another thing is that I think prefetching is not supported on all platforms (Windows) and for such systems as per above algorithm we need to

Re: [HACKERS] PQputCopyEnd doesn't adhere to its API contract

2015-01-22 Thread Bruce Momjian
On Fri, Jan 9, 2015 at 03:04:19PM -0500, Bruce Momjian wrote: Uh, where are we on this? I think someone needs to take Tom's proposed language and make it into a patch. And figure out which other functions in the documentation need similar updates. I have developed such a patch ---

Re: [HACKERS] basebackups during ALTER DATABASE ... SET TABLESPACE ... not safe?

2015-01-22 Thread Andres Freund
Hi, On 2015-01-20 16:28:19 +0100, Andres Freund wrote: I'm analyzing a problem in which a customer had a pg_basebackup (from standby) created 9.2 cluster that failed with WAL contains references to invalid pages. The failed record was a xlog redo visible i.e. XLOG_HEAP2_VISIBLE. First I

Re: [HACKERS] Sequence Access Method WIP

2015-01-22 Thread Heikki Linnakangas
On 01/12/2015 11:33 PM, Petr Jelinek wrote: Second patch adds DDL support. I originally wanted to make it CREATE/DROP SEQUENCE ACCESS METHOD... but that would mean making ACCESS a reserver keyword so I went for CREATE ACCESS METHOD FOR SEQUENCES which does not need to change anything (besides

Re: [HACKERS] Sequence Access Method WIP

2015-01-22 Thread Petr Jelinek
On 22/01/15 16:50, Heikki Linnakangas wrote: On 01/12/2015 11:33 PM, Petr Jelinek wrote: Second patch adds DDL support. I originally wanted to make it CREATE/DROP SEQUENCE ACCESS METHOD... but that would mean making ACCESS a reserver keyword so I went for CREATE ACCESS METHOD FOR SEQUENCES

Re: [HACKERS] [POC] FETCH limited by bytes.

2015-01-22 Thread Tom Lane
Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp writes: Hello, as the discuttion on async fetching on postgres_fdw, FETCH with data-size limitation would be useful to get memory usage stability of postgres_fdw. Is such a feature and syntax could be allowed to be added? This seems like a

Re: [HACKERS] Windows buildfarm animals are still not happy with abbreviated keys patch

2015-01-22 Thread Robert Haas
On Thu, Jan 22, 2015 at 10:57 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Jan 21, 2015 at 2:30 PM, Peter Geoghegan p...@heroku.com wrote: Even following Robert's disabling of abbreviated keys on Windows, buildfarm animals hamerkop, brolga, currawong and bowerbird remain unhappy, with

Re: [HACKERS] Windows buildfarm animals are still not happy with abbreviated keys patch

2015-01-22 Thread Robert Haas
On Wed, Jan 21, 2015 at 2:30 PM, Peter Geoghegan p...@heroku.com wrote: Even following Robert's disabling of abbreviated keys on Windows, buildfarm animals hamerkop, brolga, currawong and bowerbird remain unhappy, with failing regression tests for collate and sometimes (but not always)

Re: [HACKERS] fix typo in reinit.h

2015-01-22 Thread Alvaro Herrera
Sawada Masahiko wrote: Hi, Attached patch fixes a typo in init.h. Thanks, pushed. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] Sequence Access Method WIP

2015-01-22 Thread Robert Haas
On Thu, Jan 22, 2015 at 10:50 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 01/12/2015 11:33 PM, Petr Jelinek wrote: Second patch adds DDL support. I originally wanted to make it CREATE/DROP SEQUENCE ACCESS METHOD... but that would mean making ACCESS a reserver keyword so I went for

Re: [HACKERS] PATCH: decreasing memory needlessly consumed by array_agg

2015-01-22 Thread Tomas Vondra
Hi, On 21.1.2015 09:01, Jeff Davis wrote: On Tue, 2015-01-20 at 23:37 +0100, Tomas Vondra wrote: Tom's message where he points that out is here: http://www.postgresql.org/message-id/20707.1396372...@sss.pgh.pa.us That message also says: I think a patch that stood a chance of getting

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-01-22 Thread Tom Lane
Sawada Masahiko sawada.m...@gmail.com writes: As per discussion http://www.postgresql.org/message-id/cad21aodkds8oqbr199wwrcp7fidvow6bbb+cgdwqhuf+gx_...@mail.gmail.com, I would like to proposal new view like pg_file_settings to know detail of config file via SQL. - Background In 9.4

Re: [HACKERS] PATCH: Reducing lock strength of trigger and foreign key DDL

2015-01-22 Thread Andreas Karlsson
On 01/20/2015 10:08 AM, Noah Misch wrote: Fair enough. It did reinforce pg_get_constraintdef() as a subroutine of pg_dump rather than an independent, rigorous interface. It perhaps made the function worse for non-pg_dump callers. In that vein, each one of these hacks has a cost. One could

Re: [HACKERS] basebackups during ALTER DATABASE ... SET TABLESPACE ... not safe?

2015-01-22 Thread Stephen Frost
Andres, * Andres Freund (and...@2ndquadrant.com) wrote: 1) Make do_pg_start_backup() acquire a SHARE lock on pg_database. That'll prevent it from starting while a movedb() is still in progress. Then additionally add pg_backup_in_progress() function to xlog.c that checks

Re: [HACKERS] alter user/role CURRENT_USER

2015-01-22 Thread Alvaro Herrera
Looking at this a bit, I'm not sure completely replacing RoleId with a node is the best idea; some of the users of that production in the grammar are okay with accepting only normal strings as names, and don't need all the CURRENT_USER etc stuff. Maybe we need a new production, say RoleSpec, and

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-01-22 Thread David G Johnston
Tom Lane-2 wrote regression=# alter system reset timezone; ALTER SYSTEM regression=# select pg_reload_conf(); How does someone know that performing the above commands will result in the TimeZone setting being changed from Asia/Shanghai to US/Eastern? David J. -- View this message in

Re: [HACKERS] hung backends stuck in spinlock heavy endless loop

2015-01-22 Thread Merlin Moncure
On Fri, Jan 16, 2015 at 5:20 PM, Peter Geoghegan p...@heroku.com wrote: On Fri, Jan 16, 2015 at 10:33 AM, Merlin Moncure mmonc...@gmail.com wrote: ISTM the next step is to bisect the problem down over the weekend in order to to narrow the search. If that doesn't turn up anything productive

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-01-22 Thread David Johnston
On Thu, Jan 22, 2015 at 3:04 PM, Tom Lane t...@sss.pgh.pa.us wrote: David G Johnston david.g.johns...@gmail.com writes: Tom Lane-2 wrote regression=# alter system reset timezone; ALTER SYSTEM regression=# select pg_reload_conf(); How does someone know that performing the above

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-01-22 Thread Tom Lane
David G Johnston david.g.johns...@gmail.com writes: Tom Lane-2 wrote regression=# alter system reset timezone; ALTER SYSTEM regression=# select pg_reload_conf(); How does someone know that performing the above commands will result in the TimeZone setting being changed from Asia/Shanghai to

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-01-22 Thread Tom Lane
David Johnston david.g.johns...@gmail.com writes: On Thu, Jan 22, 2015 at 3:04 PM, Tom Lane t...@sss.pgh.pa.us wrote: Is that a requirement, and if so why? Because this proposal doesn't guarantee any such knowledge AFAICS. ​The proposal provides for SQL access to all possible sources of

Re: [HACKERS] basebackups during ALTER DATABASE ... SET TABLESPACE ... not safe?

2015-01-22 Thread Andres Freund
On 2015-01-22 16:38:49 -0500, Stephen Frost wrote: Andres, * Andres Freund (and...@2ndquadrant.com) wrote: 1) Make do_pg_start_backup() acquire a SHARE lock on pg_database. That'll prevent it from starting while a movedb() is still in progress. Then additionally add

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-01-22 Thread David Johnston
On Thu, Jan 22, 2015 at 3:19 PM, Tom Lane t...@sss.pgh.pa.us wrote: David Johnston david.g.johns...@gmail.com writes: On Thu, Jan 22, 2015 at 3:04 PM, Tom Lane t...@sss.pgh.pa.us wrote: Is that a requirement, and if so why? Because this proposal doesn't guarantee any such knowledge

Re: [HACKERS] New CF app: changing email sender

2015-01-22 Thread Magnus Hagander
On Tue, Jan 20, 2015 at 10:58 AM, Andrew Gierth and...@tao11.riddles.org.uk wrote: Kyotaro == Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp writes: Kyotaro Hmm. The mail address indeed *was* mine but is now obsolete, Kyotaro so that the email might bounce. But I haven't find how to

Re: [HACKERS] delta relations in AFTER triggers

2015-01-22 Thread Kevin Grittner
Robert Haas robertmh...@gmail.com wrote: Another idea is to change what actually gets passed to the parser callback. Right now we just pass the PLpgSQL_expr. If we created a new structure that contained that plus the PLpgSQL_execstate, we'd be in fine shape. But this sort of gets at the

[HACKERS] fix typo in reinit.h

2015-01-22 Thread Sawada Masahiko
Hi, Attached patch fixes a typo in init.h. Regards, --- Sawada Masahiko fix_typo_reinit_h.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Windows buildfarm animals are still not happy with abbreviated keys patch

2015-01-22 Thread Peter Geoghegan
On Thu, Jan 22, 2015 at 12:34 PM, Robert Haas robertmh...@gmail.com wrote: This isn't really Windows-specific. The root of the problem is that when LC_COLLATE=C you were trying to use strxfrm() for the abbreviated key even though memcmp() is the authoritative comparator in that case. Exactly

Re: [HACKERS] Using 128-bit integers for sum, avg and statistics aggregates

2015-01-22 Thread Andreas Karlsson
A new version of the patch is attached, which changes the following: - Changed from using __int128_t to __int128. - Actually compiles and runs code in configure to see that int128 works. - No longer tests for __uint128_t. - Updated pg_config.h.win32 - Renamed some things from int12 to int128,

Re: [HACKERS] Back-branch update releases scheduled

2015-01-22 Thread Bruce Momjian
On Thu, Jan 22, 2015 at 03:28:39PM -0800, Peter Geoghegan wrote: On Thu, Jan 22, 2015 at 3:23 PM, Tom Lane t...@sss.pgh.pa.us wrote: We're really rather overdue for updates of the pre-9.4 back branches, and 9.4 itself has probably baked for long enough to justify a 9.4.1. Accordingly, the

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: On Fri, Jan 23, 2015 at 01:19:33AM +0100, Andres Freund wrote: Or do you - as the text edited in your patch, but not the quote above - mean to run pg_upgrade just on the primary and then rsync? No, I was going to run it on both, then rsync. I'm

Re: [HACKERS] Using 128-bit integers for sum, avg and statistics aggregates

2015-01-22 Thread Petr Jelinek
On 23/01/15 00:40, Andreas Karlsson wrote: - Renamed some things from int12 to int128, there are still some places with int16 which I am not sure what to do with. I'd vote for renaming them to int128 too, there is enough C functions that user int16 for 16bit integer that this is going to be

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread David Steele
On 1/22/15 8:54 PM, Stephen Frost wrote: The problem, as mentioned elsewhere, is that you have to checksum all the files because the timestamps will differ. You can actually get around that with rsync if you really want though- tell it to only look at file sizes instead of size+time by

Re: [HACKERS] Parallel Seq Scan

2015-01-22 Thread Josh Berkus
On 01/22/2015 05:53 AM, Robert Haas wrote: Also, I think testing with 2 workers is probably not enough. I think we should test with 8 or even 16. FWIW, based on my experience there will also be demand to use parallel query using 4 workers, particularly on AWS. -- Josh Berkus PostgreSQL

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread Stephen Frost
* David Steele (da...@pgmasters.net) wrote: On 1/22/15 8:54 PM, Stephen Frost wrote: The problem, as mentioned elsewhere, is that you have to checksum all the files because the timestamps will differ. You can actually get around that with rsync if you really want though- tell it to only

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread David Steele
On 1/22/15 10:05 PM, Stephen Frost wrote: In addition, there is a possible race condition in rsync where a file that is modified in the same second after rsync starts to copy will not be picked up in a subsequent rsync unless --checksum is used. This is fairly easy to prove and is shown here:

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-01-22 Thread Amit Kapila
On Fri, Jan 23, 2015 at 3:49 AM, Tom Lane t...@sss.pgh.pa.us wrote: I know what the proposal is. What I am questioning is the use-case that justifies having us build and support all this extra mechanism. How often does anyone need to know what the next down variable value would be? I would

[HACKERS] Back-branch update releases scheduled

2015-01-22 Thread Tom Lane
We're really rather overdue for updates of the pre-9.4 back branches, and 9.4 itself has probably baked for long enough to justify a 9.4.1. Accordingly, the core committee has agreed to wrap releases the week after next; that's wrap Mon Feb 2 for public announcement Thu Feb 5.

Re: [HACKERS] Back-branch update releases scheduled

2015-01-22 Thread Peter Geoghegan
On Thu, Jan 22, 2015 at 3:23 PM, Tom Lane t...@sss.pgh.pa.us wrote: We're really rather overdue for updates of the pre-9.4 back branches, and 9.4 itself has probably baked for long enough to justify a 9.4.1. Accordingly, the core committee has agreed to wrap releases the week after next;

Re: [HACKERS] Using 128-bit integers for sum, avg and statistics aggregates

2015-01-22 Thread Andreas Karlsson
On 01/11/2015 02:36 AM, Andres Freund wrote: a) Afaics only __int128/unsigned __int128 is defined. See https://gcc.gnu.org/onlinedocs/gcc/_005f_005fint128.html b) I'm doubtful that AC_CHECK_TYPES is a sufficiently good test on all platforms. IIRC gcc will generate calls to functions to

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread Bruce Momjian
On Thu, Jan 22, 2015 at 10:48:37PM +0200, Heikki Linnakangas wrote: * If we need to protect hint bit updates from torn writes, WAL-log a * full page image of the page. This full page image is only necessary * if the hint bit update is the first change to the

Re: [HACKERS] Back-branch update releases scheduled

2015-01-22 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Thu, Jan 22, 2015 at 03:28:39PM -0800, Peter Geoghegan wrote: On Thu, Jan 22, 2015 at 3:23 PM, Tom Lane t...@sss.pgh.pa.us wrote: We're really rather overdue for updates of the pre-9.4 back branches, and 9.4 itself has probably baked for long enough to

Re: [HACKERS] Back-branch update releases scheduled

2015-01-22 Thread Peter Geoghegan
On Thu, Jan 22, 2015 at 3:51 PM, Tom Lane t...@sss.pgh.pa.us wrote: So let's get on with it. We're not holding up releases for patches that may or may not materialize. I don't disagree. Just pointing out that it's a consideration. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread Jim Nasby
On 1/22/15 5:43 PM, Bruce Momjian wrote: This brings up the other problem that the mod times of the files are likely to be different between master and slave --- should I recommend to only use rsync --checksum? I don't think so. AIUI if the timestamps are different the very next thing it does

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread Andres Freund
On 2015-01-22 14:20:51 -0500, Bruce Momjian wrote: It is possible to upgrade on pg_upgrade on streaming standby servers by making them master servers, running pg_upgrade on them, then shuting down all servers and using rsync to make the standby servers match the real master. Isn't that a

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-01-22 Thread Josh Berkus
On 01/22/2015 02:09 PM, David Johnston wrote: ​The proposal provides for SQL access to all possible sources of variable value setting and, ideally, a means of ordering them in priority order, so that a search for TimeZone would return two records, one for postgresql.auto.conf and one for

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread Bruce Momjian
On Thu, Jan 22, 2015 at 06:04:24PM -0600, Jim Nasby wrote: On 1/22/15 5:43 PM, Bruce Momjian wrote: This brings up the other problem that the mod times of the files are likely to be different between master and slave --- should I recommend to only use rsync --checksum? I don't think so. AIUI

[HACKERS] Minor issues with code comments related to abbreviated keys

2015-01-22 Thread Peter Geoghegan
Attached patch fixes minor issues in code comments that relate to abbreviated keys. -- Peter Geoghegan diff --git a/src/backend/utils/adt/varlena.c b/src/backend/utils/adt/varlena.c index c79b641..cfa1921 100644 --- a/src/backend/utils/adt/varlena.c +++ b/src/backend/utils/adt/varlena.c @@

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread Bruce Momjian
On Fri, Jan 23, 2015 at 01:19:33AM +0100, Andres Freund wrote: On 2015-01-22 14:20:51 -0500, Bruce Momjian wrote: It is possible to upgrade on pg_upgrade on streaming standby servers by making them master servers, running pg_upgrade on them, then shuting down all servers and using rsync to

Re: [HACKERS] tracking commit timestamps

2015-01-22 Thread Petr Jelinek
On 05/01/15 17:50, Petr Jelinek wrote: On 05/01/15 16:17, Petr Jelinek wrote: On 05/01/15 07:28, Fujii Masao wrote: On Thu, Dec 4, 2014 at 12:08 PM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Dec 3, 2014 at 11:54 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Pushed with some extra

Re: [HACKERS] Proposal: knowing detail of config files via SQL

2015-01-22 Thread Jim Nasby
On 1/22/15 11:13 AM, Sawada Masahiko wrote: Hi, As per discussion http://www.postgresql.org/message-id/cad21aodkds8oqbr199wwrcp7fidvow6bbb+cgdwqhuf+gx_...@mail.gmail.com, I would like to proposal new view like pg_file_settings to know detail of config file via SQL. - Background In 9.4

[HACKERS] pg_upgrade and rsync

2015-01-22 Thread Bruce Momjian
It is possible to upgrade on pg_upgrade on streaming standby servers by making them master servers, running pg_upgrade on them, then shuting down all servers and using rsync to make the standby servers match the real master. However, Josh Berkus reported that he found that hint bits set on the

Re: [HACKERS] basebackups during ALTER DATABASE ... SET TABLESPACE ... not safe?

2015-01-22 Thread Alvaro Herrera
Andres Freund wrote: 2) Make movedb() (and possibly created(), not sure yet) use proper WAL logging and log the whole copied data. I think this is the right long term fix and would end up being much more reliable. But it either requires some uglyness during redo (creating nonexistant

Re: [HACKERS] proposal: plpgsql - Assert statement

2015-01-22 Thread Pavel Stehule
Hi here is updated patch 2015-01-21 23:28 GMT+01:00 Jim Nasby jim.na...@bluetreble.com: On 1/21/15 3:10 PM, Pavel Stehule wrote: is there some agreement on this behave of ASSERT statement? I would to assign last patch to next commitfest. Possible changes: * I would to simplify a

Re: [HACKERS] Windows buildfarm animals are still not happy with abbreviated keys patch

2015-01-22 Thread Robert Haas
On Thu, Jan 22, 2015 at 11:28 AM, Robert Haas robertmh...@gmail.com wrote: This seems to have broken more stuff. My working hypothesis is that the culprit is here: /* * There is no special handling of the C locale here, unlike with * varstr_cmp(). strxfrm() is

Re: [HACKERS] collate test now failing

2015-01-22 Thread Robert Haas
On Thu, Jan 22, 2015 at 12:07 PM, Bruce Momjian br...@momjian.us wrote: Back to watching the buildfarm returns roll in... Does this explain the Windows failures too? The Windows machines have mostly been failing since the original abbreviated keys patch went in. See the message I just posted

Re: [HACKERS] collate test now failing

2015-01-22 Thread Kevin Grittner
Kevin Grittner kgri...@ymail.com wrote: I think this may have just started with: b529b65d1bf8537ca7fa024760a9782d7c8b66e5 Confirmed that I get a clean check on the prior commit. ubuntu 14.04 LTS -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --

Re: [HACKERS] collate test now failing

2015-01-22 Thread Robert Haas
On Thu, Jan 22, 2015 at 11:50 AM, Kevin Grittner kgri...@ymail.com wrote: Kevin Grittner kgri...@ymail.com wrote: I think this may have just started with: b529b65d1bf8537ca7fa024760a9782d7c8b66e5 Confirmed that I get a clean check on the prior commit. Can you check whether this fixes it?

Re: [HACKERS] Additional role attributes superuser review

2015-01-22 Thread Stephen Frost
Adam, all, * Adam Brightwell (adam.brightw...@crunchydatasolutions.com) wrote: After re-reading through this thread is seems like EXCLUSIVEBACKUP (proposed by Magnus) seemed to be a potentially acceptable alternative. I just chatted a bit on IRC w/ Magnus about this and I'm on-board with his

Re: [HACKERS] collate test now failing

2015-01-22 Thread Bruce Momjian
On Thu, Jan 22, 2015 at 12:04:14PM -0500, Robert Haas wrote: On Thu, Jan 22, 2015 at 11:53 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jan 22, 2015 at 11:50 AM, Kevin Grittner kgri...@ymail.com wrote: Kevin Grittner kgri...@ymail.com wrote: I think this may have just started with:

[HACKERS] collate test now failing

2015-01-22 Thread Kevin Grittner
I think this may have just started with: b529b65d1bf8537ca7fa024760a9782d7c8b66e5 -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company regression.diffs Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] Proposal: knowing detail of config files via SQL

2015-01-22 Thread Sawada Masahiko
Hi, As per discussion http://www.postgresql.org/message-id/cad21aodkds8oqbr199wwrcp7fidvow6bbb+cgdwqhuf+gx_...@mail.gmail.com, I would like to proposal new view like pg_file_settings to know detail of config file via SQL. - Background In 9.4 postgresql.auto.conf is added to support ALTER SYSTEM

Re: [HACKERS] Merging postgresql.conf and postgresql.auto.conf

2015-01-22 Thread Sawada Masahiko
On Thu, Jan 22, 2015 at 11:41 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Wed, Jan 21, 2015 at 9:43 PM, Sawada Masahiko sawada.m...@gmail.com wrote: On Wed, Jan 21, 2015 at 3:38 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Tue, Jan 20, 2015 at 9:38 PM, Robert Haas

Re: [HACKERS] Merging postgresql.conf and postgresql.auto.conf

2015-01-22 Thread Robert Haas
On Wed, Jan 21, 2015 at 1:32 AM, David Johnston david.g.johns...@gmail.com wrote: to make the whole thing work. Maybe it does all fit directly on pg_settings but tacking on some read-only columns to this updateable view/table doesn't come across as something that should be forbidden in

Re: [HACKERS] New CF app deployment

2015-01-22 Thread Alvaro Herrera
Hi, Thanks for the excellent work on the new commitfest app. It looks awesome so far, though I'm betting the commitfest manager is the one who reaps the most benefits. Wanted to highlight this request: Andres Freund wrote: What I'm also missing from the old app is that previously 'reviews'

Re: [HACKERS] BRIN range operator class

2015-01-22 Thread Alvaro Herrera
Can you please break up this patch? I think I see three patches, 1. add sql-callable functions such as inet_merge, network_overright, etc etc. These need documentation and a trivial regression test somewhere. 2. necessary changes to header files (skey.h etc) 3. the inclusion opclass itself

Re: [HACKERS] basebackups during ALTER DATABASE ... SET TABLESPACE ... not safe?

2015-01-22 Thread Jim Nasby
On 1/22/15 1:43 PM, Alvaro Herrera wrote: Andres Freund wrote: 2) Make movedb() (and possibly created(), not sure yet) use proper WAL logging and log the whole copied data. I think this is the right long term fix and would end up being much more reliable. But it either requires

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread Heikki Linnakangas
On 01/22/2015 09:20 PM, Bruce Momjian wrote: One question I have is whether hint bits are set by read-only transactions on standby servers. No. See comments in MarkBufferDirtyHint: /* * If we need to protect hint bit updates from torn writes, WAL-log a

Re: [HACKERS] Windows buildfarm animals are still not happy with abbreviated keys patch

2015-01-22 Thread Robert Haas
On Thu, Jan 22, 2015 at 1:00 PM, Peter Geoghegan p...@heroku.com wrote: On Thu, Jan 22, 2015 at 9:55 AM, Robert Haas robertmh...@gmail.com wrote: Stay tuned for more exciting dispatches from the department of abbreviated keys! I certainly suspected that we'd have problems with Windows, but

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread Jim Nasby
On 1/22/15 2:19 PM, Heikki Linnakangas wrote: On 01/22/2015 09:20 PM, Bruce Momjian wrote: One question I have is whether hint bits are set by read-only transactions on standby servers. No. See comments in MarkBufferDirtyHint: /* * If we need to protect hint bit updates

Re: [HACKERS] pg_upgrade and rsync

2015-01-22 Thread Heikki Linnakangas
On 01/22/2015 10:34 PM, Jim Nasby wrote: On 1/22/15 2:19 PM, Heikki Linnakangas wrote: On 01/22/2015 09:20 PM, Bruce Momjian wrote: One question I have is whether hint bits are set by read-only transactions on standby servers. No. See comments in MarkBufferDirtyHint: /*

Re: [HACKERS] Merging postgresql.conf and postgresql.auto.conf

2015-01-22 Thread Robert Haas
On Wed, Jan 21, 2015 at 1:38 AM, Amit Kapila amit.kapil...@gmail.com wrote: Now as I have suggested upthread, that we can have a new view pg_file_settings which will display information about settings even when there exists multiple entries for the same in different files. I think adding such

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2015-01-22 Thread Alvaro Herrera
Here's v23. I reworked a number of things. First, I changed trivial stuff like grouping all the vacuuming options in a struct, to avoid passing an excessive number of arguments to functions. full, freeze, analyze_only, and_analyze and verbose are all in a single struct now. Also, the

Re: [HACKERS] Windows buildfarm animals are still not happy with abbreviated keys patch

2015-01-22 Thread Robert Haas
On Thu, Jan 22, 2015 at 12:17 PM, Robert Haas robertmh...@gmail.com wrote: Long story short: this was broken. It may be that when the dust settles we can try re-enabling this on Windows. It might work now that this issue is (hopefully) fixed. Uggh. That still wasn't right; I've pushed

Re: [HACKERS] Merging postgresql.conf and postgresql.auto.conf

2015-01-22 Thread Robert Haas
On Wed, Jan 21, 2015 at 11:13 AM, Sawada Masahiko sawada.m...@gmail.com wrote: I think this new view is updated only when postmaster received SIGHUP or is started. And we can have new function like pg_update_file_setting() which updates this view. I really don't think the postmaster should be

Re: [HACKERS] Windows buildfarm animals are still not happy with abbreviated keys patch

2015-01-22 Thread Peter Geoghegan
On Thu, Jan 22, 2015 at 9:55 AM, Robert Haas robertmh...@gmail.com wrote: Stay tuned for more exciting dispatches from the department of abbreviated keys! I certainly suspected that we'd have problems with Windows, but nothing this bad. -- Peter Geoghegan -- Sent via pgsql-hackers mailing

Re: [HACKERS] basebackups during ALTER DATABASE ... SET TABLESPACE ... not safe?

2015-01-22 Thread Andres Freund
On 2015-01-22 14:42:18 -0600, Jim Nasby wrote: On 1/22/15 1:43 PM, Alvaro Herrera wrote: Andres Freund wrote: 2) Make movedb() (and possibly created(), not sure yet) use proper WAL logging and log the whole copied data. I think this is the right long term fix and would end up being

Re: [HACKERS] jsonb, unicode escapes and escaped backslashes

2015-01-22 Thread Noah Misch
On Wed, Jan 21, 2015 at 06:51:34PM -0500, Andrew Dunstan wrote: The following case has just been brought to my attention (look at the differing number of backslashes): andrew=# select jsonb '\\u'; jsonb -- \u (1 row) andrew=# select jsonb

Re: [HACKERS] B-Tree support function number 3 (strxfrm() optimization)

2015-01-22 Thread David Rowley
On 20 January 2015 at 17:10, Peter Geoghegan p...@heroku.com wrote: On Mon, Jan 19, 2015 at 7:47 PM, Michael Paquier michael.paqu...@gmail.com wrote: With your patch applied, the failure with MSVC disappeared, but there is still a warning showing up: (ClCompile target) -