I have left out SECURITY LABEL which would require a special security
label provider. [...]
You can add tests in src/test/modules/dummy_seclabel.
Thanks for the pointer, I have indeed missed these special tests. I'll
have a look.
--
Fabien.
--
Sent via pgsql-hackers mailing list
Fabien COELHO wrote:
Here are some more tests for event triggers, especially about new features
introduced recently in 296f3a6053844089bc533630fffafaba8f016384.
Check that COMMENT, GRANT and REVOKE do trigger some events.
The patch also check some more error cases: SQL function,
On 02/13/2015 06:17 PM, Teodor Sigaev wrote:
Now that the input data type and leaf data type can be different, which one is
attType? It's the leaf data type, as the patch stands. I renamed that to
attLeafType, and went fixing all the references to it. In most places it's just
a matter of search
Hi all,
Coverity is pointing out that addRangeTableEntry contains the
following code path that does a NULL-pointer check on pstate:
if (pstate != NULL)
pstate-p_rtable = lappend(pstate-p_rtable, rte);
But pstate is dereferenced before in isLockedRefname when grabbing the
Hi Tom,
EBCDIC isn't strictly mandatory, but it is the lingua franca of
mainframes, so for most applications not running EBCDIC would result in
constant translation between EBCDIC and ASCII, which can become a
performance issue. The platform does support ASCII and Unicode, but in
most cases
Hello Andres,
So I have a question: is there a particular reason why arguments were not
provided in the first place?
Yea. The existing trigger argument mechanims is extremely odd
implementation wise - they don't have real datatypes and aren't passed
via the normal parameter passing
Hi,
When working with the autoconf rule for detecting __int128 I noticed we
get a lot of warnings like the below in the autconf trace output so I
decided to clean them up. All the macros we get complaints about seems
to have been made obsolete between 2000 and 2003, and since we have a
You can add tests in src/test/modules/dummy_seclabel.
Patch attached to test sec label there, in addition to the other more
standard checks in event_trigger.
--
Fabien.diff --git a/src/test/modules/dummy_seclabel/expected/dummy_seclabel.out
Tom == Tom Lane t...@sss.pgh.pa.us writes:
So while helping someone with an unrelated issue, I did a quick
query to look for collation-dependent indexes, and was rather
shocked to find that not only are there two such in the system
catalogs, both set to default collation, but that one of
Andrew Gierth and...@tao11.riddles.org.uk writes:
So while helping someone with an unrelated issue, I did a quick query to
look for collation-dependent indexes, and was rather shocked to find
that not only are there two such in the system catalogs, both set to
default collation, but that one
On 02/25/2015 06:59 PM, Joe Conway wrote:
I doubt we want to rip it out without some suitable replacement -- do we?
No, probably not. I think there are a few options:
0. Find out that the current situation is OK, and the Artistic license
is not a problem the way the code is used.
1. Ask
On Mon, Jan 5, 2015 at 10:37 AM, Fabien COELHO coe...@cri.ensmp.fr wrote:
Anyway, I suggest to keep that for another round and keep the Robert's
isofunctional patch as it is before extending.
+1. Let's please get the basic thing committed, and then people can
write more patches to extend
So while helping someone with an unrelated issue, I did a quick query to
look for collation-dependent indexes, and was rather shocked to find
that not only are there two such in the system catalogs, both set to
default collation, but that one of them is in a _shared_ catalog
(pg_shseclabel).
How
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 02/24/2015 04:47 AM, Dave Page wrote:
On Tue, Feb 24, 2015 at 12:24 PM, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
contrib/fuzzystrmatch/dmetaphone.c says this:
/* COPYRIGHT NOTICES
***
Gord Tomlin gord.tom...@sympatico.ca writes:
EBCDIC doesn't always have to be a show stopper. There are plenty of
applications that have been ported successfully, and a few (notably
Python) that haven't gone so well. An easy way to get burned is to make
ASCII-centric assumptions about
On 02/24/2015 12:13 AM, Amit Langote wrote:
Here is an experimental patch that attempts to implement this.
This looks awesome. I would love to have it for 9.5, but I guess the
patch isn't nearly baked enough for that?
It implements the following syntax:
* Syntax for defining partition key:
On 02/25/2015 03:13 AM, Thom Brown wrote:
Can you think of a reasonable syntax for doing that via operators? I
can imagine that as a json_path function, i.e.:
jsonb_add_to_path(jsonb, text[], jsonb)
or where the end of the path is an array:
jsonb_add_to_path(jsonb,
Hi David,
I've been looking at this patch, mostly because it seems like a great
starting point for improving estimation for joins on multi-column FKs.
Currently we do this:
CREATE TABLE parent (a INT, b INT, PRIMARY KEY (a,b));
CREATE TABLE child (a INT, b INT, FOREIGN KEY (a,b)
Tom Lane wrote:
Andrew Gierth and...@tao11.riddles.org.uk writes:
So while helping someone with an unrelated issue, I did a quick query to
look for collation-dependent indexes, and was rather shocked to find
that not only are there two such in the system catalogs, both set to
default
Alvaro Herrera alvhe...@2ndquadrant.com writes:
Tom Lane wrote:
Andrew Gierth and...@tao11.riddles.org.uk writes:
How did that happen? And how could it possibly work?
It probably doesn't, and the reason nobody has noticed is that the
security label stuff has fewer users than I have fingers
Tom Lane wrote:
Alvaro Herrera alvhe...@2ndquadrant.com writes:
Tom Lane wrote:
Andrew Gierth and...@tao11.riddles.org.uk writes:
How did that happen? And how could it possibly work?
It probably doesn't, and the reason nobody has noticed is that the
security label stuff has fewer
* Peter Eisentraut (pete...@gmx.net) wrote:
On 12/29/14 7:16 PM, Adam Brightwell wrote:
Given this discussion, I have attached a patch that removes CATUPDATE
for review/discussion.
One of the interesting behaviors (or perhaps not) is how
'pg_class_aclmask' handles an invalid role id
On 2015-02-25 12:08:32 -0500, Tom Lane wrote:
Andrew Gierth and...@tao11.riddles.org.uk writes:
So while helping someone with an unrelated issue, I did a quick query to
look for collation-dependent indexes, and was rather shocked to find
that not only are there two such in the system
On 24.2.2015 19:08, Jim Nasby wrote:
On 2/22/15 8:32 PM, Tomas Vondra wrote:
On 23.2.2015 03:20, Jim Nasby wrote:
On 2/22/15 5:41 PM, Tomas Vondra wrote:
Otherwise, the code looks OK to me. Now, there are a few features I'd
like to have for production use (to minimize the impact):
1) no
Andres Freund and...@2ndquadrant.com writes:
On 2015-02-25 12:08:32 -0500, Tom Lane wrote:
The most obvious fix is to change provider to a NAME column.
Yea. I'm not sure why that wasn't done initially. I can't really see the
length be an issue. How about we add an error check enforcing ascii,
On 2015-02-25 15:59:55 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
On 2015-02-25 12:08:32 -0500, Tom Lane wrote:
The most obvious fix is to change provider to a NAME column.
Yea. I'm not sure why that wasn't done initially. I can't really see the
length be an
On Wed, Feb 25, 2015 at 3:26 AM, Andres Freund and...@2ndquadrant.com wrote:
I'm pretty sure this will entirely fail if you have a transaction that's
large enough to spill to disk. Calling ReorderBufferIterTXNNext() will
reuse the memory for the in memory changes.
It's also borked because it
Could the large allocation[2] for the dead tuple array in
lazy_space_alloc cause problems with linux OOM? [1] and some other
things I've read indicate that a large mmap will count towards total
system memory, including producing a failure if overcommit is disabled.
Would it be worth avoiding
On 02/25/2015 11:59 AM, Joe Conway wrote:
It's largely because of such uncertainties that I have been advised
in the past (by those with appropriate letters after their names)
to stop using the Artistic licence. This is why I spent nearly a
year working on changing pgAdmin to the PostgreSQL
On 20 February 2015 at 20:44, Tom Lane t...@sss.pgh.pa.us wrote:
Well, assuming that we're satisfied with just having a way to warn
when the behavior changed (and not, in particular, a switch that can
select old or new behavior)
I'm in favour of your proposed improvements, but I'm having a
On 2/19/15 4:11 AM, Andres Freund wrote:
Thoughts? Can't say that I've given conflict resolution for
multi-master systems a great deal of thought before now, so I might be
quite off the mark here.
I don't think conflict resolution actually plays a role here. This is
about consistency inside a
Mark Kirkwood wrote:
On 26/02/15 13:32, Simon Riggs wrote:
On 25 February 2015 at 23:30, Jim Nasby jim.na...@bluetreble.com wrote:
That said, I don't want to block this; I think it's useful. Though, perhaps
it would be better as an extension instead of in contrib? I don't think it
should be
Dean, Etsuro,
* Dean Rasheed (dean.a.rash...@gmail.com) wrote:
On 18 February 2015 at 16:22, Stephen Frost sfr...@snowman.net wrote:
Here's the patch against master. I'm still fiddling with the comment
wording and the commit message a bit, but barring objections these
patches are what I'm
On 26-02-2015 AM 10:31, Jim Nasby wrote:
On 2/25/15 7:24 PM, Amit Langote wrote:
Does ALTER TABLE parent_monthly_x_201401 ADD COLUMN foo still
operate the same as today? I'd like to see us continue to support that,
but perhaps it would be wise to not paint ourselves into that corner
just
On Tue, Feb 24, 2015 at 1:29 AM, David Steele da...@pgmasters.net wrote:
On 2/18/15 10:25 AM, David Steele wrote:
On 2/18/15 6:11 AM, Fujii Masao wrote:
The pg_audit doesn't log BIND parameter values when prepared statement is
used.
Seems this is an oversight of the patch. Or is this
Thanks all. I opened an issue in GitHub
(https://github.com/vmware/pg_rewind/issues/43). Sorry for posting to the
wrong spot. I found some discussions on pg_rewind on this list, so I thought
it was the appropriate place to send my questions.
Thanks, Steve
From: Michael Paquier
* Peter Eisentraut (pete...@gmx.net) wrote:
On 2/25/15 3:39 PM, Stephen Frost wrote:
I'd get rid of that whole check, not just replace rolcatupdate by rolsuper.
Err, wouldn't this make it possible to grant normal users the ability to
modify system catalogs? I realize that they wouldn't
On 2/25/15 3:39 PM, Stephen Frost wrote:
I'd get rid of that whole check, not just replace rolcatupdate by rolsuper.
Err, wouldn't this make it possible to grant normal users the ability to
modify system catalogs? I realize that they wouldn't have that
initially, but I'm not sure we want
On 26-02-2015 AM 05:15, Josh Berkus wrote:
On 02/24/2015 12:13 AM, Amit Langote wrote:
Here is an experimental patch that attempts to implement this.
This looks awesome.
Thanks!
I would love to have it for 9.5, but I guess the
patch isn't nearly baked enough for that?
I'm not quite
Hello,
I have the following table:
\d a
Table phxconfig.a
Column | Type | Modifiers
---+-+---
phx_run_id| integer |
cell_id | integer |
Indexes:
a_phx_run_id_cell_id_idx btree (phx_run_id, cell_id)
When I use a min() query I get
On 2/24/15 1:23 AM, Michael Paquier wrote:
On Mon, Feb 23, 2015 at 9:31 PM, Robert Haas robertmh...@gmail.com
mailto:robertmh...@gmail.com wrote:
On Feb 22, 2015, at 5:41 AM, Michael Paquier michael.paqu...@gmail.com
mailto:michael.paqu...@gmail.com wrote:
This is up to the
On 25 February 2015 at 23:30, Jim Nasby jim.na...@bluetreble.com wrote:
That said, I don't want to block this; I think it's useful. Though, perhaps
it would be better as an extension instead of in contrib? I don't think it
should be very version dependent?
The whole point of this is to get it
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
Tom Lane wrote:
Alvaro Herrera alvhe...@2ndquadrant.com writes:
Tom Lane wrote:
Andrew Gierth and...@tao11.riddles.org.uk writes:
How did that happen? And how could it possibly work?
It probably doesn't, and the reason nobody has
On 2/24/15 2:13 AM, Amit Langote wrote:
-- a plain table
CREATE TABLE parent_monthly(year int, month int, day int);
-- a partitioned table
-- x: number of partitions
CREATE TABLE parent_monthly_x(LIKE parent_monthly) PARTITION BY
RANGE ON(year, month);
To be clear, in this example
On 2/25/15 5:47 PM, Stephen Frost wrote:
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
Tom Lane wrote:
Alvaro Herrera alvhe...@2ndquadrant.com writes:
Tom Lane wrote:
Andrew Gierth and...@tao11.riddles.org.uk writes:
How did that happen? And how could it possibly work?
It probably
On 2/25/15 7:24 PM, Amit Langote wrote:
Does ALTER TABLE parent_monthly_x_201401 ADD COLUMN foo still
operate the same as today? I'd like to see us continue to support that,
but perhaps it would be wise to not paint ourselves into that corner
just yet.
Nothing prevents that from working, at
On 2/25/15 2:56 PM, Tomas Vondra wrote:
On 24.2.2015 19:08, Jim Nasby wrote:
On 2/22/15 8:32 PM, Tomas Vondra wrote:
On 23.2.2015 03:20, Jim Nasby wrote:
On 2/22/15 5:41 PM, Tomas Vondra wrote:
Otherwise, the code looks OK to me. Now, there are a few features I'd
like to have for production
On 02/23/2015 08:56 AM, Heikki Linnakangas wrote:
Everyone seems to be happy with the names and behaviour of the GUCs, so
committed.
Yay!
But ... I thought we were going to raise the default for max_wal_size to
something much higher, like 1GB? That's what was discussed on this thread.
When I
* Jim Nasby (jim.na...@bluetreble.com) wrote:
On 2/25/15 4:10 PM, Andrew Dunstan wrote:
On 02/25/2015 11:59 AM, Joe Conway wrote:
It's largely because of such uncertainties that I have been advised
in the past (by those with appropriate letters after their names)
to stop using the
Hi,
I tried to do an initdb with the patch applied, and seems there's a bug
somewhere in analyzejoins.c:
tomas@rimmer ~ $ pg_ctl -D tmp/pg-unidata init
The files belonging to this database system will be owned by user tomas.
This user must also own the server process.
The database cluster will
On 26/02/15 13:32, Simon Riggs wrote:
On 25 February 2015 at 23:30, Jim Nasby jim.na...@bluetreble.com wrote:
That said, I don't want to block this; I think it's useful. Though, perhaps
it would be better as an extension instead of in contrib? I don't think it
should be very version dependent?
On 2/25/15 4:10 PM, Andrew Dunstan wrote:
On 02/25/2015 11:59 AM, Joe Conway wrote:
It's largely because of such uncertainties that I have been advised
in the past (by those with appropriate letters after their names)
to stop using the Artistic licence. This is why I spent nearly a
year
On 26-02-2015 AM 09:28, Jim Nasby wrote:
On 2/24/15 2:13 AM, Amit Langote wrote:
-- a plain table
CREATE TABLE parent_monthly(year int, month int, day int);
-- a partitioned table
-- x: number of partitions
CREATE TABLE parent_monthly_x(LIKE parent_monthly) PARTITION BY
RANGE
On 26-02-2015 AM 10:24, Amit Langote wrote:
To clarify things a bit more, transformCreateStmt() transforms PARTITION
OF into LIKE INCLUDING ALL, not INHERITS. And as mentioned, for Append
to work, I have made ATExecAddInherit() to do some of the things
ATExecAttachPartition() does. Again, that
On 02/25/2015 06:44 PM, Jim Nasby wrote:
On 2/25/15 4:10 PM, Andrew Dunstan wrote:
On 02/25/2015 11:59 AM, Joe Conway wrote:
It's largely because of such uncertainties that I have been advised
in the past (by those with appropriate letters after their names)
to stop using the Artistic
Dean,
* Dean Rasheed (dean.a.rash...@gmail.com) wrote:
Here's an updated patch with a new test for this bug. I've been
developing the fixes for these RLS issues as one big patch, but I
suppose it would be easy to split up, if that's preferred.
Thanks for working on all of this!
I've brought
Dean,
* Dean Rasheed (dean.a.rash...@gmail.com) wrote:
Attached is a patch to make RLS checks run before attempting to
insert/update any data rather than afterwards.
Excellent, this I really like and it's a pretty straight-forward change.
I wonder if there are some documentation updates which
Fujii Masao wrote:
On Tue, Feb 24, 2015 at 1:29 AM, David Steele da...@pgmasters.net wrote:
1) Follow Oracle's as session option and only log each statement type
against an object the first time it happens in a session. This would
greatly reduce logging, but might be too little detail.
Robert, all,
* Stephen Frost (sfr...@snowman.net) wrote:
* Robert Haas (robertmh...@gmail.com) wrote:
I happened to notice this morning while hacking that the
hasRowSecurity fields added to PlannerGlobal and PlannedStmt have
not been given proper nodefuncs.c support. Both need to be added
On Wed, Feb 25, 2015 at 4:27 AM, Peter Eisentraut pete...@gmx.net wrote:
On 2/23/15 1:27 AM, Michael Paquier wrote:
I would like to have an extension in tree that also does this, so we
have a regression test of this functionality.
Sure. Here is one in the patch attached added as a test
On Thu, Feb 26, 2015 at 1:40 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Fujii Masao wrote:
On Tue, Feb 24, 2015 at 1:29 AM, David Steele da...@pgmasters.net wrote:
1) Follow Oracle's as session option and only log each statement type
against an object the first time it happens in a
On Wed, Jan 14, 2015 at 11:04 AM, Ali Akbar the.ap...@gmail.com wrote:
2014-12-18 19:35 GMT+07:00 Fujii Masao masao.fu...@gmail.com:
On Mon, Dec 15, 2014 at 2:38 PM, Andrew Gierth
and...@tao11.riddles.org.uk wrote:
I was thinking something like this, added just after that para:
On 2015-02-25 10:43:57 +0100, Fabien COELHO wrote:
While looking at event triggers, I noticed that, contrary to basic triggers,
arguments are not allowed.
However, the example in the documentation with an hour-based filtering of
ddl commands suggest some handling of arguments would be
On 25.2.2015 10:20, Alexander Korotkov wrote:
On Tue, Feb 24, 2015 at 5:15 PM, Tomas Vondra
tomas.von...@2ndquadrant.com mailto:tomas.von...@2ndquadrant.com wrote:
I hoped lowering the fillfactor will improve this, but
fillfactor=75 had pretty much no effect in this case. Is that
expected
While looking at event triggers, I noticed that, contrary to basic
triggers, arguments are not allowed.
However, the example in the documentation with an hour-based filtering of
ddl commands suggest some handling of arguments would be useful so as to
allow more generic event triggers.
So
On 24 February 2015 at 18:51, Heikki Linnakangas
hlinnakan...@vmware.com wrote:
On 02/20/2015 05:21 PM, Andres Freund wrote:
In the attached patch I've merged compact/noncompact code, made aborts
use similar logic to avoid including useless bytes and used both for the
2pc equivalents.
+1
Here are some more tests for event triggers, especially about new features
introduced recently in 296f3a6053844089bc533630fffafaba8f016384.
Check that COMMENT, GRANT and REVOKE do trigger some events.
The patch also check some more error cases: SQL function, functions with
declared arguments,
On 25/02/15 00:42, Peter Geoghegan wrote:
On Tue, Feb 24, 2015 at 4:32 PM, Jeremy Harris j...@wizmail.org wrote:
On 23/02/15 16:40, Tomas Vondra wrote:
On 22.2.2015 22:30, Peter Geoghegan wrote:
You should try it with the data fully sorted like this, but with one
tiny difference: The very
Hi!
On Tue, Feb 24, 2015 at 5:39 PM, Tomas Vondra tomas.von...@2ndquadrant.com
wrote:
On 17.2.2015 14:21, Alexander Korotkov wrote:
On Sun, Feb 15, 2015 at 2:08 PM, Alexander Korotkov
aekorot...@gmail.com mailto:aekorot...@gmail.com wrote:
Revised patch with reordering in GiST is
On 24-02-2015 PM 05:13, Amit Langote wrote:
On 21-01-2015 PM 07:26, Amit Langote wrote:
Ok, I will limit myself to focusing on following things at the moment:
* Provide syntax in CREATE TABLE to declare partition key
* Provide syntax in CREATE TABLE to declare a table as partition of a
On Tue, Feb 24, 2015 at 5:15 PM, Tomas Vondra tomas.von...@2ndquadrant.com
wrote:
I hoped lowering the fillfactor will improve this, but fillfactor=75 had
pretty much no effect in this case. Is that expected for this kind of
workload? I see the previous discussion talked about random updates,
Hi,
On 2015-02-24 20:51:42 +0200, Heikki Linnakangas wrote:
On 02/20/2015 05:21 PM, Andres Freund wrote:
To avoid using more space in the compact case the 'xinfo' field
indicating the presence of further data is only included when a byte in
the xl_info flag is set (similar to what heap rmgr
On 24 February 2015 at 19:16, Josh Berkus j...@agliodbs.com wrote:
Is there a way to take the json:
'{a: 1, b: 2, c: {type: json, stuff: test}, d:
[aa,bb,cc,dd]}'
and add ee to d without replacing it? I can think of ways of
currently doing it, but it's very convoluted just for
A patch is attached, and the issue has been spotted by Coverity.
Regards,
Thanks, committed.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot
Hi,
Well, that implies that we'd actually know that we'd succeed when WAL
logging the speculative heap tuple's insertion. We literally have no
way of knowing if that's the case at that point, though - that's just
the nature of value locking scheme #2's optimistic approach.
Attached
75 matches
Mail list logo
