Re: [HACKERS] Perf Benchmarking and regression.

2016-05-12 Thread Ashutosh Sharma
Hi, Please find the test results for the following set of combinations taken at 128 client counts: *1)* *Unpatched master, default *_flush_after :* TPS = 10925.882396 *2) Unpatched master, *_flush_after=0 :* TPS = 18613.343529 *3)* *That line removed with #if 0, default *_flush_after :* TPS

Re: [HACKERS] Error during restore - dump taken with pg_dumpall -c option

2016-05-12 Thread Fabrízio de Royes Mello
Em quinta-feira, 12 de maio de 2016, Rushabh Lathia < rushabh.lat...@gmail.com> escreveu: > > On master branch when we do pg_dumpall with -c option, I can see that > it also dumping the "DROP ROLE pg_signal_backend", which seems wrong. > Because when you restore the dump, its throwing an error >

Re: [HACKERS] Incremental refresh of materialized view - Patch

2016-05-12 Thread Kevin Grittner
On Thu, May 12, 2016 at 1:05 AM, hari.prasath wrote: > However if the same methods in matview.c > OpenMatViewIncrementalMaintenance & CloseMatViewIncrementalMaintenance are > mad extern its possible to do DML from the patches like i am building now. > > Is

Re: [HACKERS] Perf Benchmarking and regression.

2016-05-12 Thread Robert Haas
On Thu, May 12, 2016 at 8:39 AM, Ashutosh Sharma wrote: > Please find the test results for the following set of combinations taken at > 128 client counts: > > 1) Unpatched master, default *_flush_after : TPS = 10925.882396 > > 2) Unpatched master, *_flush_after=0 : TPS =

Re: [HACKERS] Perf Benchmarking and regression.

2016-05-12 Thread Robert Haas
On Thu, May 12, 2016 at 11:13 AM, Andres Freund wrote: > Could you run this one with a number of different backend_flush_after > settings? I'm suspsecting the primary issue is that the default is too low. What values do you think would be good to test? Maybe provide 3 or 4

Re: [HACKERS] Academic help for Postgres

2016-05-12 Thread Michael Banck
On Thu, May 12, 2016 at 08:57:34AM +0800, Craig Ringer wrote: > On 11 May 2016 at 22:20, Bruce Momjian wrote: > > I am giving a keynote at an IEEE database conference in Helsinki next > > week (http://icde2016.fi/). (Yes, I am not attending PGCon Ottawa > > because I accepted

Re: [HACKERS] Perf Benchmarking and regression.

2016-05-12 Thread Andres Freund
On 2016-05-12 10:49:06 -0400, Robert Haas wrote: > On Thu, May 12, 2016 at 8:39 AM, Ashutosh Sharma > wrote: > > Please find the test results for the following set of combinations taken at > > 128 client counts: > > > > 1) Unpatched master, default *_flush_after : TPS =

Re: [HACKERS] Change error code for hstore syntax error

2016-05-12 Thread Robert Haas
On Mon, May 9, 2016 at 1:42 PM, Sherrylyn Branchaw wrote: > I'm attaching a revised patch; please let me know if there are any other > issues before I submit to the commitfest. Submitting to the CommitFest is how you make sure that someone looks at the patch to see if any

Re: [HACKERS] Perf Benchmarking and regression.

2016-05-12 Thread Andres Freund
On 2016-05-12 11:27:31 -0400, Robert Haas wrote: > On Thu, May 12, 2016 at 11:13 AM, Andres Freund wrote: > > Could you run this one with a number of different backend_flush_after > > settings? I'm suspsecting the primary issue is that the default is too low. > > What values

Re: [HACKERS] [sqlsmith] Failed assertion in parallel worker (ExecInitSubPlan)

2016-05-12 Thread Tom Lane
Robert Haas writes: > I could be wrong, but I thought that the target list for an expression > would always contain only Vars at this stage. Non-default tlists get > injected at the end of scan/join planning. Am I wrong? Target list for a relation, you mean? See

Re: [HACKERS] Change error code for hstore syntax error

2016-05-12 Thread Robert Haas
On Thu, May 12, 2016 at 11:46 AM, Sherrylyn Branchaw wrote: > Understood. It's just that Tom had already replied, so I wanted to give him > first crack at it, if, say, I had grossly misinterpreted his suggestions. > The guide on submitting a patch advises taking silence as

Re: [HACKERS] Minor documentation patch

2016-05-12 Thread Peter Eisentraut
On 5/11/16 7:00 AM, Martín Marqués wrote: Yesterday I was going over some consultancy and went to check some syntax for CREATE FUNCTION, particularly related to SECURITY DEFINER part. Reading there I saw a paragraph which had a sentence that wasn't very clear at first. The patch's description

Re: [HACKERS] [COMMITTERS] pgsql: Add TAP tests for pg_dump

2016-05-12 Thread Robert Haas
On Mon, May 9, 2016 at 11:58 AM, Stephen Frost wrote: > Further, this test framework was under discussion on-list and commented > on by at least one other committer prior to being committed. It was not > entirely without review. No, just almost entirely without review. --

Re: [HACKERS] Perf Benchmarking and regression.

2016-05-12 Thread Andres Freund
Hi, On 2016-05-12 18:09:07 +0530, Ashutosh Sharma wrote: > Please find the test results for the following set of combinations taken at > 128 client counts: Thanks. > *1)* *Unpatched master, default *_flush_after :* TPS = 10925.882396 Could you run this one with a number of different

Re: [HACKERS] "Allow usage of huge maintenance_work_mem for GIN build" patch

2016-05-12 Thread Robert Haas
On Fri, May 6, 2016 at 7:58 PM, Peter Geoghegan wrote: > I noticed that commit 30bb26b5 ("Allow usage of huge > maintenance_work_mem for GIN build") made the following modification: > > --- a/src/include/access/gin_private.h > +++ b/src/include/access/gin_private.h > @@ -903,7

Re: [HACKERS] [sqlsmith] Failed assertion in parallel worker (ExecInitSubPlan)

2016-05-12 Thread Robert Haas
On Thu, May 12, 2016 at 7:46 AM, Amit Kapila wrote: > On further analysis, I think I know what is going on in the original bug > report. We add the Vars (build_base_rel_tlists) and PlaceholderVars > (add_placeholders_to_base_rels()) to each relations (RelOptInfo) target

Re: [HACKERS] Change error code for hstore syntax error

2016-05-12 Thread Sherrylyn Branchaw
Submitting to the CommitFest is how you make sure that someone looks at the patch to see if any issues exist. Obviously, if someone reviews before then, that's great, but you can't count on it. Understood. It's just that Tom had already replied, so I wanted to give him first crack at it, if,

Re: [HACKERS] Use %u to print user mapping's umid and userid

2016-05-12 Thread Tom Lane
Robert Haas writes: > My suggestion is that we switch from using a List to marshal the data > to using an ExtensibleNode. An advantage of that is that we'd have > some in-core test coverage for the ExtensibleNode stuff. In theory it > ought to be simpler and less messy,

Re: [HACKERS] alter table alter column ... (larger type) ... when there are dependent views

2016-05-12 Thread Robert Haas
On Tue, May 10, 2016 at 11:22 PM, Tom Lane wrote: > You should look at the code in ALTER TABLE that tries to rebuild index > definitions during ALTER COLUMN TYPE, and see if that can be adapted > to updating views. I think the problems are almost entirely different. In the

Re: [HACKERS] Does Type Have = Operator?

2016-05-12 Thread Tom Lane
"David E. Wheeler" writes: > Some might argue that it ought to compare JSON objects, effectively be the > equivalent of ::jsonb = ::jsonb, rather than ::text = ::text. But as Andrew > points out to me offlist, “if that's what they want why aren't they using > jsonb in

Re: [HACKERS] Perf Benchmarking and regression.

2016-05-12 Thread Fabien COELHO
I'm getting increasingly unhappy about the checkpoint flush control. I saw major regressions on my parallel COPY test, too: Yes, I'm concerned too. A few thoughts: - focussing on raw tps is not a good idea, because it may be a lot of tps followed by a sync panic, with an unresponsive

Re: [HACKERS] alter table alter column ... (larger type) ... when there are dependent views

2016-05-12 Thread Tom Lane
Robert Haas writes: > On Tue, May 10, 2016 at 11:22 PM, Tom Lane wrote: >> You should look at the code in ALTER TABLE that tries to rebuild index >> definitions during ALTER COLUMN TYPE, and see if that can be adapted >> to updating views. > I think

Re: [HACKERS] Use %u to print user mapping's umid and userid

2016-05-12 Thread Robert Haas
On Thu, May 12, 2016 at 12:18 AM, Etsuro Fujita wrote: > I think if scanning a foreign join, the user mapping is still valid at > execution, and that is ensured by RevalidateChachedQuery, IIUC. Yes, we added special machinery for that, along the lines of what is also

Re: [HACKERS] Does Type Have = Operator?

2016-05-12 Thread Fabrízio de Royes Mello
On Wed, May 11, 2016 at 9:09 PM, David E. Wheeler wrote: > > On May 11, 2016, at 11:01 AM, Fabrízio de Royes Mello < fabriziome...@gmail.com> wrote: > > > I know... but you can do that just in case the current behaviour fail by cathing it with "begin...exception...", so

Re: [HACKERS] [sqlsmith] Failed assertion in parallel worker (ExecInitSubPlan)

2016-05-12 Thread Robert Haas
On Thu, May 12, 2016 at 11:48 AM, Tom Lane wrote: > Robert Haas writes: >> I could be wrong, but I thought that the target list for an expression >> would always contain only Vars at this stage. Non-default tlists get >> injected at the end of

Re: [HACKERS] Does Type Have = Operator?

2016-05-12 Thread David E. Wheeler
On May 12, 2016, at 11:19 AM, Fabrízio de Royes Mello wrote: > Yeah.. it's ugly but you can do something like that: I could, but I won’t, since this is pgTAP and users of the library might have defined their own json operators. Andrew Dunstan has done the yeoman’s

Re: [HACKERS] Use %u to print user mapping's umid and userid

2016-05-12 Thread Robert Haas
On Thu, May 12, 2016 at 2:29 PM, Alvaro Herrera wrote: > Robert Haas wrote: >> My suggestion is that we switch from using a List to marshal the data >> to using an ExtensibleNode. An advantage of that is that we'd have >> some in-core test coverage for the

Re: [HACKERS] Use %u to print user mapping's umid and userid

2016-05-12 Thread Alvaro Herrera
Robert Haas wrote: > My suggestion is that we switch from using a List to marshal the data > to using an ExtensibleNode. An advantage of that is that we'd have > some in-core test coverage for the ExtensibleNode stuff. In theory it > ought to be simpler and less messy, too, but I guess we'll

Re: [HACKERS] [sqlsmith] Failed assertion in parallel worker (ExecInitSubPlan)

2016-05-12 Thread Tom Lane
Robert Haas writes: >> Target list for a relation, you mean? See relation.h: >> >> * reltarget - Default Path output tlist for this rel; normally contains >> * Var and PlaceHolderVar nodes for the values we need to >> * output from

[HACKERS] Error during restore - dump taken with pg_dumpall -c option

2016-05-12 Thread Rushabh Lathia
On master branch when we do pg_dumpall with -c option, I can see that it also dumping the "DROP ROLE pg_signal_backend", which seems wrong. Because when you restore the dump, its throwing an error "ERROR: cannot drop role pg_signal_backend because it is required by the database system".

[HACKERS] NULL concatenation

2016-05-12 Thread Sridhar N Bamandlapally
Hi In migration, am facing issue with NULL concatenation in plpgsql, by concatenating NULL between any where/position to Text / Varchar, the total string result is setting value to NULL *In Oracle:* declare txt1 VARCHAR2(100) := 'ABCD'; txt2 VARCHAR2(100) := NULL; txt3

Re: [HACKERS] Declarative partitioning

2016-05-12 Thread Amit Langote
Hi, On 2016/05/12 17:42, Sameer Thakur-2 wrote: > Hello Amit, > In the example >> create table part201606week4 partition of parted >> for values start (2016, 6, 2) end (2016, 6, 29); > > seems to be a typo Oops, there indeed is. create table part201606week4 partition of parted for values

Re: [HACKERS] Declarative partitioning

2016-05-12 Thread Sameer Thakur-2
Hello Amit, In the example >create table part201606week4 partition of parted >for values start (2016, 6, 2) end (2016, 6, 29); seems to be a typo regards Sameer -- View this message in context: http://postgresql.nabble.com/Declarative-partitioning-tp5862462p5903204.html Sent from the

Re: [HACKERS] NULL concatenation

2016-05-12 Thread Pavel Stehule
Hi 2016-05-12 10:47 GMT+02:00 Sridhar N Bamandlapally : > Hi > > In migration, am facing issue with NULL concatenation in plpgsql, > by concatenating NULL between any where/position to Text / Varchar, the > total string result is setting value to NULL > > > *In Oracle:* >

Re: [HACKERS] NULL concatenation

2016-05-12 Thread Sridhar N Bamandlapally
Thanks Pavel Great !! I was thinking both || and CANCAT does same Thanks again - Sridhar OpenText On Thu, May 12, 2016 at 2:22 PM, Pavel Stehule wrote: > Hi > > 2016-05-12 10:47 GMT+02:00 Sridhar N Bamandlapally > : > >> Hi >> >> In

[HACKERS] Incremental refresh of materialized view - Patch

2016-05-12 Thread hari.prasath
Hi all I am building a patch to refresh materialized view incrementally from the change set decoded by using logical decoding from WAL. As of now i can able to generate the changes that has to be updated in the materialized view but the thing was it not possible to do any

Re: [HACKERS] Academic help for Postgres

2016-05-12 Thread konstantin knizhnik
On May 12, 2016, at 6:16 AM, Rajeev rastogi wrote: > On 11 May 2016 19:50, Bruce Momjian Wrote: > > >> I am giving a keynote at an IEEE database conference in Helsinki next >> week (http://icde2016.fi/). (Yes, I am not attending PGCon Ottawa >> because I accepted the Helsinki conference

Re: [HACKERS] Lets (not) break all the things. Was: [pgsql-advocacy] 9.6 -> 10.0

2016-05-12 Thread Joshua Drake
On Apr 30, 2016 2:07 PM, Oleg Bartunov wrote: > > > > On Fri, Apr 29, 2016 at 7:40 PM, Joshua D. Drake wrote: >> > I'd not limited by the companies, individual developes are highly welcome. I'm afraid there are some. >   Oh, absolutely. I was just

Re: [HACKERS] [sqlsmith] Failed assertion in parallel worker (ExecInitSubPlan)

2016-05-12 Thread Amit Kapila
On Fri, May 13, 2016 at 9:43 AM, Amit Kapila wrote: > > On Thu, May 12, 2016 at 11:37 PM, Tom Lane wrote: > > > > Robert Haas writes: > > >> Target list for a relation, you mean? See relation.h: > > >> > > >> * reltarget

Re: [HACKERS] [sqlsmith] Failed assertion in parallel worker (ExecInitSubPlan)

2016-05-12 Thread Amit Kapila
On Thu, May 12, 2016 at 11:37 PM, Tom Lane wrote: > > Robert Haas writes: > >> Target list for a relation, you mean? See relation.h: > >> > >> * reltarget - Default Path output tlist for this rel; normally contains > >> * Var and

Re: [HACKERS] [GENERAL] NULL concatenation

2016-05-12 Thread Sridhar N Bamandlapally
Hi Adam we need simple concatenation of all variables(which values may come NULL or valid-values based on functional process), coalesce is different functionality Thanks Sridhar OpenText On Thu, May 12, 2016 at 4:56 PM, Adam Pearson < adam.pear...@realisticgames.co.uk> wrote: > Hello

Re: [HACKERS] Does Type Have = Operator?

2016-05-12 Thread Andrew Dunstan
On 05/12/2016 03:02 PM, Tom Lane wrote: "David E. Wheeler" writes: Some might argue that it ought to compare JSON objects, effectively be the equivalent of ::jsonb = ::jsonb, rather than ::text = ::text. But as Andrew points out to me offlist, “if that's what they

Re: [HACKERS] Keeping CURRENT_DATE and similar constructs in original format

2016-05-12 Thread David G. Johnston
On Thursday, May 12, 2016, Tom Lane wrote: > "David G. Johnston" > writes: > > On Thursday, May 12, 2016, Tom Lane > > ');>> > wrote: >

Re: [HACKERS] Incremental refresh of materialized view - Patch

2016-05-12 Thread hari.prasath
Hi all I am building a patch to refresh materialized view incrementally from the change set decoded by using logical decoding from WAL. As of now i can able to generate the changes that has to be updated in the materialized view but the thing was it not possible to do any

[HACKERS] Keeping CURRENT_DATE and similar constructs in original format

2016-05-12 Thread Tom Lane
I got annoyed again about a minor issue I've complained about before, and this time decided to do something about it. The issue is that gram.y translates a number of argument-less SQL constructs, such as CURRENT_DATE, into very implementation-specific things such as 'now'::text::date. There are

Re: [HACKERS] Does Type Have = Operator?

2016-05-12 Thread David E. Wheeler
On May 12, 2016, at 12:02 PM, Tom Lane wrote: > Andrew mentions in the extension you pointed to that providing a default > comparison operator would enable people to do UNION, DISTINCT, etc on JSON > columns without thinking about it. I'm not convinced that "without >

Re: [HACKERS] Keeping CURRENT_DATE and similar constructs in original format

2016-05-12 Thread Tom Lane
"David G. Johnston" writes: > On Thursday, May 12, 2016, Tom Lane > wrote: >> (I'm not particularly in love with the node type name >> ValueFunction; anybody got a better idea?) >

[HACKERS] Keeping CURRENT_DATE and similar constructs in original format

2016-05-12 Thread David G. Johnston
On Thursday, May 12, 2016, Tom Lane > wrote: > > So what I've wanted to do for some time is invent a new expression node > type that represents any one of these functions and can be reverse-listed > in the same format that

Re: [HACKERS] silent data loss with ext4 / all current versions

2016-05-12 Thread Michael Paquier
On Thu, May 12, 2016 at 2:58 PM, Michael Paquier wrote: > On Mon, Mar 28, 2016 at 8:25 AM, Andres Freund wrote: >> I've also noticed that > > Coming back to this issue because... > >> a) pg_basebackup doesn't do anything about durability (it

Re: [HACKERS] [GENERAL] NULL concatenation

2016-05-12 Thread Adam Pearson
Hello Sridhar, Have you tried the 'coalesce' function to handle the nulls? Kind Regards, Adam Pearson From: pgsql-general-ow...@postgresql.org on behalf of Sridhar N Bamandlapally Sent: 12 May

Re: [HACKERS] [sqlsmith] Failed assertion in parallel worker (ExecInitSubPlan)

2016-05-12 Thread Amit Kapila
On Sat, May 7, 2016 at 6:37 PM, Amit Kapila wrote: > > On Fri, May 6, 2016 at 8:45 AM, Tom Lane wrote: > > > > Andreas Seltenreich writes: > > > when fuzz testing master as of c1543a8, parallel workers trigger the > > > following