Re: [HACKERS] ORDER/GROUP BY expression not found in targetlist

2016-05-26 Thread Tom Lane
Andreas Seltenreich writes: > Peter Geoghegan writes: >> It's surprising that SQL Smith didn't catch something with such simple >> steps to reproduce. > I removed distinct relatively early because it causes a large part of > queries to fail due to it not finding an equality

Re: [HACKERS] [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet

2016-05-26 Thread Nikolay Shaplov
В письме от 26 мая 2016 10:05:56 пользователь Tom Lane написал: > > 2. I think expression with USING in it is more human readable: > > CREATE INDEX (xxx op_yyy); > > is less sensible then > > CREATE INDEX (xxx USING op_yyy); > > Yes. If we were working in a green field, it would have been

Re: [HACKERS] ORDER/GROUP BY expression not found in targetlist

2016-05-26 Thread Andreas Seltenreich
Tom Lane writes: > Andreas Seltenreich writes: >> Peter Geoghegan writes: >>> It's surprising that SQL Smith didn't catch something with such simple >>> steps to reproduce. > >> I removed distinct relatively early because it causes a large part of >> queries to fail due to it

Re: [HACKERS] Parallel pg_dump's error reporting doesn't work worth squat

2016-05-26 Thread Tom Lane
Kyotaro HORIGUCHI writes: >> Next, I got the following behavior for the following command, >> then freeze. Maybe stopping at the same point with the next >> paragraph but I'm not sure. The same thing occurs this patch on >> top of the current master but doesn't on

Re: [HACKERS] ORDER/GROUP BY expression not found in targetlist

2016-05-26 Thread Tom Lane
Andreas Seltenreich writes: > Tom Lane writes: >> It's looking for an operator that is known to be semantically equality, >> by virtue of being the equality member of a btree or hash opclass. >> Type path has no such opclass unfortunately. > As do lots of data types in the

Re: [HACKERS] pg_dump -j against standbys

2016-05-26 Thread Tom Lane
Magnus Hagander writes: > Here's an updated patch based on this,and the other feedback. Looks sane in a quick once-over, but I haven't tested it. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Parallel pg_dump's error reporting doesn't work worth squat

2016-05-26 Thread Tom Lane
Kyotaro HORIGUCHI writes: > At Wed, 25 May 2016 10:11:28 -0400, Tom Lane wrote in > <24577.1464185...@sss.pgh.pa.us> >> The only case >> that is certain to work is switches before non-switch arguments, and so >> we should not give any

Re: [HACKERS] Inheritance

2016-05-26 Thread Jim Nasby
On 5/25/16 8:19 PM, Craig Ringer wrote: Postgres is well past the point where our relational features are the big selling point. It's now about scale, an incredibly robust storage engine, and all the extensiblity opportunities. We've moved from being an RDBMS to being a "Data

Re: [HACKERS] Fix a failure of pg_dump with !HAVE_LIBZ

2016-05-26 Thread Tom Lane
Kyotaro HORIGUCHI writes: > The warning says that it makes uncompressed archive but it really > doesn't since workers die unexpectedly from the succeeding > errors. This is because that compressLevel is corrected in > ReadHead(), where too late for it to be

Re: [HACKERS] [GENERAL] Permission Denied Error on pg_xlog/RECOVERYXLOG file

2016-05-26 Thread Tom Lane
[ redirecting to -hackers ] writes: > When performing a vanilla database restore using either the 9.2.16 or 9.2.17 > executables (i.e. just restoring the database files from a 'tar' backup and > reading the WAL files created during the 'tar' backup - no specific PIT

Re: [HACKERS] ORDER/GROUP BY expression not found in targetlist

2016-05-26 Thread Tom Lane
Andres Freund writes: > trying to reproduce a performance problem I just found: > =# CREATE TABLE twocol(col01 int, col02 int); > =# SELECT DISTINCT col01, col02, col01 FROM twocol ; > ERROR: XX000: ORDER/GROUP BY expression not found in targetlist > LOCATION:

Re: [HACKERS] Adding an alternate syntax for Phrase Search

2016-05-26 Thread Josh berkus
On 05/22/2016 06:53 PM, Teodor Sigaev wrote: > >> to_tsquery(' Berkus & "PostgreSQL Version 10.0" ') >> >> ... would be equivalent to: >> >> to_tsquery(' Berkus & ( PostgreSQL <-> version <-> 10.0 )') > > select to_tsquery('Berkus') && phraseto_tsquery('PostgreSQL Version 10.0'); > does it as

Re: [HACKERS] Parallel pg_dump's error reporting doesn't work worth squat

2016-05-26 Thread Kyotaro HORIGUCHI
> Sounds reasonable. I look into this further. I looked into that and found one problem in the patch. > Next, I got the following behavior for the following command, > then freeze. Maybe stopping at the same point with the next > paragraph but I'm not sure. The same thing occurs this patch on >

Re: [HACKERS] Optimization for updating foreign tables in Postgres FDW

2016-05-26 Thread Etsuro Fujita
On 2016/05/17 0:25, Robert Haas wrote: On Wed, May 11, 2016 at 3:20 AM, Etsuro Fujita wrote: Thanks for the review! I'll add this to the next CF. I think this should be addressed in advance of the release of 9.6, though. I agree. Committed. Thanks! Best

Re: [HACKERS] RLS related docs

2016-05-26 Thread Dean Rasheed
On 25 May 2016 at 02:04, Joe Conway wrote: > Please see attached two proposed patches for the docs related to RLS: > > 1) Correction to pg_restore > 2) Additional mentions that "COPY FROM" does not allow RLS to be enabled > > Comments? > The pg_restore change looks good --

Re: [HACKERS] statistics for shared catalogs not updated when autovacuum is off

2016-05-26 Thread Tom Lane
Noah Misch writes: > You may want to compare your patch to this pending patch for the same bug: > http://www.postgresql.org/message-id/flat/24f09c2d-e5bf-1f73-db54-8255c1280...@2ndquadrant.com Oh, interesting. I had not been paying any attention to that thread. I'll go

Re: [HACKERS] [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet

2016-05-26 Thread Tom Lane
Nikolay Shaplov writes: > Actually I did not expected any discussion for this case. Documentations > missed an optional keyword, documentation should be fixed. 99% of the time, you'd be right. But this is an unusual case, for the reasons I mentioned before.

Re: [HACKERS] Re: PATCH: Split stats file per database WAS: autovacuum stress-testing our system

2016-05-26 Thread Tom Lane
Tomas Vondra writes: > Attached is a patch that should fix the coalescing, including the clock > skew detection. In the end I reorganized the code a bit, moving the > check at the end, after the clock skew detection. Otherwise I'd have to > do the clock skew

Re: [HACKERS] pg_dump -j against standbys

2016-05-26 Thread Magnus Hagander
On Thu, May 26, 2016 at 5:57 PM, Tom Lane wrote: > Magnus Hagander writes: > > Here's an updated patch based on this,and the other feedback. > > Looks sane in a quick once-over, but I haven't tested it. > > I've run some tests and it looks good. Will

Re: [HACKERS] foreign table batch inserts

2016-05-26 Thread Michael Paquier
On Thu, May 26, 2016 at 4:25 AM, Etsuro Fujita wrote: > On 2016/05/18 7:08, Michael Paquier wrote: >> >> On Wed, May 18, 2016 at 6:00 AM, Manuel Kniep wrote: >>> >>> I realized that inserts into foreign tables are only done row by row. >>> Consider

Re: [HACKERS] PATCH: pg_restore parallel-execution-deadlock issue

2016-05-26 Thread Tom Lane
Michael Paquier writes: > ea274b2 has changed the way disconnection is done is is now closing > both the read and write pipes. So you may want to retry if things get > better with the next round of minor releases. Hadn't paid attention to this thread before ... It

Re: [HACKERS] Adding an alternate syntax for Phrase Search

2016-05-26 Thread Oleg Bartunov
On Thu, May 26, 2016 at 3:00 PM, Josh berkus wrote: > On 05/22/2016 06:53 PM, Teodor Sigaev wrote: >> >>> to_tsquery(' Berkus & "PostgreSQL Version 10.0" ') >>> >>> ... would be equivalent to: >>> >>> to_tsquery(' Berkus & ( PostgreSQL <-> version <-> 10.0 )') >> >> select

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618

2016-05-26 Thread Michael Paquier
On Thu, May 26, 2016 at 3:01 AM, Amit Kapila wrote: > On Wed, May 25, 2016 at 9:44 PM, Michael Paquier > wrote: >> >> On Wed, May 25, 2016 at 12:11 AM, Amit Kapila >> wrote: >> > >> > Okay, attached patch just does

Re: [HACKERS] Perf Benchmarking and regression.

2016-05-26 Thread Andres Freund
Hi, On May 26, 2016 9:29:51 PM PDT, Ashutosh Sharma wrote: >Hi All, > >As we have seen the regression of more than 45% with >"*backend_flush_after*" >enabled and set to its default value i.e. 128KB or even when it is set >to >some higher value like 2MB, i think we should

Re: [HACKERS] Perf Benchmarking and regression.

2016-05-26 Thread Ashutosh Sharma
Hi All, As we have seen the regression of more than 45% with "*backend_flush_after*" enabled and set to its default value i.e. 128KB or even when it is set to some higher value like 2MB, i think we should disable it such that it does not impact the read write performance and here is the attached

Re: [HACKERS] [PROPOSAL] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind

2016-05-26 Thread Nikolay Shaplov
В письме от 25 мая 2016 14:03:17 Вы написали: > > > > >This all should me moved behind "access method" abstraction... > > > > > > > > +1 relopt_kind should be moved in am, at least. Or removed. > > > > > > Hm, but we have tablespace options too, so I'm not sure that using AM as > > >

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618

2016-05-26 Thread Amit Kapila
On Wed, May 25, 2016 at 9:44 PM, Michael Paquier wrote: > > On Wed, May 25, 2016 at 12:11 AM, Amit Kapila wrote: > > > > Okay, attached patch just does that and I have verified that it allows to > > start multiple services in windows. In off

Re: [HACKERS] [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet

2016-05-26 Thread Nikolay Shaplov
В письме от 24 мая 2016 12:47:20 пользователь Tom Lane написал: > Nikolay Shaplov writes: > > If I read gram.y code for insert statement, I see that there is an > > optional > > USING keyword before opclass name > > > > opt_class: any_name

[HACKERS] Further stabilization of isolationtester's timeouts test

2016-05-26 Thread Tom Lane
I've been noticing recently that certain buildfarm members sometimes fail the "timeouts" isolation test with this symptom: *** /home/pgbf/buildroot/HEAD/pgsql.build/src/test/isolation/expected/timeouts.out Mon May 16 23:45:12 2016 ---

Re: [HACKERS] PATCH: Batch/pipelining support for libpq

2016-05-26 Thread Tsunakawa, Takayuki
From: pgsql-hackers-ow...@postgresql.org [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Craig Ringer I'll follow this mood. Yeha. BTW, I've publushed the HTML-ified SGML docs to http://2ndquadrant.github.io/postgres/libpq-batch-mode.html as a preview. Sorry for my late reply.

Re: [HACKERS] 9.6 Open Item Ownership

2016-05-26 Thread Noah Misch
On Wed, Mar 30, 2016 at 08:20:02PM -0400, Noah Misch wrote: > The release management team has determined the following: > > From time to time, individual members of the release management team (RMT) > may attribute a PostgreSQL 9.6 open item to a particular git commit and > determine

Re: [HACKERS] Re: PATCH: Split stats file per database WAS: autovacuum stress-testing our system

2016-05-26 Thread Michael Paquier
On Thu, May 26, 2016 at 6:43 PM, Tomas Vondra wrote: > On 05/26/2016 10:10 PM, Tom Lane wrote: >> Tomas Vondra writes: >> In view of 52e8fc3e2, there's more or less no case in which we'd be >> writing stats without writing stats for the

Re: [HACKERS] Re: PATCH: Split stats file per database WAS: autovacuum stress-testing our system

2016-05-26 Thread Tomas Vondra
Hi, On 05/26/2016 10:10 PM, Tom Lane wrote: Tomas Vondra writes: Attached is a patch that should fix the coalescing, including the clock skew detection. In the end I reorganized the code a bit, moving the check at the end, after the clock skew detection.

Re: [HACKERS] Re: PATCH: Split stats file per database WAS: autovacuum stress-testing our system

2016-05-26 Thread Tom Lane
Tomas Vondra writes: > On 05/26/2016 10:10 PM, Tom Lane wrote: >> In view of 52e8fc3e2, there's more or less no case in which we'd be >> writing stats without writing stats for the shared catalogs. So I'm >> tempted to propose that we try to reduce the overhead by

Re: [HACKERS] [sqlsmith] Failed assertions on parallel worker shutdown

2016-05-26 Thread Amit Kapila
On Tue, May 24, 2016 at 6:36 PM, Andreas Seltenreich wrote: > > > Each of the sent plans was collected when a worker dumped core due to > the failed assertion. More core dumps than plans were actually > observed, since with this failed assertion, multiple workers usually >

Re: [HACKERS] pg_dump -j against standbys

2016-05-26 Thread Magnus Hagander
On Wed, May 25, 2016 at 4:21 PM, Tom Lane wrote: > Magnus Hagander writes: > >> Also, why didn't you keep using ExecuteSqlQueryForSingleRow()? > > > The reason I did that is that ExecuteSqlQueryForSingleRow() is a static > > method in pg_dump.c. I was

[HACKERS] Fix a failure of pg_dump with !HAVE_LIBZ

2016-05-26 Thread Kyotaro HORIGUCHI
Hello. I got the following messages during investigating some other bug, from pg_dump compiled with --without-zlib. > $ rm -rf testdump; pg_dump "postgres://horiguti:hoge@localhost/postgres" > --jobs=9 -Fd -f testdump; echo $? > pg_dump: [archiver] WARNING: requested compression not available

Re: [HACKERS] foreign table batch inserts

2016-05-26 Thread Etsuro Fujita
On 2016/05/18 7:08, Michael Paquier wrote: On Wed, May 18, 2016 at 6:00 AM, Manuel Kniep wrote: I realized that inserts into foreign tables are only done row by row. Consider copying data from one local table to a foreign table with INSERT INTO foreign_table(a,b,c) SELECT

Re: [HACKERS] [sqlsmith] Failed assertion in parallel worker (ExecInitSubPlan)

2016-05-26 Thread Amit Kapila
On Thu, May 12, 2016 at 11:37 PM, Tom Lane wrote: > > Robert Haas writes: > >> Target list for a relation, you mean? See relation.h: > >> > >> * reltarget - Default Path output tlist for this rel; normally contains > >> * Var and

Re: [HACKERS] Login into PostgreSQL without password

2016-05-26 Thread Christoph Berg
Re: Murtuza Zabuawala 2016-05-26 > Hi, > > I have created a role using below sql, then I disconnected & try to login > into postgres db with newly created user "test_role", It prompt for > password and I pressed Enter key

Re: [HACKERS] [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet

2016-05-26 Thread Tom Lane
Nikolay Shaplov writes: > В письме от 24 мая 2016 12:47:20 пользователь Tom > Lane написал: >> I think we should seriously consider fixing this code/docs discrepancy >> by making the code match the docs, not vice versa. That is, let's

Re: [HACKERS] ORDER/GROUP BY expression not found in targetlist

2016-05-26 Thread Andreas Seltenreich
Peter Geoghegan writes: > On Wed, May 25, 2016 at 7:12 PM, Andres Freund wrote: >> >> =# CREATE TABLE twocol(col01 int, col02 int); >> =# SELECT DISTINCT col01, col02, col01 FROM twocol ; >> ERROR: XX000: ORDER/GROUP BY expression not found in targetlist >> LOCATION:

[HACKERS] Login into PostgreSQL without password

2016-05-26 Thread Murtuza Zabuawala
Hi, I have created a role using below sql, then I disconnected & try to login into postgres db with newly created user "test_role", It prompt for password and I pressed Enter key because I did not provided any password when I created role so it throw me an error as below *Error: fe_sendauth: no

Re: [HACKERS] [PATCH][Documination] Add optional USING keyword before opclass name in INSERT statemet

2016-05-26 Thread David G. Johnston
On Thu, May 26, 2016 at 8:09 AM, Nikolay Shaplov wrote: > В письме от 24 мая 2016 12:47:20 пользователь Tom Lane написал: > > Nikolay Shaplov writes: > > > If I read gram.y code for insert statement, I see that there is an > > > optional > > >