2017-03-18 12:29 GMT-03:00 Tom Lane :
>
> But createuser/dropuser are a real problem, because they certainly could
> be mistaken for system-level utilities.
I proposed something along those lines [1] to fix this historical mistake
but we didn't reach a consensus. createuser/dropuser could be a c
Hi,
On 23/03/17 23:06, Michael Banck wrote:
> Hi,
>
> On Thu, Mar 23, 2017 at 09:00:16AM -0400, Peter Eisentraut wrote:
>> On 3/21/17 21:38, Peter Eisentraut wrote:
>>> This patch is looking pretty good to me, modulo the failing pg_dump tests.
>>>
>>> Attached is a fixup patch. I have mainly upd
> "Andres" == Andres Freund writes:
Andres> We usually cast the result of palloc.
>> Rough count in the backend has ~400 without casts to ~1350 with, so
>> this doesn't seem to have been consistently enforced.
Andres> Yea, but we're still trying.
Well, a lot of the uncasted ones are in
> "Andres" == Andres Freund writes:
Andres> a) cast result of lfirst/lnext/whatnot.
Again, what we need here is something like
#define lfirst_node(_type_, l) (castNode(_type_, lfirst(l)))
etc.
--
Andrew (irc:RhodiumToad)
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresq
On 24/03/17 02:00, Peter Eisentraut wrote:
On 3/21/17 21:38, Peter Eisentraut wrote:
This patch is looking pretty good to me, modulo the failing pg_dump tests.
Attached is a fixup patch. I have mainly updated some comments and
variable naming for (my) clarity. No functional changes.
Committe
On 3/23/17 12:37 PM, Andres Freund wrote:
On 2017-03-23 15:26:51 -0400, Tom Lane wrote:
There is a test in privileges.sql (currently lines 589-625 in
privileges.out) that seems to be dependent on the fact that the
ArrayCoerceExpr logic doesn't check for EXECUTE privilege on the
per-element type
On 24/03/17 00:14, Mark Kirkwood wrote:
> On 24/03/17 02:00, Peter Eisentraut wrote:
>> On 3/21/17 21:38, Peter Eisentraut wrote:
>>> This patch is looking pretty good to me, modulo the failing pg_dump
>>> tests.
>>>
>>> Attached is a fixup patch. I have mainly updated some comments and
>>> variab
On 2/25/17 10:27 AM, Peter Eisentraut wrote:
So I'm also wondering here which style people prefer so
I can implement it there.
I think the more OO style is definitely better. I expect it would
simplify the code as well.
--
Jim C. Nasby, Data Architect j...@nasby.net
512.
On Tue, Mar 14, 2017 at 7:51 AM, Kevin Grittner wrote:
> On Sun, Mar 12, 2017 at 4:08 PM, Thomas Munro
> wrote:
>> I found a new way to break it: run the trigger function so
>> that the plan is cached by plpgsql, then ALTER TABLE incompatibly,
>> then run the trigger function again. See attached
On Fri, Mar 24, 2017 at 1:45 AM, Teodor Sigaev wrote:
> I believe patch looks good and it's ready to commit.
Thanks for the review!
> As I understand, it fixes bug introduced by
> commit 7117685461af50f50c03f43e6a622284c8d54694
> Date: Tue Apr 5 20:03:49 2016 +0200
>
> Implement backup API
I found a rather nasty bug :-( ... the comment in EEOP_INNER_VAR_FIRST about
+/*
+ * Can't assert tts_nvalid, as wholerow var evaluation or such
+ * could have materialized the slot - but the contents are still
+ * valid :/
+ */
+
Hi,m
On 2017-03-23 17:40:55 -0400, Tom Lane wrote:
> Stylistic thought ... I am wondering if it wouldn't be a good idea
> to replace EEOP_CASE_WHEN_STEP, EEOP_CASE_THEN_STEP, EEOP_COALESCE,
> and EEOP_ARRAYREF_CHECKINPUT with instructions defined in a less
> usage-dependent way as
>
> EEOP_
On 2017-03-23 20:36:32 -0400, Tom Lane wrote:
> I found a rather nasty bug :-( ... the comment in EEOP_INNER_VAR_FIRST about
>
> +/*
> + * Can't assert tts_nvalid, as wholerow var evaluation or such
> + * could have materialized the slot - but the contents are s
On 2017/03/23 23:47, Amit Langote wrote:
> On Thu, Mar 23, 2017 at 11:27 PM, Maksim Milyutin
> wrote:
>> Hi!
>>
>> I have noticed that there is scheduled unlinking of nonexistent physical
>> storage under partitioned table when we execute DROP TABLE statement on this
>> partitioned table. Though t
On 2017-03-23 20:36:32 -0400, Tom Lane wrote:
> So I think that we have got to fix ExecEvalWholeRowVar so that it doesn't
> clobber the state of the slot. Right at the moment, the only way to do
> that seems to be to do this instead of ExecFetchSlotTupleDatum:
>
> tuple = ExecCopySlotTuple(sl
On 2015-08-01 17:14:10 +0200, Andres Freund wrote:
> According to https://www.openssl.org/blog/blog/2015/08/01/cla/ openssl
> is planning to relicense to the apache license 2.0. While APL2 is not
> compatible with GLP2 it *is* compatible with GPL3.
Just 5 minutes later, some progress on that front
Andres Freund writes:
> On 2017-03-23 20:36:32 -0400, Tom Lane wrote:
>> The problem here is that once we drop the buffer pin, any pointers we may
>> have into on-disk data are dangling pointers --- we're at risk of some
>> other backend taking away that shared buffer. (So I'm afraid that the
>>
On 24 March 2017 at 05:39, Thomas Munro wrote:
> Fujii-san for the idea of tracking write and flush lag too
You mentioned wishing that logical replication would update sent lag
as the decoding position.
It appears to do just that already; see the references to restart_lsn
in StartLogicalReplica
On 24 March 2017 at 04:54, Peter Eisentraut
wrote:
> Fixed.
Congratulations on getting this done. It's great work, and it'll make
a whole class of potential bugs and platform portability warts go away
if widely adopted.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL
On 08/01/2015 05:14 PM, Andres Freund wrote:
According to https://www.openssl.org/blog/blog/2015/08/01/cla/ openssl
is planning to relicense to the apache license 2.0. While APL2 is not
compatible with GLP2 it *is* compatible with GPL3.
Great! This means that the Debian packages will eventually
On 2017-03-23 21:26:19 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2017-03-23 20:36:32 -0400, Tom Lane wrote:
> >> The problem here is that once we drop the buffer pin, any pointers we may
> >> have into on-disk data are dangling pointers --- we're at risk of some
> >> other backend taki
On 2017-03-24 02:31:47 +0100, Andreas Karlsson wrote:
> On 08/01/2015 05:14 PM, Andres Freund wrote:
> > According to https://www.openssl.org/blog/blog/2015/08/01/cla/ openssl
> > is planning to relicense to the apache license 2.0. While APL2 is not
> > compatible with GLP2 it *is* compatible with
On Thu, Mar 23, 2017 at 1:45 PM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 3/22/17 17:33, David Steele wrote:
>
> > and I doubt that most tool writers would be quick to
> > add support for a feature that very few people (if any) use.
>
> I'm not one of those tool writers, al
Andres Freund writes:
> On 2017-03-23 21:26:19 -0400, Tom Lane wrote:
>> Hmm, I see ... but that only works in the cases where the caller of
>> ExecBuildProjectionInfo supplied a source slot, and a lot of 'em
>> don't.
> Right, the old and new code comment on that:
> * inputDesc can be NULL, bu
On 2017-03-23 21:58:03 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2017-03-23 21:26:19 -0400, Tom Lane wrote:
> >> Hmm, I see ... but that only works in the cases where the caller of
> >> ExecBuildProjectionInfo supplied a source slot, and a lot of 'em
> >> don't.
>
> > Right, the old a
At Wed, 22 Mar 2017 02:15:26 +0900, Masahiko Sawada
wrote in
> On Mon, Mar 20, 2017 at 11:28 PM, Robert Haas wrote:
> > On Sat, Mar 18, 2017 at 5:42 PM, Jeff Janes wrote:
> >> Isn't HEAP2_CLEAN only issued before an intended HOT update? (Which then
> >> can't leave the block as all visible or
From: pgsql-hackers-ow...@postgresql.org
> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Robert Haas
> On Tue, Mar 21, 2017 at 2:36 AM, Tsunakawa, Takayuki
> wrote:
> > Should I create a page for PostgreSQL 11 likewise? Or, do you want a
> more stable page named "PostgreSQL Roadmap" in
I think the fix belongs into the web site CSS, so there is nothing to
commit into PostgreSQL here. I will close the commit fest entry, but I
have added a section to the open items list so we keep track of it.
(https://wiki.postgresql.org/wiki/PostgreSQL_10_Open_Items#Documentation_tool_chain)
--
On Thu, Mar 23, 2017 at 1:10 AM, Stephen Frost wrote:
> Andrew,
>
> * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote:
>> On 03/22/2017 11:39 AM, Stephen Frost wrote:
>> > * Andrew Dunstan (and...@dunslane.net) wrote:
>> >> Sync pg_dump and pg_dumpall output
>> > This probably should have ad
On 3/17/17 18:35, Tomas Vondra wrote:
> On 03/17/2017 05:23 PM, Peter Eisentraut wrote:
>> I'm struggling to find a good way to share code between
>> bt_page_items(text, int4) and bt_page_items(bytea).
>>
>> If we do it via the SQL route, as I had suggested, it makes the
>> extension non-relocatabl
On 3/21/17 23:34, Tom Lane wrote:
> Peter Eisentraut writes:
>> No answer. Can we remove this chunk?
>
>>> + if (no_role_passwords && binary_upgrade)
>
> Perhaps, but why? ISTM that trying to run pg_upgrade as non-superuser
> is a nonstarter for a number of reasons, while if you're superuser
At the conclusion of
, pg_upgrade was
changed to upgrade sequences "logically". We initially did that by
adding a pg_dump option --sequence-data that would dump sequence data
(setval calls) in spite of --schema-only. Later, that option was
removed as a separate option and made automatic in --bina
On Thu, Mar 23, 2017 at 6:46 PM, Ashutosh Sharma wrote:
>>
>> Oh, okay, but my main objection was that we should not check hash page
>> type (hasho_flag) without ensuring whether it is a hash page. Can you
>> try to adjust the above code so that this check can be moved after
>> hasho_page_id chec
On Fri, Mar 24, 2017 at 11:01 AM, Kyotaro HORIGUCHI
wrote:
> At Wed, 22 Mar 2017 02:15:26 +0900, Masahiko Sawada
> wrote in
>> On Mon, Mar 20, 2017 at 11:28 PM, Robert Haas wrote:
>> > On Sat, Mar 18, 2017 at 5:42 PM, Jeff Janes wrote:
>> >> Isn't HEAP2_CLEAN only issued before an intended HO
On Fri, Mar 24, 2017 at 9:21 AM, Amit Kapila wrote:
> On Thu, Mar 23, 2017 at 6:46 PM, Ashutosh Sharma
> wrote:
>>>
>>> Oh, okay, but my main objection was that we should not check hash page
>>> type (hasho_flag) without ensuring whether it is a hash page. Can you
>>> try to adjust the above co
Here is a patch to add COMMENT support for publications and subscriptions.
On a similar issue, do we need SECURITY LABEL support for those? Does
that make sense?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Fri, Mar 24, 2017 at 9:46 AM, Ashutosh Sharma wrote:
> On Fri, Mar 24, 2017 at 9:21 AM, Amit Kapila wrote:
>> On Thu, Mar 23, 2017 at 6:46 PM, Ashutosh Sharma
>> wrote:
Oh, okay, but my main objection was that we should not check hash page
type (hasho_flag) without ensuring wh
On 2/15/17 12:11, Robert Haas wrote:
> On Wed, Feb 15, 2017 at 11:30 AM, Peter Eisentraut
> wrote:
>> If RegisterBackgroundWorker() (the non-dynamic kind that is only
>> loadable from shared_preload_libraries) fails to register the worker, it
>> writes a log message and proceeds, ignoring the regi
On 3/23/17 16:58, Stephen Frost wrote:
> The backup tools need to also get the LSN from the pg_stop_backup and
> verify that they have the WAL file associated with that LSN.
There is a function for that.
> They also
> need to make sure that they have all of the WAL files between the
> starting LS
On 3/23/17 21:47, Jeff Janes wrote:
> I have a pg_restore which predicts the file 5 files ahead of the one it
> was asked for, and initiates a pre-fetch and decompression of it. Then
> it delivers the file it was asked for, either by pulling it out of the
> pre-staging area set up by the N-5th invo
On Fri, Mar 24, 2017 at 1:14 PM, Thomas Munro
wrote:
> If that's fixed and the permissions question can be waved away by
> saying it's the same as the per-row situation, my only other comment
> would be a bikeshed issue: Enr isn't a great name for a struct.
One more thought: should this be allowe
On 3/22/17 09:17, Stephen Frost wrote:
>> If we do it via GRANTs instead, then users can easily extend it.
> The intent here is that users will *also* be able to do it via GRANTs if
> they wish to.
But why not do it with GRANTs in the first place then?
--
Peter Eisentraut http://www
On Thu, Mar 23, 2017 at 4:26 PM, Ashutosh Sharma wrote:
> On Thu, Mar 23, 2017 at 9:17 AM, Amit Kapila wrote:
>>
>> On Thu, Mar 23, 2017 at 8:43 AM, Amit Kapila wrote:
>> >
>> > I think this will work, but not sure if there is a merit to deviate
>> > from what btree does to handle this case. O
On 3/23/17 06:09, Vitaly Burovoy wrote:
> I think we'll end up with "DROP IDENTITY IF EXISTS" to avoid raising
> an exception and "ADD OR SET" if your grammar remains.
That sounds reasonable to me.
> Right. From that PoV IDENTITY also changes a default value: "SET (ADD
> ... AS?) IDENTITY" works
On Wed, Mar 22, 2017 at 3:43 PM, Ashutosh Bapat
wrote:
> Hi,
> In create_unique_path() there's comment
> /*
> * We must ensure path struct and subsidiary data are allocated in main
> * planning context; otherwise GEQO memory management causes trouble.
> */
> oldcontext = Mem
Hello,
In Windows, if one needs to take a dump in plain text format (this is
the default option, or can be specified using -Fp) with some level of
compression (-Z[0-9]), an output file has to
be specified. Otherwise, if the output is redirected to stdout, it'll
create a corrupted dump (cmd is set t
Hello Peter,
I think the fix belongs into the web site CSS, so there is nothing to
commit into PostgreSQL here.
Indeed, the changes were only for the "remove nesting" solution.
I will close the commit fest entry, but I have added a section to the
open items list so we keep track of it.
(ht
On Fri, Mar 24, 2017 at 11:28 AM, Kuntal Ghosh
wrote:
> Hello,
> In Windows, if one needs to take a dump in plain text format (this is
> the default option, or can be specified using -Fp) with some level of
> compression (-Z[0-9]), an output file has to
> be specified. Otherwise, if the output is
On Wed, Mar 22, 2017 at 3:43 PM, Ashutosh Bapat <
ashutosh.ba...@enterprisedb.com> wrote:
> Hi,
> In create_unique_path() there's comment
> /*
> * We must ensure path struct and subsidiary data are allocated in main
> * planning context; otherwise GEQO memory management causes troubl
On 23 March 2017 at 17:44, Craig Ringer wrote:
Minor update to catalog_xmin walsender patch to fix failure to
parenthesize definition of PROCARRAY_PROC_FLAGS_MASK .
This one's ready to go. Working on drop slots on DB drop now.
--
Craig Ringer http://www.2ndQuadrant.com/
Pos
On 24 March 2017 at 02:29, Robert Haas wrote:
> On Tue, Mar 21, 2017 at 11:35 PM, Craig Ringer wrote:
>> Changes made per discussion.
>
> Committed 0001.
Much appreciated.
Here's the 2nd patch rebased on top of master, with the TAP test
included this time. Looks ready to go.
I really appreciat
On Fri, Mar 24, 2017 at 1:20 PM, Peter Eisentraut
wrote:
> On 2/15/17 12:11, Robert Haas wrote:
>> On Wed, Feb 15, 2017 at 11:30 AM, Peter Eisentraut
>> wrote:
>>> If RegisterBackgroundWorker() (the non-dynamic kind that is only
>>> loadable from shared_preload_libraries) fails to register the wo
On Fri, Mar 24, 2017 at 11:52 AM, Rushabh Lathia
wrote:
>
>
> On Wed, Mar 22, 2017 at 3:43 PM, Ashutosh Bapat
> wrote:
>>
>> Hi,
>> In create_unique_path() there's comment
>> /*
>> * We must ensure path struct and subsidiary data are allocated in
>> main
>> * planning context; other
On Fri, Mar 24, 2017 at 1:22 AM, Mithun Cy wrote:
> Hi Amit please find the new patch
The pageinspect.sgml has an example which shows the output of
"hash_metapage_info()". Since we increase the spares array and
eventually ovflpoint, I have updated the example with corresponding
values..
--
Tha
>>> > I think this will work, but not sure if there is a merit to deviate
>>> > from what btree does to handle this case. One thing I find slightly
>>> > awkward in hash_xlog_vacuum_get_latestRemovedXid() is that you are
>>> > using a number of tuples registered as part of fixed data
>>> > (xl_ha
101 - 155 of 155 matches
Mail list logo
