On 9/8/17 1:32 PM, Peter Eisentraut wrote:
>
> Yes, some of the error messages had changed. Fixed patches attached.
Patches apply and all tests pass. A few comments:
* [PATCH v2 1/7] adminpack: Add test suite
There are no regular tests for pg_logdir_ls(). It looks like TAP tests
would be req
2017-09-14 15:17 GMT+02:00 Alvaro Herrera :
> Tom Lane wrote:
> > "David G. Johnston" writes:
> > >If I was going to try and read it like a book I'd want the extra
> > > white-space to make doing so easier (white-space gives the eye a
> breather
> > > when done with a particular concept) - and t
BTW I added --with-ldap and --with-pam to the configure line for the
reports in coverage.postgresql.org and the % covered in auth.c went from
24% to 18.9% (from very bad to terribly sad).
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DB
On 14 August 2017 at 01:35, Tomas Vondra wrote:
> Hi,
>
> Attached is a rebased version of the Generational context, originally
> submitted with SlabContext (which was already committed into Pg 10).
>
> The main change is that I've abandoned the pattern of defining a Data
> structure and then a po
I think the ldap_unbind() changes should be in a separate preliminary
patch to be committed separately and backpatched.
The other bits looks fine, with nitpicks
1. please move the new support function to the bottom of the section
dedicated to LDAP, and include a prototype
2. please wrap lines lo
On Thu, Sep 14, 2017 at 11:57 AM, Thomas Munro
wrote:
> On Thu, Sep 14, 2017 at 12:51 AM, Prabhat Sahu
> wrote:
>> Setting with lower "shared_buffers" and "work_mem" as below, query getting
>> crash but able to see explain plan.
>
> Thanks Prabhat. A small thinko in the batch reset code means
On 14 September 2017 at 19:57, Ashutosh Sharma
wrote:
>
> Are you planning to work on the review comments from Robert, Moon
> Insung and supply the new patch. I just had a quick glance into this
> mail thread (after a long time) and could understand Robert's concern
> till some extent. I think,
On Thu, Sep 14, 2017 at 2:20 PM, Dmitriy Sarafannikov <
dsarafanni...@yandex.ru> wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Docu
Tom Lane wrote:
> "David G. Johnston" writes:
> >If I was going to try and read it like a book I'd want the extra
> > white-space to make doing so easier (white-space gives the eye a breather
> > when done with a particular concept) - and the length wouldn't really
> > matter since I'd just make
Hi
2017-09-14 12:33 GMT+02:00 Anthony Bykov :
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation:tested, failed
>
> Hell
On 09/11/2017 11:01 AM, Jesper Pedersen wrote:
Thanks for working on this !
Moved to "Ready for Committer".
Best regards,
Jesper
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Sep 13, 2017 at 1:46 PM, Amit Langote
wrote:
>>
>> Ok. May be then create_function_1.sql is the right place. Just add it
>> to the section of passing tests and annotate that it's testing
>> creating an FDW handler. Sorry for jumping back and forth.
>
> Alright, done. Thanks for reviewing.
On Wed, Sep 13, 2017 at 6:58 AM, Thomas Munro
wrote:
> On Tue, Sep 12, 2017 at 11:23 PM, Ashutosh Bapat
> wrote:
>> On Wed, Aug 16, 2017 at 11:13 AM, Ashutosh Bapat
>> wrote:
>>> On Wed, Aug 16, 2017 at 8:44 AM, Alvaro Herrera
>>> wrote:
Christoph Berg wrote:
> "Diagnostic message" doe
Peter Eisentraut wrote:
> On 9/13/17 09:56, Alvaro Herrera wrote:
> > Tom Lane wrote:
> >> Peter Eisentraut writes:
> >
> >>> - Disallow DROP SUBSCRIPTION in a transaction under certain
> >>> circumstances, for example if a transaction has previously manipulated
> >>> the same subscription.
> >
Hi Craig,
On Thu, Aug 17, 2017 at 5:50 AM, Craig Ringer wrote:
> On 16 August 2017 at 23:14, Robert Haas wrote:
>>
>> On Tue, Aug 15, 2017 at 4:36 PM, Tomas Vondra
>> wrote:
>> > You might say that people investigating issues in this area of code
>> > should
>> > be aware of how HEAP_XMIN_FROZE
On 14 September 2017 at 06:43, Amit Langote
> langote_amit...@lab.ntt.co.jp> wrote:
> Attached updated patch.
@@ -1222,151 +1209,130 @@ PartitionDispatch *
RelationGetPartitionDispatchInfo(Relation rel,
int
*num_parted, List **leaf_
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
This is simple and intuitive patch. Code looks pretty clear a
On Thu, Sep 14, 2017 at 6:36 PM, Amit Kapila wrote:
> Why do we need to change metapage at every place for btree ...
I have been hunting for some time places where meta buffers were
marked as dirtied and logged. So in the effort, I think that my hands
and mind got hotter, forgetting that pd_lower
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: not tested
Documentation:tested, failed
Hello,
As far as I understand, this patch adds functionality (cor
On 14 September 2017 at 10:42, Konstantin Knizhnik
wrote:
>
>
> On 13.09.2017 14:00, Simon Riggs wrote:
>>
>> On 13 September 2017 at 11:30, Konstantin Knizhnik
>> wrote:
>>
>>> The only reason of all this discussion about terms is that I need to
>>> choose
>>> name for correspondent index option
Hadi Moshayedi wrote:
> To provide more context, in cstore_fdw creating the storage is easy, we
> only need to hook into CREATE FOREIGN TABLE using event triggers. Removing
> the storage is not that easy, for DROP FOREIGN TABLE we can use event
> triggers.
This all sounds a little more complicated
At Wed, 13 Sep 2017 20:20:48 -0400, Robert Haas wrote
in
> On Mon, Jun 26, 2017 at 4:46 AM, Kyotaro HORIGUCHI
> wrote:
> > The cause is that NO INHERIT doesn't take an exlusive lock on the
> > parent. This allows expand_inherited_rtentry to add the child
> > relation into appendrel after remova
On Thu, Sep 14, 2017 at 9:24 AM, Michael Paquier
wrote:
> Hi all,
>
> While reviewing another patch, I have bumped into a couple of failures
> when running installcheck if log_statement = 'ddl'. This pops
> regression failures for 4 tests: object_address, alter_generic,
> alter_operator and stats_
On 13.09.2017 14:00, Simon Riggs wrote:
On 13 September 2017 at 11:30, Konstantin Knizhnik
wrote:
The only reason of all this discussion about terms is that I need to choose
name for correspondent index option.
Simon think that we do not need this option at all. In this case we should
not wo
On Thu, Sep 14, 2017 at 12:30 PM, Michael Paquier
wrote:
> On Wed, Sep 13, 2017 at 4:43 PM, Amit Langote
> wrote:
>> Sure, no problem.
>
>
> +*
> +* This won't be of any help unless we use option like REGBUF_STANDARD
> +* while registering the buffer for metapage as otherwise, it won
On Tue, 12 Sep 2017 12:59:20 -0400
Tom Lane wrote:
> Quick comment on this patch: recently, we've decided that having
> patches replace the whole base script for an extension is too much of
> a maintenance problem, especially when there are several patches in
> the pipeline for the same contrib m
On 14/09/17 08:57, Heikki Linnakangas wrote:
On 09/12/2017 04:09 AM, Noah Misch wrote:
On Wed, May 10, 2017 at 10:50:51PM -0400, Bruce Momjian wrote:
On Mon, May 1, 2017 at 08:12:51AM -0400, Robert Haas wrote:
On Tue, Apr 25, 2017 at 10:16 PM, Bruce Momjian
wrote:
Well, we could add "MD5
On 2017-09-13 17:53:44 -0400, Tom Lane wrote:
> Andres Freund writes:
> > Indeed that seems plausible. I guess something like the attached should
> > fix the issue?
>
> Ah, I see you came to the same conclusion I did. But see comment
> about adding a comment.
I've pushed something - Not sure if
On 2017-09-13 14:46:08 -0700, Jeff Janes wrote:
> On Wed, Sep 13, 2017 at 2:41 PM, Andres Freund wrote:
> > Indeed that seems plausible. I guess something like the attached should
> > fix the issue?
> >
>
> Yep, that fixes it.
Cool. Pushed. Thanks for the report!
Thanks,
Andres
--
Sent via
On 2017/09/14 16:53, Dean Rasheed wrote:
> On 13 September 2017 at 10:05, Amit Langote
> wrote:
>> Coincidentally, I just wrote the patch for canonicalizing stored values,
>> instead of erroring out. Please see attached if that's what you were
>> thinking too.
>>
>
> Looks reasonable to me, if w
On Wed, Sep 13, 2017 at 7:43 PM, Jesper Pedersen wrote:
> Hi Amul,
>
> On 09/08/2017 08:40 AM, amul sul wrote:
>
>> Rebased 0002 against this commit & renamed to 0001, PFA.
>>
>>
> This patch needs a rebase.
>
>
Thanks for your note.
Attached is the patch rebased on the latest master head.
Al
On Wed, Sep 13, 2017 at 7:24 PM, Jesper Pedersen
wrote:
> I have done a run with this patch on a 2S/28C/56T/256Gb w/ 2 x RAID10 SSD
> machine.
>
> Both for -M prepared, and -M prepared -S I'm not seeing any improvements (1
> to 375 clients); e.g. +-1%.
My test was done on an 8 socket NUMA intel m
Hi Martin,
> > === Build Failed: 7 ===
> > Title: Fix the optimization to skip WAL-logging on table created in same
> > transaction
> > Author: Martijn van Oosterhout
> > URL: https://commitfest.postgresql.org/14/528/
>
> I'm not the author of this patch, and the page doesn't say so.
> Somethin
Thanks Amit for reviewing.
Patch looks fine to me. By the way, why don't we just say "Can we skip
> scanning part_rel?" in the comment before the newly added call to
> PartConstraintImpliedByRelConstraint()? We don't need to repeat the
> explanation of what it does at the every place we call it.
On 14 September 2017 at 03:49, Noah Misch wrote:
> On Wed, Sep 13, 2017 at 12:06:40PM -0400, Robert Haas wrote:
>> OK, thanks. I still don't really like allowing this, but I can see
>> that compatibility with other systems has some value here, and if
>> nobody else is rejecting these cases, maybe
On 13 September 2017 at 14:51, Robert Haas wrote:
> Coincidentally, I wrote a patch for this too, but mine goes back to
> rejecting MINVALUE or MAXVALUE followed by anything else.
>
LGTM, if we decide to go this way.
One minor review comment -- you missed an example code snippet using
(MINVALUE,
On 13 September 2017 at 10:05, Amit Langote
wrote:
> Coincidentally, I just wrote the patch for canonicalizing stored values,
> instead of erroring out. Please see attached if that's what you were
> thinking too.
>
Looks reasonable to me, if we decide to go this way.
One minor review comment --
At Tue, 12 Sep 2017 19:30:44 +0200, Emre Hasegeli wrote in
> > Hello, sorry to late for the party, but may I comment on this?
>
> Thank you for picking this up again.
>
> > The first patch reconstructs the operators in layers. These
> > functions are called very frequently when used. Some func
Hello, Robert, Noah
From: Robert Haas [mailto:robertmh...@gmail.com]
> On Fri, Jul 28, 2017 at 1:30 AM, Noah Misch wrote:
> > We've reached that period. If anyone is going to push for a change
> > here, now is the time. Absent such arguments, the behavior won't change.
>
> Well, I started out
Repeating links for better accessibility:
On 2017/09/14 16:13, Amit Langote wrote:
> [1]
https://www.postgresql.org/message-id/CA%2BTgmoafr%3DhUrM%3Dcbx-k%3DBDHOF2OfXaw95HQSNAK4mHBwmSjtw%40mail.gmail.com
> [2]
https://www.postgresql.org/message-id/7fe0007b-7ad1-a593-df11-ad05364ebce4%40lab.ntt.
Hi.
It seems to me that some of the code in partition.c is better placed
somewhere under the executor directory. There was even a suggestion
recently [1] to introduce a execPartition.c to house some code around
tuple-routing.
IMO, catalog/partition.c should present an interface for handling
oper
On Thu, Sep 14, 2017 at 3:57 PM, Heikki Linnakangas wrote:
> I updated the list of drivers on the wiki
> (https://wiki.postgresql.org/wiki/List_of_drivers), adding a column for
> whether the driver supports SCRAM authentication. Currently, the only
> non-libpq driver that has implemented SCRAM is
On Wed, Sep 13, 2017 at 4:43 PM, Amit Langote
wrote:
> Sure, no problem.
OK, I took a closer look at all patches, but did not run any manual
tests to test the compression except some stuff with
wal_consistency_checking.
+ if (opaque->flags & GIN_DELETED)
+ mask_page_content(page);
+ el
101 - 143 of 143 matches
Mail list logo
