Re: [HACKERS] GUC for cleanup indexes threshold.

At Fri, 22 Sep 2017 15:00:20 +0900, Masahiko Sawada wrote in > On Tue, Sep 19, 2017 at 3:31 PM, Kyotaro HORIGUCHI > wrote: > > I was just looking the thread since it is found left alone for a > > long time in the CF app. > > > > At Mon, 18 Sep 2017 16:35:58 -0700, Peter Geoghegan wrote in > >

Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

On Fri, Sep 22, 2017 at 3:46 PM, Michael Paquier wrote: > On Fri, Sep 22, 2017 at 3:24 PM, Masahiko Sawada > wrote: >> I have a question. Since WALInsertLockRelease seems not to call >> LWLockWaitForVar I thought you wanted to mean LWLockReleaseClearVar >> instead, is that right? > > This looks

Re: [HACKERS] pg_stat_wal_write statistics view

Hello, On Wed, Sep 13, 2017 at 3:01 AM, Haribabu Kommi wrote: > I ran the latest performance tests with and without IO times, there is an > overhead involved with IO time calculation and didn't observe any > performance > overhead with normal stats. May be we can enable the IO stats only in the >

Re: [HACKERS] GUC for cleanup indexes threshold.

I apologize in advance of possible silliness. At Thu, 21 Sep 2017 13:54:01 -0300, Claudio Freire wrote in > On Tue, Sep 19, 2017 at 8:55 PM, Peter Geoghegan wrote: > > On Tue, Sep 19, 2017 at 4:47 PM, Claudio Freire > > wrote: > >> Maybe this is looking at the problem from the wrong directio

Re: [HACKERS] [PROPOSAL] Temporal query processing with range types

2017-09-12 16:33 GMT+02:00 Simon Riggs : > PostgreSQL tries really very hard to implement the SQL Standard and > just the standard. ISTM that the feedback you should have been given > is that this is very interesting but will not be committed in its > current form; I am surprised to see nobody has

Re: [HACKERS] [PROPOSAL] Temporal query processing with range types

2017-09-22 9:59 GMT+02:00 Peter Moser : > 2017-09-12 16:33 GMT+02:00 Simon Riggs : > > PostgreSQL tries really very hard to implement the SQL Standard and > > just the standard. ISTM that the feedback you should have been given > > is that this is very interesting but will not be committed in its

Re: [HACKERS] [PROPOSAL] Temporal query processing with range types

2017-09-22 10:06 GMT+02:00 Pavel Stehule : > ANSI SQL 2011 has temporal data support > > https://www.slideshare.net/CraigBaumunk/temporal-extensions-tosql20112012010438 As operations it only supports temporal inner joins using the overlap predicate. Temporal aggregation, temporal outer joins, temp

Re: [HACKERS] [PROPOSAL] Temporal query processing with range types

2017-09-22 10:15 GMT+02:00 Peter Moser : > 2017-09-22 10:06 GMT+02:00 Pavel Stehule : > > ANSI SQL 2011 has temporal data support > > > > https://www.slideshare.net/CraigBaumunk/temporal- > extensions-tosql20112012010438 > > As operations it only supports temporal inner joins using the overlap > p

Re: [HACKERS] GUC for cleanup indexes threshold.

On Fri, Sep 22, 2017 at 4:16 PM, Kyotaro HORIGUCHI wrote: > At Fri, 22 Sep 2017 15:00:20 +0900, Masahiko Sawada > wrote in >> On Tue, Sep 19, 2017 at 3:31 PM, Kyotaro HORIGUCHI >> wrote: >> > I was just looking the thread since it is found left alone for a >> > long time in the CF app. >> > >>

Re: [HACKERS] GUC for cleanup indexes threshold.

At Fri, 22 Sep 2017 17:21:04 +0900, Masahiko Sawada wrote in > On Fri, Sep 22, 2017 at 4:16 PM, Kyotaro HORIGUCHI > wrote: > > At Fri, 22 Sep 2017 15:00:20 +0900, Masahiko Sawada > > wrote in > > > >> On Tue, Sep 19, 2017 at 3:31 PM, Kyotaro HORIGUCHI > >> wrote: > >> Could you elaborate a

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Fri, Sep 22, 2017 at 10:45 AM, Rafia Sabih wrote: >> >> On completing the benchmark for all queries for the above mentioned >> setup, following performance improvement can be seen, >> Query | Patch | Head >> 3 | 1455 | 1631 >> 4 | 499 | 4344 >> 5 | 1464 | 1606 >> 10 | 1475 | 1599

Re: [HACKERS] CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it?

On 09/21/2017 10:55 PM, Peter Geoghegan wrote: I agree, but the bigger issue is that we're *half way* between supporting only one format, and supporting two formats. AFAICT, there is no reason that we can't simply support one format on all ICU versions, and keep what ends up within pg_collation a

Re: [HACKERS] [PROPOSAL] Temporal query processing with range types

2017-09-22 10:21 GMT+02:00 Pavel Stehule : > Currently Postgres has zero support for SQL:2011 temporal tables. Isn't > better start with already standard features than appends some without > standard? The standard has some concept and if we start out of this concept, > then the result will be far t

Re: [HACKERS] UPDATE of partition key

On 21 September 2017 at 19:52, amul sul wrote: > On Wed, Sep 20, 2017 at 9:27 PM, Amit Khandekar > wrote: >> >> On 20 September 2017 at 00:06, Robert Haas wrote: >> > On Fri, Sep 15, 2017 at 7:25 AM, Amit Khandekar >> > wrote: >> >> [ new patch ] > > > 86 - (event == TRIGGER_EVENT_U

Re: [HACKERS] Should we cacheline align PGXACT?

On Thu, Sep 21, 2017 at 12:08 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Mon, Sep 18, 2017 at 12:41 PM, Daniel Gustafsson > wrote: > >> > On 16 Sep 2017, at 01:51, Alexander Korotkov >> wrote: >> > >> > On Tue, Sep 5, 2017 at 2:47 PM, Daniel Gustafsson >

Re: [HACKERS] Windows warnings from VS 2017

On 09/21/2017 09:41 PM, Andres Freund wrote: > On 2017-09-21 09:30:31 -0400, Tom Lane wrote: >> Andrew Dunstan writes: >>> The speed of memset is hardly going to be the dominating factor in a >>> 'CREATE DATABASE' command, so we could certainly afford to change to >>> plain memset calls here. >>

Re: [HACKERS] Generate wait event list and docs from text file

Michael Paquier wrote: > On Fri, Sep 22, 2017 at 1:52 PM, Schneider wrote: > > Seems an apt occasion to point out that 10rc1 is missing documentation > > for a couple events. > Indeed, I can see as well that those are the three new ones between > 9.6 and 10. Attached is a patch to correct the doc

Re: [HACKERS] Improve catcache/syscache performance.

On Fri, Sep 22, 2017 at 2:15 AM, Andres Freund wrote: > This results in making cache lookups themselves roughly three times as > fast - full-system benchmarks obviously improve less than that. Wow. That's really good. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

Masahiko Sawada writes: > On Sun, Sep 17, 2017 at 2:01 AM, Masahiko Sawada > wrote: >> + >> + Since dropping a replication slot is not transactional, we cannot run >> + DROP SUBSCRIPTION inside a transaction block if >> dropping >> + the replication slot. Also, DROP SUBSCRIPTOIN stops

Re: [HACKERS] visual studio 2017 build support

On 09/21/2017 08:16 PM, Haribabu Kommi wrote: > > > > > I was about to commit this after a good bit of testing when I > noticed this: > >     +   Building with Visual Studio 2017 is >     supported >     +   down to Windows 7 SP1 and Windows >     Server 2012 R2. > > I

Re: [HACKERS] GUC for cleanup indexes threshold.

On Fri, Sep 22, 2017 at 4:46 AM, Kyotaro HORIGUCHI wrote: > I apologize in advance of possible silliness. > > At Thu, 21 Sep 2017 13:54:01 -0300, Claudio Freire > wrote in >> On Tue, Sep 19, 2017 at 8:55 PM, Peter Geoghegan wrote: >> > On Tue, Sep 19, 2017 at 4:47 PM, Claudio Freire >> > wro

Re: [HACKERS] [PATCH] Generic type subscripting

On 9/21/17 11:24, Dmitry Dolgov wrote: > One last thing that I need to clarify. Initially there was an idea to > minimize changes in `pg_type` I see, but there is no value in that if it makes everything else more complicated. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQ

Re: [HACKERS] SCRAM in the PG 10 release notes

On 9/21/17 14:15, Jeff Janes wrote: > This looks good to me.  Might suggest adding verifying the clients as a > specific step:   > > "To upgrade an existing installation from md5 to scram-sha-256, verify > that all client software supports it, set password_encryption = > 'scram-sha-256' in postgre

Re: [HACKERS] [COMMITTERS] pgsql: Fix bool/int type confusion

On 9/21/17 14:58, Tom Lane wrote: > I've just been going through their git commit log to see what else has > changed since tzcode2017b, and I note that there are half a dozen other > portability-ish fixes. I think that some of them affect only code we > don't use, but I'm not sure that that's the

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

On Fri, Sep 15, 2017 at 5:29 PM, Ashutosh Bapat wrote: > >> >> Apart from these there is a regression case on a custom table, on head >> query completes in 20s and with this patch it takes 27s. Please find >> the attached .out and .sql file for the output and schema for the test >> case respective

Re: [HACKERS] Re: proposal - psql: possibility to specify sort for describe commands, when size is printed

2017-09-21 20:30 GMT+02:00 Pavel Stehule : > > > 2017-09-21 20:20 GMT+02:00 Peter Eisentraut com>: > >> On 9/21/17 13:54, Pavel Stehule wrote: >> > I see where you are coming from, but there is no association in the >> > existing UI that equates "+" to the word "verbose". I think just >>

Re: [HACKERS] GUC for cleanup indexes threshold.

On 2017-09-22 11:21, Masahiko Sawada wrote: On Fri, Sep 22, 2017 at 4:16 PM, Kyotaro HORIGUCHI wrote: At Fri, 22 Sep 2017 15:00:20 +0900, Masahiko Sawada wrote in On Tue, Sep 19, 2017 at 3:31 PM, Kyotaro HORIGUCHI wrote: > I was just looking the thread since it is found left alone for a >

Re: [HACKERS] !USE_WIDE_UPPER_LOWER compile errors in v10+

On 9/21/17 17:38, Tom Lane wrote: > Meanwhile, I see that Peter has posted a fix for the immediate problem. > I propose that Peter should apply his fix in HEAD and v10, and then done > I'll rip out the !USE_WIDE_UPPER_LOWER code paths in HEAD only. -- Peter Eisentraut http://www.2n

Re: [HACKERS] [COMMITTERS] pgsql: Fix bool/int type confusion

Peter Eisentraut writes: > On 9/21/17 14:58, Tom Lane wrote: >> I've just been going through their git commit log to see what else has >> changed since tzcode2017b, and I note that there are half a dozen other >> portability-ish fixes. I think that some of them affect only code we >> don't use, b

Re: [HACKERS] GUC for cleanup indexes threshold.

On 2017-09-22 16:22, Sokolov Yura wrote: On 2017-09-22 11:21, Masahiko Sawada wrote: On Fri, Sep 22, 2017 at 4:16 PM, Kyotaro HORIGUCHI wrote: At Fri, 22 Sep 2017 15:00:20 +0900, Masahiko Sawada wrote in On Tue, Sep 19, 2017 at 3:31 PM, Kyotaro HORIGUCHI wrote: > I was just looking the th

Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows

On 9/21/17 15:21, Peter Geoghegan wrote: > On Thu, Sep 21, 2017 at 12:12 PM, Peter Eisentraut > wrote: >>> Attached patch shows what I'm getting at. This is untested, since I >>> don't use Windows. Proceed with caution. >> >> Your analysis makes sense, but the patch doesn't work, because "locale"

Re: [HACKERS] coverage analysis improvements

On 9/21/17 03:42, Michael Paquier wrote: > -SPI.c: SPI.xs plperl_helpers.h > +%.c: %.xs > @if [ x"$(perl_privlibexp)" = x"" ]; then echo "configure switch > --with-perl was not specified."; exit 1; fi > - $(PERL) $(XSUBPPDIR)/ExtUtils/xsubpp -typemap > $(perl_privlibexp)/ExtUtils/typemap $< >

[HACKERS] Re: "inconsistent page found" with checksum and wal_consistency_checking enabled

On Wed, Sep 20, 2017 at 01:52:15PM +0900, Michael Paquier wrote: > On Wed, Sep 20, 2017 at 5:23 AM, Ashwin Agrawal wrote: > > Currently, page checksum is not masked by Page masking routines used by > > wal_consistency_checking facility. So, when running `make installcheck` with > > data checksum e

Re: [HACKERS] GUC for cleanup indexes threshold.

The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, passed Documentation:tested, passed We're using Postgres with this patch for some time. In our u

Re: [HACKERS] !USE_WIDE_UPPER_LOWER compile errors in v10+

Peter Eisentraut writes: > On 9/21/17 17:38, Tom Lane wrote: >> Meanwhile, I see that Peter has posted a fix for the immediate problem. >> I propose that Peter should apply his fix in HEAD and v10, and then > done >> I'll rip out the !USE_WIDE_UPPER_LOWER code paths in HEAD only. And done.

[HACKERS] 10RC1 crash testing MultiXact oddity

I am running some crash recovery testing against 10rc1 by injecting torn page writes, using a test case which generates a lot of multixact, some naturally by doing a lot fk updates, but most artificially by calling the pg_burn_multixact function from one of the attached patches. In 22 hours of run

Re: [HACKERS] CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it?

On Fri, Sep 22, 2017 at 1:50 AM, Andreas Karlsson wrote: > On 09/21/2017 10:55 PM, Peter Geoghegan wrote: >> >> I agree, but the bigger issue is that we're *half way* between >> supporting only one format, and supporting two formats. AFAICT, there >> is no reason that we can't simply support one f

Re: [HACKERS] 10RC1 crash testing MultiXact oddity

Jeff Janes wrote: > I am running some crash recovery testing against 10rc1 by injecting torn > page writes, using a test case which generates a lot of multixact, some > naturally by doing a lot fk updates, but most artificially by calling > the pg_burn_multixact function from one of the attached pa

Re: [HACKERS] additional contrib test suites

On 9/18/17 09:54, Peter Eisentraut wrote: > On 9/16/17 08:10, David Steele wrote: (5) drop contrib/chkpass altogether, on the grounds that it's too badly designed, and too obsolete crypto-wise, to be useful or supportable. >>> crypt() uses the 7 lowest characters, which makes for 7.2e16 v

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

Hi This is the new pacth with TAP test and use Macro XLOGDIR. And i had add this patch to the commitfest, https://commitfest.postgresql.org/15/1302/ -- Best Regards, Chen Huajun pg_rewind_wal_copy_reduce_v2.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hac

Re: [HACKERS] 10RC1 crash testing MultiXact oddity

On Fri, Sep 22, 2017 at 11:37 AM, Jeff Janes wrote: > Is the presence of this log message something that needs to be investigated > further? I'd say yes. It sounds like we have a race condition someplace that previous fixes in this area failed to adequately understand. -- Robert Haas Enterpris

Re: [HACKERS] ICU locales and text/char(n) SortSupport on Windows

On Fri, Sep 22, 2017 at 7:25 AM, Peter Eisentraut wrote: > I agree. The attached patch should do it. I see one small issue here: You'll now need to set ssup->comparator back to NULL before you return early in the Windows' libc case. That way, a shim comparator (that goes through bttextcmp(), in

Re: [HACKERS] close_ps, NULLs, and DirectFunctionCall

On Wed, Sep 20, 2017 at 4:25 PM, Andrew Gierth wrote: > postgres=# select point(1,2) ## '((0,0),(NaN,NaN))'::box; > ERROR: function 0x9c5de0 returned NULL > > postgres=# select point(1,2) <-> '((0,0),(NaN,NaN))'::box; > ERROR: function 0x9c5de0 returned NULL > > This seems ... unhelpful (though

Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

On Tue, Sep 19, 2017 at 4:15 PM, Melanie Plageman wrote: > > The latest patch applies cleanly and builds (I am also seeing the failing > TAP tests), however, I have a concern. With a single server set up, when I > attempt to make a connection with target_session_attrs=read-write, I get > the messa

Re: [HACKERS] pgbench regression test failure

Fabien COELHO writes: >> It could be as simple as putting the check-for-done at the bottom of the >> loop not the top, perhaps. > I agree that it is best if tests should work in all reasonable conditions, > including a somehow overloaded host... > I'm going to think about it, but I'm not sure o

Re: [HACKERS] additional contrib test suites

On 2017-09-18 09:54:52 -0400, Peter Eisentraut wrote: > On 9/16/17 08:10, David Steele wrote: > >>> (5) drop contrib/chkpass altogether, on the grounds that it's too badly > >>> designed, and too obsolete crypto-wise, to be useful or supportable. > >> crypt() uses the 7 lowest characters, which mak

Re: [HACKERS] pgbench regression test failure

[...] After another week of buildfarm runs, we have a few more cases of 3 rows of output, and none of more than 3 or less than 1. So I went ahead and pushed your patch. I'm still suspicious of these results, but we might as well try to make the buildfarm green pending investigation of how t

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

On Fri, Sep 22, 2017 at 7:16 PM, chenhj wrote: > This is the new pacth with TAP test and use Macro XLOGDIR. > Good. I took a quick look over the patch. Why do you need master_query(), standby_query() and run_query() in RewindTest.pm? You can do just $node_master->safe_psql() and $node_slave->sa

Re: [HACKERS] Page Scan Mode in Hash Index

On Thu, Sep 21, 2017 at 3:08 AM, Ashutosh Sharma wrote: > I have added a note for handling of logged and unlogged tables in > README file and also corrected the header comment for > hashbucketcleanup(). Please find the attached 0003*.patch having these > changes. Thanks. I committed 0001 and 0002

Re: [HACKERS] CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it?

On 9/21/17 16:55, Peter Geoghegan wrote: >> I strongly prefer if there, as much as possible, is only one format for >> inputting ICU locales. > I agree, but the bigger issue is that we're *half way* between > supporting only one format, and supporting two formats. AFAICT, there > is no reason that

Re: [HACKERS] "inconsistent page found" with checksum and wal_consistency_checking enabled

On Wed, Sep 20, 2017 at 12:52 AM, Michael Paquier wrote: > Indeed. This had better be fixed before PG10 is out. I am adding an open item. This seems a little hyperbolic to me. Sure, it's a new bug in v10, and sure, it's always better to fix bugs sooner rather than later, but there's nothing part

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

On 9/21/17 04:43, Masahiko Sawada wrote: >> Once we got this patch, DROP SUBSCRIPTION is not transactional either >> if dropping a replication slot or if the subscription got disabled in >> a transaction block. But we disallow to do DROP SUBSCRIPTION in a >> transaction block only in the former cas

Re: [HACKERS] Re: proposal - psql: possibility to specify sort for describe commands, when size is printed

On 9/22/17 09:16, Pavel Stehule wrote: > Example: somebody set SORT_COLUMNS to schema_name value. This is > nonsense for \l command > > Now, I am thinking so more correct and practical design is based on > special mode, activated by variable > > PREFER_SIZE_SORT .. (off, asc, desc) > > This has

[HACKERS] Shaky coding for vacuuming partitioned relations

Somebody inserted this into vacuum.c's get_rel_oids(): tuple = SearchSysCache1(RELOID, ObjectIdGetDatum(relid)); if (!HeapTupleIsValid(tuple)) elog(ERROR, "cache lookup failed for relation %u", relid); apparently without having read the very verbose comment two lines a

Re: [HACKERS] Patch: add --if-exists to pg_recvlogical

On 9/20/17 02:26, Rosser Schwarz wrote: > The more I think about it, I don't think it's nonsensical, though. > --create-slot --if-exists or --drop-slot --if-not-exists, obviously. I > mean, do you even logic? Those pieces make sense. We have many CREATE IF NOT EXISTS and DROP IF EXISTS commands.

Re: [HACKERS] Re: proposal - psql: possibility to specify sort for describe commands, when size is printed

2017-09-22 21:12 GMT+02:00 Peter Eisentraut < peter.eisentr...@2ndquadrant.com>: > On 9/22/17 09:16, Pavel Stehule wrote: > > Example: somebody set SORT_COLUMNS to schema_name value. This is > > nonsense for \l command > > > > Now, I am thinking so more correct and practical design is based on > >

Re: [HACKERS] [Proposal] Make the optimiser aware of partitions ordering

On Thu, Sep 21, 2017 at 11:13 AM, Julien Rouhaud wrote: > On Thu, Sep 21, 2017 at 10:52 AM, Ashutosh Bapat > wrote: >> With 9140cf8269b0c4ae002b2748d93979d535891311, we store the >> RelOptInfos of partitions in the RelOptInfo of partitioned table. For >> range partitioned table without default pa

Re: [HACKERS] 10RC1 crash testing MultiXact oddity

On Fri, Sep 22, 2017 at 8:47 AM, Alvaro Herrera wrote: > Jeff Janes wrote: > > I am running some crash recovery testing against 10rc1 by injecting torn > > page writes, using a test case which generates a lot of multixact, some > > naturally by doing a lot fk updates, but most artificially by cal

Re: [HACKERS] Page Scan Mode in Hash Index

On Fri, Sep 22, 2017 at 11:56 PM, Robert Haas wrote: > On Thu, Sep 21, 2017 at 3:08 AM, Ashutosh Sharma > wrote: >> I have added a note for handling of logged and unlogged tables in >> README file and also corrected the header comment for >> hashbucketcleanup(). Please find the attached 0003*.pa

Re: [HACKERS] [Proposal] Make the optimiser aware of partitions ordering

On Fri, Sep 22, 2017 at 3:34 PM, Julien Rouhaud wrote: > PFA v3 of the patch, once again rebased and that now use all the newly > available infrastructure. > > I also added a check that a sorted append can't be generated when a > default partition has been declared. I just took a quick look at th

Re: [HACKERS] 10RC1 crash testing MultiXact oddity

On Fri, Sep 22, 2017 at 3:39 PM, Jeff Janes wrote: > It turns out it is not new in pg10. I spotted in the log file only by > accident while looking for something else. Now that I am looking for it, I > do see it in 9.6 as well. So I guess the next question is whether it also shows up if you ini

Re: [HACKERS] [Proposal] Make the optimiser aware of partitions ordering

On Fri, Sep 22, 2017 at 9:58 PM, Robert Haas wrote: > On Fri, Sep 22, 2017 at 3:34 PM, Julien Rouhaud wrote: >> PFA v3 of the patch, once again rebased and that now use all the newly >> available infrastructure. >> >> I also added a check that a sorted append can't be generated when a >> default

Re: [HACKERS] CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it?

On Fri, Sep 22, 2017 at 11:34 AM, Peter Eisentraut wrote: > After reviewing this thread and testing around a bit, I think the code > is mostly fine as it is, but the documentation is lacking. Hence, > attached is a patch to expand the documentation quite a bit, especially > to document in more de

Re: [HACKERS] Rewriting the test of pg_upgrade as a TAP test

On 9/19/17 19:00, Michael Paquier wrote: > On Wed, Sep 20, 2017 at 7:57 AM, Peter Eisentraut > wrote: >> To get things rolling, I have committed just the basic TAP tests, to >> give it a spin on the build farm. I'll work through the rest in the >> coming days. I have reverted this because of the

Re: [HACKERS] [Proposal] Make the optimiser aware of partitions ordering

On Fri, Sep 22, 2017 at 4:23 PM, Julien Rouhaud wrote: > That was one of the first question we had with the initial POC. The > reason is that this "sorted append" is not using a merge algorithm but > just appending partitions in the right order, so it looked like we > could either create a new So

[HACKERS] Rethinking autovacuum.c memory handling

I notice that autovacuum.c calls autovacuum_do_vac_analyze, and thereby vacuum(), in TopTransactionContext. This doesn't seem like a terribly great idea, because it doesn't correspond to what happens during a manually-invoked vacuum. TopTransactionContext will go away when vacuum() commits the ou

Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?

bal...@obiserver.hu writes: > PostgreSQL version: 10beta4 > testdb=# begin; > BEGIN > testdb=# create type enumtype as enum ('v1', 'v2'); > CREATE TYPE > testdb=# alter type enumtype owner to testrole; > ALTER TYPE > testdb=# create table testtable (enumcolumn enumtype not null default 'v1'); > ER

Re: [HACKERS] Small improvement to compactify_tuples

On Tue, Sep 12, 2017 at 12:49 PM, Sokolov Yura wrote: > On 2017-07-21 13:49, Sokolov Yura wrote: >> >> On 2017-05-17 17:46, Sokolov Yura wrote: >>> >>> Alvaro Herrera писал 2017-05-15 20:13: As I understand, these patches are logically separate, so putting them together in a single

[HACKERS] Built-in plugin for logical decoding output

We have been working on a project that makes extensive use of logical replication for use inside Apigee (which is a very small part of Google): https://github.com/apigee-labs/transicator In order to do this, we had to write our own logical replication plugin because the supplied "test_decoding" p

Re: [HACKERS] Built-in plugin for logical decoding output

On 23/09/17 00:28, Gregory Brail wrote: We have been working on a project that makes extensive use of logical replication for use inside Apigee (which is a very small part of Google): https://github.com/apigee-labs/transicator In order to do this, we had to write our own logical replication

Re: [HACKERS] Built-in plugin for logical decoding output

Thanks! I didn't read the version 10 RC docs carefully enough. I found the code that generates the protocol message (looks like its replication/proto/logical.c). Are there docs somewhere on the format, or is it just the code? Also in lieu of the new snapshot mechanism for logical replication, whi

Re: [HACKERS] CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it?

On Fri, Sep 22, 2017 at 4:46 PM, Peter Geoghegan wrote: > But you are *already* canonicalizing ICU collation names as BCP 47. My > point here is: Why not finish the job off, and *also* canonicalize > colcollate in the same way? Peter, with respect, it's time to let this argument go. We're schedu

Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?

On 09/22/2017 05:46 PM, Tom Lane wrote: > bal...@obiserver.hu writes: >> PostgreSQL version: 10beta4 >> testdb=# begin; >> BEGIN >> testdb=# create type enumtype as enum ('v1', 'v2'); >> CREATE TYPE >> testdb=# alter type enumtype owner to testrole; >> ALTER TYPE >> testdb=# create table testtabl

Re: [HACKERS] Built-in plugin for logical decoding output

Hi, On 2017-09-22 17:11:47 -0700, Gregory Brail wrote: > Also in lieu of the new snapshot mechanism for logical replication, which > might not work for us This needs context... >, we were using the transaction ID to calculate what > was committed in a client's snapshot and what they need to appl

Re: [HACKERS] CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it?

On Fri, Sep 22, 2017 at 5:58 PM, Robert Haas wrote: > On Fri, Sep 22, 2017 at 4:46 PM, Peter Geoghegan wrote: >> But you are *already* canonicalizing ICU collation names as BCP 47. My >> point here is: Why not finish the job off, and *also* canonicalize >> colcollate in the same way? > > Peter, w

Re: [HACKERS] [BUGS] BUG #14825: enum type: unsafe use?

Andrew Dunstan writes: > On 09/22/2017 05:46 PM, Tom Lane wrote: >> I'm not sure if that qualifies as a stop-ship problem, but it ain't >> good, for sure. We need to look at whether we should revert 15bc038f9 >> or somehow revise its rules. > I wonder if we wouldn't be better > doing this more d

[HACKERS] pgbench - use enum for meta commands

Minor code enhancement. While having a look at adding if/elif/else/endif to pgbench, and given the current gset/cset added meta commands in cf queue, it occured to me that repeated string comparisons to check for the various meta commands is neither efficient nor readable. Use an enum instead

Re: [HACKERS] CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it?

Robert Haas writes: > Peter, with respect, it's time to let this argument go. We're > scheduled to wrap a GA release in just over 72 hours. FWIW, the release is a week from Monday, not Monday. (Or if it is Monday, somebody else is wrapping it.) We have some other embarrassingly critical things

Re: [HACKERS] pgbench - use enum for meta commands

2017-09-23 5:45 GMT+02:00 Fabien COELHO : > > Minor code enhancement. > > While having a look at adding if/elif/else/endif to pgbench, and given the > current gset/cset added meta commands in cf queue, it occured to me that > repeated string comparisons to check for the various meta commands is >

Re: [HACKERS] CREATE COLLATION does not sanitize ICU's BCP 47 language tags. Should it?

On Fri, Sep 22, 2017 at 8:56 PM, Tom Lane wrote: > The big concern I have here is that this feels a lot like something that > we'll regret at leisure, if it's not right in the first release. I'd > much rather be restrictive in v10 and then loosen the rules later, than > be lax in v10 and then hav