Re: [HACKERS] CVS pg_config --includedir-server broken

2005-06-29 Thread strk
On Tue, Jun 28, 2005 at 08:12:16PM -0400, Bruce Momjian wrote: strk wrote: The valure returned from pg_config --includedir-server is broken as of CVS. It points to unexistent directory: /home/extra/pgroot-cvs/include/server Correct value would be:

Re: [HACKERS] Wierd panic with 7.4.7

2005-06-29 Thread Greg Stark
Tom Lane [EMAIL PROTECTED] writes: In the second place, we don't treat communication failures as ERRORs, so how did step 3 happen? You probably realize this, but just in case: Broken Pipe probably means the backend received SIGPIPE, not just that some file operation syscall returned -1. --

[HACKERS] Startup successful message, even on failure

2005-06-29 Thread Michael Glaesemann
A number of times when I've attempted to start the postmaster (using pg_ctl start) I've gotten Fatal error messages (usually when I don't have the shmmax/shmall settings correct) followed by a success message (something like postmaster sucessfully started). I don't currently have any shell

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-06-29 Thread Michael Paesold
Bruce Momjian wrote: Dave Page wrote: pg_relation_size(text) - Get relation size by name/schema.name pg_relation_size(oid)- Get relation size by OID pg_tablespace_size(name) - Get tablespace size by name pg_tablespace_size(oid) - Get tablespace size by OID pg_database_size(name) -

Re: [HACKERS] [SQL] ENUM like data type

2005-06-29 Thread Dawid Kuroczko
On 6/28/05, Martín Marqués martin@bugs.unl.edu.ar wrote: El Mar 28 Jun 2005 13:58, PFC escribió: Personnally I use one table which has columns (domain, name) and which stores all enum values for all different enums. I have then CHECK( is_in_domain( column, 'domain_name' )) which

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Simon Riggs
On Wed, 2005-06-22 at 11:11 -0700, Josh Berkus wrote: Hans, Tom, We have done extensive testing some time ago. We could not see any difference on any platform we have tested (AIX, Linux, Solaris). I don't think that there is one at all - at least not on common systems. Keen then.

Re: [HACKERS] GiST concurrency commited

2005-06-29 Thread Teodor Sigaev
And there is one more problem: it caused approximatly one time per 2-4 million statements, I got traps: TRAP: FailedAssertion(!((*curpage)-offsets_used == num_tuples), File: vacuum.c, Line: 2766) LOG: server process (PID 15847) was terminated by signal 6 Odd. Will look at it later (after

[HACKERS] bug in ALTER TABLE / TYPE

2005-06-29 Thread Neil Conway
A coworker of mine reported a subtle issue in ATExecAlterColumnType() in tablecmds.c. Suppose we have the following DDL: CREATE TABLE pktable (a int primary key, b int); CREATE TABLE fktable (fk int references pktable, c int); ALTER TABLE pktable ALTER COLUMN a TYPE bigint; Circa line 4891 in

Re: [HACKERS] Open items

2005-06-29 Thread Magnus Hagander
Changes --- integrated auto-vacuum (Alvaro) ICU locale patch? That would be Palle, and he's said he thinks he can have it in place in time. I'll have to update it for win32 build specifics after that, but that should be ok after the freeze, right? Please consider removing the question

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Michael Paesold
Simon Riggs wrote: Group commit is a well-documented technique for improving performance, but the gains only show themselves on very busy systems. It is possible in earlier testing any apparent value was actually hidden by the BufMgrLock issues we have now resolved in 8.1. We now see XLogInsert

Re: [HACKERS] Implementing SQL/PSM for PG 8.2 - debugger

2005-06-29 Thread Mark Cave-Ayland
Hi guys, I lean with you and Tom. While running it over the same libpq protocol would be helpful in some ways, it would have a lot of drawbacks and would really change the function of libpq. I think a separate debugging protocol is in order. Just putting on my network hat for a

[HACKERS] symbol name clash with libpq.so: md5_hash

2005-06-29 Thread Martin Münstermann
Hi, after linking my database client application with a crypto library (as shared library), I noticed that I couldn't connect to postgresql any longer. Error message was Password authentication failed. After some time I found out that the issue was caused by both the crypto library and

Re: [HACKERS] Implementing SQL/PSM for PG 8.2 - debugger

2005-06-29 Thread Hannu Krosing
On K, 2005-06-29 at 10:33 +0100, Mark Cave-Ayland wrote: Hi guys, I lean with you and Tom. While running it over the same libpq protocol would be helpful in some ways, it would have a lot of drawbacks and would really change the function of libpq. I think a separate debugging

Re: [HACKERS] GiST concurrency commited

2005-06-29 Thread Qingqing Zhou
Teodor Sigaev [EMAIL PROTECTED] writes concur.pl - generator of SQL statements retrieving it is forbidden ... Regards, Qingqing ---(end of broadcast)--- TIP 7: don't forget to increase your free space map settings

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-06-29 Thread Dave Page
-Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: Wed 6/29/2005 2:16 AM To: Dave Page Cc: PostgreSQL-patches; PostgreSQL-development Subject: Re: [PATCHES] Dbsize backend integration OK, so you went with relation as heap/index/toast only, and table as the total

Re: [HACKERS] GiST concurrency commited

2005-06-29 Thread Teodor Sigaev
Sorry, fixed. Qingqing Zhou wrote: Teodor Sigaev [EMAIL PROTECTED] writes concur.pl - generator of SQL statements retrieving it is forbidden ... Regards, Qingqing ---(end of broadcast)--- TIP 7: don't forget to increase your free space

Re: [HACKERS] contrib/rtree_gist into core system?

2005-06-29 Thread falcon
Teodor Sigaev [EMAIL PROTECTED] writes: 1. In your meaning, btree has bad split algorithm too. Look at _bt_compare, if first keys on page are unique the the later keys will not be compared ;) Please look at BUG 1614/1616. Pleeaaaeee. There are also troubles with intarray, may be it can

Re: [HACKERS] contrib/rtree_gist into core system?

2005-06-29 Thread Oleg Bartunov
On Wed, 29 Jun 2005, falcon wrote: Teodor Sigaev [EMAIL PROTECTED] writes: 1. In your meaning, btree has bad split algorithm too. Look at _bt_compare, if first keys on page are unique the the later keys will not be compared ;) Please look at BUG 1614/1616. Pleeaaaeee. There are also

Re: [HACKERS] Open items

2005-06-29 Thread Bruce Momjian
Satoshi Nagayasu wrote: How about enable/disable triggers? From TODO: Allow triggers to be disabled. http://momjian.postgresql.org/cgi-bin/pgtodo?trigger I think this is good for COPY performance improvement. Now I have user functions to enable/disable triggers, not DDL. It

Re: [HACKERS] contrib/rtree_gist into core system?

2005-06-29 Thread Oleg Bartunov
Yura, I found your message http://archives.postgresql.org/pgsql-bugs/2005-04/msg00213.php So, what's the problem ? Could you reproduce your problem without silly plpgsql functions ? Just plain create table, inserts and selects. Also, have you tried CVS HEAD before crying too much ?

Re: [HACKERS] Open items

2005-06-29 Thread Bruce Momjian
Marc G. Fournier wrote: On Tue, 28 Jun 2005, Bruce Momjian wrote: Here are our open items. How hard are we going to be about the cutoff date? Do we give people the weekend to complete some items? Sounds reasonable to me ... Always hate doing stuff like this on a Friday myself ...

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-06-29 Thread Bruce Momjian
Dave Page wrote: -Original Message- From: Bruce Momjian [mailto:[EMAIL PROTECTED] Sent: Wed 6/29/2005 2:16 AM To: Dave Page Cc: PostgreSQL-patches; PostgreSQL-development Subject: Re: [PATCHES] Dbsize backend integration OK, so you went with relation as heap/index/toast only,

Re: [HACKERS] Open items

2005-06-29 Thread Bruce Momjian
Magnus Hagander wrote: Changes --- integrated auto-vacuum (Alvaro) ICU locale patch? That would be Palle, and he's said he thinks he can have it in place in time. I'll have to update it for win32 build specifics after that, but that should be ok after the freeze, right? Yes,

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Bruce Momjian
Simon Riggs wrote: On Wed, 2005-06-22 at 11:11 -0700, Josh Berkus wrote: Hans, Tom, We have done extensive testing some time ago. We could not see any difference on any platform we have tested (AIX, Linux, Solaris). I don't think that there is one at all - at least not on common

Re: [HACKERS] Implementing SQL/PSM for PG 8.2 - debugger

2005-06-29 Thread Dave Cramer
This is an interesting suggestion, particularly the addition of additional connections for management However it does require all clients rewrite (yet again ) their connection code. My reasoning for suggesting a separate port for debugging are: 1) no changes to existing clients ( this

[HACKERS] Bytecode and virtual machine

2005-06-29 Thread Dave Cramer
Jonah, What do you see as the advantages of using a VM and bytecode? Regarding Antlr etal, are there any that generate C code. I am more familiar with the java parsers. If we can't generate C this is probably a non-starter. Dave On 28-Jun-05, at 5:58 PM, Jonah H. Harris wrote: Dave, I

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-06-29 Thread Bruce Momjian
Michael Paesold wrote: Do we have to use pg_object_size? Is there a better name? Are indexes/toasts even objects? Relation is not an ideal names, but I heard people talk about heap relation and index relation. Indexes and tables (and sequences) are treated in a similar way quite

Re: [HACKERS] Implementing SQL/PSM for PG 8.2 - debugger

2005-06-29 Thread Hannu Krosing
On K, 2005-06-29 at 08:00 -0400, Dave Cramer wrote: This is an interesting suggestion, particularly the addition of additional connections for management However it does require all clients rewrite (yet again ) their connection code. My reasoning for suggesting a separate port for

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Tom Lane
Simon Riggs [EMAIL PROTECTED] writes: Group commit is a well-documented technique for improving performance, The issue here is not is group commit a good idea in the abstract?. It is is the commit_delay implementation of the idea worth a dime? ... and the evidence we have all points to the

Re: [HACKERS] Startup successful message, even on failure

2005-06-29 Thread Tom Lane
Michael Glaesemann [EMAIL PROTECTED] writes: A number of times when I've attempted to start the postmaster (using pg_ctl start) I've gotten Fatal error messages (usually when I don't have the shmmax/shmall settings correct) followed by a success message (something like postmaster

[HACKERS] Proposal: associative arrays for plpgsql (concept)

2005-06-29 Thread Pavel Stehule
Hello The concept is from Oracle 9i, but with some changes. http://www.oracle-10g.de/oracle_10g_documentation/appdev.101/b10807/05_colls.htm#i35672 Associative arrays are any arrays with index. Will be created DECLARE x varchar[] INDEX BY VARCHAR = '{}'; -- some format, haven't

Re: [HACKERS] Implementing SQL/PSM for PG 8.2

2005-06-29 Thread Affan Bin Salman
Andrew Dunstan wrote: It could be done by putting the SPL parser in front of the SQL parser. Maybe Luss will tell us how it was done ;-) We added SPL 'CREATE [OR REPLACE] PROCEDURE' and 'CREATE [OR REPLACE] FUNCTION' Syntax support to the main scanner, parser for the backend. By entering

Re: [HACKERS] Bytecode and virtual machine

2005-06-29 Thread Jonah H. Harris
Hey Dave, I see a few of the advantages and disadvantages as follows: ADVANTAGES - Faster execution (a single parse/compile) - The ability for companies/people to write PL code and not directly share the source (though disassembly is always possible) - Built-in debugging support (could be

Re: [HACKERS] Proposal: associative arrays for plpgsql (concept)

2005-06-29 Thread David Fetter
On Wed, Jun 29, 2005 at 05:59:26PM +0200, Pavel Stehule wrote: Hello The concept is from Oracle 9i, but with some changes. http://www.oracle-10g.de/oracle_10g_documentation/appdev.101/b10807/05_colls.htm#i35672 Associative arrays are any arrays with index. Will be created

[HACKERS] problem with plpgsql

2005-06-29 Thread Pavel Stehule
Hello In my code I evaluate expr select array(select generate_series from generate_series(1,800) my code var = (PLpgSQL_var *) (estate-datums[stmt-varno]); value = exec_eval_expr(estate, stmt-expr, isnull, valtype); exec_eval_cleanup(estate); and iteration over array

Re: [HACKERS] Proposal: associative arrays for plpgsql (concept)

2005-06-29 Thread Josh Berkus
Pavel, The concept is from Oracle 9i, but with some changes. http://www.oracle-10g.de/oracle_10g_documentation/appdev.101/b10807/05_coll s.htm#i35672 How does this match the SQL2003 spec? -- Josh Berkus Aglio Database Solutions San Francisco ---(end of

Re: [HACKERS] Proposal: associative arrays for plpgsql (concept)

2005-06-29 Thread Douglas McNaught
David Fetter [EMAIL PROTECTED] writes: I'm all in favor of having associative arrays as a 1st-class data type in PostgreSQL. How much harder would it be to make these generally available vs. tied to one particular language? We already have them--they're called tables with primary keys. :)

Re: [HACKERS] [PATCHES] Users/Groups - Roles

2005-06-29 Thread Tom Lane
I notice that AddRoleMems/DelRoleMems assume that ADMIN OPTION is not inherited indirectly; that is it must be granted directly to you. This seems wrong; SQL99 has under privileges 19) B has the WITH ADMIN OPTION on a role if a role authorization descriptor identifies the role

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Kenneth Marshall
On Wed, Jun 29, 2005 at 08:14:36AM +0100, Simon Riggs wrote: Group commit is a well-documented technique for improving performance, but the gains only show themselves on very busy systems. It is possible in earlier testing any apparent value was actually hidden by the BufMgrLock issues we

Re: [HACKERS] Proposal: associative arrays for plpgsql (concept)

2005-06-29 Thread Pavel Stehule
On Wed, 29 Jun 2005, Josh Berkus wrote: Pavel, The concept is from Oracle 9i, but with some changes. http://www.oracle-10g.de/oracle_10g_documentation/appdev.101/b10807/05_coll s.htm#i35672 How does this match the SQL2003 spec? I don't know. What I can read about it, it's

[HACKERS] Checkpoint cost, looks like it is WAL/CRC

2005-06-29 Thread Josh Berkus
Tom, All: Ok, finally managed though the peristent efforts of Mark Wong to get some tests through. Here are two tests with the CRC and wall buffer checking completely cut out of the code, as Tom suggested: 5-min checkpoint: http://khack.osdl.org/stp/302738/results/0/

Re: [HACKERS] Proposal: associative arrays for plpgsql (concept)

2005-06-29 Thread Pavel Stehule
On Wed, 29 Jun 2005, Douglas McNaught wrote: David Fetter [EMAIL PROTECTED] writes: I'm all in favor of having associative arrays as a 1st-class data type in PostgreSQL. How much harder would it be to make these generally available vs. tied to one particular language? We already have

Re: [HACKERS] [PATCHES] Users/Groups - Roles

2005-06-29 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: I notice that AddRoleMems/DelRoleMems assume that ADMIN OPTION is not inherited indirectly; that is it must be granted directly to you. This seems wrong; SQL99 has under privileges 19) B has the WITH ADMIN OPTION on a role if a role authorization

Re: [HACKERS] Proposal: associative arrays for plpgsql (concept)

2005-06-29 Thread Andrew Dunstan
Pavel Stehule wrote: On Wed, 29 Jun 2005, Josh Berkus wrote: Pavel, The concept is from Oracle 9i, but with some changes. http://www.oracle-10g.de/oracle_10g_documentation/appdev.101/b10807/05_coll s.htm#i35672 How does this match the SQL2003 spec? I

Re: [HACKERS] Open items

2005-06-29 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: Stephen Frost [EMAIL PROTECTED] writes: ... We really should also support SET ROLE. Perhaps if I have time I'll go through the SQL spec looking at the specific requirements of 'Basic Role Support' and 'Extended Role Support' and come up with what

Re: [HACKERS] Open items

2005-06-29 Thread Tom Lane
Stephen Frost [EMAIL PROTECTED] writes: Here's the results of this. I think we're pretty close to having both Basic roles and Extended roles personally. For 'Basic roles' we need SET ROLE and some information schema tables. The information schema views already exist, although I suspect the

Re: [HACKERS] Proposal: associative arrays for plpgsql (concept)

2005-06-29 Thread David Fetter
On Wed, Jun 29, 2005 at 01:20:17PM -0400, Douglas McNaught wrote: David Fetter [EMAIL PROTECTED] writes: I'm all in favor of having associative arrays as a 1st-class data type in PostgreSQL. How much harder would it be to make these generally available vs. tied to one particular

Re: [HACKERS] commit_delay, siblings

2005-06-29 Thread Simon Riggs
On Wed, 2005-06-29 at 10:16 -0400, Tom Lane wrote: Simon Riggs [EMAIL PROTECTED] writes: Group commit is a well-documented technique for improving performance, The issue here is not is group commit a good idea in the abstract?. It is is the commit_delay implementation of the idea worth a

Re: [HACKERS] Open items

2005-06-29 Thread Stephen Frost
* Tom Lane ([EMAIL PROTECTED]) wrote: Stephen Frost [EMAIL PROTECTED] writes: Here's the results of this. I think we're pretty close to having both Basic roles and Extended roles personally. For 'Basic roles' we need SET ROLE and some information schema tables. The information schema

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-06-29 Thread Andreas Pflug
Bruce Momjian wrote: Yea, but then we have toast and we would need another name. I suggested pg_storage_size() because it relates to a storage unit (index, toast, etc), and not a real object or relation. I'm not really happy that all functions change their names (more versioning handling

[HACKERS] Catch the commit

2005-06-29 Thread Andreas 'ads' Scherbaum
Hello, seems like a complicated question: is it possible in a module to receive an event, get a trigger fired, get a function called or something like this when the current transaction is about to be committed? Background: In a module (tablelog) i need the latest possible timestamp before

Re: [HACKERS] problem with plpgsql

2005-06-29 Thread Tom Lane
Pavel Stehule [EMAIL PROTECTED] writes: Hello In my code I evaluate expr select array(select generate_series from generate_series(1,800) my code var = (PLpgSQL_var *) (estate-datums[stmt-varno]); value = exec_eval_expr(estate, stmt-expr, isnull, valtype);

Re: [HACKERS] Checkpoint cost, looks like it is WAL/CRC

2005-06-29 Thread Tom Lane
Josh Berkus josh@agliodbs.com writes: Ok, finally managed though the peristent efforts of Mark Wong to get some tests through. Here are two tests with the CRC and wall buffer checking completely cut out of the code, as Tom suggested: Uh, what exactly did you cut out? I suggested dropping

Re: [HACKERS] [PATCHES] Dbsize backend integration

2005-06-29 Thread Tom Lane
Andreas Pflug [EMAIL PROTECTED] writes: I'm not really happy that all functions change their names (more versioning handling in pgadmin), but pg_storage_size is certainly the most precise name. Actually, it seems excessively imprecise to me: the name conveys nothing at all to help you

Re: [HACKERS] Open items

2005-06-29 Thread Satoshi Nagayasu
Bruce, I have another patch for the TODO item. From TODO item: Add ability to monitor the use of temporary sort files As I mentioned before, I created a sort statistics patch. http://archives.postgresql.org/pgsql-hackers/2004-09/msg00380.php Now my patch can work with 7.4.6 and it creates

Re: [HACKERS] Checkpoint cost, looks like it is WAL/CRC

2005-06-29 Thread Josh Berkus
Tom, Uh, what exactly did you cut out? I suggested dropping the dumping of full page images, but not removing CRCs altogether ... Attached is the patch I used. (it's a -Urn patch 'cause that's what STP takes) -- --Josh Josh Berkus Aglio Database Solutions San Francisco diff -urN

Re: [HACKERS] Open items

2005-06-29 Thread Josh Berkus
Satoshi, sort=# select * from pg_stat_sorts ;   datname  | heap_all | index_all | heap_tape | index_tape | max_size ---+--+---+---++--  sort      |       11 |         0 |         3 |          0 | 11141120  template1 |        2 |         0 |

Re: [HACKERS] Open items

2005-06-29 Thread Tom Lane
Josh Berkus josh@agliodbs.com writes: Satoshi, sort=# select * from pg_stat_sorts ;   datname  | heap_all | index_all | heap_tape | index_tape | max_size Good for me, if you explain the column names? I was wondering about that too ... temporary sort files haven't got indexes ...

Re: [HACKERS] Checkpoint cost, looks like it is WAL/CRC

2005-06-29 Thread Tom Lane
Josh Berkus josh@agliodbs.com writes: Uh, what exactly did you cut out? I suggested dropping the dumping of full page images, but not removing CRCs altogether ... Attached is the patch I used. OK, thanks for the clarification. So it does seem that dumping full page images is a pretty big

Re: [HACKERS] Checkpoint cost, looks like it is WAL/CRC

2005-06-29 Thread Tom Lane
Josh Berkus josh@agliodbs.com writes: 1. Offer a GUC to turn off full-page-image dumping, which you'd use only if you really trust your hardware :-( Are these just WAL pages? Or database pages as well? Database pages. The current theory is that we can completely reconstruct from WAL data

Re: [HACKERS] Open items

2005-06-29 Thread Satoshi Nagayasu
Tom Lane wrote: Josh Berkus josh@agliodbs.com writes: Satoshi, sort=# select * from pg_stat_sorts ; � datname �| heap_all | index_all | heap_tape | index_tape | max_size Good for me, if you explain the column names? I was wondering about that too ... temporary sort files haven't got

[HACKERS] Build errors latest CVS freebsd

2005-06-29 Thread Christopher Kings-Lynne
gmake distclean ./configure ... gmake install ... gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -fno-strict-aliasing -g -I../../../../src/include -c -o timestamp.o timestamp.c -MMD timestamp.c: In function `GetCurrentTimestamp': timestamp.c:955: storage size of `tp' isn't known

Re: [HACKERS] Checkpoint cost, looks like it is WAL/CRC

2005-06-29 Thread Josh Berkus
Tom, 1. Offer a GUC to turn off full-page-image dumping, which you'd use only if you really trust your hardware :-( Are these just WAL pages? Or database pages as well? -- --Josh Josh Berkus Aglio Database Solutions San Francisco ---(end of

Re: [HACKERS] HEAD: Compile issues on UnixWare 7.1.4

2005-06-29 Thread Andrew Dunstan
Larry Rosenman wrote: I'll play some more, but I'm at a loss. Especially since REL8_0_STABLE fails as well :( It was a PATH problem, as Larry discovered. With the patch I posted tonight both these branches run fine on Larry's machine (see below) FYI, I notice that, on this platform,

Re: [HACKERS] HEAD: Compile issues on UnixWare 7.1.4

2005-06-29 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: FYI, I notice that, on this platform, on both HEAD and REL8_0_STABLE, the contrib/intarray tests run *extremely* slowly on both branches, apparently taking huge amounts of time over the last two gist index creation statements. It ran so slowly that I

Re: [HACKERS] Open items

2005-06-29 Thread Tom Lane
Satoshi Nagayasu [EMAIL PROTECTED] writes: My patch counts inittapes(), tuplesort_begin_heap() and tuplesort_begin_index(), and collect them, and sum them through the stat collector. Hm, that doesn't seem like quite the right level to be counting at. Shouldn't you be hacking fd.c to count

Re: [HACKERS] Build errors latest CVS freebsd

2005-06-29 Thread Tom Lane
Christopher Kings-Lynne [EMAIL PROTECTED] writes: timestamp.c: In function `GetCurrentTimestamp': timestamp.c:955: storage size of `tp' isn't known timestamp.c:957: warning: implicit declaration of function `gettimeofday' timestamp.c:955: warning: unused variable `tp' timestamp.c:954: