Re: [HACKERS] CommitFest 2009-07 - End of Week 1

2009-07-22 Thread Magnus Hagander
On Wed, Jul 22, 2009 at 05:35, Tom Lanet...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: There are a few patches that have some level of committer endorsement from previous discussions, and it's not clear whether any round-robin review is required.  These are: Fix memory

Re: [HACKERS] [PATCH] SE-PgSQL/tiny rev.2193

2009-07-22 Thread Peter Eisentraut
On Monday 20 July 2009 17:52:44 Joshua Brindle wrote: That is your (and the communities) prerogative. Linus wasn't very supportive of SELinux in the kernel either but it is the only way Linux got an EAL4+ LSPP evaluation for use in certain government systems. I personally would love to see an

Re: [HACKERS] Non-blocking communication between a frontend and a backend (pqcomm)

2009-07-22 Thread Fujii Masao
Hi, On Wed, Jul 22, 2009 at 2:20 AM, Robert Haasrobertmh...@gmail.com wrote: Fujii Masao, Are you planning to update this patch based on Martin's review? Sure. Attached is an updated patch. On Fri, Jul 17, 2009 at 5:26 PM, Martin Pihlakmartin.pih...@gmail.com wrote: Here's my initial

Re: [HACKERS] [PATCH] SE-PgSQL/tiny rev.2193

2009-07-22 Thread KaiGai Kohei
Peter Eisentraut wrote: On Monday 20 July 2009 17:52:44 Joshua Brindle wrote: That is your (and the communities) prerogative. Linus wasn't very supportive of SELinux in the kernel either but it is the only way Linux got an EAL4+ LSPP evaluation for use in certain government systems. I

Re: [HACKERS] Higher TOAST compression.

2009-07-22 Thread Laurent Laborde
My 1st applied patch is the safest and simpliest : in pg_lzcompress.c : static const PGLZ_Strategy strategy_default_data = { 256,/* Data chunks less than 256 are not compressed */ 256,/* force compression on data chunks on record = 256bytes */ 1, /*

Re: [HACKERS] [PATCH] user mapping extension to pg_ident.conf

2009-07-22 Thread Magnus Hagander
On Tue, Jul 21, 2009 at 16:06, Tom Lanet...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Tue, Jul 21, 2009 at 15:58, Tom Lanet...@sss.pgh.pa.us wrote: Are you not describing a behavior that you yourself removed in 8.4, ie the libpq code that looked aside at Kerberos for

Re: [HACKERS] psql - small fix in \du

2009-07-22 Thread Andreas Wenk
ANdreas Wenk schrieb: Hi, attached you can find a very small patch for the help in psql (\?). It's possible to use \du also as \du+ . The [+] was missing in help. I was asking about this at the general list and Peter E. was asking me to provide a patch. I sent the patch there but realized

Re: [HACKERS] WIP: Deferrable unique constraints

2009-07-22 Thread Dean Rasheed
2009/7/22 Dean Rasheed dean.a.rash...@googlemail.com: OK, here's an updated patch. In case it's not obvious, I've opted for backend/commands for the new file.  - Dean -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Upgrading our minimum required flex version for 8.5

2009-07-22 Thread Magnus Hagander
On Tue, Jul 14, 2009 at 05:10, Andrew Dunstanand...@dunslane.net wrote: Tom Lane wrote: Maybe for the time being we need to think about keeping scan.c in CVS. It's not like scan.l gets updated all that often. We could if we had to, though it amounts to saying that Windows-based developers

Re: [HACKERS] Upgrading our minimum required flex version for 8.5

2009-07-22 Thread Dave Page
On Wed, Jul 22, 2009 at 12:42 PM, Magnus Hagandermag...@hagander.net wrote: FWIW, it seems the version that Andrew put up doesn't work in one of my test environments, and also not in at last one of Dave's. I will test it in my second test environment later today to be sure. It doesn't work in

Re: [HACKERS] Upgrading our minimum required flex version for 8.5

2009-07-22 Thread Andrew Dunstan
Dave Page wrote: On Wed, Jul 22, 2009 at 12:42 PM, Magnus Hagandermag...@hagander.net wrote: FWIW, it seems the version that Andrew put up doesn't work in one of my test environments, and also not in at last one of Dave's. I will test it in my second test environment later today to be

Re: [HACKERS] [PATCH] user mapping extension to pg_ident.conf

2009-07-22 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: Yup, you would need a protocol change that would allow the client to change its mind about what the username was after it got the auth challenge.  And then what effects does that have on username-sensitive pg_hba.conf decisions?  We go back and

Re: [HACKERS] [PATCH] user mapping extension to pg_ident.conf

2009-07-22 Thread Magnus Hagander
On Wed, Jul 22, 2009 at 14:53, Tom Lanet...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Yup, you would need a protocol change that would allow the client to change its mind about what the username was after it got the auth challenge.  And then what effects does that have

Re: [HACKERS] Upgrading our minimum required flex version for 8.5

2009-07-22 Thread Tom Lane
Dave Page dp...@pgadmin.org writes: It doesn't work in any of my bf animals, or build machines :-( ?? narwhal seems to have gone green. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] psql - small fix in \du

2009-07-22 Thread Tom Lane
Andreas Wenk a.w...@netzmeister-st-pauli.de writes: I am not sure when the function shobj_description(oid, name) is giving a result. That retrieves the comment for the object (the role, in this case). regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Upgrading our minimum required flex version for 8.5

2009-07-22 Thread Dave Page
On Wed, Jul 22, 2009 at 2:16 PM, Tom Lanet...@sss.pgh.pa.us wrote: Dave Page dp...@pgadmin.org writes: It doesn't work in any of my bf animals, or build machines :-( ?? narwhal seems to have gone green. Narwhal is mingw/msys. The misbehaving flex is the one provided by Andrew for use with

Re: [HACKERS] Upgrading our minimum required flex version for 8.5

2009-07-22 Thread Andrew Dunstan
Tom Lane wrote: Dave Page dp...@pgadmin.org writes: It doesn't work in any of my bf animals, or build machines :-( ?? narwhal seems to have gone green. Yeah, the problem is with MSVC, Narwal is a Mingw box. cheers andrew -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Higher TOAST compression.

2009-07-22 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kevin.gritt...@wicourts.gov writes: It seems like it might be reasonable to have a separate threshold for compression from that for out-of-line storage. Since I've been in that code recently, I would be pretty comfortable doing something

Re: [HACKERS] [PATCH] could not reattach to shared memory on Windows

2009-07-22 Thread Magnus Hagander
On Tue, Jul 21, 2009 at 14:06, Magnus Hagandermag...@hagander.net wrote: On Wed, Jul 15, 2009 at 11:20, Tsutomu Yamadatsut...@sraoss.co.jp wrote: Hello, Alvaro Herrera alvhe...@commandprompt.com wrote:   Tsutomu Yamada wrote:     This patch using VirtualAlloc()/VirtualFree() to avoid

Re: [HACKERS] Higher TOAST compression.

2009-07-22 Thread Kevin Grittner
I wrote: If we want to allow a compression target external storage target, I guess we would have to allow the smaller target to go first Scratch that part -- even with a compression target the external storage target, it would make sense use the same sequence of steps. -Kevin -- Sent

Re: [HACKERS] Higher TOAST compression.

2009-07-22 Thread Kevin Grittner
Sorry I responded that quickly this early. I keep having additional thoughts Kevin Grittner kevin.gritt...@wicourts.gov wrote: Tom Lane t...@sss.pgh.pa.us wrote: And especially, how could you have per-column targets? Yeah, this would have to be done by table, not by column. If we

Re: [HACKERS] revised hstore patch

2009-07-22 Thread Andrew Gierth
Tom == Tom Lane t...@sss.pgh.pa.us writes: I'm prepared to give slightly more consideration to option #3: make the new code read the old format as well as the new one. Tom If you think you can make that work, it would solve the problem. I was hoping to do it without changing the new

Re: [HACKERS] revised hstore patch

2009-07-22 Thread David E. Wheeler
On Jul 22, 2009, at 8:55 AM, Andrew Gierth wrote: The other option would be to fix the wasted-space bug in the existing hstore, and document that stored data must be updated at least once subsequent to that fix before doing a binary migrate to 8.5. Given this… (The pathological case is

Re: [HACKERS] change do_tup_output to take Datum arguments rather than cstring

2009-07-22 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Mon, Jun 15, 2009 at 1:20 PM, Tom Lanet...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: it looks like I can probably rip that member out of TupOutputState altogether. Yeah, that's exactly what I was thinking. Excellent.

Re: [HACKERS] revised hstore patch

2009-07-22 Thread Dimitri Fontaine
Hi, Le 22 juil. 09 à 02:56, Robert Haas a écrit : On Tue, Jul 21, 2009 at 7:25 PM, Tom Lanet...@sss.pgh.pa.us wrote: Or maybe we should think about having two versions of hstore. This is all tied up in the problem of having a decent module infrastructure (which I hope somebody is working

Re: [HACKERS] revised hstore patch

2009-07-22 Thread Robert Haas
On Wed, Jul 22, 2009 at 1:40 PM, Dimitri Fontainedfonta...@hi-media.com wrote: Hi, Le 22 juil. 09 à 02:56, Robert Haas a écrit : On Tue, Jul 21, 2009 at 7:25 PM, Tom Lanet...@sss.pgh.pa.us wrote: Or maybe we should think about having two versions of hstore.  This is all tied up in the

Re: [HACKERS] revised hstore patch

2009-07-22 Thread Andrew Gierth
David == David E Wheeler da...@kineticode.com writes: The other option would be to fix the wasted-space bug in the existing hstore, and document that stored data must be updated at least once subsequent to that fix before doing a binary migrate to 8.5. [...] David Could it be that

[HACKERS] Extension Facility

2009-07-22 Thread Dimitri Fontaine
Hi, The same mail as before in a new thread, per Robert comment. Including the body rather than an archive link for various reasons, including making it easy to comment here rather than there. Le 22 juil. 09 à 02:56, Robert Haas a écrit : On Tue, Jul 21, 2009 at 7:25 PM, Tom

[HACKERS] SRPMs?

2009-07-22 Thread Andrew Dunstan
Where are the SRPMs to go with the binary RPMs on our download sites (or for that matter on yum.pgsqlrpms.org). ISTM we should not be publishing binary RPMs without simultaneously publishing the corresponding SRPMs. cheers andrew -- Sent via pgsql-hackers mailing list

Re: [HACKERS] psql - small fix in \du

2009-07-22 Thread Andreas Wenk
Tom Lane wrote: Andreas Wenk a.w...@netzmeister-st-pauli.de writes: I am not sure when the function shobj_description(oid, name) is giving a result. That retrieves the comment for the object (the role, in this case). regards, tom lane Tom, thank you. I will provide

Re: [HACKERS] GEQO vs join order restrictions

2009-07-22 Thread Andres Freund
Hi Tom, Robert, Hi all, nks, On Sunday 19 July 2009 19:23:18 Tom Lane wrote: Andres Freund and...@anarazel.de writes: On Saturday 18 July 2009 17:48:14 Tom Lane wrote: I'm inclined to address this by rewriting gimme_tree so that it *always* finds a valid join order based on the given tour.

Re: [HACKERS] extension facility (was: revised hstore patch)

2009-07-22 Thread Robert Haas
On Tue, Jul 21, 2009 at 8:56 PM, Robert Haasrobertmh...@gmail.com wrote: A decent module infrastructure is probably not going to fix this problem unless it links with -ldwiw. There are really only two options here: - Keep the old version around for compatibility and add a new version that

[HACKERS] Aggregate-function space leakage

2009-07-22 Thread Tom Lane
I looked into Chris Spotts' recent report of massive memory leakage in 8.4, in a case involving array_agg() executed in a GROUP BY query: http://archives.postgresql.org/pgsql-general/2009-07/msg00858.php The reason for that turns out to be that we deliberately lobotomized array_agg that way, just

Re: [HACKERS] Aggregate-function space leakage

2009-07-22 Thread Jeff Davis
On Wed, 2009-07-22 at 17:14 -0400, Tom Lane wrote: One possibility is to have nodeAgg.c reset the aggcontext between groups when in group mode. I think this would be more than a one-liner fix because it probably has pointers to transvalues that are in that context, but it's surely doable. Is

Re: [HACKERS] Aggregate-function space leakage

2009-07-22 Thread Tom Lane
Jeff Davis pg...@j-davis.com writes: On Wed, 2009-07-22 at 17:14 -0400, Tom Lane wrote: One possibility is to have nodeAgg.c reset the aggcontext between groups when in group mode. I think this would be more than a one-liner fix because it probably has pointers to transvalues that are in that

Re: [HACKERS] Aggregate-function space leakage

2009-07-22 Thread Greg Stark
On Wed, Jul 22, 2009 at 10:14 PM, Tom Lanet...@sss.pgh.pa.us wrote: The reason for that turns out to be that we deliberately lobotomized array_agg that way, just last month: http://archives.postgresql.org/pgsql-committers/2009-06/msg00259.php in response to this problem:

Re: [HACKERS] Determining client_encoding from client locale

2009-07-22 Thread Jaime Casanova
On Mon, Jul 6, 2009 at 10:00 AM, Heikki Linnakangasheikki.linnakan...@enterprisedb.com wrote: Here's my first attempt at setting client_encoding automatically from locale. It adds a new conninfo parameter to libpq, client_encoding. If set to auto, libpq uses the encoding as returned by

[HACKERS] join regression failure on cygwin

2009-07-22 Thread Andrew Dunstan
My Cygwin buildfarm member started failing (hanging, in fact) recently. It seems to hang consistently in join.sql and the only way I can get it to complete is to kill the backend fairly violently. See http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=brown_batdt=2009-07-22%2023:10:21 It

Re: [HACKERS] Determining client_encoding from client locale

2009-07-22 Thread Alvaro Herrera
Jaime Casanova wrote: this little test compiles fine until i applied your patch :( postg...@casanova1:~/pg_releases/pgtests$ gcc -o test-libpq test-libpq.o -L/usr/local/pgsql/head/lib -lpq /usr/local/pgsql/head/lib/libpq.so: undefined reference to `pg_get_encoding_from_locale' Do you have

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-22 Thread Robert Haas
On Fri, Jul 17, 2009 at 9:46 PM, Joshua Tolleyeggyk...@gmail.com wrote: On Tue, Jul 14, 2009 at 11:10:00PM +0200, Petr Jelinek wrote: Hello, this is first public version of our DefaultACLs patch as described on http://wiki.postgresql.org/wiki/DefaultACL . Ok, here's my first crack at a

Re: [HACKERS] [PATCH 1/2 v3] [libpq] rework sigpipe-handling macros

2009-07-22 Thread Robert Haas
On Mon, Jul 20, 2009 at 3:14 AM, Jeremy Kerrj...@ozlabs.org wrote: That code is not broken as it stands, and doesn't appear to really gain anything from the proposed change.  Why should we risk any portability questions when the code isn't going to get either simpler or shorter? OK, after

Re: [HACKERS] [PATCH] Psql List Languages

2009-07-22 Thread Robert Haas
On Sun, Jul 19, 2009 at 4:00 AM, Peter Eisentrautpete...@gmx.net wrote: Please submit an updated patch. Fernando, If you would like to have this change committed during this CommitFest, please submit an updated patch ASAP. Otherwise, you can resubmit for the next CommitFest in September.

Re: [HACKERS] [PATCH] Psql List Languages

2009-07-22 Thread Greg Stark
On Thu, Jul 23, 2009 at 2:23 AM, Robert Haasrobertmh...@gmail.com wrote: If you would like to have this change committed during this CommitFest, please submit an updated patch ASAP.  Otherwise, you can resubmit for the next CommitFest in September. You know, I don't think we have any rules

Re: [HACKERS] [PATCH] Psql List Languages

2009-07-22 Thread Robert Haas
On Wed, Jul 22, 2009 at 9:35 PM, Greg Starkgsst...@mit.edu wrote: On Thu, Jul 23, 2009 at 2:23 AM, Robert Haasrobertmh...@gmail.com wrote: If you would like to have this change committed during this CommitFest, please submit an updated patch ASAP.  Otherwise, you can resubmit for the next

Re: [HACKERS] Upgrading our minimum required flex version for 8.5

2009-07-22 Thread Greg Smith
I got bit by this tonight as part of testing a patch on CentOS 5, which like RHEL 5 still ships flex 2.5.4. I just wrote a little guide on how to grab a source RPM from a Fedora version and install it to work around that problem:

Re: [HACKERS] join regression failure on cygwin

2009-07-22 Thread Andrew Dunstan
I wrote: My Cygwin buildfarm member started failing (hanging, in fact) recently. It seems to hang consistently in join.sql and the only way I can get it to complete is to kill the backend fairly violently. See

Re: [HACKERS] [PATCH] Psql List Languages

2009-07-22 Thread Robert Haas
On Wed, Jul 22, 2009 at 9:43 PM, Robert Haasrobertmh...@gmail.com wrote: On Wed, Jul 22, 2009 at 9:35 PM, Greg Starkgsst...@mit.edu wrote: On Thu, Jul 23, 2009 at 2:23 AM, Robert Haasrobertmh...@gmail.com wrote: If you would like to have this change committed during this CommitFest, please

Re: [HACKERS] multi-threaded pgbench

2009-07-22 Thread Greg Smith
I just took multi-threaded pgbench for an initial spin, looks good overall with only a couple of small rough edges. The latest code works differently depending on whether you compiled with --enable-thread-safety or not, it defines some structures based on fork if it's not enabled: #elif

Re: [HACKERS] [PATCH] Psql List Languages

2009-07-22 Thread Greg Stark
On Thu, Jul 23, 2009 at 3:11 AM, Robert Haasrobertmh...@gmail.com wrote: If my email struck you as rude, I certainly apologize for that.  I'm trying really hard to be efficient about this without stepping on anyone's feelings, but that's a fine line to walk and I'm not sure I'll always be on

Re: [HACKERS] Determining client_encoding from client locale

2009-07-22 Thread Jaime Casanova
On Wed, Jul 22, 2009 at 7:30 PM, Alvaro Herreraalvhe...@commandprompt.com wrote: Jaime Casanova wrote: this little test compiles fine until i applied your patch :( postg...@casanova1:~/pg_releases/pgtests$ gcc -o test-libpq test-libpq.o -L/usr/local/pgsql/head/lib -lpq

Re: [HACKERS] generic explain options v3

2009-07-22 Thread Robert Haas
On Tue, Jul 21, 2009 at 10:29 PM, Robert Haasrobertmh...@gmail.com wrote: On Tue, Jul 21, 2009 at 10:05 PM, Tom Lanet...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Tue, Jul 21, 2009 at 7:47 PM, Tom Lanet...@sss.pgh.pa.us wrote: Also, I'd suggest changing the ExplainStmt

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-22 Thread Joshua Tolley
On Wed, Jul 22, 2009 at 08:54:19PM -0400, Robert Haas wrote: I am gathering that this patch is still a bit of a WIP. I don't consider it a WIP. Petr posted a patch a couple of days ago, but I've not been able to verify its changes or perform some additional testing I had in mind, because of my

Re: [HACKERS] multi-threaded pgbench

2009-07-22 Thread Itagaki Takahiro
Greg Smith gsm...@gregsmith.com wrote: That second code path, when --enable-thread-safety is turned off, crashes and burns on my Linux system: It comes from confliction of identifiers. Renaming identifiers with #define can solve the errors: #define pthread_t

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-22 Thread Petr Jelinek
Robert Haas wrote: So are these warts fixed in the latest revision of this patch? http://archives.postgresql.org/pgsql-hackers/2009-07/msg01216.php I am gathering that this patch is still a bit of a WIP. I think it might be best to mark it returned with feedback and let Petr resubmit for the

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-22 Thread Robert Haas
On Wed, Jul 22, 2009 at 11:21 PM, Joshua Tolleyeggyk...@gmail.com wrote: On Wed, Jul 22, 2009 at 08:54:19PM -0400, Robert Haas wrote: I am gathering that this patch is still a bit of a WIP. I don't consider it a WIP. Petr posted a patch a couple of days ago, but I've not been able to verify

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-22 Thread Robert Haas
On Wed, Jul 22, 2009 at 11:26 PM, Petr Jelinekpjmo...@pjmodos.net wrote: Robert Haas wrote: So are these warts fixed in the latest revision of this patch? http://archives.postgresql.org/pgsql-hackers/2009-07/msg01216.php I am gathering that this patch is still a bit of a WIP.  I think it

Re: [HACKERS] [PATCH] DefaultACLs

2009-07-22 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: On Wed, Jul 22, 2009 at 11:26 PM, Petr Jelinekpjmo...@pjmodos.net wrote: The docs are not complete but that's up to Stephen, otherwise the patch should be finished. But I am not the reviewer :) Well, perhaps we had better prod Stephen then,

Re: [HACKERS] Determining client_encoding from client locale

2009-07-22 Thread Jaime Casanova
On Wed, Jul 22, 2009 at 9:58 PM, Jaime Casanovajcasa...@systemguards.com.ec wrote: On Wed, Jul 22, 2009 at 7:30 PM, Alvaro Herreraalvhe...@commandprompt.com wrote: Jaime Casanova wrote: this little test compiles fine until i applied your patch :( postg...@casanova1:~/pg_releases/pgtests$

Re: [HACKERS] join regression failure on cygwin

2009-07-22 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: My Cygwin buildfarm member started failing (hanging, in fact) recently. It seems to hang consistently in join.sql and the only way I can get it to complete is to kill the backend fairly violently. See