Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-08 Thread Pavel Stehule
Hello 2010/8/8 Tom Lane : > Pavel Stehule writes: >> updated patch attached > > What exactly is the point of the \sf command?  It seems like quite a lot > of added code for a feature that nobody has requested, and whose > definition is about as ad-hoc as could be.  Personally I'd much sooner > us

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-08 Thread Pavel Stehule
2010/8/9 Tom Lane : > Robert Haas writes: >> On Sun, Aug 8, 2010 at 1:14 PM, Tom Lane wrote: >>> What exactly is the point of the \sf command? > >> I rather like \sf, actually; in fact, I think there's a decent >> argument to be made that it's more useful than the line-numbering >> stuff for \ef.

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-08 Thread Mike Fowler
On 09/08/10 04:07, Tom Lane wrote: Robert Haas writes: On Sun, Aug 8, 2010 at 11:36 AM, Mike Fowler wrote: 1) XML2 is largely undocumented, giving rise to the problems encountered. Since the module is deprecated anyways, does it make more sense to get xslt handling moved into core and get it

Re: [HACKERS] more personal copyrights

2010-08-08 Thread Tatsuo Ishii
> A few months ago Bruce was doing a hunting of personal Copyrights > notices, but i still found a lot of files copyrighted to: Regents of > the University of California and other files copyrighted to > individuals (ej: almost everything inside src/backend/regex is > copyrighted to Henry Spencer) >

[HACKERS] more personal copyrights

2010-08-08 Thread Jaime Casanova
Hi, A few months ago Bruce was doing a hunting of personal Copyrights notices, but i still found a lot of files copyrighted to: Regents of the University of California and other files copyrighted to individuals (ej: almost everything inside src/backend/regex is copyrighted to Henry Spencer) there

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-08 Thread Tom Lane
Robert Haas writes: > On Sun, Aug 8, 2010 at 1:14 PM, Tom Lane wrote: >> What exactly is the point of the \sf command? > I rather like \sf, actually; in fact, I think there's a decent > argument to be made that it's more useful than the line-numbering > stuff for \ef. I don't particularly like

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-08 Thread Tom Lane
Robert Haas writes: > On Sun, Aug 8, 2010 at 11:36 AM, Mike Fowler wrote: >> 1) XML2 is largely undocumented, giving rise to the problems encountered. >> Since the module is deprecated anyways, does it make more sense to get xslt >> handling moved into core and get it fully documented? > Yes, I

Re: [HACKERS] Patch review: make RAISE without arguments work like Oracle

2010-08-08 Thread Tom Lane
David Fetter writes: > I'd like to mark this as Ready for Committer :) Applied with corrections. The main noncosmetic change was that the estate field has to be saved and restored, not just arbitrarily reset to null after running a handler. Otherwise nested exception handlers interfere with eac

Re: [HACKERS] pg_stat_user_functions' notion of user

2010-08-08 Thread Josh Berkus
On 8/8/10 8:40 AM, David Fetter wrote: >> Would anyone object to changing it to make it more consistent with >> other others? And since we're jollily making catalog changes in 9.0 >> still, could this also be backpatched? I'd object. It's not a bug (arguable spec, maybe, but working as spec'd),

Re: [HACKERS] pg_stat_user_functions' notion of user

2010-08-08 Thread Tom Lane
Peter Eisentraut writes: > On sön, 2010-08-08 at 11:59 -0400, Tom Lane wrote: >> The reason for the inconsistency is that the underlying behavior is >> different: fmgr automatically doesn't collect stats for internal >> functions. > Sure it does: When they are defined in language SQL. Those are

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-08 Thread Robert Haas
On Sun, Aug 8, 2010 at 11:36 AM, Mike Fowler wrote: > On 06/08/10 17:50, Pavel Stehule wrote: >> attached updated patch with regression test > > Bravely ignoring the quotation/varidic/ > conversations, Thank you! > I've taken a look at the patch as is. Excellent. > Thanks to Tom's input I > ca

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-08 Thread Robert Haas
On Sun, Aug 8, 2010 at 1:14 PM, Tom Lane wrote: > Pavel Stehule writes: >> updated patch attached > > What exactly is the point of the \sf command?  It seems like quite a lot > of added code for a feature that nobody has requested, and whose > definition is about as ad-hoc as could be.  Personall

[HACKERS] parallel quicksort

2010-08-08 Thread Mark Wong
Hi everyone, I've been playing around with a process based parallel quicksort (http://github.com/markwkm/quicksort) and I tried to shoehorn it into postgres because I wanted to see if I could sort more than integers. I've attached a patch that creates a new GUC to control the degree of parallelism

Re: [HACKERS] review: xml_is_well_formed

2010-08-08 Thread Robert Haas
On Sun, Aug 8, 2010 at 1:45 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On lör, 2010-07-31 at 13:40 -0400, Robert Haas wrote: >>> I think the point of this function is to determine whether a cast to >>> xml will throw an error.  The behavior should probably match exactly >>> whatever test w

[HACKERS] ALTER TYPE extensions

2010-08-08 Thread Peter Eisentraut
For the next review cycle, here is a patch that adds some ALTER TYPE subcommands for composite types: ALTER TYPE ... ADD ATTRIBUTE ALTER TYPE ... DROP ATTRIBUTE ALTER TYPE ... ALTER ATTRIBUTE ... SET DATA TYPE ALTER TYPE ... RENAME ATTRIBUTE These work similarly to the analogous ALTER TABLE / $AC

Re: [HACKERS] pg_stat_user_functions' notion of user

2010-08-08 Thread Peter Eisentraut
On sön, 2010-08-08 at 11:59 -0400, Tom Lane wrote: > The reason for the inconsistency is that the underlying behavior is > different: fmgr automatically doesn't collect stats for internal > functions. Sure it does: When they are defined in language SQL. -- Sent via pgsql-hackers mailing list (p

Re: Review: Re: [PATCH] Re: [HACKERS] Adding xpath_exists function

2010-08-08 Thread Tom Lane
Mike Fowler writes: > On 06/08/10 20:55, Peter Eisentraut wrote: >> On fre, 2010-08-06 at 09:04 +0100, Mike Fowler wrote: >>> If the patch is to be committed, does it make sense for me to refine >>> it such that it uses the new xpath internal function you extracted in >>> the xmlexists patch? >>

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-08 Thread Pavel Stehule
2010/8/8 David E. Wheeler : > On Aug 8, 2010, at 9:10 AM, Pavel Stehule wrote: > >>> There are no keys. >> >> ok - I didn't use a correct name - so "indexed set" is better. > > Hash? Just only hash isn't good model, because I sometimes we would prefer a ordered set Regards Pavel > > David > >

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-08 Thread Pavel Stehule
2010/8/8 Kevin Grittner : > Pavel Stehule  wrote: > >> I didn't use a correct name - so "indexed set" is better. > > How would such a thing differ from a RAM-based local temporary table? temporary tables are too heavy for this purposes. In SQL environment I expecting a transactional behave from ta

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-08 Thread Pavel Stehule
2010/8/8 Tom Lane : > Pavel Stehule writes: >> updated patch attached > > What exactly is the point of the \sf command?  It seems like quite a lot > of added code for a feature that nobody has requested, and whose > definition is about as ad-hoc as could be.  Personally I'd much sooner > use \ef f

Re: [HACKERS] review: xml_is_well_formed

2010-08-08 Thread Tom Lane
Peter Eisentraut writes: > On lör, 2010-07-31 at 13:40 -0400, Robert Haas wrote: >> I think the point of this function is to determine whether a cast to >> xml will throw an error. The behavior should probably match exactly >> whatever test would be applied there. > Maybe there should be > xml

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-08 Thread David E. Wheeler
On Aug 8, 2010, at 9:10 AM, Pavel Stehule wrote: >> There are no keys. > > ok - I didn't use a correct name - so "indexed set" is better. Hash? David -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] review: psql: edit function, show function commands patch

2010-08-08 Thread Tom Lane
Pavel Stehule writes: > updated patch attached What exactly is the point of the \sf command? It seems like quite a lot of added code for a feature that nobody has requested, and whose definition is about as ad-hoc as could be. Personally I'd much sooner use \ef for looking at a function definit

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-08 Thread Kevin Grittner
Pavel Stehule wrote: > I didn't use a correct name - so "indexed set" is better. How would such a thing differ from a RAM-based local temporary table? -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.

Re: [HACKERS] pg_stat_transaction patch

2010-08-08 Thread Tom Lane
Itagaki Takahiro writes: > "Accessor functions to get so far collected statistics for the current > transaction" > https://commitfest.postgresql.org/action/patch_view?id=301 > The only issue in the patch is too long view and function names: > - pg_stat_transaction_user_tables (31 chars) > - p

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-08 Thread Pavel Stehule
2010/8/8 David E. Wheeler : > On Aug 7, 2010, at 11:05 PM, Pavel Stehule wrote: > >>> COLLECTION? >> >> yes, sorry - simply - class where fields can be accessed via specified >> index - unique or not unique. > > Like in Oracle? From: > http://download.oracle.com/docs/cd/B19306_01/appdev.102/b14261

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-08 Thread David E. Wheeler
On Aug 7, 2010, at 11:05 PM, Pavel Stehule wrote: >> COLLECTION? > > yes, sorry - simply - class where fields can be accessed via specified > index - unique or not unique. Like in Oracle? From: http://download.oracle.com/docs/cd/B19306_01/appdev.102/b14261/collections.htm > A collection is an

Re: [HACKERS] pg_stat_user_functions' notion of user

2010-08-08 Thread Tom Lane
Peter Eisentraut writes: > On tor, 2010-08-05 at 07:13 -0700, David Fetter wrote: >> On Thu, Aug 05, 2010 at 04:58:32PM +0300, Peter Eisentraut wrote: >>> pg_stat_user_functions has an inconsistent notion of what "user" is. >>> Whereas the other pg_stat_user_* views filter out non-user objects >>>

Re: [HACKERS] scheduling

2010-08-08 Thread Tom Lane
Robert Haas writes: > Do we have a projected data for the next 9.0 wrap, and will it be > beta5 or rc1? No, and don't know ;-). It won't be till after the 15th because assorted people are on vacation. Perhaps a reasonable plan is to wrap on the 19th (week from Thursday), and to decide mid next

Re: [HACKERS] pg_stat_user_functions' notion of user

2010-08-08 Thread David Fetter
On Sun, Aug 08, 2010 at 03:25:06PM +0300, Peter Eisentraut wrote: > On tor, 2010-08-05 at 07:13 -0700, David Fetter wrote: > > On Thu, Aug 05, 2010 at 04:58:32PM +0300, Peter Eisentraut wrote: > > > pg_stat_user_functions has an inconsistent notion of what "user" > > > is. Whereas the other pg_sta

Re: [HACKERS] Initial review of xslt with no limits patch

2010-08-08 Thread Mike Fowler
On 06/08/10 17:50, Pavel Stehule wrote: attached updated patch with regression test Bravely ignoring the quotation/varidic/ conversations, I've taken a look at the patch as is. Thanks to Tom's input I can now correctly drive the function. I can also report that code is now behaving in

Re: [HACKERS] Surprising dead_tuple_count from pgstattuple

2010-08-08 Thread Kevin Grittner
Gordon Shannon wrote: > If it was HOT prune, can anyone summarize what that does? Get a copy of the PostgreSQL source, and read this file: src/backend/access/heap/README.HOT -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] pg_stat_user_functions' notion of user

2010-08-08 Thread Peter Eisentraut
On tor, 2010-08-05 at 07:13 -0700, David Fetter wrote: > On Thu, Aug 05, 2010 at 04:58:32PM +0300, Peter Eisentraut wrote: > > pg_stat_user_functions has an inconsistent notion of what "user" is. > > Whereas the other pg_stat_user_* views filter out non-user objects > > by schema, pg_stat_user_func

Re: [HACKERS] Proposal / proof of concept: Triggers on VIEWs

2010-08-08 Thread Marko Tiikkaja
On 8/8/2010 12:49 PM, Dean Rasheed wrote: On 7 August 2010 10:56, Marko Tiikkaja wrote: The problem is that this isn't even nearly sufficient. I gave this some more thought while I was away, and it seems that I missed at least one more important thing: the WHERE clause. Imagine this query: D

Re: [HACKERS] Proposal / proof of concept: Triggers on VIEWs

2010-08-08 Thread Dean Rasheed
On 7 August 2010 10:56, Marko Tiikkaja wrote: > The problem is that this isn't even nearly sufficient.  I gave this some > more thought while I was away, and it seems that I missed at least one more > important thing: the WHERE clause.  Imagine this query: > > DELETE FROM view WHERE pk = 1 AND f1