Re: [HACKERS] Surprising behaviour of \set AUTOCOMMIT ON

2016-08-13 Thread Amit Kapila
On Sat, Aug 13, 2016 at 1:05 AM, David G. Johnston wrote: > > I'll admit I haven't tried to find fault with the idea (or discover better > alternatives) nor how it would look in implementation. As a user, though, > it would make sense if the system behaved in this

Re: [HACKERS] Slowness of extended protocol

2016-08-13 Thread Tatsuo Ishii
> Tatsuo>Interesting. What would happen if a user changes some of GUC > parameters? Subsequent session accidentally inherits the changed GUC > parameter? > > Yes, that is what happens. Ouch. > The idea is not to mess with gucs. > > Tatsuo>There's nothing wrong with DICARD ALL > Tatsuo>"DISCARD

Re: [HACKERS] Undiagnosed bug in Bloom index

2016-08-13 Thread Tom Lane
Jeff Janes writes: > I am getting corrupted Bloom indexes in which a tuple in the table > heap is not in the index. Hmm. I can trivially reproduce a problem, but I'm not entirely sure whether it matches yours. Same basic test case as the bloom regression test:

Re: [HACKERS] Slowness of extended protocol

2016-08-13 Thread Vladimir Sitnikov
Tatsuo>Interesting. What would happen if a user changes some of GUC parameters? Subsequent session accidentally inherits the changed GUC parameter? Yes, that is what happens. The idea is not to mess with gucs. Tatsuo>There's nothing wrong with DICARD ALL Tatsuo>"DISCARD ALL" is perfect for this

[HACKERS] WIP: Barriers

2016-08-13 Thread Thomas Munro
Hi hackers, I would like to propose "barriers" for Postgres processes. A barrier is a very simple mechanism for coordinating parallel computation, as found in many threading libraries. First, you initialise a Barrier object somewhere in shared memory, most likely in the DSM segment used by

Re: [HACKERS] to_date_valid()

2016-08-13 Thread Andreas 'ads' Scherbaum
On 27.07.2016 05:00, Joshua D. Drake wrote: On 07/26/2016 06:25 PM, Peter Eisentraut wrote: On 7/5/16 4:24 AM, Albe Laurenz wrote: But notwithstanding your feeling that you would like your application to break if it makes use of this behaviour, it is a change that might make some people pretty

[HACKERS] Reminder: upcoming 9.6 branch split and rc1 release

2016-08-13 Thread Tom Lane
Just to make sure that everyone's on the same page: the schedule the release team has agreed to is that we'll branch off REL9_6_STABLE on Aug 15 (Monday!) and issue 9.6rc1 the week of Aug 29. Barring scary bugs emerging, this should keep us on track for 9.6.0 release in late September. I will

Re: [HACKERS] Slowness of extended protocol

2016-08-13 Thread Tatsuo Ishii
> Shay>I don't know much about the Java world, but both pgbouncer and pgpool > (the major pools?) > > In Java world, https://github.com/brettwooldridge/HikariCP is a very good > connection pool. > Neither pgbouncer nor pgpool is required. > The architecture is: application <=> HikariCP <=>

Re: [HACKERS] No longer possible to query catalogs for index capabilities?

2016-08-13 Thread Tom Lane
Andrew Gierth writes: > Latest patch. > Names and scopes are as per discussion. New files for code and > regression test. Docs included. Pushed with (mostly) cosmetic adjustments. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] condition variables

2016-08-13 Thread Thomas Munro
On Fri, Aug 12, 2016 at 9:47 AM, Robert Haas wrote: > [condition-variable-v1.patch] Don't you need to set proc->cvSleeping = false in ConditionVariableSignal? -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Add hint for function named "is"

2016-08-13 Thread Tom Lane
Jim Nasby writes: > FWIW, I've always disliked how some types could contains spaces without > being quoted. AFAIK nothing else in the system allows that, and I don't > see why character varying and timestamp with* should get a special pass. Because the SQL standard

Re: [HACKERS] Add hint for function named "is"

2016-08-13 Thread Jim Nasby
On 8/12/16 1:40 PM, Tom Lane wrote: What this is telling us is that given input like, say, SELECT 'foo'::character varying Bison is no longer sure whether "varying" is meant as a type name modifier or a ColLabel. And indeed there is *no* principled answer to that that doesn't involve

Re: [HACKERS] Slowness of extended protocol

2016-08-13 Thread Vladimir Sitnikov
Shay>To be honest, the mere idea of having an SQL parser inside my driver makes me shiver. Same for me. However I cannot wait for PostgreSQL 18 that does not need client-side parsing. Shay>We did, you just dismissed or ignored them Please prove me wrong, but I did provide a justified answer to

[HACKERS] Undiagnosed bug in Bloom index

2016-08-13 Thread Jeff Janes
I am getting corrupted Bloom indexes in which a tuple in the table heap is not in the index. I see it as early as commit a9284849b48b, with commit e13ac5586c49c cherry picked onto it. I don't see it before a9284849b48b because the test-case seg faults before anything interesting can happen. I

Re: [HACKERS] Slowness of extended protocol

2016-08-13 Thread Shay Rojansky
Vladimir wrote: Shay>I don't know much about the Java world, but both pgbouncer and pgpool > (the major pools?) > > In Java world, https://github.com/brettwooldridge/HikariCP is a very good > connection pool. > Neither pgbouncer nor pgpool is required. > The architecture is: application <=>

Re: [HACKERS] No longer possible to query catalogs for index capabilities?

2016-08-13 Thread Tom Lane
Andrew Gierth writes: > Latest patch. > Names and scopes are as per discussion. New files for code and > regression test. Docs included. I'm starting to review this now. If anyone has objections to the property names/behaviors shown in Andrew's previous message,

Re: [HACKERS] handling unconvertible error messages

2016-08-13 Thread Victor Wagner
On Sat, 13 Aug 2016 12:02:30 -0400 Tom Lane wrote: > Victor Wagner writes: > > I think it is better to avoid such a problem and fix system so > > server would never send a message in the encoding, different from > > client one. > > Don't hold your

Re: [HACKERS] handling unconvertible error messages

2016-08-13 Thread Vladimir Sitnikov
Tom> while giving something at least passable in the cases that are broken today. Would you mind adding an explicit "encoding" field to the error message? At least it would give clear explanation how to parse that message without resorting to a guess dance. The biggest problem is client has no

Re: [HACKERS] handling unconvertible error messages

2016-08-13 Thread Tom Lane
Victor Wagner writes: > I think it is better to avoid such a problem and fix system so server > would never send a message in the encoding, different from client one. Don't hold your breath waiting for that to happen. Quite aside from the question of whether we want to trust

Re: [HACKERS] max_parallel_degree > 0 for 9.6 beta

2016-08-13 Thread Alvaro Herrera
Michael Paquier wrote: > Being cautious pays more in the long term, so seeing the number of > bugs that showed up I'd rather vote for having it disabled by default > in 9.6 stable, and enabled on master to aim at enabling it in 10.0. I too prefer to keep it turned off in 9.6 and consider

Re: [HACKERS] Logical Replication WIP

2016-08-13 Thread Steve Singer
On 08/05/2016 11:00 AM, Petr Jelinek wrote: Hi, as promised here is WIP version of logical replication patch. Thanks for keeping on this. This is important work Feedback is welcome. + + Publication + +A Publication object can be defined on any master node, owned by one +

Re: [HACKERS] No longer possible to query catalogs for index capabilities?

2016-08-13 Thread Andrew Gierth
Latest patch. Names and scopes are as per discussion. New files for code and regression test. Docs included. -- Andrew (irc:RhodiumToad) diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 7830334..4552a74 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@

Re: [HACKERS] handling unconvertible error messages

2016-08-13 Thread Vladimir Sitnikov
Victor>It is not a client job to convert encodings. Of course. However, there is a vast amount of old PG versions deployed in the wild that send wrong data to clients. This indeed makes bad user experience, so it is worth doing 2 things: 1) Implement proper solution in further PostgreSQL

Re: [HACKERS] Slowness of extended protocol

2016-08-13 Thread Dave Cramer
On 11 August 2016 at 10:18, Shay Rojansky wrote: > > > On Thu, Aug 11, 2016 at 1:22 PM, Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> wrote: > > 2) The driver can use safepoints and autorollback to the good "right >> before failure" state in case of a known failure. Here's

Re: [HACKERS] Slowness of extended protocol

2016-08-13 Thread Vladimir Sitnikov
Shay>I don't know much about the Java world, but both pgbouncer and pgpool (the major pools?) In Java world, https://github.com/brettwooldridge/HikariCP is a very good connection pool. Neither pgbouncer nor pgpool is required. The architecture is: application <=> HikariCP <=> pgjdbc <=>

Re: [HACKERS] handling unconvertible error messages

2016-08-13 Thread Victor Wagner
On Sat, 13 Aug 2016 09:24:47 + Vladimir Sitnikov wrote: > Victor>We don't have 190 message catalog translations in the > Victor>PostgreSQL. So problem with encoding for messages is quite > Victor>limited. > > Even though the number of translations is limited,

Re: [HACKERS] handling unconvertible error messages

2016-08-13 Thread Vladimir Sitnikov
Victor>We don't have 190 message catalog translations in the PostgreSQL. Victor>So problem with encoding for messages is quite limited. Even though the number of translations is limited, there's a problem when trying to tell one "one-byte-encoding" from another "one-byte" one. It would be so

Re: [HACKERS] new autovacuum criterion for visible pages

2016-08-13 Thread Amit Kapila
On Thu, Aug 11, 2016 at 9:29 PM, Jeff Janes wrote: > On Thu, Aug 11, 2016 at 8:32 AM, Amit Kapila wrote: >> On Thu, Aug 11, 2016 at 2:09 AM, Jeff Janes wrote: >>> I wanted to create a new relopt named something like >>>

Re: [HACKERS] [parallel query] random server crash while running tpc-h query on power2

2016-08-13 Thread Amit Kapila
On Sat, Aug 13, 2016 at 11:10 AM, Rushabh Lathia wrote: > Hi All, > > Recently while running tpc-h queries on postgresql master branch, I am > noticed > random server crash. Most of the time server crash coming while turn tpch > query > number 3 - (but its very random).