ike the better approach, as it would
> logically be part of the re-mastering command. What changes would be
> required to do this?
On my test, standby servers succeeded to subscribe the new master
when I set "recovery_target_timeline" to the new master's one.
It actually wo
the only type that
is converted to different representation in typoutput or cast-to-test,
but we should consider to have boolean-specific hardwired code,
or cast all types to text instead of output functions.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hac
re not valid syntax.
If we only use output functions, boolean values should be written as
't' or 'f' (single-quoted), Only numeric values can be unquoted on %v.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes
a to have any type-specific special
> cases.
As I remember, the original motivation of %v formatter is
some DBMSes don't like quoted numeric literals. However,
Postgres accepts quoted numerics, and we're developing Postgres.
So, our consensus would be %v formatter should be removed
c
Hi,
Anyone working on JSON datatype?
If no, I'm going to submit simplified version of JSON datatype patch.
On Wed, Aug 25, 2010 at 2:34 PM, Itagaki Takahiro
wrote:
> On Fri, Aug 13, 2010 at 7:33 PM, Joseph Adams
> wrote:
>> Updated patch: the JSON code has all been moved i
rn naked scalar values in the result array.
--
Itagaki Takahiro
basic_json-20100915.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
rt. So, I'd like to submit
>> only basic and minimal JSON datatype support at first.
>
> So should this be added to the commitfest, or replace this one?
I added my patch, but the previous one will be returned with feedback
if the author doesn't have a new version adjusted t
like to encourage use of the simplified structure to implement
his other works, including JSONPath.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
d,
and we need the part anyway if we want to support the standard.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ance
commands have non-linear progress -- Progress of index scans in VACUUM
is not linear. ALTER TABLE could have REINDEX after table rewrites.
We might need to have arbitrary knowledges for the non-uniform commands;
For example, "CREATE INDEX assigns 75% of the progress for table scan,
and 25% f
enhanced
with pains for condition push-down.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
scan + sort for CLUSTER" patch.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
mple, "ALTER TABLE ADD COLUMN" can add a column to a foreign tables
but "DROP TABLE" cannot remove foreign tables.
IMHO, however, we can allow such looseness because operations actually
forbidden will end with ERRORs without problems.
--
Itagaki Takahiro
--
Sent via
d json_stringify() is well-known APIs for JSON:
https://developer.mozilla.org/En/Using_JSON_in_Firefox
So, it'd be worth buying the names and signatures for our APIs.
(I'll rename json_pretty in my previous patch to json_stringify.)
--
Itagaki Takahiro
--
Sent via pgsql-hack
Script), and let's merge our codes to the core.
> I can't compile your initial patch against the latest checkout because
> json_parser.h and json_scanner.h are missing.
Hmm, those files should be generated from .y and .l files. I'll check it.
--
Itagaki Takahiro
--
Sent v
f whitespaces as-is in the input.
But I'd say we can simplify it.
Except whitespaces, normalization of strings and numbers might be
problem when we support JSON comparison operators -- comparison of
Unicode escaped characters in strings or 0 vs. 0.0 in numbers.
--
Itagaki Takahiro
-
modified version of the code under PostgreSQL's more
> relaxed license, just to be on the safe side.
Sorry for my insincere manner. Surely I read his code.
Do you know his contact address? I cannot find it...
--
Itagaki Takahiro
basic_json-20100921.patch
Description: Binary data
--
Sen
the regular expression? I would be inclined
> to flush this patch altogether rather than take ANY risk of GPL
> contamination.
Only regular expressions in the scanner. So I've thought it's OK,
but I should have been more careful. Sorry.
--
Itagaki Takahiro
--
Sent via pgsql
espace in headers itself is reasonable,
but the change breaks almost all of regression tests. Will we adjust
expected results for the change?
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailp
of tuples" is better than other units for the parameter? For example,
"threshold bytes" or "percentage in a page" also seems to be reasonable for me.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
support it also on MSVC.
http://msdn.microsoft.com/en-us/library/a7cwbx4t(v=VS.90).aspx -- _strcoll_l
http://msdn.microsoft.com/en-us/library/45119yx3(v=VS.90).aspx -- _towupper_l
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
, no?
> 5.
> postgres=# create table xy(a text, b text collate "cs_CZ");
> ERROR: collation "cs_CZ" for current database encoding "UTF8" does not exist
> can be there some more friendly message or hint ?
I hope Postgres automatically detects the omitted e
e support both glibc and msvc, how to we handle CREATE TABLE DDLs
in pg_dump? Since collation names depend on platforms, a backup dumped
at UNIX cannot be reloaded to Windows. We might need to normalize
locale names to generate a portable dump.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mai
ready to commit if we
accept the proposal itself. Of course we need more discussions about FDW
Routines, but it must be developed based on the infrastructure.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ze" syndrome before. DDL changes are 5K
lines of diff -c patch, and "select" part is additional 6K lines.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
JOIN push-down require planner integration.
More works will be required for fdw_select20100917.patch.gz.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
reorg/pg_reorg/lib/reorg.c
http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/reorg/pg_reorg/lib/pgut/pgut-be.h
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
procedural
> code".
Can you use pg_options_to_table() for your purpose?
=# CREATE TABLE tbl (i integer) with (fillfactor = 70);
=# SELECT (pg_options_to_table(reloptions)).* FROM pg_class WHERE oid
= 'tbl'::regclass;
option_name | option_value
-----+------
fillfa
t be an internal API
(for pg_dump?), but it'd be better to add documentation for it.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Sep 28, 2010 at 5:13 AM, Euler Taveira de Oliveira
wrote:
> Itagaki Takahiro escreveu:
>> I had the same problems before, and I wrote some hacks for VC++.
>>
> Isn't there such a code in core or am i missing something? Is it worth
> supporting the VC++ standalon
On Tue, Aug 31, 2010 at 8:04 PM, Itagaki Takahiro
wrote:
> I think the patch is almost ready to commit, but still
> have some comments for the usability and documentations.
> I hope native English speakers would help improving docs.
I'm checking the latest patch for applying.
I fou
this question a few times lately.
If we do so, many PGDLLEXPORT will be added:
* 17 in src/tutorial
* 507 in contrib
for each exported PGFunction, _PG_init, and _PG_fini.
Any objections? Am I missing something?
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgres
Personally, I learned many idioms from contrib modules, but didn't
notice the tutorial directory. I think codes in contribs are often
copied-and-pasted. So, if we add PGDLLEXPORTs to some places,
I'd like to add them to contribs, too.
--
Itagaki Takahiro
--
Sent via pgsql-hackers m
ne!) and can
be generate DLLs in the same way we're using to build the core.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
st(array) or generate_subscripts(array) ?
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
that it is not recommendable, but users
need to build their codes in different build environment from ours if so.
> We might, however, want to add a specific section to the
> *documentation* about building extensions on Windows
+1. It will be a longer section than ones for other platforms.
--
any plans for it? According to the commitfest app, one patch
has only one reviewer at once. A new reviewer might avoid reviewing
a patch that have another reviewer already.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your su
, replication
or snapshot management requires special skills to review.
I'm worrying about new reviewers hesitate to review a patch that has
a previous reviewer, and then, if they think the remaining patches are
too difficult for them, they would just leave the commitfest page.
--
Itagaki Takahi
in some places. They are not so
important because we will run pgindent, but careful choice will be
preferred even of a patch.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
t be "consistent".)
http://reorg.projects.postgresql.org/
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ph describing this older idiom is being removed, perhaps a
> brief mention in the documentation could be made of this similarity.
Good idea.
> Some more wordsmithing: change
> ! The planner tries to choose a faster method in them base on the
> information
> to:
> ! The
ATOR <<< (
PROCEDURE = text_lt,
LEFTARG = text,
RIGHTARG = text,
COMMUTATOR = 16395 <== HERE
);
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Sep 29, 2010 at 10:14 PM, Robert Haas wrote:
>> http://reorg.projects.postgresql.org/
>
> Can you reproduce that with this patch?
No, I can't use the machine anymore.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To mak
> added at 2, and 4 adds a operator that
has a different oid from <<<'s commutator. The operator <<<
becomes broken state in system catalog.
Anyway, it must be a rare case, and we can just avoid the usage.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
. Those characters are discarded in Japanese docs?
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
FDW routines, has CREATE FOREIGN INDEX.
I think it is a little ugly and won't work in some cases -- for example,
index organized tables -- but evidently it's a realistic solution.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make cha
pgctl_start_type = SERVICE_DEMAND_START;
It accepts only "a" and "auto" for auto, but "au" or "aut" are rejected.
Is is an intended behavior? I think we can use prefix match here because
we use the logic in some places. For example,
postgres=# SELE
check whether my modification broke your patch.
Thank you.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
h is acceptable, I was asked for "queries ordered by CPU times"
in pg_stat_statements several times. The getrusage infrastructure will
make it a real possibility.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscri
me other setting I'm forgetting?
It might come from effective_cache_size. We consider the value only
in the index scans. We can also use the effective cache in addition
to work_mem for tapes used by disk sorting, but we don't consider
the effective cache for now.
--
Itagaki Takahiro
--
of such variables and \echo is
not tab-completed even with the patch. "Only supported by \set" might be
a bit unbalanced.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
t it might have better balance between overhead and resolution.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
loption. So, it needed to modify routines about
> reloptions because it is the first case to store reloptions of views.
Why did you need to extend StdRdOptions strucuture? Since other fields in
the structure are not used by views at all, I think adding a new structure
struct ViewOptions { vl_len
m.
If the patch is an internal improvement, docs are not needed.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Oct 8, 2010 at 10:49 AM, Tom Lane wrote:
> Itagaki Takahiro writes:
>> I wrote a patch to improve CLUSTER VERBOSE (and VACUUM FULL VERBOSE).
>> The patch should be applied after sorted_cluster-20100721.patch .
>
> Applied with minor fixes; in particular, I think y
| VARYING ARRAY} (size_limit)
OF element_type [NOT NULL];
a1 array_type_name;
"IS ARRAY OF" syntax is similar enough to PL/SQL, but is not compatible.
I'm not sure whether PL/SQL has "IS ELEMENT OF" variants.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mail
eed to be back-patched to older versions?
Since they use get_roleid_checked() instead of get_role_oid(), the fix
cannot be applied cleanly to them, though it will be similar codes.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
quot; does not exist
>> >
>> > Here's a patch implementing this idea.
I applied it almost as-is, except an unused variable in
get_role_oid_or_public().
>> BTW, does the patch need to be back-patched to older versions?
> There's no intention to do so.
OK. Applied
ks on 8.3, but it's still broken. Here is the code in 8.3.
It ignores "ROLLBACK TO savepoint", but also ignores "ROLLBACK TRANSACTION".
if (strcmp(transaction, "commit") == 0 || strcmp(transaction, "rollback") == 0)
con->committed = true;
e
are reversed in C sprintf.
% [ pos $ ] format -- ex. %3$l , %l
Escapes: %% => %
IMHO, I like {} syntax as like as C# because the format strings are extensible.
{ pos [ : format ] } -- ex {3:l}, {3} (, and {l} could be also supported)
Escapes: {{ => {, }} => }
--
Itagaki Ta
1? Thanks :-)
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Oct 14, 2010 at 10:23 AM, Robert Haas wrote:
> On Wed, Sep 29, 2010 at 3:59 AM, Pavel Stehule
> wrote:
>> [ updated patch, in response to a review from Itagaki Takahiro ]
>
> This patch appears to be waiting for a second round of review.
> Itagaki-san, are you pl
k the string-comparison is unreliable. So, I'd like to replace
the code to use PQtransactionStatus(). I have two patches to do it:
The first one (ecpg-trans-quick_20101014.patch) is a quick fix
that replaces only the above test.
The second one (ecpg-trans-full_20101014.patch) replaces all of
ntation for sprintf() in strincfunc might not be used now,
but it will be a conflict when we also merge it to format() in the future.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
e
will ask us "Why don't have numeric formats though we have %s?".
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Features to write simple queries are constantly in demand.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
So,
we might need to normalize the internal format even in text representation.
The most interesting parts of json types, including indexing and jsonpath,
would be made on the json core. We need conclusions about those issues.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hac
mple,
{1:-MM-DD} for date is expanded to to_char($1, '-MM-DD').
(Maybe it's not so easy; It requires function lookups depending on types.)
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http:/
ased on v8.
http://code.google.com/p/plv8js/
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
)
* Docs sql-createextension.html has two odd links:
See Also
DROP EXTENSION, Table 9-61, Appendix F
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
n Log log;
It might be platform-dependent, but I think we'd better rename it.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
and client might be different.
If encodings in script and client are different, the server might
need to handle two different client encodings in the same time.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ml2' in the doc. There is no 'pgxml' at all in it.
http://developer.postgresql.org/pgdocs/postgres/xml2.html
However, I don't think we can change the module name because pg_upgrade
will fail if the module (.so) name was changed. So, it might be the
point of compromise to keep tw
Sorry. I missed v5 patch and other new ones.
Some of the issues might have been already fixed in the new version.
On Wed, Oct 20, 2010 at 12:19 PM, Itagaki Takahiro
wrote:
> On Tue, Oct 19, 2010 at 9:33 PM, Dimitri Fontaine
>> Fixed in v4, attached.
>
> Source code
>
precision than it to compare two
numbers eventually. Even if we use BSON format, we need to extend
it to store all of numeric values, that precision is 10^1000.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
nstall" won't modify files at all, and "make clean" just removes
*.control. It is the way we're using for *.sql.in and MODULE_PATHNAME.
> Some extensions are missing here because they fail to compile on my
> workstation where all the libs aren't installed ---
But
configuration files for replication might be more complex. If needed,
it would be reasonable to introduce a JSON reader.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ROM child;
QUERY PLAN
Append (cost=0.00..83.00 rows=3400 width=4)
-> Seq Scan on parent (cost=0.00..34.00 rows=2400 width=4)
-> Seq Scan on child (cost=0.00..15.00 rows=1000 width=4)
(3 rows)
--
I
n on parent (cost=0.00..1.00 rows=1 width=4)
-> Index Scan using child_i_idx on child
(cost=0.00..43.25 rows=1000 width=4)
(8 rows)
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
; palloc would be better here.
BTW, did you register your patch to the next commitfest?
It would be better to do so for tracking the activities.
https://commitfest.postgresql.org/action/commitfest_view?id=8
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
nnot
be used to upgrade to 9.1 from older versions, no?
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
node->plan->vtable->ReScan(node);
...
--
Itagaki Takahiro
extensible_execnodes-20101025.patch.gz
Description: GNU Zip compressed data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
tions
in Query_for_list_of_insertables/deleteables/updateables?
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
trigger
to has_table_privilege() (and relkind IN ('r', 'v')) for INSERT, UPDATE,
and DELETE cases. Query_for_list_of_writeables might still require your
patch, though.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make chang
hink your original patch is the best solution. We could use
has_table_privilege() additionally, but we need to consider any
other places if we use it. For example, DROP privileges, etc.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to
7;tbl')) FROM tbl;
=# CREATE FUNCTION test(n integer) RETURNS void LANGUAGE plpgsql AS
$$
DECLARE
i integer;
r bigint;
BEGIN
FOR i IN 1..n LOOP
SELECT count(*) INTO r FROM tbl;
END LOOP;
END;
$$;
=# \timing
=# SELECT test(30);
--
Itagaki Takahiro
--
Sent via pgsql-hackers mail
6, 2010 at 12:21 PM, Itagaki Takahiro
wrote:
> I didn't intend performance, but there is small but measurable win
> in it if I avoided indirections. We might not always need to copy
> a whole vtable into planstate; only ExecProcNode might be enough.
> I'll continue the resear
think direct patching to the core is enough at the first
testing, and we will decide the interface according to the
result. If one algorithm win in all cases, we could just
include it in the core, and then extensibility would not need.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list
.
I'd suggest to fill a fixed-size local buffer from right to left
and copy it to the actual output.
* C++-style comments should be cleaned up.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
/interfaces/ecpg/preproc/ecpg.c(310):
ptr2ext[3] = (header_mode
== true) ? 'h' : 'c';
src/interfaces/ecpg/preproc/ecpg.c(327):
ptr2ext[1] = (header_mode
== true) ? 'h' : 'c';
= 4
#define PGDLLEXPORT __declspec (dllexport)
#else
#define PGDLLEXPORT __declspec (dllimport)
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
t; in the case __GNUC__ >=4?
Hmmm, I didn't test compiling with gcc version between 3.5 and 4.4.
Does anyone test them? If it works only on gcc 4.5, I'll also add
_GNUC_MINOR__ >= 5 for the check.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgres
em was shut down at 2010-11-02 10:32:13 JST
LOG: database system is ready to accept connections
LOG: autovacuum launcher started
FATAL: parameter "port" cannot be changed without restarting the server
(repeated)
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-
On Wed, Nov 3, 2010 at 2:19 AM, Michael Meskes wrote:
> On Mon, Nov 01, 2010 at 12:17:02PM +0900, Itagaki Takahiro wrote:
>> There are some "== true" in the codes, but they might not be safe
>> because all non-zero values are true in C. Is it worth cleaning up them?
H
Table descriptor -> Relation, Form_pg_class
> * Qual descriptor -> PlanState.qual
Do you think you have all counterpart methods for VTI AMs?
If so, it's a good news ;-) We could support foreign table
features as same level as Informix.
--
Itagaki Takahiro
--
Sent via
but it has different purpose; it's as DEVELOPER_OPTIONS
for delay to attach a debugger.
BTW, the module could save CPU usage of the server on attacks,
but do nothing about connection flood attacks, right?
If an attacker attacks the server with multiple connections,
the server still consumes max_conn
not block
the caller. OTOH, Iterate() are called at the first time tuples
in the node are required.
PL/Proxy has a similar functionality with RUN ON ALL to start queries
in parallel. So, I think it's a infrastructure commonly required.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailin
On Mon, Nov 1, 2010 at 7:24 PM, Itagaki Takahiro
wrote:
> 1. warning: '' redeclared without dllimport attribute:
> previous dllimport ignored
I discussed with Hiroshi-san about the dllimport issue, and he pointed
out that __declspec(dllexport) and dllwrap cannot work well togeth
probably not
>> much point.
>
> We're on the same page. I'm implementing the basic cases now and then will
> come up with some benchmarks.
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
= heaptup->t_len;
/*
* If we're gonna fail for oversize tuple, do it right away
--
Itagaki Takahiro
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
101 - 200 of 891 matches
Mail list logo
