Re: [HACKERS] Sampling profiler updated

2009-07-20 Thread Itagaki Takahiro
y issues I need to fix or improve by the next commitfest? I feel we don't have enough discussion about the feature, like: * Is is useful enough? or are there any idea to be more useful? * Is it ok we have two versions of profiling? (this and dtrace probes) * Is the quality of the patch eno

Re: [HACKERS] pg_restore --clean vs. large object

2009-07-20 Thread Itagaki Takahiro
patch to documentation? [pg_restore.sgml] -c --clean Clean (drop) database objects before recreating them. (8.5) Also drop large objects with same oids. (older) Large objects with same oids are not dropped. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent

Re: [HACKERS] Duplicate key value error

2009-07-20 Thread Itagaki Takahiro
; [1] http://archives.postgresql.org/pgsql-hackers/2009-04/msg00234.php I exported the reporting function to itup.h. [include/access/itup.h] extern void report_unique_violation(Relation rel, IndexTuple itup); Regards, --- ITAGAKI Takahiro NTT Open Source Software Center report_dupkey-20090721

Re: [HACKERS] COPY WITH CSV FORCE QUOTE * -- REVIEW

2009-07-16 Thread Itagaki Takahiro
The attached patch only adds "FORCE QUOTE *" feature. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center force_quote_all-20090717.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Sampling profiler updated

2009-07-14 Thread Itagaki Takahiro
based tuning in Oracle? I didn't know that. What is the point of the works? Are there some knowledge we should learn from? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscriptio

[HACKERS] Sampling profiler updated

2009-07-14 Thread Itagaki Takahiro
ch is platform-independent. A new feature compared with previous patch is function pgstat_register_condition(condition, name). We can add user-defined conditions in extended modules. Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center profiler-20090714.gz Descri

Re: [HACKERS] COPY WITH CSV FORCE QUOTE *

2009-07-14 Thread Itagaki Takahiro
ons. The attached is an updated version of patch; just add documenation to copy.sgml. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center force_quote_all-20090714.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] COPY WITH CSV FORCE QUOTE *

2009-07-13 Thread Itagaki Takahiro
nge the behavior. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] New types for transparent encryption

2009-07-12 Thread Itagaki Takahiro
bles as a write-only variable. When we supply some show_hook function to GUC variable, SET still works but SHOW only shows '' and hides real passwords. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] multi-threaded pgbench

2009-07-09 Thread Itagaki Takahiro
cleaner. * Accept "\sleep 1ms" format (no spaces between "1" and "ms") for sleep meta command. The old version of pgbench interprets "1ms" as just "1", that means "1 s". It was confusable. I'll add the patch to the commit

Re: [HACKERS] multi-threaded pgbench

2009-07-08 Thread Itagaki Takahiro
e just abandoned and not maintained... Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] New types for transparent encryption

2009-07-07 Thread Itagaki Takahiro
ifferent disk drives. We cannot decrypt the data unless we have all copies of the drives. If postgres server is started manually, there might be another design that DBA sets password as a postmaster's startup parameter. If do so, the password is only in memory but not in disk drives. Rega

[HACKERS] multi-threaded pgbench

2009-07-07 Thread Itagaki Takahiro
ptable to use pthread in contrib module? If ok, I will add the patch to the next commitfest. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center pgbench-mt.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] New types for transparent encryption

2009-07-07 Thread Itagaki Takahiro
efine new types that have only difference in typin/typout attributes, such as CREATE TYPE INHERITS or CREATE DOMAIN WITH INPUT/OUTPUT. It is too difficult for standard users to define operators and index support methods. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent vi

[HACKERS] New types for transparent encryption

2009-07-07 Thread Itagaki Takahiro
n database server and applications don't have to know the details. I hope this will be an enhancement of contrib/pgcrypto. Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to yo

Re: [HACKERS] ALTER SET DISTINCT vs. Oracle-like DBMS_STATS

2009-07-06 Thread Itagaki Takahiro
for the module, for example, "TRIGGER ON DROP TABLE" or some drop-relation-hooks. There might be another approach that we add pg_attribute.attoptions for generic column-based options, like pg_class.reloptions. Which approach is better, or something else? Regards, --- ITAGAKI Takahiro NTT

[HACKERS] ALTER SET DISTINCT vs. Oracle-like DBMS_STATS

2009-07-06 Thread Itagaki Takahiro
ile. - FUNCTION dbms_stats.import() : import statistics from external text file. If acceptable, I'd like to submit DBMS_STATS for Postgres module to September commitfest. I'm not sure the feature should be in core, in contrib, or in pgFoundry... Comments welcome. Regards, --- ITAGAKI Takahi

[HACKERS] foreign.h is not installed

2009-06-29 Thread Itagaki Takahiro
rewrite storage tcop \ snowball snowball/libstemmer tsearch tsearch/dicts utils \ port port/win32 port/win32_msvc port/win32_msvc/sys \ Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] query cancel issues in contrib/dblink

2009-06-28 Thread Itagaki Takahiro
te_query() and wait_for_result() in the patch. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center dblink.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] query cancel issues in contrib/dblink

2009-06-25 Thread Itagaki Takahiro
r the remote query using a loop with CHECK_FOR_INTERRUPTS(). For (2), we might need to store PGresult not only in funcctx->user_fctx but also in a global list, and free all results in XactCallback if remain. Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center --

[HACKERS] dblink for 8.4 should work without user-mappings

2009-06-23 Thread Itagaki Takahiro
ECT 1') AS t(i integer); ERROR: user mapping not found for "postgres" The attached patch adds 'missing_ok' parameter to GetUserMapping() and made dblink to use it. There should be no additional security issues here because dblink's original security check works even fo

Re: [HACKERS] Determining client_encoding from client locale

2009-06-17 Thread Itagaki Takahiro
not a Japanese-specific problem and just because they use multiple encodings. Encodings of OSes in Japan are often SJIS or EUC_JP, but UTF8 is well-used in web-services and databases. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-ha

Re: [HACKERS] Win32 link() function

2009-05-31 Thread Itagaki Takahiro
com/en-us/library/aa363860.aspx Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [BUGS] BUG #4822: xmlattributes encodes '&' twice

2009-05-28 Thread Itagaki Takahiro
element, xmlattributes (1 as one, 'deuce' as two, '<>&"''' as three), 'content', '<>&"'''); xmlelement

[HACKERS] pg_restore --clean vs. large object

2009-05-18 Thread Itagaki Takahiro
ECT CASE WHEN EXISTS (SELECT 1 FROM pg_catalog.pg_largeobject WHERE loid = %u) THEN lo_unlink(%u) END; Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center pg_restore_clean_lo.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hacker

Re: [HACKERS] how to insure libpq(dll/so) for thread-safety?

2009-05-13 Thread Itagaki Takahiro
o) for > thread-safety? Use PQescape[String|Bytea]Conn() instead of PQescape[String|Bytea](). The static variables are used only in those deprecated functions. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) T

[HACKERS] COPY WITH CSV FORCE QUOTE *

2009-05-11 Thread Itagaki Takahiro
4.php The attached is a WIP patch add a support of '*' for FORCE QUOTE and FORCE NOT NULL options. I'd like to submit it for the next commit fest (8.5). Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center force_quote_all-20090512.patch Description: Binary

Re: [HACKERS] Creating a tablespace directory in recovery

2009-05-01 Thread Itagaki Takahiro
ectory of the tablespace directory. So, makeing directory might fail with permission denied error. However, it might be as well to create tablespace directories for less-restricted installations. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mai

Re: [HACKERS] Extra cost of "lossy mode" Bitmap Scan plan

2009-04-27 Thread Itagaki Takahiro
ace_bitmapscan to print the information of bitmap scan, like trace_sort for sorting. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Why isn't stats_temp_directory automatically created?

2009-04-14 Thread Itagaki Takahiro
as a symbolic link, the destination directory might be lost in such a situation. If you try to make servers more robust, you might also need to consider broken symlinks. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql

[HACKERS] Patch for server-side encoding issues

2009-04-14 Thread Itagaki Takahiro
x27;" C:\home\>psql eucdb -c "SELECT '日本語' WITH ERROR" ERROR: syntax error at or near "WITH ERROR" LINE 1: SELECT '日本語' WITH ERROR ^ Regards, --- ITAGAKI Takahiro NTT Open Source Software Center server-side_encoding_issues_20090415.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Solution of the file name problem of copy on windows.

2009-04-13 Thread Itagaki Takahiro
Tom Lane wrote: > Itagaki Takahiro writes: > > Here is a patch to implement GetPlatformEncoding() and convert absolute > > file paths from database encoding to platform encoding. > > This seems like a fairly significant overhead added to solve a really > minor proble

Re: [HACKERS] Solution of the file name problem of copy on windows.

2009-04-13 Thread Itagaki Takahiro
Itagaki Takahiro wrote: > "Hiroshi Saito" wrote: > > > Um, I had a focus in help the problem which is not avoided. > > I am not sensitive to a problem being avoided depending on usage. > > However, I will wish to work spontaneously, when it is help much. &

Re: [HACKERS] Sampling Profler for Postgres

2009-04-09 Thread Itagaki Takahiro
h and dtrace probes, but I'll submit it to the next commit-fest for the record. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center profiler-20090409.tar.gz Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscrip

Re: [HACKERS] Solution of the file name problem of copy on windows.

2009-04-08 Thread Itagaki Takahiro
stem path is affected by locale settings or not in some platforms. Also, we need to research where we should get the system encoding when the locale is set to "C", which is popular in Japanese users. I'll report to you the progress :) Regards, --- ITAGAKI Takahiro NTT Open Source Softwa

Re: [HACKERS] Auto-delete large objects when referencing row is deleted

2009-04-07 Thread Itagaki Takahiro
rks perfectly as you expected. Why don't you use bytea instead of large objects? In other words, what you want actually is not LO improvement but efficient TOASTing, no? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgr

Re: [HACKERS] Solution of the file name problem of copy on windows.

2009-04-07 Thread Itagaki Takahiro
Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] 8.4 release notes proof reading 1/2

2009-04-06 Thread Itagaki Takahiro
there are no 'all' and 'sys' versions. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Duplicate key value error

2009-04-03 Thread Itagaki Takahiro
ubmit the patch to the next commit-fest (8.5). Regards, --- ITAGAKI Takahiro NTT Open Source Software Center report_dupkey.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] display previous query string of idle-in-transaction

2009-03-26 Thread ITAGAKI Takahiro
action_min_duration' will be possible. I'm not sure this feature should be in the core or not. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] benchmarking the query planner

2009-03-19 Thread ITAGAKI Takahiro
ourColumn) ((Form_pg_statistic) (vardata->statsTuple))->stadistinct = YourNDistinct; } Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Has anybody think about changing BLCKSZ to an option of initdb?

2009-03-15 Thread ITAGAKI Takahiro
not supported by companies and 3rd party tools. Their database designs are bad, of course, but they want to resolve their problem using knobs of databases. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.

Re: [HACKERS] Sampling Profler for Postgres

2009-03-10 Thread ITAGAKI Takahiro
regular load (like benchmarks). I cannot see any differences whether profiling is on/off. So I think sampling has little overheads for now. Please notify me report if you see troubles. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center profiler_0311.tar.gz Description: Binary data

Re: [HACKERS] Sampling Profler for Postgres

2009-03-09 Thread ITAGAKI Takahiro
. Also, I'd better measure overheads by the patch. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Sampling Profler for Postgres

2009-03-08 Thread ITAGAKI Takahiro
|1.74 31 | Lock:Tuple |1.74 4 | CPU:Parse |0.87 11 | CPU:Commit | 0.87 (14 rows) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center profiler_0309.tar.gz Description: Binary data additional_script.sql Description: Binary dat

Re: [HACKERS] Additional DTrace Probes

2009-03-06 Thread ITAGAKI Takahiro
too. In my experience, they could be bottlenecks or consume much time in some situations. - idle in transaction - spinlock wait-and-retry - CPU: Trigger execution - CPU: Encoding conversion - Network: send() and recv() - smgr: lseek() calls - Tempfile reads and writes Regar

[HACKERS] Why do we keep UnusedLock1 in LWLockId?

2009-03-02 Thread ITAGAKI Takahiro
k. So the IDs are changed anyway. Are there any reason to keep UnusedLock1 there? Or can we remove it simpley? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Immediate shutdown and system(3)

2009-03-02 Thread ITAGAKI Takahiro
in them. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] graph representation of data structures in optimizer

2009-02-26 Thread ITAGAKI Takahiro
for a core feature. Could you split the patch into a core-patch and an extension module? The extension module would be put in contrib or in a pgFoundry project. XML might be good for communications between the core and the module; XML-explain was ongoingly discussed, but had not been completed yet. R

Re: [HACKERS] Allow on/off as input texts for boolean.

2009-02-20 Thread ITAGAKI Takahiro
Peter Eisentraut wrote: > ITAGAKI Takahiro wrote: > > Here is a patch to allow 'on' and 'off' as input texts for boolean. > > Regarding your FIXME comment, I think parse_bool* should be in bool.c > and declared in builtins.h, which guc.c already includes.

[HACKERS] Allow on/off as input texts for boolean.

2009-02-16 Thread ITAGAKI Takahiro
ITAGAKI Takahiro wrote: > - Postgres interprets 'on' as true and 'off' as false in configuration > parameters, but they are not accepted in sql-boolean. > Is it a design? or should we add a parser for 'on' and 'off' ? > I'd l

Re: [HACKERS] [BUGS] BUG #4660: float functions return -0

2009-02-16 Thread ITAGAKI Takahiro
I reported the following bug to -bugs, and I'd like to discuss whether we need to fix the issue or how to fix it. "ITAGAKI Takahiro" wrote: > Bug reference: 4660 > PostgreSQL version: 8.3.3 > Operating system: Fedora 8 > Description:float functions ret

Re: [HACKERS] Questions about parsing boolean and casting to anyelement

2009-02-16 Thread ITAGAKI Takahiro
Tom Lane wrote: > ITAGAKI Takahiro writes: > > - Are there any limitations in casting to anyelement? > > It's a no-op ... probably we shouldn't even let you do it, if the > lack of an error leaves room for such misinterpretation as this. > anyelement and frie

Re: [HACKERS] fillfactor for toast tables is useless?

2009-02-16 Thread ITAGAKI Takahiro
ITAGAKI Takahiro wrote: > The attached is a patch to change 3 things: > - Reject toast.fillfactor. > - Modify relopt_kind to bit flags. > - Report relation type on "unrecognized parameter" errors. I registered the patch as an open item: http://wi

Re: [HACKERS] connection logging dtrace probe

2009-02-15 Thread ITAGAKI Takahiro
but also for connection performance? The name would be CONNECTION_[START|DONE] like other existing probes. I received a report from my client that Postgres didn't return responce of heatbeat connection requests for *1 minute*, but there are few methods to dig it now... Regards, --- ITAGAKI Takahir

[HACKERS] Questions about parsing boolean and casting to anyelement

2009-02-15 Thread ITAGAKI Takahiro
casts, it seems to be ignored. CREATE FUNCTION array_find(text[], text, anyelement) RETURNS anyelement AS $$ SELECT substring(i from E'\\W*=(.*)')::anyelement FROM unnest($1) AS t(i) WHERE i LIKE $2 || '=%' UNION ALL SELECT $3 LIMIT 1 $$

Re: [HACKERS] fillfactor for toast tables is useless?

2009-02-12 Thread ITAGAKI Takahiro
Alvaro Herrera wrote: > ITAGAKI Takahiro wrote: > > With reloption patch, we can set WITH options to toast tables. > > However, fillfactor for toast tables is useless, no? > > Maybe what we should do is just reject fillfactor for toast tables for > now. I think t

[HACKERS] fillfactor for toast tables is useless?

2009-02-11 Thread ITAGAKI Takahiro
not changed by update. Fillfactor for toast tables will be only useful after the optimization. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] temporarily stop autovacuum

2009-02-11 Thread ITAGAKI Takahiro
the-fly, though. The current version of postgres doesn't allow to set them. ERROR: parameter "..." cannot be changed now Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] [COMMITTERS] pgsql: Update autovacuum to use reloptions instead of a system catalog,

2009-02-09 Thread ITAGAKI Takahiro
descriptions about options here. *** =# SELECT oid, relname, reloptions FROM pg_class WHERE oid = 'pg_toast.pg_toast_16388'::regclass; oid |relname | reloptions ---+----+----- 16391 | pg_toast_16388 | {fillfactor=70} Regards, --- ITAGAKI Takahiro NT

Re: [HACKERS] using composite types in insert/update

2009-01-30 Thread ITAGAKI Takahiro
g application in Slony-I. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Compiler warnings fix

2009-01-26 Thread ITAGAKI Takahiro
Peter Eisentraut wrote: > ITAGAKI Takahiro wrote: > > Here is a patch to surpress compiler warnings in pg_locale.c and > > pg_regress.c. > > > > There are following warnings if nls is enabled: > > pg_locale.c: In function `pg_perm_setlocale': > &

[HACKERS] Compiler warnings fix

2009-01-25 Thread ITAGAKI Takahiro
abled: pg_locale.c:615: warning: 'IsoLocaleName' defined but not used There is also a warning in pg_regress.c: pg_regress.c: In function `wait_for_tests': pg_regress.c:1367: warning: passing arg 2 of `GetExitCodeProcess' from incompatible pointer type Regards, --- ITAGAKI

Re: [HACKERS] Visibility map and freezing

2009-01-18 Thread ITAGAKI Takahiro
es to maximum values? Are there any trade-off? - Are there some conditions where whole-table-scanning vacuum is more effective than vacuums using visibility map? If so, we should switch to full-scan *automatically*, without relying on user configurations. Regards, --- ITAGAKI Tak

Re: [HACKERS] V4 of PITR performance improvement for 8.4

2009-01-13 Thread ITAGAKI Takahiro
a bad idea to place a large object as a static variable. It should be a pointer and allocated with palloc() in runtime. Also those variable are only used by startup process. - Merge readahead.h to xlog.h or something. It export just a few functions and the functionality belongs xlog and recover

Re: [HACKERS] Buffer pool statistics in Explain Analyze

2009-01-08 Thread ITAGAKI Takahiro
have at least two requirements: - Avoid overheads. If checking cpu usage is slow, we'd better to have only buffer counters. - Output plans with statistics more readable way. It would be better to use XML or tables to show the information. Regards, --- ITAGAKI Takahiro NT

Re: [HACKERS] Solve a problem of LC_TIME of windows.

2009-01-07 Thread ITAGAKI Takahiro
Magnus Hagander wrote: > ITAGAKI Takahiro wrote: > > Ok, wcsftime() requries both LC_TIME and LC_CTYPE are the same setting > > (at least encoding) on Windows. > > > Hmm. Is this actually cleaner than using the original method as > suggested? Because if I understand

Re: [HACKERS] Solve a problem of LC_TIME of windows.

2009-01-06 Thread ITAGAKI Takahiro
I have no other idea... Regards, --- ITAGAKI Takahiro NTT Open Source Software Center pg_locale-2009-01-07.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SQL/MED dummy vs postgresql wrapper

2009-01-06 Thread ITAGAKI Takahiro
d the flexibility because it should accept only valid parameters for PostgreSQL. Then, 'dummy_fdw' might be kept only for user-defined FDWs. Since users see the library name, we'd better to choose more suitable name for it. Regards, --- ITAGAKI Takahiro NTT Open Source Software Cente

Re: [HACKERS] Many "loaded library" logs by preload libraries

2009-01-05 Thread ITAGAKI Takahiro
Tom Lane wrote: > ITAGAKI Takahiro writes: > > If we set shared_preload_libraries or local_preload_libraries to > > load some modules, "loaded library" messages are logged in server > > log every new connections and autovacuum workers. > > Yeah, I w

Re: [HACKERS] contrib/pg_stat_statements 1226

2009-01-04 Thread ITAGAKI Takahiro
ime not total call count. I think the current implementation is not ideal, too. I also don't like using fixed-size shared memory. I'm thinking that shared memory used by extended modules to be allocated from the shared buffer pool in the future. If we could do it, memory management will b

[HACKERS] Many "loaded library" logs by preload libraries

2009-01-04 Thread ITAGAKI Takahiro
ged only once on non-EXEC_BACKEND platforms, but many times on Windows. On the other hand, local_preload_libraries outputs logs meny times in all platforms. Is it too noisy? How about reducing the log level to DEBUG and/or logging them only in postmaster? Regards, --- ITAGAKI Takahiro NTT Open So

[HACKERS] Export IsUnderPostmaster for pg_stat_statements on win32

2009-01-04 Thread ITAGAKI Takahiro
3,7 +123,7 @@ */ extern pid_t PostmasterPid; extern bool IsPostmasterEnvironment; -extern bool IsUnderPostmaster; +extern PGDLLIMPORT bool IsUnderPostmaster; extern bool ExitOnAnyError; Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing l

[HACKERS] contrib/pg_stat_statements 1226

2008-12-25 Thread ITAGAKI Takahiro
ix character, not only 0-9A-Za-z. > I do like the consistency of having the custom gucs be the same as the > module name, easy to grep or google for. Should I also rename variables used in auto_explain module? It uses 'explain.*' now. Regards, --- ITAGAKI Takahiro NTT Open Source Software

[HACKERS] Unused include/storage/itempos.h

2008-12-25 Thread ITAGAKI Takahiro
Hi, I found include/storage/itempos.h is not included from any sources. What is it for? Should we remove it from the source tree? struct ItemSubpositionData typedef ItemSubpositionData *ItemSubposition; Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql

Re: [HACKERS] contrib/pg_stat_statements 1212

2008-12-21 Thread ITAGAKI Takahiro
passed by reference (especially on 32bit platform). It'd be better to copy values: Counterstmp; /* copy the actual values in spinlock */ SpinLockAcquire(&entry->mutex); tmp = entry->counters; SpinLockRelease(&entry->mutex); /* create a tuple aft

Re: [HACKERS] generic reloptions improvement

2008-12-21 Thread ITAGAKI Takahiro
o another struct something like: struct relopt_value { const relopt_gen *which; boolisset; union { boolval_bool; int val_int; double val_real; } types; }; the ariables 'isset' and 'parsed_val' are not used in definition, AFA

Re: [HACKERS] rmgr hooks (v2)

2008-12-17 Thread ITAGAKI Takahiro
ad_libraries(); + #endif + /* * We use the ProcStructLock to protect assignment and releasing of * AuxiliaryProcs entries. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chan

Re: [HACKERS] Coding TODO for 8.4: Synch Rep

2008-12-17 Thread ITAGAKI Takahiro
ot; . However, pg_is_in_replication() is enough for 8.4, so I think it has low priority. IP address of standby can be retrived with ps command already. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Looking for someone with MinGW

2008-12-17 Thread ITAGAKI Takahiro
ession test in my environment. Who renames *-minGW32.stderr to .stderr ? Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] parallel restore vs. windows

2008-12-17 Thread ITAGAKI Takahiro
ling and connections pooling are typically used in the context. -- it might be a ToDo item in 8.5. I have no idea about performance because I don't have multi-core machine for windows. Parallel restore seems to be slower than serial restore on single-cpu machine. Regards, --- ITAGAKI Takah

Re: [HACKERS] Looking for someone with MinGW

2008-12-16 Thread ITAGAKI Takahiro
egression tests can finish successfully but there is still a difference. The diff seems to be trivial and come from error message changes. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center regression.diffs Description: Binary data ecpg-fix.patch Description: Binary data -- Sent v

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread ITAGAKI Takahiro
on-0 result normally. Some O/R mapping tools also checks the result exactly and raises errors (it could be turned off, but default is on). Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread ITAGAKI Takahiro
ave it. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] contrib/pg_stat_statements 1212

2008-12-12 Thread ITAGAKI Takahiro
ffer hits %R : # of local buffer reads %W : # of local buffer writes %t : # of buffile reads %T : # of buffile writes %u : user cpu time %s : sys cpu time %p : total cpu times (= %u + %s) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center pg_stat_statements-1212.tar.gz Description:

Re: [HACKERS] Looking for someone with MinGW

2008-12-11 Thread ITAGAKI Takahiro
Regards, --- ITAGAKI Takahiro NTT Open Source Software Center regression.diffs Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] build failure in pgevent

2008-12-10 Thread ITAGAKI Takahiro
Peter Eisentraut <[EMAIL PROTECTED]> wrote: > On Thursday 11 December 2008 07:19:00 ITAGAKI Takahiro wrote: > > I enconterd build failure in mingw. > > Do we need a rule for win32ver.rc in pgevent/Makefile ? > > It should be in src/makefiles/Makefile.win32. It

[HACKERS] build failure in pgevent

2008-12-10 Thread ITAGAKI Takahiro
_builddir)/src/Makefile.global + all-lib: $(NAME) install-lib: $(NAME) Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] posix_fadvise v22

2008-12-10 Thread ITAGAKI Takahiro
_concurrency()] + prefetch_pages = new_prefetch_pages+0.99; You want to do as follows, right? + prefetch_pages = (int) ceil(new_prefetch_pages); Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list

Re: [HACKERS] contrib/pg_stat_statements 1202

2008-12-09 Thread ITAGAKI Takahiro
slow queries. We could use the logging for slow queries executed rarely and use the module queries executed many times. Excluding backup scripts is easy; You can create a database role for backup and disable statement-tracking for the user using ALTER ROLE. Regards, --- ITAGAKI Takahiro

Re: [HACKERS] contrib/pg_stat_statements 1202

2008-12-09 Thread ITAGAKI Takahiro
ery). We can get accumulated statistics for each query. It might be unsufficient for complex queries. 3. Should not add any counters. No changes to core, but usability of pg_stat_statement module would be very poor... Which should we take? or are there another idea? Regards,

Re: [HACKERS] contrib/pg_stat_statements 1202

2008-12-08 Thread ITAGAKI Takahiro
t XML-explain and TABLE-expalin are useful, but they are independent features from pg_stat_statements. So I'd like to discuss them in separated threads (and it will come in 8.5). Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] contrib/pg_stat_statements 1202

2008-12-08 Thread ITAGAKI Takahiro
ght slow down EXPLAIN ANALYZE because some fields are added in struct Instrumentation and they are counted up per tuple in EXPLAIN ANALYZE. > Also find attached some very minor verbiage changes. Thanks. I'll apply your fixes. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center

[HACKERS] contrib/pg_stat_statements 1202

2008-12-02 Thread ITAGAKI Takahiro
ed by struct Instrumentation. ---- Comments welcome. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center pg_stat_statements.1202.tar.gz Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCHES] Solve a problem of LC_TIME of windows.

2008-11-26 Thread ITAGAKI Takahiro
Is it acceptable? I think we need to set LC_CTYPE and other LC_* independently... Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCHES] Solve a problem of LC_TIME of windows.

2008-11-26 Thread ITAGAKI Takahiro
ast (and the bug is fixed there). Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCHES] Solve a problem of LC_TIME of windows.

2008-11-25 Thread ITAGAKI Takahiro
7 6a 93 fa EUCJP:wcs = 90 85 97 6a 93 fa NOTE: There is another problem that specified encoding is ignored by the functions. The result encoding is always platform default one. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center localetest.c Description: Binary data -- Sen

Re: [HACKERS] [PATCHES] Solve a problem of LC_TIME of windows.

2008-11-25 Thread ITAGAKI Takahiro
erals in the format strings, the macro adds wide character prefix (L"...") to them. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center pg_locale-1125.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chang

[HACKERS] Comments to Synchronous replication patch v3

2008-11-24 Thread ITAGAKI Takahiro
w flag argument in XLogFlush. [6] Bit-OR or Logical-OR WaitXLogSend(XactLastRecEnd, false, forceSyncCommit | haveNonTemp); should be WaitXLogSend(XactLastRecEnd, false, forceSyncCommit || haveNonTemp); | is bit OR and || is logical OR. Regards, --- ITAGAKI Takahiro NTT Open Source Software C

Re: [HACKERS] HEAD build failure on win32 mingw

2008-11-20 Thread ITAGAKI Takahiro
e so inclined). I used a nightly snapshot(snapshot/postgresql-snapshot.tar.bz2) and it includes *.gz files. It would be the cause. Thanks. I'll delete the file before building. Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hac

<    1   2   3   4   5   6   7   8   9   >