Hi - I'm cross-compiling the master branch (cygwin/mingw) and have found a
reference to S_ISLNK that isn't guarded by #ifndef WIN32 like the ones in
basebackup.c are. Could you merge the attached fix? Thanks -
Nick
exec-symlink-ifdef.patch
Description: Binary data
--
Sent via pgsql-hackers
-mingw32 --build=x86_64-w64-mingw32
--host=x86_64-w64-mingw32 --without-readline --without-zlib
--disable-thread-safety
On 14 November 2012 06:25, Tom Lane t...@sss.pgh.pa.us wrote:
Nicholas White n.j.wh...@gmail.com writes:
Hi - I'm cross-compiling the master branch (cygwin/mingw) and have found
The SQL standard defines a RESPECT NULLS or IGNORE NULLS option for lead,
lag, [...]. This is not implemented in PostgreSQL
(http://www.postgresql.org/docs/devel/static/functions-window.html)
I've had a go at implementing this, and I've attached the resulting patch.
It's not finished yet
The SQL standard defines a RESPECT NULLS or IGNORE NULLS option for lead,
lag, [...]. This is not implemented in PostgreSQL
(http://www.postgresql.org/docs/devel/static/functions-window.html)
I've had a go at implementing this, and I've attached the resulting patch.
It's not finished yet, but I
wrote:
Nicholas White n.j.wh...@gmail.com writes:
The SQL standard defines a RESPECT NULLS or IGNORE NULLS option for lead,
lag, [...]. This is not implemented in PostgreSQL
(http://www.postgresql.org/docs/devel/static/functions-window.html)
I've had a go at implementing this, and I've
of copies of Datums in the memory
context while a query is executing. I've attached the revised patch...
Thanks -
Nick
On 24 March 2013 03:43, Hitoshi Harada umi.tan...@gmail.com wrote:
On Sat, Mar 23, 2013 at 3:25 PM, Nicholas White n.j.wh...@gmail.comwrote:
Thanks - I've added it here
Thanks for the reviews. I've attached a revised patch that has the lexer
refactoring Alvaro mentions (arbitarily using a goto rather than a bool
flag) and uses Jeff's idea of just storing the index of the last non-null
value (if there is one) in the window function's context (and not the Datum
Good catch - I've attached a patch to address your point 1. It now returns
the below (i.e. correctly doesn't fill in the saved value if the index is
out of the window. However, I'm not sure whether (e.g.) lead-2-ignore-nulls
means count forwards two rows, and if that's null use the last one you've
OK - I've attached another iteration of the patch with Troels' grammar
changes. I think the only issue remaining is what the standard says about
lead semantics. Thanks -
lead-lag-ignore-nulls.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
The result of the current patch using lead
Actually, I think I agree with you (and, FWIW, so does Oracle:
http://docs.oracle.com/cd/E11882_01/server.112/e25554/analysis.htm#autoId18).
I've refactored the window function's implementation so that (e.g.) lead(5)
means the 5th non-null value away in
This patch will need to be rebased over those changes
See attached -
lead-lag-ignore-nulls.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
I've fixed the problems you mentioned (see attached) - sorry, I was a bit
careless with the docs.
+ null_values = (Bitmapset *) WinGetPartitionLocalMemory(
+ winobj,
+ BITMAPSET_SIZE(words_needed));
+
this should throw a FEATURE_NOT_SUPPORTED error if it is used for window
functions that don't support it
arbitrary aggregate functions over a window ... should also throw a
FEATURE_NOT_SUPPORTED error.
Fixed (with test cases) in the attached patch.
because the same window may be shared by
I've attached another iteration of the patch that fixes the multiple-window
bug and adds ( uses) a function to create a Bitmapset using a custom
allocator. I don't think there's any outstanding problems with it now.
Alternatively, it might be trivial to make all aggregate functions work
with
pg_get_viewdef() needs to be updated
Ah, good catch - I've fixed this in the attached. I also discovered that
there's a parent-child hierarchy of WindowDefs (using relname-name), so
instead of cloning the WindowDef (in parse_agg.c) if the frameOptions are
different (e.g. by adding the
I've attached a revised version that fixes the issues above:
changing a reference of the form:
OVER w
into:
OVER (w)
Fixed (and I've updated the tests).
It's bad form to modify a list while iterating through it.
Fixed
We shouldn't create an arbitrary number of duplicate windows
np, optimising for quality not speed :)
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
but needs a rebase.
See attached - thanks!
lead-lag-ignore-nulls.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Please fix these compiler warnings
Fixed - see attached. Thanks -
lead-lag-ignore-nulls.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
bms_add_member() is an accident waiting to happen
I've attached a patch that makes it use repalloc as suggested - is it
OK to commit separately? I'll address the lead-lag patch comments in
the next couple of days. Thanks -
repalloc.patch
Description: Binary data
--
Sent via pgsql-hackers
Thanks for the detailed feedback, I'm sorry it took so long to
incorporate it. I've attached the latest version of the patch, fixing
in particular:
We have this block:
I've re-written this so it only does a single pass through the window
definitions (my patch originally added a second pass), and
Hi Abhijit -
What's the status of this patch?
The latest version of the patch needs a review, and I'd like to get it
committed in this CF if possible. Thanks -
Nick
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
22 matches
Mail list logo
