Re: [HACKERS] Adding the optional clause 'AS' in CREATE TRIGGER

2017-02-07 Thread Okano, Naoki
On Wednesday, November 16, 2016 4:31 PM Okano Naoki wrote: > > But in any case it would be a serious mistake to do this without first > > implementing CREATE OR REPLACE TRIGGER. I think that's an entirely > > separate > > proposal and you would be well advised to t

Re: [HACKERS] Keep ECPG comment for log_min_duration_statement

2017-02-24 Thread Okano, Naoki
e check the [WIP]patch I attached. I am appreciated if you give me any idea or opinion. Regards, Okano Naoki Fujitsu [WIP]enable-parse-comment.patch Description: [WIP]enable-parse-comment.patch -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes t

Re: [HACKERS] Adding the optional clause 'AS' in CREATE TRIGGER

2017-02-12 Thread Okano, Naoki
On Thursday, February 9, 2017 4:41 AM Robert Haas wrote: > You should add this to the next CommitFest so it doesn't get missed. > > https://commitfest.postgresql.org/ Thank you for your kind advice! I have added this patch to the CommitFest 2017-03. Regards, Okano Naoki Fujitsu --

[HACKERS] Keep ECPG comment for log_min_duration_statement

2017-02-12 Thread Okano, Naoki
/* qid=3, at line 30 in yourApp.ecpg */ SELECT * INTO :C1, :C2 FROM T1 WHERE C1=1; As far as I searched, there seems no discussion on this topic. Please let me know if exists. Regards, Okano Naoki Fujitsu -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to you

Re: [HACKERS] Keep ECPG comment for log_min_duration_statement

2017-02-27 Thread Okano, Naoki
without creating a lot of overhead. I see. Based on your advice, I try to make a patch. I will attach a patch when I finish it. Regards, Okano Naoki Fujitsu -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Keep ECPG comment for log_min_duration_statement

2017-02-27 Thread Okano, Naoki
comments. 3. comments are put back or forth in SQL statement. Regards, Okano Naoki Fujitsu -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Adding the optional clause 'AS' in CREATE TRIGGER

2016-11-14 Thread Okano, Naoki
) | AS 'trigger function definition' [ LANGUAGE lang_name ] [ SET configuration_parameter { TO value | = value | FROM CURRENT }] } If you have your opinion on this concept, please give me it. Regards, Okano Naoki Fujitsu -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] pg_recvlogical --endpos

2016-11-22 Thread Okano, Naoki
+mode, an error is raised. So, it is better to output an error message that matches the document when changing the error message. Regards, Okano Naoki Fujitsu -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Adding the optional clause 'AS' in CREATE TRIGGER

2016-11-15 Thread Okano, Naoki
rs change the function or change the condition of 'WHEN' clause. Regard, Okano Naoki Fujitsu -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_recvlogical --endpos

2016-11-29 Thread Okano, Naoki
On Wednesday, November 30, 2016 10:34 AM Craig Ringer wrote: >On 30 November 2016 at 09:18, Okano, Naoki ><okano(dot)naoki(at)jp(dot)fujitsu(dot)com> wrote: >> >> On November 29, 2016 at 5:03 PM Craig Ringer wrote: >>> Would it be better rephrased as "

Re: [HACKERS] pg_recvlogical --endpos

2016-11-29 Thread Okano, Naoki
hat it did not make sense with --create-slot. But if exists, would you let me know? Regards, Okano Naoki Fujitsu -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Adding the optional clause 'AS' in CREATE TRIGGER

2017-03-27 Thread Okano, Naoki
g this patch to "Returned with Feedback". Regards, Okano Naoki Fujitsu -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Adding the optional clause 'AS' in CREATE TRIGGER

2017-03-08 Thread Okano, Naoki
Peter Eisentraut wrote: > On 3/8/17 04:12, Okano, Naoki wrote: > > Peter Eisentraut wrote: > >> I have a feeling that this was proposed a few times in the ancient past > >> but did not go through because of locking issues. I can't find any > >> emails abo

Re: [WIP] RE: [HACKERS] DECLARE STATEMENT setting up a connection in ECPG

2017-03-05 Thread Okano, Naoki
Regards, Okano Naoki

Re: [HACKERS] Adding the optional clause 'AS' in CREATE TRIGGER

2017-03-08 Thread Okano, Naoki
rrently have ShareRowExclusiveLock lock on relation on which trigger is created. ShareRowExclusiveLock is enough to replace a trigger. Also, we currently have RowExclusiveLock on pg_trigger. RowExclusiveLock is enough to replace a trigger, too. Regards, Okano Naoki Fujitsu -- Sent via pgsql-hackers