Re: [HACKERS] patch (for 9.1) string functions

2010-07-08 Thread Takahiro Itagaki
, display length might be better for the length specifier. How about having both s and S? %10s -- 10 characters %10S -- 10 disp length; we could use pg_dsplen() for the purpse. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] patch (for 9.1) string functions

2010-07-08 Thread Takahiro Itagaki
. --- Takahiro Itagaki -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Partitioning syntax

2010-07-07 Thread Takahiro Itagaki
treats ADD PARTITION as adding a column named PARTITION. We need to add PARTITION into the reserved keyword list to avoid shift/reduce errors. Do you have any better idea? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: I: [HACKERS] About Our CLUSTER implementation is pessimal patch

2010-07-07 Thread Takahiro Itagaki
-randomAccess)/* need trailing length word? */ if (LogicalTapeRead(state-tapeset, tapenum, tuplen, sizeof(tuplen)) != sizeof(tuplen)) elog(ERROR, unexpected end of data); Regards, --- Takahiro Itagaki

Re: [HACKERS] patch: preload dictionary new version

2010-07-07 Thread Takahiro Itagaki
. - mmap() is not always portable. We should check the availability in configure, and also have an alternative implementation for Win32. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: I: [HACKERS] About Our CLUSTER implementation is pessimal patch

2010-07-06 Thread Takahiro Itagaki
better description than copypaste from FormIndexDatum. Regards, --- Takahiro Itagaki NTT Open Source Software Center sorted_cluster-20100706.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Does mbutils.c really need to use L'\0' ?

2010-07-06 Thread Takahiro Itagaki
work in the same way at least on Windows, where the codes are actually used. utf16[dstlen] = L'\0'; utf16[dstlen] = '\0'; utf16[dstlen] = 0; utf16[dstlen] = (WCHAR) 0; Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Always truncate segments before unlink

2010-07-05 Thread Takahiro Itagaki
on timeout, where the signal is sent when we have some old messages in the queue longer than 30sec - 1min. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

[HACKERS] Always truncate segments before unlink

2010-07-04 Thread Takahiro Itagaki
spaces in the early stages. Am I missing something? Comments welcome. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Additional startup logging

2010-06-30 Thread Takahiro Itagaki
information you want from _PG_init() or shmem_startup_hook. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] system views for walsender activity

2010-06-21 Thread Takahiro Itagaki
replication to spread the changes to slaves. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Partitioning syntax

2010-06-17 Thread Takahiro Itagaki
for the feature.) * master branch is a copy of postgres' HEAD. * 'partition' branch contains codes for partitioning. The details and discussion for partitioning are in the wiki page: http://wiki.postgresql.org/wiki/Table_partitioning Regards, --- Takahiro Itagaki NTT Open Source Software

[HACKERS] system views for walsender activity

2010-06-17 Thread Takahiro Itagaki
codes for the case 2, but it might be better to design management policy via SQL in 9.1 before such detailed implementation. Comments welcome. Regards, --- Takahiro Itagaki NTT Open Source Software Center walsender_activity-20100618.patch Description: Binary data -- Sent via pgsql-hackers

[HACKERS] GetOldestWALSendPointer() in header

2010-06-16 Thread Takahiro Itagaki
Hi, GetOldestWALSendPointer() is commented out in the source code with NOT_USED block, but is still declared in the header file. Should we remove the function prototype from walsender.h ? [walsender.h] extern XLogRecPtr GetOldestWALSendPointer(void); Regards, --- Takahiro Itagaki NTT Open

Re: [HACKERS] debug log in pg_archivecleanup

2010-06-15 Thread Takahiro Itagaki
%s: ERROR failed to remove \%s\: %s, Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ps display waiting for max_standby_delay

2010-06-10 Thread Takahiro Itagaki
information about conflictions in recovery, we would supply them with SQL views instead of ps display in 9.1. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] LLVM / clang

2010-06-10 Thread Takahiro Itagaki
) { /* * The change in number of backend slots doesn't need to be Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] failover vs. read only queries

2010-06-09 Thread Takahiro Itagaki
of the trigger file based management. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] failover vs. read only queries

2010-06-09 Thread Takahiro Itagaki
; Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] InvalidXLogRecPtr in docs

2010-06-09 Thread Takahiro Itagaki
. I'd like to rewrite the description like: ... then the return value will be 0/0, that is never used in normal cases. Comments? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] [COMMITTERS] pgsql: Fix dblink to treat connection names longer than NAMEDATALEN-2

2010-06-08 Thread Takahiro Itagaki
itag...@postgresql.org (Takahiro Itagaki) wrote: Fix dblink to treat connection names longer than NAMEDATALEN-2 (62 bytes). Now long names are adjusted with truncate_identifier() and NOTICE messages are raised if names are actually truncated. Modified Files: -- pgsql

[HACKERS] Connection leak in dblink on duplicate names

2010-06-08 Thread Takahiro Itagaki
I found contrib/dblink leaks a connection or a small amout of memory when dblink_connect() ends with a duplicate connection name error. We should disconnect the connection before raise any ERRORs. Patch attached. Regards, --- Takahiro Itagaki NTT Open Source Software Center dblink-connection

Re: [HACKERS] Command to prune archive at restartpoints

2010-06-08 Thread Takahiro Itagaki
preference for archive_cleanup_command here. OK, sounds like we have consensus on that. Who wants to do it? Do we just need to replace all of them? If so, patch attached. I replaced 3 terms: recovery_end_command, recovery-end-command, and recoveryEndCommand. Regards, --- Takahiro Itagaki NTT

Re: [HACKERS] Command to prune archive at restartpoints

2010-06-08 Thread Takahiro Itagaki
for it in the patch. Regards, --- Takahiro Itagaki NTT Open Source Software Center estartpoint-to-archive_cleanup.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] pgstatindex still throws ERROR: value 3220078592 is out of range for type integer

2010-06-07 Thread Takahiro Itagaki
, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] ps display waiting for max_standby_delay

2010-06-06 Thread Takahiro Itagaki
() - waitStart set_ps_display(new_status, false); I think SQL-based activity view will be more useful than ps display, but it's an item for 9.1. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

[HACKERS] Open item: slave to standby in docs

2010-06-03 Thread Takahiro Itagaki
places where slave is used. - Terminology: ... are called standby or slave servers. - Words in old release notes for 8.2 and 8.4. Could you check those replacements are proper? Regards, --- Takahiro Itagaki NTT Open Source Software Center slave_to_standby.patch Description: Binary data

Re: [HACKERS] fillfactor gets set to zero for toast tables

2010-06-03 Thread Takahiro Itagaki
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: Could you explain why default_only entries idea is better than adjusting those fields in the toast-specific codes? It's my understanding that reloption-framework is just a tool to fill reloption parameters, and it's not responsible

Re: [HACKERS] [BUGS] BUG #5487: dblink failed with 63 bytes connection names

2010-06-02 Thread Takahiro Itagaki
to it with the untruncated name because all such references are truncated too. Absolutely. I re-use the added function for the fix. Regards, --- Takahiro Itagaki NTT Open Source Software Center dblink_63bytes-2010602.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] [BUGS] BUG #5487: dblink failed with 63 bytes connection names

2010-06-02 Thread Takahiro Itagaki
, --- Takahiro Itagaki NTT Open Source Software Center dblink_63bytes-2010-603.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] fillfactor gets set to zero for toast tables

2010-05-31 Thread Takahiro Itagaki
be a good time to add an int flags parameter to the add_xxx_reloption functions. The first flag could be default_only and we'd have room to add more later without another API break. I agree the idea when we reach a conclusion to introduce default_only. Regards, --- Takahiro Itagaki NTT Open

Re: [HACKERS] [BUGS] BUG #5487: dblink failed with 63 bytes connection names

2010-05-31 Thread Takahiro Itagaki
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: Bug reference: 5487 Logged by: Takahiro Itagaki Email address: itagaki.takah...@oss.ntt.co.jp Description:dblink failed with 63 bytes connection names Details: Contib/dblink module seems to have a bug

Re: [HACKERS] fillfactor gets set to zero for toast tables

2010-05-30 Thread Takahiro Itagaki
accepted as a user-settable item. Itagaki's idea: It just fills fillfactor (and analyze_threshold) to default values for TOAST relations. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Unexpected page allocation behavior on insert-only tables

2010-05-30 Thread Takahiro Itagaki
. Of course we can ignore the case because frequent connections and disconnections should be always avoided. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] mingw initdb failure on HEAD

2010-05-27 Thread Takahiro Itagaki
, but it's curious because MSVC members are OK. Do we have special treatments for exported functions in mingw? It might export 'dllimport' funtions/variables, but not 'dllexport' ones. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] fillfactor gets set to zero for toast tables

2010-05-26 Thread Takahiro Itagaki
fills fillfactor (and analyze_threshold) to default values for TOAST relations. I think responsibility for filling reloptions with proper values is not in the generic option routines but in AM-specific reloption handlers. Regards, --- Takahiro Itagaki NTT Open Source Software Center toast-ff

Re: [HACKERS] exporting raw parser

2010-05-26 Thread Takahiro Itagaki
, and equalfuncs) The proposal will be acceptable only when all of the technical issues are solved. The libSQL should also be available in stand-alone. It should not be a collection of half-baked functions. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing

Re: [HACKERS] exporting raw parser

2010-05-26 Thread Takahiro Itagaki
the interface routines for libSQL. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_stat_transaction patch

2010-05-25 Thread Takahiro Itagaki
and after the transaction. - Export pgBufferUsage instead of relation counters. They are buffer counters for all relations, but we can obviously export them because they are just plain variables. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers

[HACKERS] Open Item: pg_controldata - machine readable?

2010-05-25 Thread Takahiro Itagaki
will retrieve those variables as GUC options. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Open Item: invalid declspec for PG_MODULE_MAGIC

2010-05-25 Thread Takahiro Itagaki
it because it should not break any existing third party modules because they cannot be even built on Windows. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Open Item: pg_controldata - machine readable?

2010-05-25 Thread Takahiro Itagaki
there was consensus that it was really needed. OK, I moved it from 9.0 open items to new features for 9.1. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] (9.1) btree_gist support for searching on not equals

2010-05-24 Thread Takahiro Itagaki
, this is achievable a lot more easily: CREATE UNIQUE INDEX a_single_row ON a ((1)); The former exclusion constraint means one same value for all rows, but your alternative means a_single_row, right? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Japanies translation breaks solaris build

2010-05-14 Thread Takahiro Itagaki
Zdenek Kotala zdenek.kot...@sun.com wrote: http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=comet_mothdt=2010-05-13%2021:06:01 The problem is that it contains mix of DOS/Unix end of lines. I removed two CRs in ja.po. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent

[HACKERS] pg_upgrade code questions

2010-05-13 Thread Takahiro Itagaki
codes for EDB in core? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_upgrade code questions

2010-05-13 Thread Takahiro Itagaki
. I'm especially worried about Windows and MSVC. So, if Windows testers can see it works, there was nothing to worry about. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] nvarchar notation accepted?

2010-05-13 Thread Takahiro Itagaki
you can remove N and just use SET client_encoding = UTF8 in the cases. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Generalized Inverted Generalized Search Tree

2010-05-13 Thread Takahiro Itagaki
)); Comments and ideas welcome. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [ANNOUNCE] Bug-fix and new feature of pg_lesslog is released

2010-05-12 Thread Takahiro Itagaki
, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Patch for PKST timezone

2010-05-11 Thread Takahiro Itagaki
/install/dbserver/bin$ ./pg_config --version PostgreSQL 9.0beta1 af...@aftab-laptop:/opt/dev/pgsql/install/dbserver/bin$ Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] [BUGS] SET search_path clause ignored during function creation

2010-05-10 Thread Takahiro Itagaki
with the current search path at the time pof creation. Thanks for the report! Please check whether the attached patch is the correct fix. An additional regression test is included. Regards, --- Takahiro Itagaki NTT Open Source Software Center create_function_with_search_path.patch Description

Re: [HACKERS] [BUGS] SET search_path clause ignored during function creation

2010-05-10 Thread Takahiro Itagaki
Tom Lane t...@sss.pgh.pa.us wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Thanks for the report! Please check whether the attached patch is the correct fix. An additional regression test is included. That's going to provoke uninitialized variable compiler warnings

Re: [HACKERS] pg_stat_transaction patch

2010-05-06 Thread Takahiro Itagaki
: pgstat.c, Line: 1756) Also, pg_stat_transaction_functions returned no rows from the test case even after I removed those assertions. There are no rows in your test/run.out, too. I like your idea itself, but more works are required for the implementation. Regards, --- Takahiro Itagaki NTT Open Source

Re: [HACKERS] CP949 for EUC-KR?

2010-05-05 Thread Takahiro Itagaki
Ioseph Kim pgsql...@postgresql.kr wrote: CP51949 is EUC-KR correct. {PG_EUC_KR, CP51949}, /* or 20949 ? */ Thank you for the information. I removed or 20949 ? from the line. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] COPY is not working

2010-04-30 Thread Takahiro Itagaki
/copy_test'; COPY 2 Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Invalidating dependent views and functions

2010-04-30 Thread Takahiro Itagaki
However, dependent objects are not only in the database, but also in the client applications. That's why we allow CREATE OR REPLACE VIEW only to add columns, but disallow to modify existing columns. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing

Re: [HACKERS] COPY is not working

2010-04-29 Thread Takahiro Itagaki
56 $ uname -a Linux xxx 2.6.29.4-167.fc11.x86_64 #1 SMP Wed May 27 17:27:08 EDT 2009 x86_64 x86_64 x86_64 GNU/Linux $ postgres --version postgres (PostgreSQL) 9.0beta1 Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

[HACKERS] CP949 for EUC-KR?

2010-04-27 Thread Takahiro Itagaki
/libiconv-13.2/libiconv/lib/cp949.h but we define CP51949 for EUC-KR in chklocale.c. {PG_EUC_KR, CP51949}, /* or 20949 ? */ Which is the compatible codeset with our PG_EUC_KR encoding? 949, 51949, or 20949? Should we add (or replace) CP949 for EUC-KR? Regards, --- Takahiro Itagaki

Re: [HACKERS] CP949 for EUC-KR?

2010-04-27 Thread Takahiro Itagaki
}, {PG_LATIN7, ISO-8859-13}, {PG_LATIN8, ISO-8859-14}, {PG_LATIN10, ISO-8859-16}, {PG_SHIFT_JIS_2004, SJIS_2004}, Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Add column if not exists (CINE)

2010-04-27 Thread Takahiro Itagaki
. Also, developers should consider not only ADD COLUMN but also other CREATE or ADD commands. The patch will be large, including documentation adjustments in many places -- it would be hard work. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list

Re: [HACKERS] CIText and pattern_ops

2010-04-26 Thread Takahiro Itagaki
%'; QUERY PLAN Seq Scan on tbl (cost=100.00..101.01 rows=1 width=64) Filter: (c ~~ 'abc%'::citext) (2 rows) Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers

Re: [HACKERS] [GENERAL] trouble with to_char('L')

2010-04-21 Thread Takahiro Itagaki
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: Revised patch attached. Please test it. I applied this version of the patch. Please check wheter the bug is fixed and any buildfarm failures. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers

Re: [HACKERS] [GENERAL] trouble with to_char('L')

2010-04-20 Thread Takahiro Itagaki
parameter? And UTF8? Regards, --- Takahiro Itagaki NTT Open Source Software Center pg_locale_20100420.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [GENERAL] trouble with to_char('L')

2010-04-20 Thread Takahiro Itagaki
it. Regards, --- Takahiro Itagaki NTT Open Source Software Center pg_locale_20100421.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] row estimation off the mark when generate_series calls are involved

2010-04-19 Thread Takahiro Itagaki
..2.51 rows=1001 width=0) Should it be 1000 rather than 1001? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [GENERAL] trouble with to_char('L')

2010-04-18 Thread Takahiro Itagaki
one. It returns locale characters in wide chars, so we can safely convert them as UTF16-UTF8-db. But it requires an additional branch in our locale codes only for Windows. [1] http://msdn.microsoft.com/en-us/library/dd318101 Regards, --- Takahiro Itagaki NTT Open Source Software Center

Re: [HACKERS] GSOC PostgreSQL partitioning issue

2010-04-08 Thread Takahiro Itagaki
-fdw.git/shortlog/refs/heads/partition I'd like to ask Necati what problem you will solve, rather than what module you will develop. Performance? Usability? Or othres? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Set LC_COLLATE to de_DE_phoneb

2010-04-07 Thread Takahiro Itagaki
database. If so, PostgreSQL cannot support it because postgres depends on locale libraries in each platform. (i.e., msvcrt on Windows) Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] fallback_application_name and pgbench

2010-04-07 Thread Takahiro Itagaki
. GetModuleFilename() is available on Windows for the purpose, but I don't know what API is available on other platforms. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Set LC_COLLATE to de_DE_phoneb

2010-04-07 Thread Takahiro Itagaki
it, unless we modify PostgreSQL to use Win32 locale functions instead of standard libc ones -- but it is hardly acceptable. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

[HACKERS] Oddly indented raw_expression_tree_walker

2010-04-07 Thread Takahiro Itagaki
(*walker) (), void *context) { ListCell *temp; Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SELECT constant; takes 15x longer on 9.0?

2010-04-06 Thread Takahiro Itagaki
them? For example, --enable-debug or --enable-cassert. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c

2010-04-05 Thread Takahiro Itagaki
)); +#else + cygwin_conv_to_full_win32_path(cmdLine, buf); +#endif strcpy(cmdLine, buf); #endif Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: xmlconcat (was [HACKERS] 9.0 release notes done)

2010-04-04 Thread Takahiro Itagaki
Tom Lane t...@sss.pgh.pa.us wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Can we take the patch for 9.0? The bug is registered as an open item: http://wiki.postgresql.org/wiki/PostgreSQL_9.0_Open_Items Given that there are still problems with it, applying the patch

[HACKERS] VACUUM FULL during initdb

2010-04-04 Thread Takahiro Itagaki
;\n, vacuum_db(void) PG_CMD_PUTS(ANALYZE;\nVACUUM FULL;\nVACUUM FREEZE;\n); Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: xmlconcat (was [HACKERS] 9.0 release notes done)

2010-04-02 Thread Takahiro Itagaki
could have ?xml before DOCTYPE. =# SELECT xmlconcat('foo', xmlparse(DOCUMENT '?xml version=1.0? !DOCTYPE html html/')); xmlconcat --- foo (1 row) Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Compile fail, alpha5 gcc 4.3.3 in elog.c

2010-04-02 Thread Takahiro Itagaki
(cmdLine, buf); + cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf)); strcpy(cmdLine, buf); #endif Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Problem of Magic Block in Postgres 8.2

2010-04-01 Thread Takahiro Itagaki
++ exceptions and destructors in your module because PostgreSQL uses siglongjmp; C++ unwind semantics don't work on postgres' errors. You cannot use those C++ features and postgres' APIs together. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list

Re: [SPAM]Re: [HACKERS] Questions about 9.0 release note

2010-03-31 Thread Takahiro Itagaki
move some contents from CREATE TABLE to the constraints doc. Regards, --- Takahiro Itagaki NTT Open Source Software Center docfix_20100331.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] [BUGS] BUG #5394: invalid declspec for PG_MODULE_MAGIC

2010-03-29 Thread Takahiro Itagaki
. Regards, --- Takahiro Itagaki NTT Open Source Software Center PGMODULEEXPORT.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Questions about 9.0 release note

2010-03-29 Thread Takahiro Itagaki
://developer.postgresql.org/pgdocs/postgres/ddl-constraints.html#AEN2431 Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Patch for 9.1: initdb -C option

2010-03-28 Thread Takahiro Itagaki
is better than initdb + echo? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] WIP: preloading of ispell dictionary

2010-03-22 Thread Takahiro Itagaki
simply mmap it? BTW, SimpleAllocContextCreate() is not used at all in the patch. Do you still need it? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Ragged latency log data in multi-threaded pgbench

2010-03-22 Thread Takahiro Itagaki
Greg Smith g...@2ndquadrant.com wrote: Attached is an updated version that I think is ready to commit. Only changes are docs--I rewrote those to improve the wording some. Thanks for the correction. Applied. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql

Re: [HACKERS] 9.0 release notes done

2010-03-22 Thread Takahiro Itagaki
DISTINCT(loid) FROM pg_largeobject to SELECT oid FROM pg_largeobject_metadata because an empty large object doesn't have rows in pg_largeobject. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Ragged latency log data in multi-threaded pgbench

2010-03-22 Thread Takahiro Itagaki
Greg Smith g...@2ndquadrant.com wrote: By the way: the pgbench.sgml that you committed looks like it passed through a system that added a CR to every line in it. Probably not the way you intended to commit that. Oops, fixed. Thanks. Regards, --- Takahiro Itagaki NTT Open Source Software

Re: [HACKERS] Partitioning syntax

2010-03-17 Thread Takahiro Itagaki
FOR SHARE; ERROR: SELECT FOR UPDATE/SHARE is not allowed with UNION/INTERSECT/EXCEPT (in 9.0) Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] [GENERAL] trouble with to_char('L')

2010-03-17 Thread Takahiro Itagaki
Bruce Momjian br...@momjian.us wrote: Takahiro Itagaki wrote: Since 9.0 has GetPlatformEncoding() for the purpose, we could simplify db_encoding_strdup() with the function. Like this: OK, I don't have any Win32 people testing this patch so if we want this fixed for 9.0 someone is going

Re: [HACKERS] Ragged latency log data in multi-threaded pgbench

2010-03-15 Thread Takahiro Itagaki
for multi-threaded implementations or semaphore for multi-threaded ones. 2. Use per-thread log files. File names would be pgbench_log.main-process-id.thread-id. Which is better, or another idea? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers

Re: [HACKERS] Ragged latency log data in multi-threaded pgbench

2010-03-15 Thread Takahiro Itagaki
Tom Lane t...@sss.pgh.pa.us wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: Oops. There might be two solutions for the issue: 1. Use explicit locks. The lock primitive will be pthread_mutex for multi-threaded implementations or semaphore for multi-threaded ones

Re: [HACKERS] Ragged latency log data in multi-threaded pgbench

2010-03-15 Thread Takahiro Itagaki
Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: 2. Use per-thread log files. File names would be pgbench_log.main-process-id.thread-id. Here is a patch to implement per-thread log files for pgbench -l. The log filenames are pgbench_log.main-process-id.thread-serial-number

Re: [HACKERS] [GENERAL] trouble with to_char('L')

2010-03-11 Thread Takahiro Itagaki
of strdup() without any #ifdef WIN32 quotes. BTW, I found we'd better to add ANSI_X3.4-1968 as an alias for PG_SQL_ASCII. My Fedora 12 returns the name when --no-locale is used. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] lock mode for ControlFileLock which pg_start_backup uses

2010-03-09 Thread Takahiro Itagaki
mode which pg_start_backup() uses. Is it worth applying this patch? Thanks, applied. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] lock mode for ControlFileLock which pg_start_backup uses

2010-03-08 Thread Takahiro Itagaki
if there is no performance benefits from it. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-08 Thread Takahiro Itagaki
, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] ecpg compiler warning about char* comparison

2010-03-07 Thread Takahiro Itagaki
*sqlstate; if (sqlstate == ECPG_SQLSTATE_ECPG_INTERNAL_ERROR) --- Instead, should we use if (strcmp(...) == 0) here? Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-07 Thread Takahiro Itagaki
it instead of PGDLLEXPORT. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Visual Studio 2005, C-language function - avoiding hacks?

2010-03-07 Thread Takahiro Itagaki
Tom Lane t...@sss.pgh.pa.us wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp writes: I'd like to propose to define PGALWAYSEXPORT macro: #ifdef WIN32 #define PGALWAYSEXPORT __declspec (dllexport) #endif and modify PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 to use

Re: [HACKERS] C libpq frontend library fetchsize

2010-03-01 Thread Takahiro Itagaki
of the interface mismatch -- libpq uses array-based APIs (PGresult) and JDBC uses a cursor-like API (ResultSet). Instead, you can use CURSOR and FETCH commands to retrieve rows in separated PGresult objects. Regards, --- Takahiro Itagaki NTT Open Source Software Center -- Sent via pgsql-hackers mailing list

[HACKERS] code cleanup: ss_currentScanDesc

2010-02-25 Thread Takahiro Itagaki
actually. Regards, --- Takahiro Itagaki NTT Open Source Software Center ss_currentScanDesc_20100226.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

  1   2   3   >