Hi,
On 19/03/14 15:12, Alvaro Herrera wrote:
I hope the silence meant assent, because I have pushed this patch now.
Great, thanks!
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpYfuVjR_gg_.pgp
,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index e2337ac..c0f5881 100644
--- a/src/backend/access/heap/heapam.c
+++ b/src/backend/access/heap/heapam.c
Hi,
On 13/03/14 03:27, Fujii Masao wrote:
Committed!
Thank you very much!
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpkDoVMmXIL4.pgp
Description: PGP signature
touch the code which has no relation
to current patch.
OK. Thanks.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 71ec740
the function name in above comment.
Fixed.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index 71ec740..0cf3537 100644
--- a/src/backend
Hi,
On 10/03/14 14:59, Robert Haas wrote:
On Mon, Mar 10, 2014 at 7:44 AM, Christian Kruse
christ...@2ndquadrant.com wrote:
[ response to review ]
This response seems to have made no mention of point #7 from Amit's
review, which seems to me to be a rather important one.
Just didn't
), but they have to be enabled explicitely via
xref linkend=guc-huge-pages. See
xref linkend=linux-huge-pages for details.
I attached a patch doing this change.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training
just
leave that last sentence out. It's mentioned later that With
literalon/literal, failure to use huge pages will prevent the server
from starting up., that's probably enough.
Fixed.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7
doesn't seem
to make sense, too – naming will then be inconsistent and thus lead to
confusion, too. Do you agree?
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpkad_A3izOE.pgp
Description: PGP signature
Hi,
On 27/02/14 08:35, Christian Kruse wrote:
Hi Peter,
Sorry, Stephen of course – it was definitely to early.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpm6lYpan4Df.pgp
Description: PGP signature
Hi,
On 25/02/14 16:11, Robert Haas wrote:
On Mon, Feb 24, 2014 at 10:13 AM, Christian Kruse
christ...@2ndquadrant.com wrote:
To be honest, I don't like the idea of setting up this error context
only for log_lock_wait messages. This sounds unnecessary complex to me
and I think
.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index 4dc1277..0006090 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src/sgml/config.sgml
, but this is in the nature
of things. Structure, diction and focus are different. Also the
information transferred is different and gathered from various
articles, including the Debian wiki, the huge page docs of the kernel,
the Wikipedia and some old IBM and Oracle docs.
Best regards,
--
Christian
had done that. However, thanks for committing and
fixing!
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpBD5IQLGElj.pgp
Description: PGP signature
it.
Using huge TLB pages reduces overhead when using large contiguous chunks of
memory, like PostgreSQL does.
Sentence added.
That's good advice, but perhaps s/calculate/estimate/. It's just an
approximation, after all.
Fixed.
New patch version is attached.
Best regards,
--
Christian Kruse
be easy to split that.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index cf11306..77c778f 100644
--- a/doc/src/sgml/config.sgml
+++ b/doc/src
Hi Peter,
thank you for your nice words, much appreciated. I'm sorry that I was
so whiny about this in the last post.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpxVj8SJRDQS.pgp
Description: PGP
,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpfzdmiy8T7D.pgp
Description: PGP signature
not my only source) read the Debian article and I was
influenced by it. It may be that the texts are more similar then I
thought, although I still don't see it.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
understand that there is no clear issue here, so may be if others also
share their opinion then it will be quite easy to take a call.
That would be nice. I didn't change it, yet.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support
because
of this, since they provide useful and precious debugging information.
Attached you will find a new version of the patch, mainly using
wrapper functions for XactLockTableWait() and MultiXactIdWait().
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL
, and is only suitable for hiding strings.
No, it is not secure. And I agree, encrypting .pgpass doesn't make
sense. Either you have a known key and then encryption is useless or
you have to provide a key at runtime and then .pgpass is useless.
Best regards,
--
Christian Kruse http
Hi,
On 18.02.2014 22:02, Andres Freund wrote:
Not really sure which way is better.
One dev against it, one dev not sure. Enough for me to change it :)
Will post a new patch this evening.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development
agree.
I will change it if this is really wanted, but I think it would be a
good idea to do it this way.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
signature.asc
Description: OpenPGP digital signature
Hi,
On Tuesday 11 February 2014 16:04:30 Peter Eisentraut wrote:
On 1/30/14, 2:42 AM, Christian Kruse wrote:
+Since Gentoo often supports different versions of a package to be
+installed you have to tell the PostgreSQL build environment where the
+Docbook DTD is located
user is not very popular in OS X land.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpZntl0SyG93.pgp
Description: PGP signature
the lock: A. Wait queue: B.
Processes holding the lock: A, B. Wait queue: C.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/doc/src/sgml/sources.sgml b/doc/src/sgml/sources.sgml
index 881b0c3
Hi,
On 04/02/14 17:41, Erik Rijkers wrote:
2014-02-04 10:34:25.376 CET 29133 LOG: server process (PID 29459) was
terminated by signal 9: Killed
Did you check if this was the OOM killer? Should be logged in dmesg.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com
sockets.
The results are pretty impressive… I will post the read-write results
as soon as they are finished.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpKL7vRo_Vp0.pgp
Description: PGP signature
Hi,
On 04/02/14 12:02, Peter Geoghegan wrote:
On Tue, Feb 4, 2014 at 11:39 AM, Christian Kruse
christ...@2ndquadrant.com wrote:
I'm doing some benchmarks regarding this problem: one set with
baseline and one set with your patch. Machine was a 32 core machine (4
CPUs with 8 cores), 252 gib
for baseline+alignment patch is running. This will take
a couple of hours and since I have to get up at about 05:00 I won't be
able to post it before tomorrow.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
: A. The request queue
consists of: B.
Plural:
Following processes are holding the lock: A, B. The request queue
consists of: C.
Attached you will find an updated patch.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training
proposal:
Singular:
Process holding the lock: A. Request queue: B
Plural:
Processes holding the lock: A, B. Request queue: C, D
This seems to be a good trade-off between project guidelines,
readability and parsability.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com
that are two different locks thus the two
different holders and queues. So…
Is this the intentional behavior?
Yes, I think so.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpr14uoFS4_6.pgp
Description
Hi,
On 31/01/14 22:17, MauMau wrote:
Thanks for reviewing the patch. Fixed. I'll add this revised patch to the
CommitFest entry soon.
Looks fine for me. Set it to „waiting for commit.“
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development
,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpkstlLLohOH.pgp
Description: PGP signature
, especially if
this is the right lock.
I also note that the docs seem to need some copy-editing:
+ entryThe current xref linked=ddl-system-columnsxmin
value./xref/entry
Can you elaborate?
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7
Hi,
personally I really dislike constructs like you used:
#ifdef WIN32
if (check_if_admin)
#endif
check_root(progname);
It is hard to read and may confuse editors. Can you rewrite it?
The rest looks fine to me.
Best regards,
--
Christian Kruse http
Hi,
For the documentation patch, I propose the attached to avoid future
confusions. Comments? It might make sense to back-patch as well.
Compiles, didn't find any typos and I think it is comprehensible.
Looks fine for me.
Best regards,
--
Christian Kruse http://www
), *or* the _().
Have a look at the psprintf() call: we first have a _(failed to look
up effective user id %ld: %s) as an argument, then we have a (long)
user_id and after that we have a ternary expression using errno. Isn't
it possible that the first _() changes errno?
Best regards,
--
Christian
not be the case.
Thanks for your explanation. I verified reading the man page and it
explicitly says:
ERRORS
errno is not modified.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpHCNemua8zx.pgp
as a fix.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
index 8705586..f40215a 100644
--- a/src/backend/utils/error/elog.c
+++ b/src
a patch for better documentation.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
old mode 100644
new mode 100755
index 1b5f831..68b38f7
--- a/doc
in this
function
pg_shmem.c:332: note: 'allocsize' was declared here
Attached patch should fix that.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/port/sysv_shmem.c b/src/backend/port
Hi,
On 29/01/14 21:36, Heikki Linnakangas wrote:
[…]
Fix pushed.
You are right. Thanks. But there is another bug, see
20140128154307.gc24...@defunct.ch
ff. Attached you will find a patch fixing that.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL
on it.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpCS2lzolGJg.pgp
Description: PGP signature
and looked for ereport calls with errno in it. I found quite a few,
attached you will find a patch addressing that issue.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/commands
Hi,
On 29/01/14 21:37, Christian Kruse wrote:
[…]
attached you will find a patch addressing that issue.
Maybe we should include the patch proposed in
20140129195930.gd31...@defunct.ch
and do this as one (slightly bigger) patch. Attached you will find
this alternative version.
Best regards
Hi,
after I finally got documentation compilation working I updated the
patch to be syntactically correct. You will find it attached.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/doc/src/sgml
Hi Tom,
On 29/01/14 20:06, Tom Lane wrote:
Christian Kruse christ...@2ndquadrant.com writes:
Your reasoning sounds quite logical to me. Thus I did a
grep -RA 3 ereport src/* | less
and looked for ereport calls with errno in it. I found quite a few,
attached you will find a patch
Hi,
as a Gentoo user I had a hard time getting the documentation
compiled. Attached you will find a Patch explaining exactly this: how
to compile the documentation under Gentoo.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support
. Request queue: Y.
Where Y is the process ID of same process, which was trying to acquire
lock.
This is on purpose due to the rewording of the Message. In the first
version the PID of the backend was missing.
Thanks for the review!
Best regards,
--
Christian Kruse http://www
and currently doing some
benchmarks. Next will be documentation.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpHMKmOD_jGn.pgp
Description: PGP signature
it should be like this:
if (huge_tlb_pages == HUGE_TLB_OFF ||
(huge_tlb_pages == HUGE_TLB_TRY ptr == MAP_FAILED))
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpG9E74KaJDV.pgp
/bugs/show_bug.cgi?id=18644
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpA2ZYq2t26Z.pgp
Description: PGP signature
) : 0));
Same if I use an if(errno == ENOMEM) instead of the ternary operator.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpjAIs_29NNJ.pgp
Description: PGP signature
Hi,
attached you will find a new version of the patch, ported to HEAD,
fixed the mentioned bug and - hopefully - dealing the the remaining
issues.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git
Hi,
On 28/01/14 16:43, Christian Kruse wrote:
ereport(FATAL,
(errmsg(could not map anonymous shared memory:
%m),
(errno == ENOMEM) ?
errhint(This error usually means that
PostgreSQL's
Hi,
I think you have attached wrong patch.
Hurm. You are right, attached v3, not v4. Sorry.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/storage/lmgr/proc.c b/src/backend
we need to take performance reading to see if any impact?
Don't think so. Diagnosing problems will help performance, not hinder it
I agree. And this code path will only get executed when log_lock_waits
= on, which seems to be a debugging method to me.
Best regards,
--
Christian Kruse
regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/storage/lmgr/proc.c b/src/backend/storage/lmgr/proc.c
index 122afb2..552c5a4 100644
--- a/src/backend/storage/lmgr/proc.c
+++ b/src/backend
not such a wise idea, and
errdetail_log() is what should be used.
Fixed. I added an errdetail_log_plural() for this, too.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/storage/lmgr
is set in postgresql.auto.conf.
+1
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpfpMOCECyB7.pgp
Description: PGP signature
for this (see comment for relationHasPrimaryKey() in
src/backend/catalog/index.c).
Regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
index
!
But, to be honest, I am still unsure where to put this. As far as I
understand this commit has substantial parts in relcache.c and
elog.c – both don't seem to be very good fitting places?
Regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support
it this
way.
Regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgphhZyFupMjQ.pgp
Description: PGP signature
of the log output;
however, I was not able to provide an expected file since the process
IDs vary from test run to test run.
Regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
diff --git a/src/backend/access/heap
://commitfest.postgresql.org/action/patch_view?id=1350) and
the second, new one is located here:
https://commitfest.postgresql.org/action/patch_view?id=1351
Regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
do you think?
I also created two test specs for easy creation of the log output;
however, I was not able to provide an expected file since the process
IDs vary from test run to test run.
Regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7
Hi,
On 17/12/13 12:08, Robert Haas wrote:
Please add your patch here so we don't lose track of it:
https://commitfest.postgresql.org/action/commitfest_view/open
Thanks. I nearly forgot that.
Regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development
with the master. Is this correct?
I don't see a problem here… the standby should not be in sync with the
master, it should be delayed. I did step by step what you did and
after 50 minutes (300ms) the standby was at the same level the
master was.
Did I missunderstand you?
Regards,
Christian Kruse
in the documentation about
time syncing?
Greetings,
CK
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgp929ckT_fsN.pgp
Description: PGP signature
,
CK
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training Services
pgpok2vtj3rMM.pgp
Description: PGP signature
Hi,
On Monday 29 October 2012 16:33:25 Tom Lane wrote:
Christian Kruse cjk+postg...@defunct.ch writes:
I created a patch which implements MAP_HUGETLB for sysv shared memory
segments (PGSharedMemoryCreate). It is based on tests of Tom Lane and
Andres Freund, I added error handling, huge
Hi,
On Wednesday, October 31, 2012 02:51:38 PM Pavel Stehule wrote:
Hello
it is expected behave?
1.session
postgres=# begin;
BEGIN
postgres=# lock oo IN ACCESS EXCLUSIVE MODE;
LOCK TABLE
2. session
postgres=# select * from oo for update nowait;
hangs forever
Yes, I
Hey,
On 30/10/12 20:33, Andres Freund wrote:
+#ifdef MAP_HUGETLB
+# ifdef __ia64__
+#define PG_HUGETLB_BASE_ADDR (void *)(0x8000UL)
+#define PG_MAP_HUGETLB (MAP_HUGETLB|MAP_FIXED)
+# else
Not your fault, but that looks rather strange to me. The level of
Hi,
On 29/10/12 21:14, Peter Geoghegan wrote:
I have a few initial observations on this.
Thanks for your feedback.
* I think you should be making the new GUC PGC_INTERNAL on platforms
where MAP_HUGETLB is not defined or available. See also,
effective_io_concurrency. This gives sane error
Hi,
On 29/10/12 16:33, Tom Lane wrote:
I created a patch which implements MAP_HUGETLB for sysv shared memory
segments
(PGSharedMemoryCreate). It is based on tests of Tom Lane and Andres Freund,
I
added error handling, huge page size detection and a GUC variable.
My recollection is
Hey,
Oh man, first I didn't sent the email to the list and now I forgot the
attachment. I should really get some sleep, sorry for any
inconveniences :(
Greetings,
CK
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index b4fcbaf..66ed10f 100644
--- a/doc/src/sgml/config.sgml
+++
Hey,
On 30/10/12 20:33, Andres Freund wrote:
+#ifdef MAP_HUGETLB
+# ifdef __ia64__
+#define PG_HUGETLB_BASE_ADDR (void *)(0x8000UL)
+#define PG_MAP_HUGETLB (MAP_HUGETLB|MAP_FIXED)
+# else
Not your fault, but that looks rather strange to me. The level of
Hey,
ok, I think I implemented all of the changes you requested. All but
the ia64 dependent, I have to do more research for this one.
Greetings,
CK
diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml
index b4fcbaf..66ed10f 100644
--- a/doc/src/sgml/config.sgml
+++
Hey,
On Tuesday 30 October 2012 20:33:18 Andres Freund wrote:
+#ifdef MAP_HUGETLB
+# ifdef __ia64__
+#define PG_HUGETLB_BASE_ADDR (void *)(0x8000UL)
+#define PG_MAP_HUGETLB (MAP_HUGETLB|MAP_FIXED)
+# else
Not your fault, but that looks rather strange to me. The level
Hey,
this is my first post to the -hackers lists, so be merciful ;-)
I created a patch which implements MAP_HUGETLB for sysv shared memory segments
(PGSharedMemoryCreate). It is based on tests of Tom Lane and Andres Freund, I
added error handling, huge page size detection and a GUC variable.
83 matches
Mail list logo