Re: [HACKERS] Review: create extension default_full_version

2012-12-11 Thread Ibrar Ahmed
at least we should give some meaningful error message. On Tue, Dec 4, 2012 at 4:46 PM, Ibrar Ahmed ibrar.ah...@gmail.com wrote: On Tue, Dec 4, 2012 at 7:54 PM, Dimitri Fontaine dimi...@2ndquadrant.frwrote: Ibrar Ahmed ibrar.ah...@gmail.com writes: I am still getting the same error

Re: [HACKERS] Review: create extension default_full_version

2012-12-04 Thread Ibrar Ahmed
On Mon, Dec 3, 2012 at 11:05 PM, Dimitri Fontaine dimi...@2ndquadrant.frwrote: Hi, Thanks for your very good review! Ibrar Ahmed ibrar.ah...@gmail.com writes: I looked at the discussion for this patch and the patch itself. Here are my comments and observations about the patch. What I

Re: [HACKERS] Review: create extension default_full_version

2012-12-04 Thread Ibrar Ahmed
On Tue, Dec 4, 2012 at 7:54 PM, Dimitri Fontaine dimi...@2ndquadrant.frwrote: Ibrar Ahmed ibrar.ah...@gmail.com writes: I am still getting the same error message. With the attached patch (v2), it works well: create extension hstore version '1.2' from 'unpackaged'; DEBUG

[HACKERS] Review: create extension default_full_version

2012-11-30 Thread Ibrar Ahmed
VERSION '1.1' FULL_VERSION '1.0'; - hstore regression is also failing. --- Ibrar Ahmed

Re: [HACKERS] errno not set in case of libm functions (HPUX)

2011-05-27 Thread Ibrar Ahmed
for the next release. Hmm. I'm a bit scared of how much might break. I don't think the autoconf tests are generally designed to guarantee no warnings. regards, tom lane -- Ibrar Ahmed

Re: [HACKERS] errno not set in case of libm functions (HPUX)

2011-05-25 Thread Ibrar Ahmed
is coming from autoconf not our own code); so I'm not optimistic that we can get more-standard behavior by overriding that. regards, tom lane -- Ibrar Ahmed diff --git a/configure b/configure index 3b23c46..d448534 100755 --- a/configure +++ b/configure @@ -4468,6 +4468,66

[HACKERS] errno not set in case of libm functions (HPUX)

2011-05-24 Thread Ibrar Ahmed
-hackers/2011-05/msg00046.php -- Ibrar Ahmed diff --git a/src/makefiles/Makefile.hpux b/src/makefiles/Makefile.hpux index 1917d61..f2a8f19 100644 --- a/src/makefiles/Makefile.hpux +++ b/src/makefiles/Makefile.hpux @@ -43,6 +43,12 @@ else CFLAGS_SL = +Z endif + +# HP-UX libm functions

Re: [HACKERS] Fwd: psql include file using relative path

2011-03-08 Thread Ibrar Ahmed
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --    Ibrar Ahmed -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] error order when debug postgresql step by step?

2011-03-01 Thread Ibrar Ahmed
compile. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --    Ibrar Ahmed -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] REVIEW: Determining client_encoding from client locale

2011-02-08 Thread Ibrar Ahmed
Stephen Frost! I have modified the code to use ADD_STARTUP_OPTION instead of writing code again. And tried the patch on Windows and Linux and it works for me. On Sun, Feb 6, 2011 at 10:19 AM, Stephen Frost sfr...@snowman.net wrote: Ibrar, * Ibrar Ahmed (ibrar.ah...@gmail.com) wrote: I

Re: [HACKERS] REVIEW: Determining client_encoding from client locale

2011-02-02 Thread Ibrar Ahmed
and will send results. -- Ibrar Ahmed On Sun, Jan 30, 2011 at 10:56 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 29.01.2011 19:23, Peter Eisentraut wrote: Also, do we really need a new set of states for this..? I would have thought, just reading through the patch

Re: [HACKERS] REVIEW: Determining client_encoding from client locale

2011-02-02 Thread Ibrar Ahmed
On Wed, Feb 2, 2011 at 5:22 AM, Ibrar Ahmed ibrar.ah...@gmail.com wrote: Hi!, I have reviewed/tested this patch. OS = Linux ubuntu 2.6.35-22-generic #33-Ubuntu SMP Sun Sep 19 20:34:50 UTC 2010 i686 GNU/Linux PostgreSQL Version = Head (9.1devel) Patch gives the desired results(still

Re: [HACKERS] Review: B-Tree emulation for GIN

2008-12-19 Thread Ibrar Ahmed
Thanks, On Fri, Dec 19, 2008 at 3:26 PM, Teodor Sigaev teo...@sigaev.ru wrote: Updated patch. Ibrar Ahmed wrote: Hi Teodor Sigaev, I am getting server crash in contrib regression. May be I am doing something wrong here. Regression diff is attached. BTW these queries work fine outside

[HACKERS] Review: B-Tree emulation for GIN

2008-12-17 Thread Ibrar Ahmed
Hi Teodor Sigaev, I am getting server crash in contrib regression. May be I am doing something wrong here. Regression diff is attached. BTW these queries work fine outside the regression. -- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com regression.diffs Description: Binary data

Re: [HACKERS] COCOMO Indians

2008-12-11 Thread Ibrar Ahmed
) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers -- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] pg_stop_backup wait bug fix

2008-12-03 Thread Ibrar Ahmed
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers -- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

[HACKERS] [Review] Grouping Sets patch

2008-11-24 Thread Ibrar Ahmed
) Some Minor code observations -- 1 - IMHO we should use enum instead of #define i.e #define CUBE_OP 1 #define ROLLUP_OP 2 #define FUNCCALL_OP 3 -- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers

Re: [HACKERS] New bug

2008-11-19 Thread Ibrar Ahmed
http://www.enterprisedb.com Ask me about EnterpriseDB's PostGIS support! -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers -- Ibrar Ahmed EnterpriseDB http

Re: [HACKERS] quick question about WIP: grouping sets support

2008-11-11 Thread Ibrar Ahmed
/src' make: *** [all] Error 2 On Tue, Nov 11, 2008 at 9:52 PM, Pavel Stehule [EMAIL PROTECTED] wrote: Hello I synced grouping sets with current CVS HEAD. Please, try: http://www.pgsql.cz/patches/gsets.diff.gz Thank you Pavel Stehule 2008/11/10 Ibrar Ahmed [EMAIL PROTECTED]: Hi

[HACKERS] server crash in to_timestamp function

2008-11-11 Thread Ibrar Ahmed
in turn calls from_char_parse_int_len which in turn calls from_char_set_int. In the function from_char_set_int the first argument dest is being derefernced without the null check. (if (*dest != 0 *dest != value) -- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql

Re: [HACKERS] pg_dump roles support [Review]

2008-11-10 Thread Ibrar Ahmed
/bin/pg_dump/pg_backup_archiver.c | 36 +- src/bin/pg_dump/pg_dump.c| 53 ++ src/bin/pg_dump/pg_dumpall.c | 23 ++ 6 files changed, 143 insertions(+), 2 deletions(-) -- Ibrar Ahmed EnterpriseDB

[HACKERS] pg_dump roles support [Review]

2008-11-05 Thread Ibrar Ahmed
+ free(defn); + die_horribly(AH, modulename, invalid ROLENAME item: %s\n, +te-defn); I think you missed curly brackets of else here. Please send updated patch! -- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql

[HACKERS] ERRORDATA_STACK_SIZE exceeded (server crash)

2008-10-27 Thread Ibrar Ahmed
; client_encoding - UTF8 (1건 있음) postgres=# set client_encoding ='euc-jp'; SET postgres=# x; 서버가 갑자기 연결을 닫았음 이런 처리는 클라이언트의 요구를 처리하는 동안이나 처리하기 전에 서버가 갑자기 종료되었음을 의미함 서버로부터 연결이 끊어졌습니다. 다시 연결을 시도합니다: 실패. ! -- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com

Re: [HACKERS] ERRORDATA_STACK_SIZE exceeded (server crash)

2008-10-27 Thread Ibrar Ahmed
PROTECTED] wrote: Ibrar Ahmed [EMAIL PROTECTED] writes: I have encountered a server crash while working with different locale settings. Are you going to give us a hint what settings those would be? regards, tom lane -- Ibrar Ahmed EnterpriseDB http

[HACKERS] [Review] fix dblink security hole

2008-09-16 Thread Ibrar Ahmed
the reviewer cover all the things that kind of reviewer is supposed to do? (should I answer this too) -- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c index 0e01470..0f90f1e 100644 --- a/contrib/dblink/dblink.c +++ b/contrib

[HACKERS] [Review] fix dblink security hole

2008-09-16 Thread Ibrar Ahmed
the reviewer cover all the things that kind of reviewer is supposed to do? (should I answer this too) -- Ibrar Ahmed diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c index 0e01470..0f90f1e 100644 --- a/contrib/dblink/dblink.c +++ b/contrib/dblink/dblink.c @@ -164,6 +164,7 @@ typedef struct

Re: [HACKERS] [Review] fix dblink security hole

2008-09-16 Thread Ibrar Ahmed
useless and now it doesn't need PGconn parameter. BTW it was just my suggestion otherwise patch looks ok to me -- Ibrar Ahmed

Re: [HACKERS] Need more reviewers!

2008-09-05 Thread Ibrar Ahmed
patches in the list, so I can assign them to beginners. Please volunteer now! Please assign me one; any of the easy ones. -- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Need more reviewers!

2008-09-05 Thread Ibrar Ahmed
patches in the list, so I can assign them to beginners. Please volunteer now! Please assign me one; any of the easy ones. -- Ibrar Ahmed EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your