we don't want to address this issue at least we should give some
meaningful error message.
On Tue, Dec 4, 2012 at 4:46 PM, Ibrar Ahmed wrote:
>
>
> On Tue, Dec 4, 2012 at 7:54 PM, Dimitri Fontaine
> wrote:
>
>> Ibrar Ahmed writes:
>> > I am still getting the
On Tue, Dec 4, 2012 at 7:54 PM, Dimitri Fontaine wrote:
> Ibrar Ahmed writes:
> > I am still getting the same error message.
>
> With the attached patch (v2), it works well:
>
> create extension hstore version '1.2' from 'unpackaged';
> DEBUG: execu
On Mon, Dec 3, 2012 at 11:05 PM, Dimitri Fontaine wrote:
> Hi,
>
> Thanks for your very good review!
>
> Ibrar Ahmed writes:
> > I looked at the discussion for this patch and the patch itself. Here
> > are my comments and observations about the patch.
> > What
CREATE EXTENSION
PS: I modified the code to get this result.
- IMHO there should be an SQL option along with the default_full_version; like.
postgres=# create EXTENSION hstore VERSION '1.1' FULL_VERSION '1.0';
- hstore regression is also failing.
---
Ibrar Ahmed
.
>
> Thanks,
Is it worth to backport this?
> > We could also do that globally, but that would probably be something for
> > the next release.
>
> Hmm. I'm a bit scared of how much might break. I don't think the
> autoconf tests are generally designed to guarantee no warnings.
>
>regards, tom lane
>
--
Ibrar Ahmed
onsistent with what it says under -Ae, so maybe some
> additional experimentation is called for. But anyway, autoconf appears
> to think that -Ae is preferable to the combination -Aa -D_HPUX_SOURCE
> (that choice is coming from autoconf not our own code); so I'm not
> optimistic t
ile.
BTW I have found same kind of discussion without any conclusion here
http://archives.postgresql.org/pgsql-hackers/2011-05/msg00046.php
--
Ibrar Ahmed
diff --git a/src/makefiles/Makefile.hpux b/src/makefiles/Makefile.hpux
index 1917d61..f2a8f19 100644
--- a/src/makefiles/Makefile.hpux
+++ b/src/makefiles/M
seDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
--
Ibrar Ahmed
--
Sent via pgsql-h
>
> -Kevin
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
--
Ibrar Ahmed
--
Sent via pgsql-hackers mailing list (pgsql-hackers@
Stephen Frost!
I have modified the code to use ADD_STARTUP_OPTION instead of writing code
again.
And tried the patch on Windows and Linux and it works for me.
On Sun, Feb 6, 2011 at 10:19 AM, Stephen Frost wrote:
> Ibrar,
>
> * Ibrar Ahmed (ibrar.ah...@gmail.com) wrote:
&
On Wed, Feb 2, 2011 at 5:22 AM, Ibrar Ahmed wrote:
> Hi!,
>
> I have reviewed/tested this patch.
>
> OS = "Linux ubuntu 2.6.35-22-generic #33-Ubuntu SMP Sun Sep 19 20:34:50 UTC
> 2010 i686 GNU/Linux"
> PostgreSQL Version = Head (9.1devel)
>
> Patch gives th
_encoding_initial) +
1;
}
}*
*
*
*
*
BTW why you have not used "ADD_STARTUP_OPTION"?
I will test this patch on Windows and will send results.
--
Ibrar Ahmed
On Sun, Jan 30, 2011 at 10:56 AM, Heikki Linnakangas <
heikki.linnakan...@enterprisedb.com&
Thanks,
On Fri, Dec 19, 2008 at 3:26 PM, Teodor Sigaev wrote:
> Updated patch.
>
> Ibrar Ahmed wrote:
>
>> Hi Teodor Sigaev,
>>
>> I am getting server crash in contrib regression. May be I am doing
>> something wrong here. Regression diff is attached.
>&
Hi Teodor Sigaev,
I am getting server crash in contrib regression. May be I am doing something
wrong here. Regression diff is attached.
BTW these queries work fine outside the regression.
--
Ibrar Ahmed
EnterpriseDB http://www.enterprisedb.com
regression.diffs
Description: Binary data
that American company will resale implementation to Indian
>> subcontractor
>> (i.e. real developers will be Indians anyway).
>>
>>
>> What requirements should satisfy code, written by Indians, to be in next
>> version of Postgres ?
>>
>>
>>
>&g
hich probably you thought) BackupHistoryFilePath?
>
> Ouch, you're right. That's subtle.
>
>> In order to prevent
>> confusion, we should add new local variable (histfilename) for the backup
>> history file name?
>
> Agreed. I included that in the patch
Denmark |2 |200
Australia |1 |100
(6 rows)
Some Minor code observations
--
1 - IMHO we should use enum instead of #define
i.e
#define CUBE_OP 1
#define ROLLUP_OP 2
#define FUNCCALL_OP 3
--
Ibrar Ahmed
.com
> Ask me about EnterpriseDB's PostGIS support!
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
--
Ibrar Ahmed
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
; was here
make[3]: *** [parse_gsets.o] Error 1
make[3]: Leaving directory
`/home/ibrar/edb-work/PostgreSQL/postgresql/src/backend/parser'
make[2]: *** [parser-recursive] Error 2
make[2]: Leaving directory
`/home/ibrar/edb-work/PostgreSQL/postgresql/src/backend'
make[1]: *** [all] Error
rst argument NULL. The function "from_char_parse_int" in turn calls
"from_char_parse_int_len" which in turn calls "from_char_set_int".
In the function "from_char_set_int" the first argument "dest" is being
derefernced without the null check.
ump/pg_dump.c| 53
> ++
> src/bin/pg_dump/pg_dumpall.c | 23 ++
> 6 files changed, 143 insertions(+), 2 deletions(-)
>
>
>
--
Ibrar Ahmed
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
free(defn);5 -
+ }
+ else
+ free(defn);
+ die_horribly(AH, modulename, "invalid ROLENAME item: %s\n",
+te->defn);
I think you missed curly brackets of else here.
Please send updated patch!
--
Ibrar Ahmed
t 6:42 PM, Tom Lane <[EMAIL PROTECTED]> wrote:
> "Ibrar Ahmed" <[EMAIL PROTECTED]> writes:
>> I have encountered a server crash while working with different locale
>> settings.
>
> Are you going to give us a hint what settings those would be?
>
&
;
client_encoding
-
UTF8
(1건 있음)
postgres=# set client_encoding ='euc-jp';
SET
postgres=# x;
서버가 갑자기 연결을 닫았음
이런 처리는 클라이언트의 요구를 처리하는 동안이나
처리하기 전에 서버가 갑자기 종료되었음을 의미함
서버로부터 연결이 끊어졌습니다. 다시 연결을 시도합니다: 실패.
!>
--
Ibrar Ahmed
EnterpriseDB http://www.ent
ck function make this function almost useless and now it doesn't
need PGconn parameter.
BTW it was just my suggestion otherwise patch looks ok to me
--
Ibrar Ahmed
ms? (I don't think so)
Review review
-
- Did the reviewer cover all the things that kind of reviewer is supposed
to do? (should I answer this too)
--
Ibrar Ahmed
diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index 0e01470..0f90f1e 100644
(I don't think so)
Review review
-
- Did the reviewer cover all the things that kind of reviewer is
supposed to do? (should I answer this too)
--
Ibrar Ahmed
EnterpriseDB http://www.enterprisedb.com
diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dbli
"easy" patches in the list, so
I can assign them to beginners.
Please volunteer now!
Please assign me one; any of the "easy" ones.
--
Ibrar Ahmed
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To
"easy" patches in the list, so
I can assign them to beginners.
Please volunteer now!
Please assign me one; any of the "easy" ones.
--
Ibrar Ahmed
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To
29 matches
Mail list logo
