Each of them looks
equally reasonable for me. GUC idea is also good because we need to
mark format() as VOLATILE anyway. We have nothing to lose.
---
Takahiro Itagaki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
quot;10 characters" in the code.
But there might be usages to format text values for display. In such
case, display length might be better for the length specifier.
How about having both "s" and "S"?
"%10s" -- 10 characters
"%10S" -- 10 d
- We need Makefile for contrib/dict_preload.
- mmap() is not always portable. We should check the availability
in configure, and also have an alternative implementation for Win32.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsq
sizeof(tuplen)) !=
sizeof(tuplen))
elog(ERROR, "unexpected end of data");
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
confict with "ALTER TABLE ... ADD [COLUMN]".
Since we can omit COLUMN, parser treats "ADD PARTITION" as adding
a column named "PARTITION". We need to add PARTITION into the reserved
keyword list to avoid shift/reduce errors.
Do you have any better idea?
Regards,
---
0' ...
I think all of the following codes work in the same way
at least on Windows, where the codes are actually used.
utf16[dstlen] = L'\0';
utf16[dstlen] = '\0';
utf16[dstlen] = 0;
utf16[dstlen] = (WCHAR) 0;
Regards,
---
Takahiro Itagaki
NTT Open S
ter
description than "copy&paste from FormIndexDatum".
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
sorted_cluster-20100706.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://w
timeout,
where the signal is sent when we have some old messages in the queue
longer than 30sec - 1min.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql
disk spaces in the early stages.
Am I missing something? Comments welcome.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ibraries'
and logs internal information you want from _PG_init() or shmem_startup_hook.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ions, and test their new features
at the master, and restart replication to spread the changes to slaves.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ached patch is a WIP codes for the case 2, but it might be
better to design management policy via SQL in 9.1 before such detailed
implementation. Comments welcome.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
walsender_activity-20100618.patch
Description: Binary data
--
Sent via p
r the feature.)
* master branch is a copy of postgres' HEAD.
* 'partition' branch contains codes for partitioning.
The details and discussion for partitioning are in the wiki page:
http://wiki.postgresql.org/wiki/Table_partitioning
Regards,
---
Takahiro Itagaki
NTT
Hi,
GetOldestWALSendPointer() is commented out in the source code
with NOT_USED block, but is still declared in the header file.
Should we remove the function prototype from walsender.h ?
[walsender.h]
extern XLogRecPtr GetOldestWALSendPointer(void);
Regards,
---
Takahiro Itagaki
NTT Open
need a line break at Line 130
because strerror() fills the last %s.
L.130: fprintf(stderr, "\n%s: ERROR failed to remove \"%s\": %s",
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Write-Ahead Log / Standby Servers
Renamed in the configuration file:
Replication ==> Streaming Replication
Hot Standby ==> Standby Servers
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
guc-category-cleanup_20100615.diff
Description: Binary data
--
Sent via pgsql-hac
= ControlFile->max_locks_per_xact)
{
/*
* The change in number of backend slots doesn't need to be
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
aiting for statement_timeout"
for normal queries.
If we need additional information about conflictions in recovery,
we would supply them with SQL views instead of ps display in 9.1.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing l
ternal
constant variable. I'd like to rewrite the description like:
... then the return value will be 0/0, that is never used in normal cases.
Comments?
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To
E conflicted-with-recovery-process;
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ad of the trigger file based management.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
he patch.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
estartpoint-to-archive_cleanup.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
erence for archive_cleanup_command here.
>
> OK, sounds like we have consensus on that. Who wants to do it?
Do we just need to replace all of them? If so, patch attached.
I replaced 3 terms: recovery_end_command, recovery-end-command,
and recoveryEndCommand.
Regards,
---
Tak
I found contrib/dblink leaks a connection or a small amout of memory
when dblink_connect() ends with a duplicate connection name error.
We should disconnect the connection before raise any ERRORs.
Patch attached.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
dblink-connection
itag...@postgresql.org (Takahiro Itagaki) wrote:
> Fix dblink to treat connection names longer than NAMEDATALEN-2 (62 bytes).
> Now long names are adjusted with truncate_identifier() and NOTICE messages
> are raised if names are actually truncated.
>
>
T,
OUT index_size BIGINT,
OUT root_block_no BIGINT,
OUT internal_pages BIGINT,
OUT leaf_pages BIGINT,
OUT empty_pages BIGINT,
OUT deleted_pages BIGINT,
OUT avg_leaf_density FLOAT8,
OUT leaf_fragmentation FLOAT8)
AS 'MODULE_PATHNAME', 'pgstatindex'
andbyDelay); ==> GetCurrentTimestamp() - waitStart
set_ps_display(new_status, false);
I think SQL-based activity view will be more useful than ps display,
but it's an item for 9.1.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postg
Takahiro Itagaki wrote:
> Could you explain why default_only entries idea is
> better than adjusting those fields in the toast-specific codes?
> It's my understanding that reloption-framework is just a tool to fill
> reloption parameters, and it's not responsible for unus
laces like third-party tools.
There are still 3 places where "slave" is used.
- Terminology: "... are called standby or slave servers."
- Words in old release notes for 8.2 and 8.4.
Could you check those replacements are proper?
Regards,
---
Takahiro Itagaki
NTT Open Source
all truncate_identifier() than roll
> your own. Assuming we want the same semantics in dblink, we'll otherwise
> have to remember to update truncate_identifier_copy() with any changes
> to truncate_identifier().
That makes sense. Now I use truncate_identifier(warn=true) for the fix.
R
it's truncated, you can still refer to it with the untruncated
> name because all such references are truncated too.
Absolutely. I re-use the added function for the fix.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
dblink_63bytes-2010602.patch
Description: Binary da
"Takahiro Itagaki" wrote:
> Bug reference: 5487
> Logged by: Takahiro Itagaki
> Email address: itagaki.takah...@oss.ntt.co.jp
> Description:dblink failed with 63 bytes connection names
> Details:
>
> Contib/dblink module seems to have
> I suggest that 9.0 would be a good time to add an "int flags" parameter
> to the add_xxx_reloption functions. The first flag could be
> default_only and we'd have room to add more later without another API
> break.
I agree the idea when we reach a conclusion
ck newly added pages with
freespace map. Of course we can ignore the case because frequent
connections and disconnections should be always avoided.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make chang
ult into the struct but
> > > isn't accepted as a user-settable item.
Itagaki's idea:
> It just fills fillfactor (and analyze_threshold)
> to default values for TOAST relations.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing lis
nges?
Probably, but it's curious because MSVC members are OK.
Do we have special treatments for exported functions in mingw?
It might export 'dllimport' funtions/variables, but not 'dllexport' ones.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
case. More research other than
pgpool is required to decide the interface routines for libSQL.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ions and support functions?
(outfuncs, readfuncs, copyfuncs, and equalfuncs)
The proposal will be acceptable only when all of the technical issues
are solved. The libSQL should also be available in stand-alone.
It should not be a collection of half-baked functions.
Regards,
---
Takahiro Itagaki
NTT Op
() functions, but it breaks ABI.
How about the attached patch? It just fills fillfactor (and analyze_threshold)
to default values for TOAST relations. I think responsibility for filling
reloptions with proper values is not in the generic option routines but in
AM-specific reloption handlers.
Regard
hack -- maybe it could be
> cleaned up for 9.1, but I'm not sure there was consensus that it was
> really needed.
OK, I moved it from 9.0 open items to new features for 9.1.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-h
rt it because it should not break any existing
third party modules because they cannot be even built on Windows.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
s
view? We will retrieve those variables as GUC options.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
t;session stats" instead "transaction stats". You can see the same
information in difference of counters between before and after the
transaction.
- Export pgBufferUsage instead of relation counters. They are
buffer counters for all relations, but we can obviously export
abort for the constraint
case because we know existing values are all the same.
> FWIW, this is achievable a lot more easily:
> CREATE UNIQUE INDEX "a_single_row" ON a ((1));
The former exclusion constraint means "one same value for all rows",
but your alternative m
Zdenek Kotala wrote:
> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=comet_moth&dt=2010-05-13%2021:06:01
> The problem is that it contains mix of DOS/Unix end of lines.
I removed two CRs in ja.po.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgs
(unnest(c));
Comments and ideas welcome.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
yte characters. So I think you can remove N and just
use "SET client_encoding = UTF8" in the cases.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
I believe.
>
> Yes, this was discussed.
I wonder some compilers or linkers might hide unexported global variables
from postgres.lib as if they are declared with 'static' specifiers.
I'm especially worried about Windows and MSVC. So, if Windows testers
can see it works, there wa
Of course it is commented out with #ifdef, but do we have codes
for EDB in core?
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
There was another idea, full-page image logs separated with WAL logging.
In theory, full-page images don't have to be written at commit, but only
by writing corresponding data pages, I'm not sure whether it is an actually
good idea or not, but if we go the direction, we won't need pg_l
2 05:23:09 UTC
> 2010 i686 GNU/Linux
> af...@aftab-laptop:/opt/dev/pgsql/install/dbserver/bin$
> af...@aftab-laptop:/opt/dev/pgsql/install/dbserver/bin$ ./pg_config
> --version
> PostgreSQL 9.0beta1
> af...@aftab-laptop:/opt/dev/pgsql/install/dbserver/bin$
Regards,
---
Takahiro
Tom Lane wrote:
> Takahiro Itagaki writes:
> > Thanks for the report! Please check whether the attached patch
> > is the correct fix. An additional regression test is included.
>
> That's going to provoke "uninitialized variable" compiler warnings,
>
ath" an _not_ with the current
> search path at the time pof creation.
Thanks for the report! Please check whether the attached patch
is the correct fix. An additional regression test is included.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
create_function_with_sear
rtion("!(tabstat->trans == trans)", File: "pgstat.c", Line:
1756)
Also, pg_stat_transaction_functions returned no rows from the test case even
after I removed those assertions. There are no rows in your test/run.out, too.
I like your idea itself, but more works are requi
"Ioseph Kim" wrote:
> CP51949 is EUC-KR correct.
> >{PG_EUC_KR, "CP51949"}, /* or 20949 ? */
Thank you for the information. I removed "or 20949 ?" from the line.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pg
ile* any dependent objects
However, dependent objects are not only in the database, but also in
the client applications. That's why we allow CREATE OR REPLACE VIEW
only to add columns, but disallow to modify existing columns.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Se
ession=# COPY (SELECT * FROM a) TO '/tmp/copy_test';
COPY 2
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
sion=# COPY a TO '/tmp/copy_test';
COPY 2
regression=# \! cat /tmp/copy_test
32
56
$ uname -a
Linux xxx 2.6.29.4-167.fc11.x86_64 #1 SMP Wed May 27 17:27:08 EDT 2009 x86_64
x86_64 x86_64 GNU/Linux
$ postgres --version
postgres (PostgreSQL) 9.0beta1
Regards,
---
Takahiro Itagaki
NTT Open Sou
s different definitions.
Also, developers should consider not only ADD COLUMN but also other
CREATE or ADD commands. The patch will be large, including documentation
adjustments in many places -- it would be hard work.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pg
ages for them, right?
{PG_LATIN6, "ISO-8859-10"},
{PG_LATIN7, "ISO-8859-13"},
{PG_LATIN8, "ISO-8859-14"},
{PG_LATIN10, "ISO-8859-16"},
{PG_SHIFT_JIS_2004, "SJIS_2004"},
Regards,
---
Takahiro Itagaki
NTT Open Source
rce.apple.com/source/libiconv/libiconv-13.2/libiconv/lib/cp949.h
but we define CP51949 for EUC-KR in chklocale.c.
{PG_EUC_KR, "CP51949"}, /* or 20949 ? */
Which is the compatible codeset with our PG_EUC_KR encoding?
949, 51949, or 20949? Should we add (or replace) CP949 for
27;::text))
Filter: (t ~~ 'abc%'::text)
(3 rows)
=# EXPLAIN SELECT * FROM tbl WHERE c LIKE 'abc%';
QUERY PLAN
Seq Scan on tbl (cost=100.00..101.01 rows=1 width=64)
Filter: (c ~~
Takahiro Itagaki wrote:
> Revised patch attached. Please test it.
I applied this version of the patch.
Please check wheter the bug is fixed and any buildfarm failures.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hack
t it.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
pg_locale_20100421.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
you
> comment on that thing about the extra parameter? And UTF8?
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
pg_locale_20100420.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
02 width=4)
-> Result (cost=0.00..2.51 rows=1001 width=0)
Should it be 1000 rather than 1001?
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
cale
functions, instead of the libc one. It returns locale characters in wide
chars, so we can safely convert them as UTF16->UTF8->db. But it requires
an additional branch in our locale codes only for Windows.
[1] http://msdn.microsoft.com/en-us/library/dd318101
Regards,
---
Takahiro Itagaki
NTT
tlog/refs/heads/partition
I'd like to ask Necati what problem you will solve, rather than
what module you will develop. Performance? Usability? Or othres?
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To m
(*walker) (), void *context)
{
ListCell *temp;
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
find a setlocale-compatible name of
"de-DE_phoneb". Or, you cannot use it, unless we modify PostgreSQL to
use Win32 locale functions instead of standard libc ones -- but it is
hardly acceptable.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mai
but it requires argv[0] away from main() function.
GetModuleFilename() is available on Windows for the purpose,
but I don't know what API is available on other platforms.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@post
n your
old database. If so, PostgreSQL cannot support it because postgres depends
on locale libraries in each platform. (i.e., msvcrt on Windows)
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes
re options between them?
For example, --enable-debug or --enable-cassert.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
N_A, cmdLine, buf, sizeof(buf));
+#else
+ cygwin_conv_to_full_win32_path(cmdLine, buf);
+#endif
strcpy(cmdLine, buf);
#endif
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your
abase;\n",
vacuum_db(void)
PG_CMD_PUTS("ANALYZE;\nVACUUM FULL;\nVACUUM FREEZE;\n");
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresq
Tom Lane wrote:
> Takahiro Itagaki writes:
> > Can we take the patch for 9.0? The bug is registered as an open item:
> > http://wiki.postgresql.org/wiki/PostgreSQL_9.0_Open_Items
>
> Given that there are still problems with it, applying the patch for 9.0
> would mean
_conv_to_full_win32_path(cmdLine, buf);
+ cygwin_conv_path(CCP_POSIX_TO_WIN_A, cmdLine, buf, sizeof(buf));
strcpy(cmdLine, buf);
#endif
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To ma
ore DOCTYPE.
=# SELECT xmlconcat('foo', xmlparse(DOCUMENT '
'));
xmlconcat
---
foo
(1 row)
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes t
UNCTION_ARGS);
}
However, you should very carefully use C++ exceptions and destructors
in your module because PostgreSQL uses siglongjmp; C++ unwind semantics
don't work on postgres' errors. You cannot use those C++ features and
postgres' APIs together.
Regards,
---
Takahiro Itagaki
NTT
short and just links to the CREATE TABLE doc.
We could move some contents from CREATE TABLE to the constraints doc.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
docfix_20100331.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
aints have a section for them:
http://developer.postgresql.org/pgdocs/postgres/ddl-constraints.html#AEN2431
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
T" might be arguable.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
PGMODULEEXPORT.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
n where the -C options is better than initdb + echo?
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Greg Smith wrote:
> By the way: the pgbench.sgml that you committed looks like it passed
> through a system that added a CR to every line in it. Probably not the
> way you intended to commit that.
Oops, fixed. Thanks.
Regards,
---
Takahiro Itagaki
NTT Open Source Softwa
T(loid) FROM pg_largeobject
to SELECT oid FROM pg_largeobject_metadata
because an empty large object doesn't have rows in pg_largeobject.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make chan
Greg Smith wrote:
> Attached is an updated version that I think is ready to commit. Only
> changes are docs--I rewrote those to improve the wording some.
Thanks for the correction. Applied.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers m
simply mmap it?
BTW, SimpleAllocContextCreate() is not used at all in the patch.
Do you still need it?
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresq
Bruce Momjian wrote:
> Takahiro Itagaki wrote:
> > Since 9.0 has GetPlatformEncoding() for the purpose, we could simplify
> > db_encoding_strdup() with the function. Like this:
>
> OK, I don't have any Win32 people testing this patch so if we want this
> fixed for
T * FROM tbl1 UNION ALL SELECT * FROM tbl2 FOR SHARE;
ERROR: SELECT FOR UPDATE/SHARE is not allowed with UNION/INTERSECT/EXCEPT
(in 9.0)
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to yo
Takahiro Itagaki wrote:
> > > 2. Use per-thread log files.
> > > File names would be "pgbench_log..".
Here is a patch to implement per-thread log files for pgbench -l.
The log filenames are "pgbench_log.."
for each thread, but the first thread
Tom Lane wrote:
> Takahiro Itagaki writes:
> > Oops. There might be two solutions for the issue:
> > 1. Use explicit locks. The lock primitive will be pthread_mutex for
> > multi-threaded implementations or semaphore for multi-threaded ones.
> >
readed implementations or semaphore for multi-threaded ones.
2. Use per-thread log files.
File names would be "pgbench_log..".
Which is better, or another idea?
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hacker
) without any #ifdef WIN32 quotes.
BTW, I found we'd better to add "ANSI_X3.4-1968" as an alias for
PG_SQL_ASCII. My Fedora 12 returns the name when --no-locale is used.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsq
he lock mode which pg_start_backup()
> uses. Is it worth applying this patch?
Thanks, applied.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ild their extension modules without mingw.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ven if there is no performance benefits from it.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Tom Lane wrote:
> Takahiro Itagaki writes:
> > I'd like to propose to define PGALWAYSEXPORT macro:
> > #ifdef WIN32
> > #define PGALWAYSEXPORT __declspec (dllexport)
> > #endif
> > and modify PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 to use it
FO_V1 to use it
instead of PGDLLEXPORT.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
uot;YE000"
char *sqlstate;
if (sqlstate == ECPG_SQLSTATE_ECPG_INTERNAL_ERROR)
---
Instead, should we use "if (strcmp(...) == 0)" here?
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To mak
nterface
mismatch -- libpq uses array-based APIs (PGresult) and JDBC uses a
cursor-like API (ResultSet). Instead, you can use CURSOR and FETCH
commands to retrieve rows in separated PGresult objects.
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing li
1 - 100 of 215 matches
Mail list logo
