Re: [HACKERS] request a new feature in fuzzystrmatch

2013-05-17 Thread Liming Hu
On Fri, May 17, 2013 at 9:39 PM, Atri Sharma atri.j...@gmail.com wrote: Sent from my iPad On 18-May-2013, at 10:00, Liming Hu dawnin...@gmail.com wrote: On 5/17/2013 9:10 PM, Atri Sharma wrote: On Sat, May 18, 2013 at 9:27 AM, Liming Hu dawnin...@gmail.com wrote: On 5/17/2013 12:39 PM,

Re: [HACKERS] request a new feature in fuzzystrmatch

2013-05-17 Thread Atri Sharma
Sent from my iPad On 18-May-2013, at 10:41, Liming Hu dawnin...@gmail.com wrote: On Fri, May 17, 2013 at 9:39 PM, Atri Sharma atri.j...@gmail.com wrote: Sent from my iPad On 18-May-2013, at 10:00, Liming Hu dawnin...@gmail.com wrote: On 5/17/2013 9:10 PM, Atri Sharma wrote: On

Re: [HACKERS] request a new feature in fuzzystrmatch

2013-05-17 Thread Liming Hu
On Fri, May 17, 2013 at 10:21 PM, Atri Sharma atri.j...@gmail.com wrote: Sent from my iPad On 18-May-2013, at 10:41, Liming Hu dawnin...@gmail.com wrote: On Fri, May 17, 2013 at 9:39 PM, Atri Sharma atri.j...@gmail.com wrote: Sent from my iPad On 18-May-2013, at 10:00, Liming Hu

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-16 Thread Greg Stark
On Fri, Oct 14, 2011 at 4:29 PM, Tom Lane t...@sss.pgh.pa.us wrote: Right.  I think this one falls into my class #2, ie, we have no idea how to implement it usefully.  Doesn't (necessarily) mean that the core concept is without merit. Hm. given that we have an implementation I wouldn't say we

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-16 Thread Tom Lane
Greg Stark st...@mit.edu writes: On Fri, Oct 14, 2011 at 4:29 PM, Tom Lane t...@sss.pgh.pa.us wrote: Right.  I think this one falls into my class #2, ie, we have no idea how to implement it usefully.  Doesn't (necessarily) mean that the core concept is without merit. Hm. given that we have

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-14 Thread Cédric Villemain
2011/10/14 Bruce Momjian br...@momjian.us: Should this be marked as TODO? I suppose TODO items *are* wanted and so working on them should remove the pain to convince people here to accept the feature, aren't they ? ---

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-14 Thread Heikki Linnakangas
On 14.10.2011 11:44, Cédric Villemain wrote: 2011/10/14 Bruce Momjianbr...@momjian.us: Should this be marked as TODO? I suppose TODO items *are* wanted and so working on them should remove the pain to convince people here to accept the feature, aren't they ? I don't think this is

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-14 Thread Tom Lane
=?ISO-8859-1?Q?C=E9dric_Villemain?= cedric.villemain.deb...@gmail.com writes: 2011/10/14 Bruce Momjian br...@momjian.us: Should this be marked as TODO? I suppose TODO items *are* wanted and so working on them should remove the pain to convince people here to accept the feature, aren't they ?

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-14 Thread Bruce Momjian
Tom Lane wrote: =?ISO-8859-1?Q?C=E9dric_Villemain?= cedric.villemain.deb...@gmail.com writes: 2011/10/14 Bruce Momjian br...@momjian.us: Should this be marked as TODO? I suppose TODO items *are* wanted and so working on them should remove the pain to convince people here to accept the

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-14 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of vie oct 14 11:56:22 -0300 2011: Tom Lane wrote: =?ISO-8859-1?Q?C=E9dric_Villemain?= cedric.villemain.deb...@gmail.com writes: 2011/10/14 Bruce Momjian br...@momjian.us: Should this be marked as TODO? I suppose TODO items *are* wanted and

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-14 Thread Bruce Momjian
Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of vie oct 14 11:56:22 -0300 2011: Tom Lane wrote: =?ISO-8859-1?Q?C=E9dric_Villemain?= cedric.villemain.deb...@gmail.com writes: 2011/10/14 Bruce Momjian br...@momjian.us: Should this be marked as TODO? I

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-14 Thread Robert Haas
On Fri, Oct 14, 2011 at 11:12 AM, Bruce Momjian br...@momjian.us wrote: OK.  But if we are pretty sure we don't want something, e.g. hibernate, we shouldn't add it. Fair enough, but I'm not even slightly sure that we don't want that. I think having prewarming utilities available as contrib

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-14 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Bruce Momjian's message of vie oct 14 11:56:22 -0300 2011: Tom Lane wrote: There is plenty of stuff in the TODO list for which there is no consensus. Uh, we should probably remove those then. Can you think of any? Unless

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-14 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of vie oct 14 12:12:22 -0300 2011: Alvaro Herrera wrote: The guideline, last I checked, was that before getting into coding any item from the TODO list, the prospective hacker should check previous discussions and initiate a new one on this list to

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-14 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, Oct 14, 2011 at 11:12 AM, Bruce Momjian br...@momjian.us wrote: OK.  But if we are pretty sure we don't want something, e.g. hibernate, we shouldn't add it. Fair enough, but I'm not even slightly sure that we don't want that. I think having

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-14 Thread Bruce Momjian
Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of vie oct 14 12:12:22 -0300 2011: Alvaro Herrera wrote: The guideline, last I checked, was that before getting into coding any item from the TODO list, the prospective hacker should check previous discussions and

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-10-13 Thread Bruce Momjian
Should this be marked as TODO? --- Mitsuru IWASAKI wrote: Hi, On 05/07/2011 03:32 AM, Mitsuru IWASAKI wrote: For 1, I've just finish my work. The latest patch is available at:

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-06-07 Thread Greg Smith
On 06/05/2011 08:50 AM, Mitsuru IWASAKI wrote: It seems that I don't have enough time to complete this work. You don't need to keep cc'ing me, and I'm very happy if postgres to be the first DBMS which support buffer cache hibernation feature. Thanks for submitting the patch, and we'll see

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-06-05 Thread Mitsuru IWASAKI
Hi, On 05/07/2011 03:32 AM, Mitsuru IWASAKI wrote: For 1, I've just finish my work. The latest patch is available at: http://people.freebsd.org/~iwasaki/postgres/buffer-cache-hibernation-postgresql-20110507.patch Reminder here--we can't accept code based on it being published to a

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-06-01 Thread Tatsuo Ishii
Yeah, I'm pretty well convinced this whole approach is a dead end. Priming the OS buffer cache seems way more useful. I also think saving the blocks to be read rather than the actual blocks makes a lot more sense. Well, his proposal works on any platforms PostgreSQL supports. On the other

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-06-01 Thread Cédric Villemain
2011/6/1 Tatsuo Ishii is...@postgresql.org: Yeah, I'm pretty well convinced this whole approach is a dead end. Priming the OS buffer cache seems way more useful.  I also think saving the blocks to be read rather than the actual blocks makes a lot more sense. Well, his proposal works on any

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-06-01 Thread Greg Smith
On 06/01/2011 03:03 AM, Tatsuo Ishii wrote: Also I really want to see the performance comparison between these two approaches in the real world database. Well, tell me how big of a performance improvement you want PgFincore to win by, and I'll construct a benchmark where it does that. If

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-06-01 Thread Jeff Janes
On Sun, May 15, 2011 at 11:19 AM, Robert Haas robertmh...@gmail.com wrote: I don't think there's any need for this to get data into shared_buffers at all.  Getting it into the OS cache oughta be plenty sufficient, no? ISTM that a very simple approach here would be to save the contents of

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-06-01 Thread Robert Haas
On Wed, Jun 1, 2011 at 11:58 AM, Jeff Janes jeff.ja...@gmail.com wrote: On Sun, May 15, 2011 at 11:19 AM, Robert Haas robertmh...@gmail.com wrote: I don't think there's any need for this to get data into shared_buffers at all.  Getting it into the OS cache oughta be plenty sufficient, no?

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-06-01 Thread Greg Stark
On Wed, Jun 1, 2011 at 8:58 AM, Jeff Janes jeff.ja...@gmail.com wrote: In the latter case, wouldn't we just trigger the same inefficient scattered read of the data that normal database operation would trigger, taking about the same amount of time to reach cache-warmth? If you have a system

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-26 Thread Greg Smith
On 05/07/2011 03:32 AM, Mitsuru IWASAKI wrote: For 1, I've just finish my work. The latest patch is available at: http://people.freebsd.org/~iwasaki/postgres/buffer-cache-hibernation-postgresql-20110507.patch Reminder here--we can't accept code based on it being published to a web page.

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-15 Thread Robert Haas
On Fri, May 6, 2011 at 5:31 PM, Greg Smith g...@2ndquadrant.com wrote: I think that all the complexity with CRCs etc. is unlikely to lead anywhere too, and those two issues are not completely unrelated.  The simplest, safest thing here is the right way to approach this, not the most

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-15 Thread Cédric Villemain
2011/5/15 Robert Haas robertmh...@gmail.com: On Fri, May 6, 2011 at 5:31 PM, Greg Smith g...@2ndquadrant.com wrote: I think that all the complexity with CRCs etc. is unlikely to lead anywhere too, and those two issues are not completely unrelated.  The simplest, safest thing here is the right

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-14 Thread Mitsuru IWASAKI
Hi, We can't accept patches just based on a pointer to a web site. Please e-mail this to the mailing list so that it can be considered a submission under the project's licensing terms. I hope this would be committable and the final version. PostgreSQL has high standards for code

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-14 Thread Mitsuru IWASAKI
Hi, I'd suggest doing this as an extension module. All the changes to existing server code seem superficial. It sounds interesting. I'll try it later. Are there any good examples for extension module? Thanks -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-14 Thread Kevin Grittner
Mitsuru IWASAKI wrote: Are there any good examples for extension module? Browse the subdirectories of contrib. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-09 Thread Mitsuru IWASAKI
Hi, Sorry, I missed these messages because I didn't subscribe to this list. # I've just subscribed temporary I think that all the complexity with CRCs etc. is unlikely to lead anywhere too, and those two issues are not completely unrelated.  The simplest, safest thing here is the right way

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-08 Thread Greg Smith
Mitsuru IWASAKI wrote: the patch is available at: http://people.freebsd.org/~iwasaki/postgres/buffer-cache-hibernation-postgresql-20110508.patch We can't accept patches just based on a pointer to a web site. Please e-mail this to the mailing list so that it can be considered a

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-08 Thread Heikki Linnakangas
On 08.05.2011 07:58, Mitsuru IWASAKI wrote: I'll do more testing tomorrow, and hopefully finalize my patch. Done! the patch is available at: http://people.freebsd.org/~iwasaki/postgres/buffer-cache-hibernation-postgresql-20110508.patch I'd suggest doing this as an extension module. All the

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-07 Thread Robert Haas
On Sat, May 7, 2011 at 3:32 AM, Mitsuru IWASAKI iwas...@jp.freebsd.org wrote: I have one more day for working on this, but I may give up... I think this is an interesting line of inquiry, but if you were hoping to get something committable in a couple of days, you had unrealistic expectations...

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-07 Thread Mitsuru IWASAKI
Hi, folks! I'll do more testing tomorrow, and hopefully finalize my patch. Done! the patch is available at: http://people.freebsd.org/~iwasaki/postgres/buffer-cache-hibernation-postgresql-20110508.patch I hope this would be committable and the final version. Major changes from the

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-06 Thread Mitsuru IWASAKI
Hi, I revised the patch against HEAD, it's available at: http://people.freebsd.org/~iwasaki/postgres/buffer-cache-hibernation-postgresql-20110506.patch Implemented hibernation file validations: - comparison with pg_control At shutdown: pg_control state should be DB_SHUTDOWNED. At startup:

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-06 Thread Greg Smith
On 05/05/2011 05:06 AM, Mitsuru IWASAKI wrote: In summary, PgFincore's target is File System Buffer Cache, Buffer Cache Hibernation's target is DB Buffer Cache(shared buffers). Right. The thing to realize is that shared_buffers is becoming a smaller fraction of the total RAM used by the

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-06 Thread Robert Haas
On Fri, May 6, 2011 at 5:31 PM, Greg Smith g...@2ndquadrant.com wrote: On 05/05/2011 05:06 AM, Mitsuru IWASAKI wrote: In summary, PgFincore's target is File System Buffer Cache, Buffer Cache Hibernation's target is DB Buffer Cache(shared buffers). Right.  The thing to realize is that

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-06 Thread Mitsuru IWASAKI
Hi, thanks for your comments! I'm glad to discuss about this topic. * pgfadv_WILLNEED * pgfadv_WILLNEED_snapshot The former ask to load each segment of a relation *but* the kernel can decide to not do that or load only part of each segment. (so it is not as brutal as cat file /dev/null

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-05 Thread Dimitri Fontaine
Josh Berkus j...@agliodbs.com writes: I thought that Dimitri had already implemented this using Fincore. It's linux-only, but that should work well enough to test the general concept. Actually, Cédric did, and I have a clone of his repository where I did some debian packaging of it.

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-05 Thread Cédric Villemain
2011/5/4 Josh Berkus j...@agliodbs.com: All, I thought that Dimitri had already implemented this using Fincore.  It's linux-only, but that should work well enough to test the general concept. Harald provided me some pointers at pgday in Stuttgart to make it work with windows but ... hum I

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-05 Thread Mitsuru IWASAKI
Hi, thanks for good suggestions. Postgres usually starts with ZERO buffer cache. By saving the buffer cache data structure into hibernation files just before shutdown, and loading them at startup, postgres can start operations with the saved buffer cache as the same condition as just

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-05 Thread Mitsuru IWASAKI
Hi, I think that PgFincore (http://pgfoundry.org/projects/pgfincore/) provides similar functionality. Are you familiar with that? If so, could you contrast your approach with that one? I'm not familiar with PgFincore at all sorry, but I got source code and documents and read through them

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-05 Thread Cédric Villemain
2011/5/5 Mitsuru IWASAKI iwas...@jp.freebsd.org: Hi, I think that PgFincore (http://pgfoundry.org/projects/pgfincore/) provides similar functionality.  Are you familiar with that?  If so, could you contrast your approach with that one? I'm not familiar with PgFincore at all sorry, but I got

[HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-04 Thread Mitsuru IWASAKI
Hi, I am working on new feature `Buffer Cache Hibernation' which enables postgres to keep higher cache hit ratio even just started. Postgres usually starts with ZERO buffer cache. By saving the buffer cache data structure into hibernation files just before shutdown, and loading them at startup,

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-04 Thread Andrew Dunstan
On 05/04/2011 10:10 AM, Mitsuru IWASAKI wrote: Hi, I am working on new feature `Buffer Cache Hibernation' which enables postgres to keep higher cache hit ratio even just started. Postgres usually starts with ZERO buffer cache. By saving the buffer cache data structure into hibernation files

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-04 Thread Greg Stark
On Wed, May 4, 2011 at 3:10 PM, Mitsuru IWASAKI iwas...@jp.freebsd.org wrote: Postgres usually starts with ZERO buffer cache.  By saving the buffer cache data structure into hibernation files just before shutdown, and loading them at startup, postgres can start operations with the saved buffer

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-04 Thread Tom Lane
Mitsuru IWASAKI iwas...@jp.freebsd.org writes: Postgres usually starts with ZERO buffer cache. By saving the buffer cache data structure into hibernation files just before shutdown, and loading them at startup, postgres can start operations with the saved buffer cache as the same condition as

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-04 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mié may 04 12:44:36 -0300 2011: This seems like a lot of complication for rather dubious gain. What happens when the DBA changes the shared_buffers setting, for instance? How do you protect against the cached buffers getting out-of-sync with the actual

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-04 Thread Dickson S. Guedes
2011/5/4 Greg Stark gsst...@mit.edu: On Wed, May 4, 2011 at 3:10 PM, Mitsuru IWASAKI iwas...@jp.freebsd.org wrote: Postgres usually starts with ZERO buffer cache.  By saving the buffer cache data structure into hibernation files just before shutdown, and loading them at startup, postgres can

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-04 Thread Greg Stark
On Wed, May 4, 2011 at 4:44 PM, Tom Lane t...@sss.pgh.pa.us wrote: Do you have any proof that writing out a few GB of buffers and then reading them back in is actually much cheaper than letting the database re-read the data from the disk files? I believe he's just writing out the meta data.

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-04 Thread Greg Smith
Alvaro Herrera wrote: As for gain, I have heard of test setups requiring hours of runtime in order to prime the buffer cache. And production ones too. I have multiple customers where a server restart is almost a planned multi-hour downtime. The system may be back up, but for a couple of

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-04 Thread Jeff Janes
On Wed, May 4, 2011 at 7:10 AM, Mitsuru IWASAKI iwas...@jp.freebsd.org wrote: Hi, I am working on new feature `Buffer Cache Hibernation' which enables postgres to keep higher cache hit ratio even just started. Postgres usually starts with ZERO buffer cache.  By saving the buffer cache data

Re: [HACKERS] patch for new feature: Buffer Cache Hibernation

2011-05-04 Thread Josh Berkus
All, I thought that Dimitri had already implemented this using Fincore. It's linux-only, but that should work well enough to test the general concept. -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] [GENERAL] streaming replication feature request

2011-01-20 Thread Bruce Momjian
Scott Ribe wrote: How about supporting something like: wal_keep_segments = '7d' [ moved to hackers] Sorry for the late reply. That is a very interesting idea. -- Bruce Momjian br...@momjian.ushttp://momjian.us EnterpriseDB http://enterprisedb.com

Re: [HACKERS] PITR - Bug or feature?

2010-02-03 Thread Rafael Martinez
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Fujii Masao wrote: On Mon, Feb 1, 2010 at 7:33 PM, Rafael Martinez r.m.guerr...@usit.uio.no wrote: Any thoughts about this? Is this a bug or a 'feature'? This is not a bug. Since pg_start_backup() uses %X/%X (not %08X/%08X) as the format of

[HACKERS] PITR - Bug or feature?

2010-02-01 Thread Rafael Martinez
Hello Today we have got one PITR backup history file in one of our systems with a format change. The PITR backup history file named pg_xlog/00010038.0020.backup included this information: START WAL LOCATION: 38/20 (file

Re: [HACKERS] PITR - Bug or feature?

2010-02-01 Thread Fujii Masao
Hi, On Mon, Feb 1, 2010 at 7:33 PM, Rafael Martinez r.m.guerr...@usit.uio.no wrote: The PITR backup history file named pg_xlog/00010038.0020.backup included this information: START WAL LOCATION: 38/20 (file

Re: [HACKERS] named generic constraints [feature request]

2009-12-06 Thread Caleb Cushing
no - -- is line comment in SQL - it same like // in C++ sorry didn't see this was updated. I know -- is a comment I mean in sql means NOT your function name is emptystr which implies it looks for an emptystr and returns true if the string is found to be empty (at least in my mind). so if you

Re: [HACKERS] named generic constraints [feature request]

2009-12-06 Thread Pavel Stehule
2009/12/7 Caleb Cushing xenoterrac...@gmail.com: no - -- is line comment in SQL - it same like // in C++ sorry didn't see this was updated. I know -- is a comment I mean in sql means NOT your function name is emptystr which implies it looks for an emptystr and returns true if the string

[HACKERS] named generic constraints [feature request]

2009-11-23 Thread Caleb Cushing
So last time I checked this wasn't possible (at least not that anyone has told me). I'd like to be able to create constraints that aren't tied to a specific table/column. I think that the syntax would look something like this CREATE CONSTRAINT empty CHECK (VALUE = '\0' ); this should allow us

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Pavel Stehule
Hello do you know domains? It is very similar to your proposal. http://www.postgresql.org/docs/8.2/static/sql-createdomain.html Regards Pavel Stehule 2009/11/23 Caleb Cushing xenoterrac...@gmail.com: So last time I checked this wasn't possible (at least not that anyone has told me). I'd like

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Caleb Cushing
On Mon, Nov 23, 2009 at 4:17 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello do you know domains? It is very similar to your proposal. obviously since I cited it. constraint cannot be  part of  expression. why not? NOT NULL is a contraint, UNIQUE is a contstraint. CREATE OR

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Pavel Stehule
2009/11/23 Caleb Cushing xenoterrac...@gmail.com: On Mon, Nov 23, 2009 at 4:17 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello do you know domains? It is very similar to your proposal. obviously since I cited it. constraint cannot be  part of  expression. why not? NOT NULL is a

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Peter Eisentraut
On mån, 2009-11-23 at 12:50 -0500, Caleb Cushing wrote: and domains only seem right if it's something, like a zip code, that has a very specific set of rules, that is in reality it's own type. A domain is not really its own type, it's a domain over its base type. Hence the name. where

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Caleb Cushing
CREATE OR REPLACE FUNCTION emptystr(text) RETURNS bool AS $$  SELECT $1 ''; -- it is SQL not C $$ LANGUAGE sql; CREATE TABLE users(  username TEXT CHECK (NOT emptystr(username)), although I'm not going to continue discussing the request. this code as the opposite desired effect. it should

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Josh Berkus
Caleb, I can understand why you want this. However, it would be tricky to implement because of data typing, and is fairly easily worked around using either domains or functions. So I don't think anyone is going to want to add it to the TODO list, sorry. Of course, Postgres is fully hackable if

Re: [HACKERS] named generic constraints [feature request]

2009-11-23 Thread Pavel Stehule
2009/11/24 Caleb Cushing xenoterrac...@gmail.com: CREATE OR REPLACE FUNCTION emptystr(text) RETURNS bool AS $$  SELECT $1 ''; -- it is SQL not C $$ LANGUAGE sql; CREATE TABLE users(  username TEXT CHECK (NOT emptystr(username)), although I'm not going to continue discussing the request.

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-10-26 Thread Michael Paquier
I see this in pgbench.c: /* return false iff client should be disconnected */ static bool doCustom(CState *st, instr_time *conn_time) I think you need to increase the verbosity of the error messages when you're working on this code, because when I compile I get a slew of these

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-10-08 Thread Greg Smith
On Tue, 22 Sep 2009, Michael Paquier wrote: The function doCustom is defined with a void. I see this in pgbench.c: /* return false iff client should be disconnected */ static bool doCustom(CState *st, instr_time *conn_time) I think you need to increase the verbosity of the error

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-09-22 Thread Greg Smith
On Tue, 22 Sep 2009, Michael Paquier wrote: Besides, you can also make tests without 2pc transactions, such as: \shell ls -ll /home/ioltas/usr/pgsql/data END; I think that demonstrating the pgbench shell feature with this 2PC example is working against your patch being even considered, much

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-09-22 Thread Michael Paquier
See attached a patch of this setshell feature. If you use in a script file something like: /setshell param_set setshellparam.sh pgbench reads from the shell script setshellparam.sh the first output value, verifies if it is an integer, then manages it as a pgbench parameter. I did not take into

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-09-21 Thread Michael Paquier
Hi, Sorry for my late reply again :o) You will find my answers on-the-line. You really should be returning a value at the point since the function signature defines a return type. If not the function should be void, which it cannot be in this context since it is used for boolean tests

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-09-18 Thread Michael Paquier
You really should be returning a value at the point since the function signature defines a return type. If not the function should be void, which it cannot be in this context since it is used for boolean tests elsewhere. The returns in question are all part of error blocks and should return

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-09-18 Thread Dan Colish
On Fri, Sep 18, 2009 at 03:10:14PM +0900, Michael Paquier wrote: You really should be returning a value at the point since the function signature defines a return type. If not the function should be void, which it cannot be in this context since it is used for boolean tests elsewhere.

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-09-17 Thread Dan Colish
On Thu, Sep 17, 2009 at 09:56:44AM +0900, Michael Paquier wrote: Hi all, Sorry for my late reply. There is no other update for this patch since the 13th of August, at least until today. The new patch is attached By the way I worked on the comments that Dan and Gabriel pointed out. I added

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-09-16 Thread Michael Paquier
Hi all, Sorry for my late reply. There is no other update for this patch since the 13th of August, at least until today. The new patch is attached By the way I worked on the comments that Dan and Gabriel pointed out. I added a check on system such as to prevent an error from this side. By the

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-09-15 Thread Stephen Frost
Michael, I just wanted to follow-up on your pgbench patch. The latest version that I see is from August 13th. Is that the correct patch to be reviewing? Do you have any other updates on it? Thanks! Stephen signature.asc Description: Digital signature

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-09-15 Thread Dan Colish
On Tue, Sep 15, 2009 at 09:53:11PM -0400, Stephen Frost wrote: Michael, I just wanted to follow-up on your pgbench patch. The latest version that I see is from August 13th. Is that the correct patch to be reviewing? Do you have any other updates on it? Thanks!

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-08-12 Thread Michael Paquier
Thanks a lot for all of your pieces of advice. I modified the name of the page as well as I deleted the parts linked to the -P option. It just consisted in deleting the right parts. Here is the lighted version. -- Michael Paquier NTT OSSC postgresql-8.4.0-pgbenchshell2.0.patch Description:

[HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-08-06 Thread Michael Paquier
Hi all, Here is a short patch implementing a new feature in pgbench so as to allow shell commands to be launched in a transaction file of pgbench. the user has just to add at the beginning of the command line in his transaction file \shell + the command wanted. As an example of transaction:

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-08-06 Thread Michael Paquier
Sorry I forgot to attach the the patch. Regards, Michael On Fri, Aug 7, 2009 at 12:23 PM, Michael Paquier michael.paqu...@gmail.comwrote: Hi all, Here is a short patch implementing a new feature in pgbench so as to allow shell commands to be launched in a transaction file of pgbench. the

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-08-06 Thread Robert Haas
On Thu, Aug 6, 2009 at 11:26 PM, Michael Paquiermichael.paqu...@gmail.com wrote: Sorry I forgot to attach the the patch. Please add your patches at https://commitfest.postgresql.org/action/commitfest_view/open ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-08-06 Thread Itagaki Takahiro
Michael Paquier michael.paqu...@gmail.com wrote: Here is a short patch implementing a new feature in pgbench so as to allow shell commands to be launched in a transaction file of pgbench. \shell ls ~/pg_twophase; +1 for \shell command itself, but does the performance fit for your purpose?

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-08-06 Thread Alvaro Herrera
Michael Paquier escribió: I also created a page in postgresql's wiki about this feature. Please refer to this link: http://wiki.postgresql.org/wiki/Pgbench:_shell_command Please don't use colons in wiki page names. Pgbench_shell_command should be fine. -- Alvaro Herrera

Re: [HACKERS] [PATCH] pgbench: new feature allowing to launch shell commands

2009-08-06 Thread Michael Paquier
Yes it dramatically decreases the transaction flow. This function has not been implemented at all for performance but for analysis purposes. I used it mainly to have a look at state files size in pg_twophase for transactions that are prepared but not committed. Regards On Fri, Aug 7, 2009 at

[HACKERS] Is this a feature?

2007-06-11 Thread Joshua D. Drake
Hello, It is past feature freeze which means we can't introduce new features. It is possible to submit a patch for slightly different logging output? Take the following: INFO: analyzing pg_catalog.pg_authid INFO: pg_authid: scanned 1 of 1 pages, containing 5 live rows and 0 dead rows; 5

Re: [HACKERS] Is this a feature?

2007-06-11 Thread Florian G. Pflug
Joshua D. Drake wrote: Take the following: INFO: analyzing pg_catalog.pg_authid INFO: pg_authid: scanned 1 of 1 pages, containing 5 live rows and 0 dead rows; 5 rows in sample, 5 estimated total rows The above is completely redundant. Why not just say: INFO: pg_authid: scanned 1 of 1

Re: [HACKERS] 5 Weeks till feature freeze or (do you know where your patch is?)

2007-02-27 Thread Henry B. Hotz
On Feb 23, 2007, at 1:24 PM, Joshua D. Drake wrote: Henry Hotz: GSSAPI (with Magnus) Progressing. Had hoped to have alpha patches by March 1, but I just got handed a proposal that I have to do by then. I trust it's OK to send the first version in next week? No real issues, except I

Re: [HACKERS] 5 Weeks till feature freeze or (do you know where your patch is?)

2007-02-27 Thread Joshua D. Drake
Henry B. Hotz wrote: On Feb 23, 2007, at 1:24 PM, Joshua D. Drake wrote: Henry Hotz: GSSAPI (with Magnus) Progressing. Had hoped to have alpha patches by March 1, but I just got handed a proposal that I have to do by then. I trust it's OK to send the first version in next week?

Re: [HACKERS] 5 Weeks till feature freeze or (do you know where your patch is?)

2007-02-27 Thread Kris Jurka
On Tue, 27 Feb 2007, Henry B. Hotz wrote: Question: are there any corresponding deadlines for the Java client code that I need to worry about? The JDBC driver will release a new version at the same time as the server, but we don't have nearly as strict rules about feature freeze/beta. We

Re: [HACKERS] 5 Weeks till feature freeze or (do you know where your patch is?)

2007-02-24 Thread Pavan Deolasee
On 2/24/07, Joshua D. Drake [EMAIL PROTECTED] wrote: Pavan Deolasee: HOT ( never met him ) I am working on it with the target of 8.3. I am posting WIP patches since couple of weeks. One of the objectives of publishing WIP patches, even though they are not well tested (for correctness as

[HACKERS] 5 Weeks till feature freeze or (do you know where your patch is?)

2007-02-23 Thread Joshua D. Drake
Hello, 5 weeks to feature freeze folks. Please provide updates including if you think you will have a patch submitted before feature freeze. Be realistic, if you can't make it -- say so. Alvaro Herrera: Autovacuum improvements (maintenance window etc..) Gavin Sherry: Bitmap Indexes (on disk),

Re: [HACKERS] 5 Weeks till feature freeze or (do you know where your patch is?)

2007-02-23 Thread Andrew Dunstan
Joshua D. Drake wrote: Andrew Dunstan: Something with COPY? Andrew? The only thing I can think of is to remove the support for ancient COPY syntax from psql's \copy, as suggested here: http://archives.postgresql.org/pgsql-hackers/2007-02/msg01078.php That's hardly a feature - more a

Re: [HACKERS] 5 Weeks till feature freeze or (do you know where your patch is?)

2007-02-23 Thread Joshua D. Drake
Neil Conway: pgmemcache Josh Drake: pgmemcache what does this refer to? Neil is cleaning up the code, I am cleaning up the docs. Joshua D. Drake cheers andrew -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 ||

Re: [HACKERS] 5 Weeks till feature freeze or (do you know where your patch is?)

2007-02-23 Thread Joshua D. Drake
The only thing I can think of is to remove the support for ancient COPY syntax from psql's \copy, as suggested here: http://archives.postgresql.org/pgsql-hackers/2007-02/msg01078.php That's hardly a feature - more a matter of tidying up. I thought you were being sponsored for something?

Re: [HACKERS] 5 Weeks till feature freeze or (do you know where your patch is?)

2007-02-23 Thread Gregory Stark
Joshua D. Drake [EMAIL PROTECTED] writes: Greg Stark: WITH/Recursive Queries? Uhm, I posted two weeks ago saying I had to shelve that temporarily. On the other hand I've submitted a patch to reduce the storage overhead of varlenas under 128 bytes by 3-7 bytes each. -- Gregory Stark

Re: [HACKERS] 5 Weeks till feature freeze or (do you know where your patch is?)

2007-02-23 Thread Joshua D. Drake
Gregory Stark wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Greg Stark: WITH/Recursive Queries? Uhm, I posted two weeks ago saying I had to shelve that temporarily. I can't read every email :) Can someone pick this up? This would be the second time that this has been dropped. Anyone?

Re: [HACKERS] 5 Weeks till feature freeze or (do you know where your patch is?)

2007-02-23 Thread Bruce Momjian
Also, I have several heavy patches in the patch queue that I am not comfortable reviewing/applying: http://momjian.postgresql.org/cgi-bin/pgpatches --- Joshua D. Drake wrote: Hello, 5 weeks to feature freeze

<    1   2   3   4   5   6   7   8   9   >