Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-05-30 Thread Devrim GÜNDÜZ
Hi, On Wed, 2012-05-30 at 22:03 -0400, Bruce Momjian wrote: > A control variable was added in this commit: > > commit db84ba65ab5c0ad0b34d68ab5a687bc5f4ca3ba6 > Author: Peter Eisentraut Thanks Bruce, apparently I missed it. Regards, -- Devrim GÜNDÜZ Principal Systems Engineer

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-05-30 Thread Bruce Momjian
On Thu, May 31, 2012 at 04:06:50AM +0300, Devrim Gunduz wrote: > Hi, > > On Mon, 2012-05-07 at 13:22 -0400, Robert Haas wrote: > > On Sat, May 5, 2012 at 9:03 AM, Bruce Momjian > > wrote: > > > On Fri, May 04, 2012 at 08:46:28PM +0300, Peter Eisentraut wrote: > > >> On tor, 2012-05-03 at 15:47 -0

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-05-30 Thread Devrim GÜNDÜZ
Hi, On Mon, 2012-05-07 at 13:22 -0400, Robert Haas wrote: > On Sat, May 5, 2012 at 9:03 AM, Bruce Momjian > wrote: > > On Fri, May 04, 2012 at 08:46:28PM +0300, Peter Eisentraut wrote: > >> On tor, 2012-05-03 at 15:47 -0400, Bruce Momjian wrote: > >> > Peter, where are we on this? > >> > >> I had

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-05-07 Thread Robert Haas
On Sat, May 5, 2012 at 9:03 AM, Bruce Momjian wrote: > On Fri, May 04, 2012 at 08:46:28PM +0300, Peter Eisentraut wrote: >> On tor, 2012-05-03 at 15:47 -0400, Bruce Momjian wrote: >> > Peter, where are we on this? >> >> I hadn't received any clear feedback, but if no one objects, I can >> commit i

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-05-05 Thread Bruce Momjian
On Fri, May 04, 2012 at 08:46:28PM +0300, Peter Eisentraut wrote: > On tor, 2012-05-03 at 15:47 -0400, Bruce Momjian wrote: > > Peter, where are we on this? > > I hadn't received any clear feedback, but if no one objects, I can > commit it. I think there were enough people that wanted some kind o

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-05-04 Thread Peter Eisentraut
On tor, 2012-05-03 at 15:47 -0400, Bruce Momjian wrote: > Peter, where are we on this? I hadn't received any clear feedback, but if no one objects, I can commit it. > --- > > On Fri, Mar 30, 2012 at 08:16:59PM +0300, Peter E

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-05-03 Thread Bruce Momjian
Peter, where are we on this? --- On Fri, Mar 30, 2012 at 08:16:59PM +0300, Peter Eisentraut wrote: > On fre, 2012-03-23 at 07:52 -0700, David Fetter wrote: > > On Thu, Mar 22, 2012 at 06:05:30PM -0400, Andrew Dunstan wrote:

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-04-10 Thread Bruce Momjian
On Fri, Mar 30, 2012 at 08:16:59PM +0300, Peter Eisentraut wrote: > On fre, 2012-03-23 at 07:52 -0700, David Fetter wrote: > > On Thu, Mar 22, 2012 at 06:05:30PM -0400, Andrew Dunstan wrote: > > > On 03/22/2012 05:49 PM, Bruce Momjian wrote: > > > >Robert Haas and I are disappointed by this change.

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-03-30 Thread Peter Eisentraut
On fre, 2012-03-23 at 07:52 -0700, David Fetter wrote: > On Thu, Mar 22, 2012 at 06:05:30PM -0400, Andrew Dunstan wrote: > > On 03/22/2012 05:49 PM, Bruce Momjian wrote: > > >Robert Haas and I are disappointed by this change. I liked the > > >fact that I could post nice-looking SQL queries without

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-03-23 Thread Peter Geoghegan
On 23 March 2012 15:13, Andrew Dunstan wrote: > Upper casing SQL keywords is a common style, which is used in lots of our > code (e.g. regression tests, psql queries, pg_dump). I think the default > should match what is in effect our house style, and what we have > historically done. The code doe

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-03-23 Thread Tom Lane
Peter Geoghegan writes: > On 22 March 2012 22:05, Andrew Dunstan wrote: >> Should it be governed by a setting? > Perhaps, but I find the behaviour that was introduced by Peter's patch > to be a more preferable default. FWIW, I like the new behavior better too. I'm not particularly a fan of all

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-03-23 Thread Andrew Dunstan
On 03/23/2012 11:07 AM, Peter Geoghegan wrote: On 22 March 2012 22:05, Andrew Dunstan wrote: On 03/22/2012 05:49 PM, Bruce Momjian wrote: Robert Haas and I are disappointed by this change. I liked the fact that I could post nice-looking SQL queries without having to use my capslock key (w

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-03-23 Thread Peter Geoghegan
On 22 March 2012 22:05, Andrew Dunstan wrote: > > > On 03/22/2012 05:49 PM, Bruce Momjian wrote: >> >> >> Robert Haas and I are disappointed by this change.  I liked the fact >> that I could post nice-looking SQL queries without having to use my >> capslock key (which I use as a second control key

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-03-23 Thread David Fetter
On Fri, Mar 23, 2012 at 11:51:16AM -0300, Alvaro Herrera wrote: > > Excerpts from Andrew Dunstan's message of jue mar 22 19:05:30 -0300 2012: > > > > On 03/22/2012 05:49 PM, Bruce Momjian wrote: > > > > > > Robert Haas and I are disappointed by this change. I liked the > > > fact that I could po

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-03-23 Thread David Fetter
On Thu, Mar 22, 2012 at 06:05:30PM -0400, Andrew Dunstan wrote: > On 03/22/2012 05:49 PM, Bruce Momjian wrote: > >Robert Haas and I are disappointed by this change. I liked the > >fact that I could post nice-looking SQL queries without having to > >use my capslock key (which I use as a second cont

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-03-23 Thread Alvaro Herrera
Excerpts from Andrew Dunstan's message of jue mar 22 19:05:30 -0300 2012: > > On 03/22/2012 05:49 PM, Bruce Momjian wrote: > > > > Robert Haas and I are disappointed by this change. I liked the fact > > that I could post nice-looking SQL queries without having to use my > > capslock key (which I

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-03-22 Thread Andrew Dunstan
On 03/22/2012 05:49 PM, Bruce Momjian wrote: Robert Haas and I are disappointed by this change. I liked the fact that I could post nice-looking SQL queries without having to use my capslock key (which I use as a second control key). Any chance of reverting this change? Should it be govern

Re: [HACKERS] Uppercase tab completion keywords in psql?

2012-03-22 Thread Andres Freund
On Thursday, March 22, 2012 10:49:55 PM Bruce Momjian wrote: > Postgres 9.2 has been modified so psql no longer uppercases SQL keywords > when using tab completation, by this commit: > > commit 69f4f1c3576abc535871c6cfa95539e32a36120f > Author: Peter Eisentraut > Date: Wed Feb

[HACKERS] Uppercase tab completion keywords in psql?

2012-03-22 Thread Bruce Momjian
Postgres 9.2 has been modified so psql no longer uppercases SQL keywords when using tab completation, by this commit: commit 69f4f1c3576abc535871c6cfa95539e32a36120f Author: Peter Eisentraut Date: Wed Feb 1 20:16:40 2012 +0200 psql: Case preserving c