Re: [HACKERS] configure gaps

2011-03-10 Thread Bruce Momjian
Andrew Dunstan wrote: On 02/21/2011 09:33 PM, Bruce Momjian wrote: Tom Lane wrote: Andrew Dunstanand...@dunslane.net writes: I propose that we add the following test for this case: AC_CHECK_HEADER(Python.h, [], [AC_MSG_ERROR([header filePython.h is required for Python])])

Re: [HACKERS] configure gaps

2011-03-10 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Andrew Dunstan wrote: On 02/21/2011 09:33 PM, Bruce Momjian wrote: Tom Lane wrote: Andrew Dunstanand...@dunslane.net writes: I propose that we add the following test for this case: AC_CHECK_HEADER(Python.h, [], [AC_MSG_ERROR([header filePython.h

Re: [HACKERS] configure gaps

2011-03-10 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Andrew Dunstan wrote: On 02/21/2011 09:33 PM, Bruce Momjian wrote: Tom Lane wrote: Andrew Dunstanand...@dunslane.net writes: I propose that we add the following test for this case: AC_CHECK_HEADER(Python.h, [],

Re: [HACKERS] configure gaps

2011-03-10 Thread Andrew Dunstan
On 03/10/2011 03:14 PM, Bruce Momjian wrote: Did this get done? If so, I don't see it. Oh, no. It skipped my TODO list. I'll try to get it done in the next day or so. I have added this to the 9.1 open items list: http://wiki.postgresql.org/wiki/PostgreSQL_9.1_Open_Items#Code_Issues

Re: [HACKERS] configure gaps

2011-02-21 Thread Bruce Momjian
Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: I propose that we add the following test for this case: AC_CHECK_HEADER(Python.h, [], [AC_MSG_ERROR([header file Python.h is required for Python])]) You'd need to pay attention to python_includespec, but otherwise seems

Re: [HACKERS] configure gaps

2011-02-21 Thread Andrew Dunstan
On 02/21/2011 09:33 PM, Bruce Momjian wrote: Tom Lane wrote: Andrew Dunstanand...@dunslane.net writes: I propose that we add the following test for this case: AC_CHECK_HEADER(Python.h, [], [AC_MSG_ERROR([header filePython.h is required for Python])]) You'd need to pay attention

Re: [HACKERS] configure gaps

2010-10-05 Thread Andrew Dunstan
On 10/02/2010 01:35 PM, Peter Eisentraut wrote: On lör, 2010-10-02 at 13:01 -0400, Andrew Dunstan wrote: Specifically, a) when python was installed but python-devel was not, configure passed by the compile for python failed quite miserably, and Yeah. Same is true if libperl-dev or similar

Re: [HACKERS] configure gaps

2010-10-05 Thread Peter Eisentraut
On tis, 2010-10-05 at 11:13 -0400, Andrew Dunstan wrote: Specifically, a) when python was installed but python-devel was not, configure passed by the compile for python failed quite miserably, and Yeah. Same is true if libperl-dev or similar is not installed. No, actually configure

Re: [HACKERS] configure gaps

2010-10-05 Thread Andrew Dunstan
On 10/05/2010 11:37 AM, Peter Eisentraut wrote: On tis, 2010-10-05 at 11:13 -0400, Andrew Dunstan wrote: Specifically, a) when python was installed but python-devel was not, configure passed by the compile for python failed quite miserably, and Yeah. Same is true if libperl-dev or similar

Re: [HACKERS] configure gaps

2010-10-05 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: I propose that we add the following test for this case: AC_CHECK_HEADER(Python.h, [], [AC_MSG_ERROR([header file Python.h is required for Python])]) You'd need to pay attention to python_includespec, but otherwise seems reasonable.

[HACKERS] configure gaps

2010-10-02 Thread Andrew Dunstan
While trying to build PostgreSQL 9.0 on a machine where the SA had omitted to install a lot of the required packages, I noticed a couple of cases where configure passed but the build failed due to missing pieces in the toolset. Specifically, a) when python was installed but python-devel was

Re: [HACKERS] configure gaps

2010-10-02 Thread Rob Wultsch
On Sat, Oct 2, 2010 at 10:01 AM, Andrew Dunstan and...@dunslane.net wrote: I'm, not sure if this is worth fixing, but it seemed worth mentioning. ISTM that if we pass configure, we should be able to assume that the requisite build tools, libraries, include files etc. are present. trolling One

Re: [HACKERS] configure gaps

2010-10-02 Thread Peter Eisentraut
On lör, 2010-10-02 at 13:01 -0400, Andrew Dunstan wrote: Specifically, a) when python was installed but python-devel was not, configure passed by the compile for python failed quite miserably, and Yeah. Same is true if libperl-dev or similar is not installed. b) with gettext installed but

Re: [HACKERS] configure gaps

2010-10-02 Thread Dimitri Fontaine
Rob Wultsch wult...@gmail.com writes: One of the things I really like about drizzle is if there a missing dependency it will explicitly tell you what you are missing and where to go find it for popular platforms. Choose your platform wisely. Then, apt-get build-dep postgresql-9.0 :) Regards,

Re: [HACKERS] configure gaps

2010-10-02 Thread Andrew Dunstan
On 10/02/2010 01:35 PM, Peter Eisentraut wrote: b) with gettext installed but not gettext-tools (and in particular xgettext was missing), the NLS stuff failed. xgettext is not required for the build. here is the tail of my make log with gettext-tools uninstalled (platform is SLES 11

Re: [HACKERS] configure gaps

2010-10-02 Thread Andrew Dunstan
On 10/02/2010 02:31 PM, Dimitri Fontaine wrote: Rob Wultschwult...@gmail.com writes: One of the things I really like about drizzle is if there a missing dependency it will explicitly tell you what you are missing and where to go find it for popular platforms. Choose your platform wisely.

Re: [HACKERS] configure gaps

2010-10-02 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: On 10/02/2010 01:35 PM, Peter Eisentraut wrote: xgettext is not required for the build. here is the tail of my make log with gettext-tools uninstalled (platform is SLES 11 SP1): make -C backend all make[2]: Entering directory

Re: [HACKERS] configure gaps

2010-10-02 Thread Tom Lane
I wrote: Andrew Dunstan and...@dunslane.net writes: make -C backend all make[2]: Entering directory `/usr/local/src/pg_9_0/src/backend' msgfmt -o po/de.mo po/de.po You don't have 'xgettext'. make[2]: *** [po/de.mo] Error 1 It seems to me that this indicates brain death on the part of the

Re: [HACKERS] configure gaps

2010-10-02 Thread Peter Eisentraut
On lör, 2010-10-02 at 16:43 -0400, Andrew Dunstan wrote: On 10/02/2010 01:35 PM, Peter Eisentraut wrote: b) with gettext installed but not gettext-tools (and in particular xgettext was missing), the NLS stuff failed. xgettext is not required for the build. here is the tail of

Re: [HACKERS] configure gaps

2010-10-02 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: Actually, it turns out the handling of nls-global.mk for missing xgettext has been broken since revision 1. Ooohh ... the ifdef's are in the wrong place, aren't they. Maybe it would be better to use the missing script for xgettext and drop the ifdefs?