Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-10-18 Thread Alvaro Herrera
Tomas Vondra wrote: > Also, I've realized the last interval may not be logged at all - I'll > take a look into this in the next version of the patch. I didn't see any later version of this patch posted anywhere. I guess it'll have to wait until the next commitfest. Please fix the remaining issu

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-09-20 Thread Tomas Vondra
On 3.9.2012 01:28, Jeff Janes wrote: > On Sun, Sep 2, 2012 at 3:46 PM, Tomas Vondra wrote: >> >> Fixed. I've kept use_log_agg only and I've removed the default. Also >> I've added one more check (that the total duration is a multiple of >> the aggregation interval). > > Hi Tomas, > > In the docs

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-09-02 Thread Jeff Janes
On Sun, Sep 2, 2012 at 3:46 PM, Tomas Vondra wrote: > > Fixed. I've kept use_log_agg only and I've removed the default. Also > I've added one more check (that the total duration is a multiple of > the aggregation interval). Hi Tomas, In the docs, -l is an option, not an application: "-l" Also,

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-09-02 Thread Tomas Vondra
Dne 30.08.2012 18:02, Robert Haas napsal: On Fri, Aug 24, 2012 at 5:25 PM, Tomas Vondra wrote: This patch is a bit less polished (and more complex) than the other pgbench patch I've sent a while back, and I'm not sure how to handle the Windows branch. That needs to be fixed during the commit

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-08-31 Thread Robert Haas
On Thu, Aug 30, 2012 at 5:55 PM, Tomas Vondra wrote: > It does, but AFAIK the "-l" means logging. I suppose > "--aggregate-interval" would be a good option name, I don't see a reason > to put there the additional word when there are other aggregated values > (e.g. num of transactions). Oh, I was

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-08-30 Thread Robert Haas
On Thu, Aug 30, 2012 at 3:25 PM, Tomas Vondra wrote: > On 30 Srpen 2012, 18:02, Robert Haas wrote: >> On Fri, Aug 24, 2012 at 5:25 PM, Tomas Vondra wrote: >>> This patch is a bit less polished (and more complex) than the other >>> pgbench patch I've sent a while back, and I'm not sure how to hand

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-08-30 Thread Tomas Vondra
On 30 Srpen 2012, 23:47, Robert Haas wrote: > On Thu, Aug 30, 2012 at 3:25 PM, Tomas Vondra wrote: >> On 30 Srpen 2012, 18:02, Robert Haas wrote: >>> On Fri, Aug 24, 2012 at 5:25 PM, Tomas Vondra wrote: This patch is a bit less polished (and more complex) than the other pgbench patch I'

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-08-30 Thread Tomas Vondra
On 30 Srpen 2012, 18:02, Robert Haas wrote: > On Fri, Aug 24, 2012 at 5:25 PM, Tomas Vondra wrote: >> This patch is a bit less polished (and more complex) than the other >> pgbench patch I've sent a while back, and I'm not sure how to handle the >> Windows branch. That needs to be fixed during the

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-08-30 Thread Robert Haas
On Fri, Aug 24, 2012 at 5:25 PM, Tomas Vondra wrote: > This patch is a bit less polished (and more complex) than the other > pgbench patch I've sent a while back, and I'm not sure how to handle the > Windows branch. That needs to be fixed during the commit fest. What's the problem with the Window

Re: [HACKERS] PATCH: pgbench - aggregation of info written into log

2012-08-24 Thread Tomas Vondra
On 24 Srpen 2012, 23:25, Tomas Vondra wrote: > Hi, > > this patch adds support for aggregation of info written into the log. > Instead of info about each transaction, a summary for time intervals (with > custom length) is written into the log. All you need to do is add "-A > seconds", e.g. > > $