Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

Mark Dilger writes: >> On Feb 17, 2017, at 3:37 PM, Peter Eisentraut >> wrote: >> If your compiler isn't warning about anything with that, then there is >> something wrong with it. > $ gcc --version > Configured with:

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

> On Feb 17, 2017, at 3:37 PM, Peter Eisentraut > wrote: > > On 2/17/17 16:13, Mark Dilger wrote: >> + PGAC_PROG_CC_CFLAGS_OPT([-Wc++-compat]) > > If your compiler isn't warning about anything with that, then there is > something wrong with it. $ gcc

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

On 2/17/17 16:13, Mark Dilger wrote: > + PGAC_PROG_CC_CFLAGS_OPT([-Wc++-compat]) If your compiler isn't warning about anything with that, then there is something wrong with it. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA,

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

I wrote: > Right now I'd rather focus on getting to where we can have -Werror on in > the buildfarm at all. longfin says we've got work to do on that, at least > in the back branches. It may be that we can't expect near-EOL branches to > always compile perfectly cleanly on newer compilers. I

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

Mark Dilger writes: > if test "$GCC" = yes -a "$ICC" = no; then >CFLAGS="-Wall -Wmissing-prototypes -Wpointer-arith" > + PGAC_PROG_CC_CFLAGS_OPT([-Wempty-body]) > + PGAC_PROG_CC_CFLAGS_OPT([-Wignored-qualifiers]) > +

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

On February 17, 2017 1:13:10 PM PST, Mark Dilger wrote: >How about we add (some of) these extra warnings, plus -Werror, >in a section that is only active for platforms/compilers where we >know there aren't spurious warnings? That would make detecting >unintentionally

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

> On Feb 17, 2017, at 12:21 PM, Tom Lane wrote: > > Thomas Munro writes: >> On Sat, Feb 18, 2017 at 9:04 AM, Tom Lane wrote: >>> [ pokes around... ] Ah, that's called COPT, and it's entirely >>> undocumented :-(.

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

Thomas Munro writes: > On Sat, Feb 18, 2017 at 9:04 AM, Tom Lane wrote: >> [ pokes around... ] Ah, that's called COPT, and it's entirely >> undocumented :-(. Probably ought to fix that. > One way to set that up is like this: > $ cat

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

On Sat, Feb 18, 2017 at 9:04 AM, Tom Lane wrote: > Andres Freund writes: >> On February 17, 2017 11:40:57 AM PST, Tom Lane wrote: >>> AFAICS, if you want to build with -Werror, you have to configure >>> without that and then inject it

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

Andres Freund writes: > On February 17, 2017 11:40:57 AM PST, Tom Lane wrote: >> AFAICS, if you want to build with -Werror, you have to configure >> without that and then inject it afterwards. I wonder how people who >> use -Werror are handling that. Is

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

> On Feb 17, 2017, at 11:40 AM, Tom Lane wrote: > > I wrote: >> Yeah. I have longfin which is running Apple's clang, and is on a machine >> that doesn't have much to do otherwise. I propose to turn on -Werror in >> its configuration, and to configure a second critter on

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

On February 17, 2017 11:40:57 AM PST, Tom Lane wrote: >I wrote: >> Yeah. I have longfin which is running Apple's clang, and is on a >machine >> that doesn't have much to do otherwise. I propose to turn on -Werror >in >> its configuration, and to configure a second critter

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

I wrote: > Yeah. I have longfin which is running Apple's clang, and is on a machine > that doesn't have much to do otherwise. I propose to turn on -Werror in > its configuration, and to configure a second critter on the same hardware > that runs with -Werror as well as

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

Alvaro Herrera writes: > Tom Lane wrote: >> My own compilers don't generate errors either, only warnings. Maybe >> we could catch this sort of thing mechanically with a critter configured >> with -Werror as well as --disable-integer-datetimes, but I'm a tad >> hesitant

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

Tom Lane wrote: > My own compilers don't generate errors either, only warnings. Maybe > we could catch this sort of thing mechanically with a critter configured > with -Werror as well as --disable-integer-datetimes, but I'm a tad > hesitant to have a buildfarm machine configured with -Werror.

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

I wrote: > Thomas Munro writes: >> Since commit 7c030783a5bd07cadffc2a1018bc33119a4c7505 it seems that $SUBJECT. > Hmm ... I thought we had at least one buildfarm member still testing > --disable-integer-datetimes. Evidently somebody needs to close that > gap.

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

Thomas Munro writes: > Since commit 7c030783a5bd07cadffc2a1018bc33119a4c7505 it seems that $SUBJECT. Hmm ... I thought we had at least one buildfarm member still testing --disable-integer-datetimes. Evidently somebody needs to close that gap. > Maybe the attached

Re: [HACKERS] pg_recvlogical.c doesn't build with --disable-integer-datetimes

Thomas Munro wrote: > Hi, > > Since commit 7c030783a5bd07cadffc2a1018bc33119a4c7505 it seems that $SUBJECT. Added it to open items list. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via